Commit 32ecf57d authored by Russ Cox's avatar Russ Cox

runtime: reject onM calls from gsignal stack

The implementation and use patterns of onM assume
that they run on either the m->curg or m->g0 stack.

Calling onM from m->gsignal has two problems:

(1) When not on g0, onM switches to g0 and then "back" to curg.
If we didn't start at curg, bad things happen.

(2) The use of scalararg/ptrarg to pass C arguments and results
assumes that there is only one onM call at a time.
If a gsignal starts running, it may have interrupted the
setup/teardown of the args for an onM on the curg or g0 stack.
Using scalararg/ptrarg itself would smash those.

We can fix (1) by remembering what g was running before the switch.

We can fix (2) by requiring that uses of onM that might happen
on a signal handling stack must save the old scalararg/ptrarg
and restore them after the call, instead of zeroing them.
The only sane way to do this is to introduce a separate
onM_signalsafe that omits the signal check, and then if you
see a call to onM_signalsafe you know the surrounding code
must preserve the old scalararg/ptrarg values.
(The implementation would be that onM_signalsafe just calls
fn if on the signal stack or else jumps to onM. It's not necessary
to have two whole copies of the function.)

(2) is not a problem if the caller and callee are both Go and
a closure is used instead of the scalararg/ptrarg slots.

For now, I think we can avoid calling onM from code executing
on gsignal stacks, so just reject it.

In the long term, (2) goes away (as do the scalararg/ptrarg slots)
once everything is in Go, and at that point fixing (1) would be
trivial and maybe worth doing just for regularity.

LGTM=iant
R=golang-codereviews, iant
CC=dvyukov, golang-codereviews, khr, r
https://golang.org/cl/135400043
parent cb767247
...@@ -205,18 +205,26 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-4 ...@@ -205,18 +205,26 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-4
RET RET
// func onM(fn func()) // func onM(fn func())
// calls fn() on the M stack.
// switches to the M stack if not already on it, and
// switches back when fn() returns.
TEXT runtime·onM(SB), NOSPLIT, $0-4 TEXT runtime·onM(SB), NOSPLIT, $0-4
MOVL fn+0(FP), DI // DI = fn MOVL fn+0(FP), DI // DI = fn
get_tls(CX) get_tls(CX)
MOVL g(CX), AX // AX = g MOVL g(CX), AX // AX = g
MOVL g_m(AX), BX // BX = m MOVL g_m(AX), BX // BX = m
MOVL m_g0(BX), DX // DX = g0 MOVL m_g0(BX), DX // DX = g0
CMPL AX, DX CMPL AX, DX
JEQ onm JEQ onm
MOVL m_curg(BX), BP
CMPL AX, BP
JEQ oncurg
// Not g0, not curg. Must be gsignal, but that's not allowed.
// Hide call from linker nosplit analysis.
MOVL $runtime·badonm(SB), AX
CALL AX
oncurg:
// save our state in g->sched. Pretend to // save our state in g->sched. Pretend to
// be switchtoM if the G stack is scanned. // be switchtoM if the G stack is scanned.
MOVL $runtime·switchtoM(SB), (g_sched+gobuf_pc)(AX) MOVL $runtime·switchtoM(SB), (g_sched+gobuf_pc)(AX)
......
...@@ -197,18 +197,26 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-8 ...@@ -197,18 +197,26 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-8
RET RET
// func onM(fn func()) // func onM(fn func())
// calls fn() on the M stack.
// switches to the M stack if not already on it, and
// switches back when fn() returns.
TEXT runtime·onM(SB), NOSPLIT, $0-8 TEXT runtime·onM(SB), NOSPLIT, $0-8
MOVQ fn+0(FP), DI // DI = fn MOVQ fn+0(FP), DI // DI = fn
get_tls(CX) get_tls(CX)
MOVQ g(CX), AX // AX = g MOVQ g(CX), AX // AX = g
MOVQ g_m(AX), BX // BX = m MOVQ g_m(AX), BX // BX = m
MOVQ m_g0(BX), DX // DX = g0 MOVQ m_g0(BX), DX // DX = g0
CMPQ AX, DX CMPQ AX, DX
JEQ onm JEQ onm
MOVQ m_curg(BX), BP
CMPQ AX, BP
JEQ oncurg
// Not g0, not curg. Must be gsignal, but that's not allowed.
// Hide call from linker nosplit analysis.
MOVQ $runtime·badonm(SB), AX
CALL AX
oncurg:
// save our state in g->sched. Pretend to // save our state in g->sched. Pretend to
// be switchtoM if the G stack is scanned. // be switchtoM if the G stack is scanned.
MOVQ $runtime·switchtoM(SB), BP MOVQ $runtime·switchtoM(SB), BP
......
...@@ -175,18 +175,26 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-4 ...@@ -175,18 +175,26 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-4
RET RET
// func onM(fn func()) // func onM(fn func())
// calls fn() on the M stack.
// switches to the M stack if not already on it, and
// switches back when fn() returns.
TEXT runtime·onM(SB), NOSPLIT, $0-4 TEXT runtime·onM(SB), NOSPLIT, $0-4
MOVL fn+0(FP), DI // DI = fn MOVL fn+0(FP), DI // DI = fn
get_tls(CX) get_tls(CX)
MOVL g(CX), AX // AX = g MOVL g(CX), AX // AX = g
MOVL g_m(AX), BX // BX = m MOVL g_m(AX), BX // BX = m
MOVL m_g0(BX), DX // DX = g0 MOVL m_g0(BX), DX // DX = g0
CMPL AX, DX CMPL AX, DX
JEQ onm JEQ onm
MOVL m_curg(BX), BP
CMPL AX, BP
JEQ oncurg
// Not g0, not curg. Must be gsignal, but that's not allowed.
// Hide call from linker nosplit analysis.
MOVL $runtime·badonm(SB), AX
CALL AX
oncurg:
// save our state in g->sched. Pretend to // save our state in g->sched. Pretend to
// be switchtoM if the G stack is scanned. // be switchtoM if the G stack is scanned.
MOVL $runtime·switchtoM(SB), SI MOVL $runtime·switchtoM(SB), SI
......
...@@ -190,16 +190,24 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-4 ...@@ -190,16 +190,24 @@ TEXT runtime·switchtoM(SB), NOSPLIT, $0-4
RET RET
// func onM(fn func()) // func onM(fn func())
// calls fn() on the M stack.
// switches to the M stack if not already on it, and
// switches back when fn() returns.
TEXT runtime·onM(SB), NOSPLIT, $0-4 TEXT runtime·onM(SB), NOSPLIT, $0-4
MOVW fn+0(FP), R0 // R0 = fn MOVW fn+0(FP), R0 // R0 = fn
MOVW g_m(g), R1 // R1 = m MOVW g_m(g), R1 // R1 = m
MOVW m_g0(R1), R2 // R2 = g0 MOVW m_g0(R1), R2 // R2 = g0
CMP g, R2 CMP g, R2
B.EQ onm B.EQ onm
MOVW m_g0(R1), R3
CMP g, R3
B.EQ oncurg
// Not g0, not curg. Must be gsignal, but that's not allowed.
// Hide call from linker nosplit analysis.
MOVW $runtime·badonm(SB), R0
BL (R0)
oncurg:
// save our state in g->sched. Pretend to // save our state in g->sched. Pretend to
// be switchtoM if the G stack is scanned. // be switchtoM if the G stack is scanned.
MOVW $runtime·switchtoM(SB), R3 MOVW $runtime·switchtoM(SB), R3
......
...@@ -58,22 +58,60 @@ func acquirem() *m ...@@ -58,22 +58,60 @@ func acquirem() *m
func releasem(mp *m) func releasem(mp *m)
func gomcache() *mcache func gomcache() *mcache
// in asm_*.s // mcall switches from the g to the g0 stack and invokes fn(g),
func mcall(func(*g)) // where g is the goroutine that made the call.
// mcall saves g's current PC/SP in g->sched so that it can be restored later.
// It is up to fn to arrange for that later execution, typically by recording
// g in a data structure, causing something to call ready(g) later.
// mcall returns to the original goroutine g later, when g has been rescheduled.
// fn must not return at all; typically it ends by calling schedule, to let the m
// run other goroutines.
//
// mcall can only be called from g stacks (not g0, not gsignal).
//go:noescape
func mcall(fn func(*g))
// onM switches from the g to the g0 stack and invokes fn().
// When fn returns, onM switches back to the g and returns,
// continuing execution on the g stack.
// If arguments must be passed to fn, they can be written to
// g->m->ptrarg (pointers) and g->m->scalararg (non-pointers)
// before the call and then consulted during fn.
// Similarly, fn can pass return values back in those locations.
// If fn is written in Go, it can be a closure, which avoids the need for
// ptrarg and scalararg entirely.
// After reading values out of ptrarg and scalararg it is conventional
// to zero them to avoid (memory or information) leaks.
//
// If onM is called from a g0 stack, it invokes fn and returns,
// without any stack switches.
//
// If onM is called from a gsignal stack, it crashes the program.
// The implication is that functions used in signal handlers must
// not use onM.
//
// NOTE(rsc): We could introduce a separate onMsignal that is
// like onM but if called from a gsignal stack would just run fn on
// that stack. The caller of onMsignal would be required to save the
// old values of ptrarg/scalararg and restore them when the call
// was finished, in case the signal interrupted an onM sequence
// in progress on the g or g0 stacks. Until there is a clear need for this,
// we just reject onM in signal handling contexts entirely.
//
//go:noescape
func onM(fn func()) func onM(fn func())
func badonm() {
gothrow("onM called from signal goroutine")
}
// C functions that run on the M stack. // C functions that run on the M stack.
// Call using mcall. // Call using mcall.
// These functions need to be written to arrange explicitly
// for the goroutine to continue execution.
func gosched_m(*g) func gosched_m(*g)
func park_m(*g) func park_m(*g)
// More C functions that run on the M stack. // More C functions that run on the M stack.
// Call using onM. // Call using onM.
// Arguments should be passed in m->scalararg[x] and m->ptrarg[x].
// Return values can be passed in those same slots.
// These functions return to the goroutine when they return.
func mcacheRefill_m() func mcacheRefill_m()
func largeAlloc_m() func largeAlloc_m()
func gc_m() func gc_m()
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment