Commit 484d9399 authored by Shenghou Ma's avatar Shenghou Ma Committed by Minux Ma

cmd/dist: enable external linking test for windows/386

Signed-off-by: default avatarShenghou Ma <minux@golang.org>
Change-Id: I2d2ea233f976aab3f356f9b508cdd246d5013e2f
Reviewed-on: https://go-review.googlesource.com/7284Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
Reviewed-by: default avatarAlex Brainman <alex.brainman@gmail.com>
parent 04642e92
...@@ -350,7 +350,8 @@ func (t *tester) extLink() bool { ...@@ -350,7 +350,8 @@ func (t *tester) extLink() bool {
"freebsd-386", "freebsd-amd64", "freebsd-arm", "freebsd-386", "freebsd-amd64", "freebsd-arm",
"linux-386", "linux-amd64", "linux-arm", "linux-386", "linux-amd64", "linux-arm",
"netbsd-386", "netbsd-amd64", "netbsd-386", "netbsd-amd64",
"openbsd-386", "openbsd-amd64": "openbsd-386", "openbsd-amd64",
"windows-386":
return true return true
case "darwin-386", "darwin-amd64": case "darwin-386", "darwin-amd64":
// linkmode=external fails on OS X 10.6 and earlier == Darwin // linkmode=external fails on OS X 10.6 and earlier == Darwin
...@@ -369,7 +370,10 @@ func (t *tester) cgoTest() error { ...@@ -369,7 +370,10 @@ func (t *tester) cgoTest() error {
env := mergeEnvLists([]string{"GOTRACEBACK=2"}, os.Environ()) env := mergeEnvLists([]string{"GOTRACEBACK=2"}, os.Environ())
iOS := t.goos == "darwin" && (t.goarch == "arm" || t.goarch == "arm64") iOS := t.goos == "darwin" && (t.goarch == "arm" || t.goarch == "arm64")
if t.gohostos == "windows" || t.goos == "android" || iOS { switch {
case t.goos == "windows" && t.goarch != "386":
fallthrough
case t.goos == "android", iOS:
cmd := t.dirCmd("misc/cgo/test", "go", "test") cmd := t.dirCmd("misc/cgo/test", "go", "test")
cmd.Env = env cmd.Env = env
return cmd.Run() return cmd.Run()
...@@ -393,7 +397,8 @@ func (t *tester) cgoTest() error { ...@@ -393,7 +397,8 @@ func (t *tester) cgoTest() error {
if err := cmd.Run(); err != nil { if err := cmd.Run(); err != nil {
return err return err
} }
case "darwin-386", "darwin-amd64": case "darwin-386", "darwin-amd64",
"windows-386":
if t.extLink() { if t.extLink() {
cmd := t.dirCmd("misc/cgo/test", "go", "test", "-ldflags", "-linkmode=external") cmd := t.dirCmd("misc/cgo/test", "go", "test", "-ldflags", "-linkmode=external")
cmd.Env = env cmd.Env = env
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment