Commit 4967f857 authored by Russ Cox's avatar Russ Cox

codereview: make sure each mail has a reviewer

R=r
CC=golang-dev
https://golang.org/cl/196050
parent 2e989df0
......@@ -960,8 +960,16 @@ def mail(ui, repo, *pats, **opts):
if err != "":
return err
cl.Upload(ui, repo, gofmt_just_warn=True)
if not cl.reviewer and not cl.cc:
return "no reviewers listed in CL"
if not cl.reviewer:
# If no reviewer is listed, assign the review to defaultcc.
# This makes sure that it appears in the
# codereview.appspot.com/user/defaultcc
# page, so that it doesn't get dropped on the floor.
if not defaultcc:
return "no reviewers listed in CL"
cl.cc = Sub(cl.cc, defaultcc)
cl.reviewer = defaultcc
cl.Flush(ui, repo)
cl.Mail(ui, repo)
def nocommit(ui, repo, *pats, **opts):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment