Commit 5597e3d3 authored by Cherry Zhang's avatar Cherry Zhang

[dev.link] all: reenable cgo internal linking tests

Cgo internal linking was disabled when switching to new object
files. Reeanble the tests, as they get supported.

Change-Id: I11d2ac8785cce73f3a42f6935c10d9f067bc90a4
Reviewed-on: https://go-review.googlesource.com/c/go/+/204520Reviewed-by: default avatarThan McIntosh <thanm@google.com>
parent 496e4273
...@@ -904,9 +904,6 @@ func (t *tester) extLink() bool { ...@@ -904,9 +904,6 @@ func (t *tester) extLink() bool {
} }
func (t *tester) internalLink() bool { func (t *tester) internalLink() bool {
if true { // appease vet...
return false // TODO: newobj
}
if gohostos == "dragonfly" { if gohostos == "dragonfly" {
// linkmode=internal fails on dragonfly since errno is a TLS relocation. // linkmode=internal fails on dragonfly since errno is a TLS relocation.
return false return false
......
...@@ -37,7 +37,7 @@ func canInternalLink() bool { ...@@ -37,7 +37,7 @@ func canInternalLink() bool {
} }
func TestInternalLinkerCgoExec(t *testing.T) { func TestInternalLinkerCgoExec(t *testing.T) {
if !canInternalLink() || true { // TODO: newobj if !canInternalLink() {
t.Skip("skipping; internal linking is not supported") t.Skip("skipping; internal linking is not supported")
} }
testGoExec(t, true, false) testGoExec(t, true, false)
......
...@@ -23,7 +23,6 @@ func TestDefaultLinkerDWARF(t *testing.T) { ...@@ -23,7 +23,6 @@ func TestDefaultLinkerDWARF(t *testing.T) {
} }
func TestInternalLinkerDWARF(t *testing.T) { func TestInternalLinkerDWARF(t *testing.T) {
t.Skip("TODO: newobj")
testCgoDWARF(t, linkCgoInternal) testCgoDWARF(t, linkCgoInternal)
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment