cmd/compile: remove redundant constant shift rules

Normal shift rules plus constant folding are enough to generate
efficient shift-by-constant instructions.

Add test to make sure we don't generate comparisons for constant
shifts.

TODO: there are still constant shift rules on PPC64. If they
are removed, the constant folding rules are not enough to remove
all the test and mask stuff for constant shifts. Leave them in
for now.

Fixes #20663.

Change-Id: I724cc324aa8607762d0c8aacf9bfa641bda5c2a1
Reviewed-on: https://go-review.googlesource.com/60330
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>

src/cmd/compile/internal/gc/asm_test.go

@@ -257,6 +257,11 @@ var allAsmTests = []*asmTests{
 		imports: []string{"math/bits"},
 		tests:   linuxMIPSTests,
 	},
+	{
+		arch:  "mips64",
+		os:    "linux",
+		tests: linuxMIPS64Tests,
+	},
 	{
 		arch:  "ppc64le",
 		os:    "linux",
@@ -1744,6 +1749,17 @@ var linuxARM64Tests = []*asmTest{
 		`,
 		pos: []string{"TEXT\t.*, [$]-8-8"},
 	},
+	{
+		// check that we don't emit comparisons for constant shift
+		fn: `
+//go:nosplit
+		func $(x int) int {
+			return x << 17
+		}
+		`,
+		pos: []string{"LSL\t\\$17"},
+		neg: []string{"CMP"},
+	},
 }
 
 var linuxMIPSTests = []*asmTest{
@@ -1839,6 +1855,19 @@ var linuxMIPSTests = []*asmTest{
 	},
 }
 
+var linuxMIPS64Tests = []*asmTest{
+	{
+		// check that we don't emit comparisons for constant shift
+		fn: `
+		func $(x int) int {
+			return x << 17
+		}
+		`,
+		pos: []string{"SLLV\t\\$17"},
+		neg: []string{"SGT"},
+	},
+}
+
 var linuxPPC64LETests = []*asmTest{
 	// Fused multiply-add/sub instructions.
 	{