Commit 7e49c819 authored by Shenghou Ma's avatar Shenghou Ma Committed by Minux Ma

runtime: skip gdb goroutine backtrace test on non-x86

Gdb is not able to backtrace our non-standard stack frames on RISC
architectures without frame pointer.

Change-Id: Id62a566ce2d743602ded2da22ff77b9ae34bc5ae
Signed-off-by: default avatarShenghou Ma <minux@golang.org>
Reviewed-on: https://go-review.googlesource.com/9456Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 6abfdc3f
...@@ -64,7 +64,7 @@ func TestGdbPython(t *testing.T) { ...@@ -64,7 +64,7 @@ func TestGdbPython(t *testing.T) {
t.Fatalf("building source %v\n%s", err, out) t.Fatalf("building source %v\n%s", err, out)
} }
got, _ := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", args := []string{"-nx", "-q", "--batch", "-iex",
fmt.Sprintf("add-auto-load-safe-path %s/src/runtime", runtime.GOROOT()), fmt.Sprintf("add-auto-load-safe-path %s/src/runtime", runtime.GOROOT()),
"-ex", "br main.go:10", "-ex", "br main.go:10",
"-ex", "run", "-ex", "run",
...@@ -79,11 +79,22 @@ func TestGdbPython(t *testing.T) { ...@@ -79,11 +79,22 @@ func TestGdbPython(t *testing.T) {
"-ex", "echo END\n", "-ex", "echo END\n",
"-ex", "echo BEGIN print ptrvar\n", "-ex", "echo BEGIN print ptrvar\n",
"-ex", "print ptrvar", "-ex", "print ptrvar",
"-ex", "echo END\n", "-ex", "echo END\n"}
"-ex", "echo BEGIN goroutine 2 bt\n",
"-ex", "goroutine 2 bt", // without framepointer, gdb cannot backtrace our non-standard
"-ex", "echo END\n", // stack frames on RISC architectures.
filepath.Join(dir, "a.exe")).CombinedOutput() canBackTrace := false
switch runtime.GOARCH {
case "amd64", "386":
canBackTrace = true
args = append(args,
"-ex", "echo BEGIN goroutine 2 bt\n",
"-ex", "goroutine 2 bt",
"-ex", "echo END\n")
}
args = append(args, filepath.Join(dir, "a.exe"))
got, _ := exec.Command("gdb", args...).CombinedOutput()
firstLine := bytes.SplitN(got, []byte("\n"), 2)[0] firstLine := bytes.SplitN(got, []byte("\n"), 2)[0]
if string(firstLine) != "Loading Go Runtime support." { if string(firstLine) != "Loading Go Runtime support." {
...@@ -117,7 +128,9 @@ func TestGdbPython(t *testing.T) { ...@@ -117,7 +128,9 @@ func TestGdbPython(t *testing.T) {
} }
btGoroutineRe := regexp.MustCompile(`^#0\s+runtime.+at`) btGoroutineRe := regexp.MustCompile(`^#0\s+runtime.+at`)
if bl := blocks["goroutine 2 bt"]; !btGoroutineRe.MatchString(bl) { if bl := blocks["goroutine 2 bt"]; canBackTrace && !btGoroutineRe.MatchString(bl) {
t.Fatalf("goroutine 2 bt failed: %s", bl) t.Fatalf("goroutine 2 bt failed: %s", bl)
} else if !canBackTrace {
t.Logf("gdb cannot backtrace for GOARCH=%s, skipped goroutine backtrace test", runtime.GOARCH)
} }
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment