Commit 903c307c authored by Austin Clements's avatar Austin Clements

runtime/pprof: skip TestStackBarrierProfiling on FreeBSD, too

Sigh. Sleeps on FreeBSD also yield the rest of the time slice and
profiling signals are only delivered when a process completes a time
slice (worse, itimer time is only accounted to the process that
completes a time slice). It's less noticeable than the other BSDs
because the default tick rate is 1000Hz, but it's still failing
regularly.

Fixes #13846.

Change-Id: I41bf116bffe46682433b677183f86944d0944ed4
Reviewed-on: https://go-review.googlesource.com/18455Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
parent 68fe6d40
...@@ -333,11 +333,11 @@ func TestMathBigDivide(t *testing.T) { ...@@ -333,11 +333,11 @@ func TestMathBigDivide(t *testing.T) {
} }
func TestStackBarrierProfiling(t *testing.T) { func TestStackBarrierProfiling(t *testing.T) {
if (runtime.GOOS == "linux" && runtime.GOARCH == "arm") || runtime.GOOS == "openbsd" || runtime.GOOS == "solaris" || runtime.GOOS == "dragonfly" { if (runtime.GOOS == "linux" && runtime.GOARCH == "arm") || runtime.GOOS == "openbsd" || runtime.GOOS == "solaris" || runtime.GOOS == "dragonfly" || runtime.GOOS == "freebsd" {
// This test currently triggers a large number of // This test currently triggers a large number of
// usleep(100)s. These kernels/arches have poor // usleep(100)s. These kernels/arches have poor
// resolution timers, so this gives up a whole // resolution timers, so this gives up a whole
// scheduling quantum. On Linux and OpenBSD (and // scheduling quantum. On Linux and the BSDs (and
// probably Solaris), profiling signals are only // probably Solaris), profiling signals are only
// generated when a process completes a whole // generated when a process completes a whole
// scheduling quantum, so this test often gets zero // scheduling quantum, so this test often gets zero
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment