Commit a4f4a46c authored by Hyang-Ah (Hana) Kim's avatar Hyang-Ah (Hana) Kim Committed by Hyang-Ah Hana Kim

misc/cgo/testcshared: fix test for android.

On android the generated header files are located in
pkg/$(go env GOOS)_$(go env GOARCH)_testcshared.
The test was broken since https://go-review.googlesource.com/9798.

The installation path differs based on codegenArgs
(around src/cmd/go/build.go line 389), and the codegenArgs
is platform dependent.

Change-Id: I01ae9cb957fb7676e399f3b8c067f24c5bd20b9d
Reviewed-on: https://go-review.googlesource.com/9980Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
parent c06b8565
...@@ -15,6 +15,14 @@ if [ ! -f src/libgo/libgo.go ]; then ...@@ -15,6 +15,14 @@ if [ ! -f src/libgo/libgo.go ]; then
fi fi
goos=$(go env GOOS) goos=$(go env GOOS)
goarch=$(go env GOARCH)
# Directory where cgo headers and outputs will be installed.
# The installation directory format varies depending on the platform.
installdir=pkg/${goos}_${goarch}_testcshared_shared
if [ "${goos}/${goarch}" == "android/arm" ]; then
installdir=pkg/${goos}_${goarch}_testcshared
fi
# Temporary directory on the android device. # Temporary directory on the android device.
androidpath=/data/local/tmp/testcshared-$$ androidpath=/data/local/tmp/testcshared-$$
...@@ -22,9 +30,9 @@ androidpath=/data/local/tmp/testcshared-$$ ...@@ -22,9 +30,9 @@ androidpath=/data/local/tmp/testcshared-$$
function cleanup() { function cleanup() {
rm -rf libgo.so libgo2.so libgo.h testp testp2 testp3 pkg rm -rf libgo.so libgo2.so libgo.h testp testp2 testp3 pkg
rm -rf $(go env GOROOT)/pkg/$(go env GOOS)_$(go env GOARCH)_testcshared_shared rm -rf $(go env GOROOT)/${installdir}
if [ "$(go env GOOS)" == "android" ]; then if [ "$goos" == "android" ]; then
adb shell rm -rf $androidpath adb shell rm -rf $androidpath
fi fi
} }
...@@ -38,11 +46,8 @@ function run() { ...@@ -38,11 +46,8 @@ function run() {
case "$goos" in case "$goos" in
"android") "android")
local args=$@ local args=$@
for ((i=0; i < ${#args}; i++)); do output=$(adb shell "cd ${androidpath}; env $@")
args[$i]=${args[$i]//.\//${androidpath}\/} output=$(echo $output|tr -d '\r')
args[$i]=${args[$i]//=./=${androidpath}}
done
output=$(adb shell ${args} | tr -d '\r')
case $output in case $output in
*PASS) echo "PASS";; *PASS) echo "PASS";;
*) echo "$output";; *) echo "$output";;
...@@ -73,8 +78,9 @@ binpush libgo.so ...@@ -73,8 +78,9 @@ binpush libgo.so
# test0: exported symbols in shared lib are accessible. # test0: exported symbols in shared lib are accessible.
# TODO(iant): using _shared here shouldn't really be necessary. # TODO(iant): using _shared here shouldn't really be necessary.
$(go env CC) $(go env GOGCCFLAGS) -I pkg/$(go env GOOS)_$(go env GOARCH)_testcshared_shared -o testp main0.c libgo.so $(go env CC) $(go env GOGCCFLAGS) -I ${installdir} -o testp main0.c libgo.so
binpush testp binpush testp
output=$(run LD_LIBRARY_PATH=. ./testp) output=$(run LD_LIBRARY_PATH=. ./testp)
if [ "$output" != "PASS" ]; then if [ "$output" != "PASS" ]; then
echo "FAIL test0 got ${output}" echo "FAIL test0 got ${output}"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment