Commit a5386f3c authored by Robert Griesemer's avatar Robert Griesemer

cmd/compile: fix internal consistency check with binary exporter

Per feedback from mdempsky from https://go-review.googlesource.com/22096.

Also fix emitted position info.

Change-Id: I7ff1967430867d922be8784832042c75d81df28b
Reviewed-on: https://go-review.googlesource.com/22198
Run-TryBot: Robert Griesemer <gri@golang.org>
Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent 26281446
...@@ -558,16 +558,13 @@ func (p *exporter) typ(t *Type) { ...@@ -558,16 +558,13 @@ func (p *exporter) typ(t *Type) {
Fatalf("exporter: predeclared type missing from type map?") Fatalf("exporter: predeclared type missing from type map?")
} }
// TODO(gri) The assertion below is incorrect (crashes during all.bash), n := typenod(t)
// likely because of symbol shadowing (we expect the respective definition if n.Type != t {
// to point to us). Determine the correct Def so we get correct position Fatalf("exporter: named type definition incorrectly set up")
// info. }
// if tsym.Def.Type != t {
// Fatalf("exporter: type definition doesn't point to us?")
// }
p.tag(namedTag) p.tag(namedTag)
p.pos(tsym.Def) // TODO(gri) this may not be the correct node - fix and add tests p.pos(n)
p.qualifiedName(tsym) p.qualifiedName(tsym)
// write underlying type // write underlying type
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment