Commit b006cd9b authored by Dave Cheney's avatar Dave Cheney

cmd/go: avoid leaking timer if test process failed to start

R=rsc
CC=golang-dev
https://golang.org/cl/7034047
parent 4e2aa9bf
...@@ -642,8 +642,8 @@ func (b *builder) runTest(a *action) error { ...@@ -642,8 +642,8 @@ func (b *builder) runTest(a *action) error {
// This is a last-ditch deadline to detect and // This is a last-ditch deadline to detect and
// stop wedged test binaries, to keep the builders // stop wedged test binaries, to keep the builders
// running. // running.
tick := time.NewTimer(testKillTimeout)
if err == nil { if err == nil {
tick := time.NewTimer(testKillTimeout)
startSigHandlers() startSigHandlers()
done := make(chan error) done := make(chan error)
go func() { go func() {
...@@ -660,8 +660,7 @@ func (b *builder) runTest(a *action) error { ...@@ -660,8 +660,7 @@ func (b *builder) runTest(a *action) error {
tick.Stop() tick.Stop()
} }
out := buf.Bytes() out := buf.Bytes()
t1 := time.Now() t := fmt.Sprintf("%.3fs", time.Since(t0).Seconds())
t := fmt.Sprintf("%.3fs", t1.Sub(t0).Seconds())
if err == nil { if err == nil {
if testShowPass { if testShowPass {
a.testOutput.Write(out) a.testOutput.Write(out)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment