Commit c0751158 authored by Bryan C. Mills's avatar Bryan C. Mills

cmd/dist: remove chatty log.Print

In CL 206757 I added a log.Printf to identify when GOROOT is not read-only.
However, it interacts badly with test sharding in the builders:
the log is repeated for every shard.

Since the log statement isn't particularly high-value, just remove it.

Updates #30316

Change-Id: I385a7f35da59e38ad8b9beef92dc11af931d9571
Reviewed-on: https://go-review.googlesource.com/c/go/+/206898
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: default avatarCarlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent 54cf7760
......@@ -195,7 +195,8 @@ func (t *tester) run() {
restoreGOROOT := func() {}
if strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "linux-") {
if os.Getuid() == 0 {
log.Printf("Not making GOROOT unwritable: running as root, so permissions would have no effect.")
// Don't bother making GOROOT unwritable:
// we're running as root, so permissions would have no effect.
} else {
restoreGOROOT = t.makeGOROOTUnwritable()
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment