Commit c095e92c authored by Josh Bleecher Snyder's avatar Josh Bleecher Snyder

cmd/compile: add comments to trackAllTypes

Per gri's suggestion on CL 41623,
add a comment to trackAllTypes
about the trade-offs of enabling it.

Change-Id: Iec42b0da7933543200729003d1b2c6e0d9dcc5f0
Reviewed-on: https://go-review.googlesource.com/42186Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 51995aa4
...@@ -158,7 +158,10 @@ const exportInlined = true // default: true ...@@ -158,7 +158,10 @@ const exportInlined = true // default: true
// less efficient encoding in rare cases. It also prevents the export of // less efficient encoding in rare cases. It also prevents the export of
// some corner-case type declarations (but those were not handled correctly // some corner-case type declarations (but those were not handled correctly
// with the former textual export format either). // with the former textual export format either).
// TODO(gri) enable and remove once issues caused by it are fixed // Note that when a type is only seen once, as many unnamed types are,
// it is less efficient to track it, since we then also record an index for it.
// See CLs 41622 and 41623 for some data and discussion.
// TODO(gri) enable selectively and remove once issues caused by it are fixed
const trackAllTypes = false const trackAllTypes = false
type exporter struct { type exporter struct {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment