Commit cb664623 authored by Daniel Martí's avatar Daniel Martí

encoding/json: use SetBytes in UnmarshalReuse benchmark

This was the only benchmark missing the SetBytes call, as spotted
earlier by Bryan.

It's not required to make the benchmark useful, but it can still be a
good way to see how its speed is affected by the reduced allocations:

name                  time/op
CodeUnmarshal-8        12.1ms ± 1%
CodeUnmarshalReuse-8   11.4ms ± 1%

name                  speed
CodeUnmarshal-8       161MB/s ± 1%
CodeUnmarshalReuse-8  171MB/s ± 1%

name                  alloc/op
CodeUnmarshal-8        3.28MB ± 0%
CodeUnmarshalReuse-8   1.94MB ± 0%

name                  allocs/op
CodeUnmarshal-8         92.7k ± 0%
CodeUnmarshalReuse-8    77.6k ± 0%

While at it, remove some unnecessary empty lines.

Change-Id: Ib2bd92d5b3237b8f3092e8c6f863dab548fee2f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/170938
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
parent 06cff114
...@@ -242,7 +242,7 @@ func BenchmarkCodeUnmarshalReuse(b *testing.B) { ...@@ -242,7 +242,7 @@ func BenchmarkCodeUnmarshalReuse(b *testing.B) {
} }
} }
}) })
// TODO(bcmills): Is there a missing b.SetBytes here? b.SetBytes(int64(len(codeJSON)))
} }
func BenchmarkUnmarshalString(b *testing.B) { func BenchmarkUnmarshalString(b *testing.B) {
......
...@@ -170,7 +170,6 @@ func ExampleDecoder_Decode_stream() { ...@@ -170,7 +170,6 @@ func ExampleDecoder_Decode_stream() {
// Sam: Go fmt who? // Sam: Go fmt who?
// Ed: Go fmt yourself! // Ed: Go fmt yourself!
// json.Delim: ] // json.Delim: ]
} }
// This example uses RawMessage to delay parsing part of a JSON message. // This example uses RawMessage to delay parsing part of a JSON message.
......
...@@ -368,7 +368,6 @@ var tokenStreamCases = []tokenStreamCase{ ...@@ -368,7 +368,6 @@ var tokenStreamCases = []tokenStreamCase{
} }
func TestDecodeInStream(t *testing.T) { func TestDecodeInStream(t *testing.T) {
for ci, tcase := range tokenStreamCases { for ci, tcase := range tokenStreamCases {
dec := NewDecoder(strings.NewReader(tcase.json)) dec := NewDecoder(strings.NewReader(tcase.json))
...@@ -401,7 +400,6 @@ func TestDecodeInStream(t *testing.T) { ...@@ -401,7 +400,6 @@ func TestDecodeInStream(t *testing.T) {
} }
} }
} }
} }
// Test from golang.org/issue/11893 // Test from golang.org/issue/11893
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment