Commit f2a520f4 authored by Russ Cox's avatar Russ Cox

clean up error output;

do not print entire buffer on error,
since it can be very large.
instead print identifying string.

R=krasin
DELTA=14  (1 added, 3 deleted, 10 changed)
OCL=35141
CL=35143
parent b71c484c
...@@ -6,6 +6,7 @@ package flate ...@@ -6,6 +6,7 @@ package flate
import ( import (
"bytes"; "bytes";
"fmt";
"io"; "io";
"os"; "os";
"testing"; "testing";
...@@ -88,43 +89,40 @@ func TestDeflate(t *testing.T) { ...@@ -88,43 +89,40 @@ func TestDeflate(t *testing.T) {
} }
} }
func testToFromWithLevel(t *testing.T, level int, input []byte) os.Error { func testToFromWithLevel(t *testing.T, level int, input []byte, name string) os.Error {
buffer := bytes.NewBuffer([]byte{}); buffer := bytes.NewBuffer([]byte{});
w := NewDeflater(buffer, level); w := NewDeflater(buffer, level);
w.Write(input); w.Write(input);
w.Close(); w.Close();
arr := buffer.Bytes();
t.Logf("compressed: %v, %v", len(arr), arr);
inflater := NewInflater(buffer); inflater := NewInflater(buffer);
decompressed, err := io.ReadAll(inflater); decompressed, err := io.ReadAll(inflater);
if err != nil && err != os.EOF { if err != nil {
t.Errorf("The error reading the buffer, %v", err); t.Errorf("reading inflater: %s", err);
return err; return err;
} }
inflater.Close(); inflater.Close();
if bytes.Compare(input, decompressed) != 0 { if bytes.Compare(input, decompressed) != 0 {
t.Errorf("the data was changed after deflate/inflate. Level: %v, input: %v, decompressed: %v", t.Errorf("decompress(compress(data)) != data: level=%d input=%s", level, name);
level, input, decompressed);
} }
return nil; return nil;
} }
func testToFrom(t * testing.T, input[] byte) { func testToFrom(t *testing.T, input[] byte, name string) {
for i := 0; i < 10; i++ { for i := 0; i < 10; i++ {
testToFromWithLevel(t, i, input); testToFromWithLevel(t, i, input, name);
} }
} }
func TestDeflateInflate(t *testing.T) { func TestDeflateInflate(t *testing.T) {
for _, h := range deflateInflateTests { for i, h := range deflateInflateTests {
testToFrom(t, h.in); testToFrom(t, h.in, fmt.Sprintf("#%d", i));
} }
} }
func TestReverseBits(t *testing.T) { func TestReverseBits(t *testing.T) {
for _, h := range reverseBitsTests { for _, h := range reverseBitsTests {
if v := reverseBits(h.in, h.bitCount); v != h.out { if v := reverseBits(h.in, h.bitCount); v != h.out {
t.Errorf("reverseBits(%v,%v) returned %v, %v expected", t.Errorf("reverseBits(%v,%v) = %v, want %v",
h.in, h.bitCount, v, h.out); h.in, h.bitCount, v, h.out);
} }
} }
...@@ -132,7 +130,7 @@ func TestReverseBits(t *testing.T) { ...@@ -132,7 +130,7 @@ func TestReverseBits(t *testing.T) {
func TestDeflateInflateString(t *testing.T) { func TestDeflateInflateString(t *testing.T) {
gold := bytes.NewBufferString(getEdata()).Bytes(); gold := bytes.NewBufferString(getEdata()).Bytes();
testToFromWithLevel(t, 1, gold); testToFromWithLevel(t, 1, gold, "2.718281828...");
} }
func getEdata() string { func getEdata() string {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment