Commit f2cde55c authored by Michael Munday's avatar Michael Munday

runtime: use Go function signatures for memclr and memmove comments

The function signatures in the comments used a C-like style. Using
Go function signatures is cleaner.

Change-Id: I1a093ed8fe5df59f3697c613cf3fce58bba4f5c1
Reviewed-on: https://go-review.googlesource.com/113876
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
parent 5654114d
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
// NOTE: Windows externalthreadhandler expects memclr to preserve DX. // NOTE: Windows externalthreadhandler expects memclr to preserve DX.
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-8 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-8
MOVL ptr+0(FP), DI MOVL ptr+0(FP), DI
MOVL n+4(FP), BX MOVL n+4(FP), BX
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
// NOTE: Windows externalthreadhandler expects memclr to preserve DX. // NOTE: Windows externalthreadhandler expects memclr to preserve DX.
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-16 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-16
MOVQ ptr+0(FP), DI MOVQ ptr+0(FP), DI
MOVQ n+8(FP), BX MOVQ n+8(FP), BX
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "textflag.h" #include "textflag.h"
// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
MOVL ptr+0(FP), DI MOVL ptr+0(FP), DI
MOVL n+4(FP), CX MOVL n+4(FP), CX
......
...@@ -30,6 +30,7 @@ ...@@ -30,6 +30,7 @@
#define N R12 #define N R12
#define TMP R12 /* N and TMP don't overlap */ #define TMP R12 /* N and TMP don't overlap */
// func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
MOVW ptr+0(FP), TO MOVW ptr+0(FP), TO
MOVW n+4(FP), N MOVW n+4(FP), N
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16
MOVD ptr+0(FP), R0 MOVD ptr+0(FP), R0
MOVD n+8(FP), R1 MOVD n+8(FP), R1
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16
MOVV ptr+0(FP), R1 MOVV ptr+0(FP), R1
MOVV n+8(FP), R2 MOVV n+8(FP), R2
......
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
#define MOVWLO MOVWL #define MOVWLO MOVWL
#endif #endif
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-8
MOVW n+4(FP), R2 MOVW n+4(FP), R2
MOVW ptr+0(FP), R1 MOVW ptr+0(FP), R1
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-8 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-8
MOVL ptr+0(FP), DI MOVL ptr+0(FP), DI
MOVL n+4(FP), BX MOVL n+4(FP), BX
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT,$0-16
MOVQ ptr+0(FP), DI MOVQ ptr+0(FP), DI
MOVQ n+8(FP), CX MOVQ n+8(FP), CX
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT|NOFRAME, $0-16 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT|NOFRAME, $0-16
MOVD ptr+0(FP), R3 MOVD ptr+0(FP), R3
MOVD n+8(FP), R4 MOVD n+8(FP), R4
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT|NOFRAME,$0-16 TEXT runtime·memclrNoHeapPointers(SB),NOSPLIT|NOFRAME,$0-16
MOVD ptr+0(FP), R4 MOVD ptr+0(FP), R4
MOVD n+8(FP), R5 MOVD n+8(FP), R5
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memclrNoHeapPointers(void*, uintptr) // func memclrNoHeapPointers(ptr unsafe.Pointer, n uintptr)
TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-16 TEXT runtime·memclrNoHeapPointers(SB), NOSPLIT, $0-16
MOVD ptr+0(FP), R0 MOVD ptr+0(FP), R0
MOVD n+8(FP), R1 MOVD n+8(FP), R1
......
...@@ -27,6 +27,7 @@ ...@@ -27,6 +27,7 @@
#include "textflag.h" #include "textflag.h"
// func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $0-12 TEXT runtime·memmove(SB), NOSPLIT, $0-12
MOVL to+0(FP), DI MOVL to+0(FP), DI
MOVL from+4(FP), SI MOVL from+4(FP), SI
......
...@@ -27,7 +27,7 @@ ...@@ -27,7 +27,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $0-24 TEXT runtime·memmove(SB), NOSPLIT, $0-24
MOVQ to+0(FP), DI MOVQ to+0(FP), DI
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
// This could use MOVSQ, but we use MOVSL so that if an object ends in // This could use MOVSQ, but we use MOVSL so that if an object ends in
// a 4 byte pointer, we copy it as a unit instead of byte by byte. // a 4 byte pointer, we copy it as a unit instead of byte by byte.
// func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $0-12 TEXT runtime·memmove(SB), NOSPLIT, $0-12
MOVL to+0(FP), DI MOVL to+0(FP), DI
MOVL from+4(FP), SI MOVL from+4(FP), SI
......
...@@ -58,6 +58,7 @@ ...@@ -58,6 +58,7 @@
#define FW3 R4 #define FW3 R4
#define FR3 R8 /* shared with TE */ #define FR3 R8 /* shared with TE */
// func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $4-12 TEXT runtime·memmove(SB), NOSPLIT, $4-12
_memmove: _memmove:
MOVW to+0(FP), TS MOVW to+0(FP), TS
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24 TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24
MOVD to+0(FP), R3 MOVD to+0(FP), R3
MOVD from+8(FP), R4 MOVD from+8(FP), R4
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24 TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24
MOVV to+0(FP), R1 MOVV to+0(FP), R1
MOVV from+8(FP), R2 MOVV from+8(FP), R2
......
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
#define MOVWLO MOVWL #define MOVWLO MOVWL
#endif #endif
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB),NOSPLIT,$-0-12 TEXT runtime·memmove(SB),NOSPLIT,$-0-12
MOVW n+8(FP), R3 MOVW n+8(FP), R3
MOVW from+4(FP), R2 MOVW from+4(FP), R2
......
...@@ -25,6 +25,7 @@ ...@@ -25,6 +25,7 @@
#include "textflag.h" #include "textflag.h"
// func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $0-12 TEXT runtime·memmove(SB), NOSPLIT, $0-12
MOVL to+0(FP), DI MOVL to+0(FP), DI
MOVL from+4(FP), SI MOVL from+4(FP), SI
......
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $0-24 TEXT runtime·memmove(SB), NOSPLIT, $0-24
MOVQ to+0(FP), DI MOVQ to+0(FP), DI
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24 TEXT runtime·memmove(SB), NOSPLIT|NOFRAME, $0-24
MOVD to+0(FP), R3 MOVD to+0(FP), R3
MOVD from+8(FP), R4 MOVD from+8(FP), R4
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB),NOSPLIT|NOFRAME,$0-24 TEXT runtime·memmove(SB),NOSPLIT|NOFRAME,$0-24
MOVD to+0(FP), R6 MOVD to+0(FP), R6
MOVD from+8(FP), R4 MOVD from+8(FP), R4
......
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
#include "textflag.h" #include "textflag.h"
// void runtime·memmove(void*, void*, uintptr) // func memmove(to, from unsafe.Pointer, n uintptr)
TEXT runtime·memmove(SB), NOSPLIT, $0-24 TEXT runtime·memmove(SB), NOSPLIT, $0-24
MOVD to+0(FP), R0 MOVD to+0(FP), R0
MOVD from+8(FP), R1 MOVD from+8(FP), R1
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment