Commit ff90f4af authored by Elias Naur's avatar Elias Naur

Revert "misc/cgo/testcshared: temporarily skip testing on android"

This reverts commit a6ffab6b.

Reason for revert: with CL 57290 the tests run on Android again.

Change-Id: Ifeb29762a4cd0178463acfeeb3696884d99d2993
Reviewed-on: https://go-review.googlesource.com/57310Reviewed-by: default avatarAlex Brainman <alex.brainman@gmail.com>
parent a9e0204c
......@@ -259,9 +259,6 @@ func cleanupAndroid(t *testing.T) {
// test0: exported symbols in shared lib are accessible.
func TestExportedSymbols(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
cmd := "testp"
bin := cmdToRun(cmd)
......@@ -284,9 +281,6 @@ func TestExportedSymbols(t *testing.T) {
// test1: shared library can be dynamically loaded and exported symbols are accessible.
func TestExportedSymbolsWithDynamicLoad(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
cmd := "testp"
bin := cmdToRun(cmd)
......@@ -309,9 +303,6 @@ func TestExportedSymbolsWithDynamicLoad(t *testing.T) {
// test2: tests libgo2 which does not export any functions.
func TestUnexportedSymbols(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
cmd := "testp2"
libname := "libgo2." + libSuffix
bin := cmdToRun(cmd)
......@@ -351,9 +342,6 @@ func TestUnexportedSymbols(t *testing.T) {
// test3: tests main.main is exported on android.
func TestMainExportedOnAndroid(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
if GOOS != "android" {
return
}
......@@ -380,9 +368,6 @@ func TestMainExportedOnAndroid(t *testing.T) {
// test4: test signal handlers
func TestSignalHandlers(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
cmd := "testp4"
libname := "libgo4." + libSuffix
bin := cmdToRun(cmd)
......@@ -416,9 +401,6 @@ func TestSignalHandlers(t *testing.T) {
// test5: test signal handlers with os/signal.Notify
func TestSignalHandlersWithNotify(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
cmd := "testp5"
libname := "libgo5." + libSuffix
bin := cmdToRun(cmd)
......@@ -451,9 +433,6 @@ func TestSignalHandlersWithNotify(t *testing.T) {
}
func TestPIE(t *testing.T) {
if GOOS == "android" {
t.Skip("Skipping failing test, see issue 21513 for details")
}
switch GOOS {
case "linux", "android":
break
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment