- 29 Jul, 2019 3 commits
-
-
Keith Randall authored
Overflow of the comparison caused very large (>=1<<32) allocations to sometimes not get sampled at all. Use uintptr so the comparison will never overflow. Fixes #33342 Tested on the example in 33342. I don't want to check a test in that needs that much memory, however. Change-Id: I51fe77a9117affed8094da93c0bc5f445ac2d3d3 Reviewed-on: https://go-review.googlesource.com/c/go/+/188017 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
-
Jonathan Amsterdam authored
Also, reorder packages so the list is in alphabetical order. Fixes #32914. Change-Id: Ifa504cb7e48df31ba6dc0e5756148430b59fa139 Reviewed-on: https://go-review.googlesource.com/c/go/+/187797Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Filippo Valsorda authored
ParsePKIXPublicKey gained Ed25519 support in CL 175478. Change-Id: I11ffe0a62743292367b3adb103956e61bad57cc4 Reviewed-on: https://go-review.googlesource.com/c/go/+/183243Reviewed-by: Katie Hockman <katie@golang.org>
-
- 28 Jul, 2019 1 commit
-
-
Dominik Honnef authored
Change-Id: I932de9bb061a8ba3332ef03207983e8b98d6f1e5 Reviewed-on: https://go-review.googlesource.com/c/go/+/187918Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 27 Jul, 2019 2 commits
-
-
Daniel Martí authored
Spotted while seeing CL 187818 in master. Change-Id: Ic3f42558f6833fc35580b2b2a15f2c5aba5713c0 Reviewed-on: https://go-review.googlesource.com/c/go/+/187822Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Giovanni Bajo authored
As noticed while mentoring at Gophercon, a common mistake for beginners is that, after they install git-codereview, it's not found by git because they haven't put GOPATH/bin in their environment. Change-Id: I885cee0f532a4069d1a17ea27365d54965ecca22 Reviewed-on: https://go-review.googlesource.com/c/go/+/187818Reviewed-by: Katie Hockman <katie@golang.org>
-
- 23 Jul, 2019 4 commits
-
-
Emmanuel T Odeke authored
Document that *os.File is subject to resource limits for concurrent operations. We aren't documenting a specific number of concurrent operations because that number is OS/system dependent. This limit comes from: internal/poll/fd_mutex.go where we use 20 bits to count locks. Fixes #32544 Change-Id: I7d305d4aaba5b2dbc6f1ab8c447117fde5e31a66 Reviewed-on: https://go-review.googlesource.com/c/go/+/181841Reviewed-by: Rob Pike <r@golang.org>
-
Jordi Martin authored
Fixed missing concatenation to build the suggested command. Fixes #33153 Change-Id: I26c02f2966247aa07d1447b8ec1a2203046842dd GitHub-Last-Rev: 9631abf1d0d187cbd94495a2a789e5863b421441 GitHub-Pull-Request: golang/go#33245 Reviewed-on: https://go-review.googlesource.com/c/go/+/187217Reviewed-by: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Than McIntosh authored
Updates #33219 Change-Id: I1702d4c630bb891fcb8b59e775dd3f1673cd8640 Reviewed-on: https://go-review.googlesource.com/c/go/+/187057 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Ian Lance Taylor authored
Change-Id: Id2c07ccba7c514ec3a4bbd493edbc68ae5cd6250 Reviewed-on: https://go-review.googlesource.com/c/go/+/187157 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org>
-
- 22 Jul, 2019 2 commits
-
-
Bryan C. Mills authored
Fixes #31859 Change-Id: I228ed93f9466d1a22f8796964f5d2f056ab9b62f Reviewed-on: https://go-review.googlesource.com/c/go/+/186818 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Caleb Spare <cespare@gmail.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
-
Bryan C. Mills authored
This reverts CL 176098. Reason for revert: added complexity, but did not completely fix the underlying problem. A complete solution would not be worth the complexity, and as a partial solution this is probably not worth the complexity either. Updates #31859 Change-Id: Ifd34c292fd1b811c60afe3c339e5edd3f37190c8 Reviewed-on: https://go-review.googlesource.com/c/go/+/186817 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Caleb Spare <cespare@gmail.com>
-
- 19 Jul, 2019 2 commits
-
-
Jay Conrod authored
Fixes #33149 Change-Id: If9ff24fea6d087b4047a9f6e50f99f449f9b1c52 Reviewed-on: https://go-review.googlesource.com/c/go/+/186618 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Austin Clements authored
Currently, GODEBUG=sbrk=1 mode aligns allocations by their type's alignment. You would think this would be the right thing to do, but because 64-bit fields are only 4-byte aligned right now (see #599), this can cause a 64-bit field of an allocated object to be 4-byte aligned, but not 8-byte aligned. If there is an atomic access to that unaligned 64-bit field, it will crash. This doesn't happen in normal allocation mode because the size-segregated allocation and the current size classes will cause any types larger than 8 bytes to be 8 byte aligned. We fix this by making sbrk=1 mode use alignment based on the type's size rather than its declared alignment. This matches how the tiny allocator aligns allocations. This was tested with GOARCH=386 GODEBUG=sbrk=1 go test sync/atomic This crashes with an unaligned access before this change, and passes with this change. This should be reverted when/if we fix #599. Fixes #33159. Change-Id: Ifc52c72c6b99c5d370476685271baa43ad907565 Reviewed-on: https://go-review.googlesource.com/c/go/+/186919 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 18 Jul, 2019 7 commits
-
-
Allen Li authored
Updates #27169 Change-Id: I22a6194c06529ba70b1ec648e3188c191224e321 GitHub-Last-Rev: 457b2a61a8ee4a745371c87756e5b6f38058af28 GitHub-Pull-Request: golang/go#32996 Reviewed-on: https://go-review.googlesource.com/c/go/+/185245Reviewed-by: Rob Pike <r@golang.org>
-
Bryan C. Mills authored
cmd/go/internal/mvs: in Req, omit versions implied by older-than-selected versions already in the graph Fixes #31248 Change-Id: Ia54f2098c3b85549681198a487a31e8ce8fc59eb Reviewed-on: https://go-review.googlesource.com/c/go/+/186557 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Bryan C. Mills authored
Fixes #29773 Updates #31248 Change-Id: Ic1923119c8cf3a60c586df1b270c3af0c9095f29 Reviewed-on: https://go-review.googlesource.com/c/go/+/186537 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Bryan C. Mills authored
'go test' uses the Root field to determine the set of files that invalidate test results, and there is no other sensible meaning of “root” for code within a module. Fixes #29111 Change-Id: Icf1be90a26d22665613e42cb968087b63c36e74c Reviewed-on: https://go-review.googlesource.com/c/go/+/154100 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Bryan C. Mills authored
Fixes #33154 Change-Id: I5a249a77843a8bd438006af0fa1d8b4429ee25f4 Reviewed-on: https://go-review.googlesource.com/c/go/+/186617 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Than McIntosh authored
Updates #33158. Change-Id: Id87eb00ddcb104ba8e7a0d2f6cf324a77a84f4a9 Reviewed-on: https://go-review.googlesource.com/c/go/+/186717Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Than McIntosh authored
Updates #33020 Change-Id: I82554ef20ea35e0087fd9ecd9548c2dfeacdc617 Reviewed-on: https://go-review.googlesource.com/c/go/+/186697 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 17 Jul, 2019 4 commits
-
-
Jay Conrod authored
The go command invokes each tool with -V=full to discover its version to compute a tool id. For release versions (that don't include the word "devel"), the go command only used the third word in the output (e.g., "go1.13"), ignoring any toolchain experiments that followed. With this change, the go command will use whole version line in the tool id for release versions. Also, when -V=full is set and there are non-default experiments, experiments are no longer printed twice. Fixes #33091 Change-Id: I19b96f939c7e2fbc5d8befe3659156ee4b58daef Reviewed-on: https://go-review.googlesource.com/c/go/+/186200 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Joe Tsai authored
In Go1.12 and below, the logic in ReverseProxy.ServeHTTP would always allocate request.Header even if it were not present in the incoming request. CL 174324 added http.Request.Clone and re-factors ReverseProxy.ServeHTTP to use the new Clone method. However, the new Clone logic is not equivalent to the former logic. We preserve former semantics by explicitly allocating the Header map if nil. Fixes #33142 Change-Id: I356f94a915dd9779584ce3fe31e56e5474b9ad37 Reviewed-on: https://go-review.googlesource.com/c/go/+/186437 Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Alberto Donizetti authored
While it's true that CL 168479 was also backported to 1.12, this is irrelevant for the Go1.13 release notes. Change-Id: I044be69f8f2bc005f58a0d63db05129add15f674 Reviewed-on: https://go-review.googlesource.com/c/go/+/186138Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Dmitri Shuralyov authored
This update has been automatically generated using the updatecontrib command: cd gotip go run golang.org/x/build/cmd/updatecontrib With minor manual changes to canonicalize letter case for a few names. Actions taken (relative to CONTRIBUTORS at origin/master): Added Ahsun Ahmed <ahmed.ahsun@gmail.com> Added Al Cutter <al@google.com> Added Alex Tokarev <aleksator@gmail.com> Added Alexander Lourier <aml@rulezz.ru> Added Alexander Rakoczy <alex@golang.org> Added Andrei Matei <andrei@cockroachlabs.com> Added Andrei Vagin <avagin@google.com> Added Andrew Z Allen <me@andrewzallen.com> Added Aofei Sheng <aofei@aofeisheng.com> Added Arash Bina <arash@arash.io> Added Benjamin Peterson <benjamin@python.org> Added Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> Added Brandon Ryan <bjryan19@gmail.com> Added Bryan Heden <b.heden@gmail.com> Added Carlos Eduardo <me@carlosedp.com> Added Carrie Bynon <cbynon@gmail.com> Added Chris Marchesi <chrism@vancluevertech.com> Added Colin Arnott <colin@urandom.co.uk> Added Daniel Cormier <danielc@knowbe4.com> Added Daniel Langner <s8572327@gmail.com> Added Daniel Lublin <daniel@lublin.se> Added Darren Grant <darren.e.grant@gmail.com> Added Derek Phan <derekphan94@gmail.com> Added Dmitri Goutnik <dgoutnik@gmail.com> Added Dmitry Mottl <dmitry.mottl@gmail.com> Added Eli Bendersky <eliben@google.com> Added Evan Digby <evandigby@gmail.com> Added Fedor Korotkiy <dartslon@gmail.com> Added Felix Bünemann <Felix.Buenemann@gmail.com> Added Francesco Renzi <rentziass@gmail.com> Added Gabriel Guzman <gabe.guzman@gmail.com> Added Gabriel Nelle <tehsphinx@web.de> Added Gernot Vormayr <gvormayr@gmail.com> Added GitHub User ZZMarquis (7624583) <zhonglingjian3821@163.com> Added GitHub User alkesh26 (1019076) <alkesh26@gmail.com> Added GitHub User bakape (7851952) <bakape@gmail.com> Added GitHub User frennkie (6499251) <mail@rhab.de> Added GitHub User hengwu0 (41297446) <41297446+hengwu0@users.noreply.github.com> Added GitHub User kazyshr (30496953) <kazyshr0301@gmail.com> Added GitHub User linguohua (3434367) <lghchinaidea@gmail.com> Added GitHub User micnncim (21333876) <micnncim@gmail.com> Added Gordon Tyler <gordon@doxxx.net> Added Greg Thelen <gthelen@google.com> Added Haosdent Huang <haosdent@gmail.com> Added Hasan Ozgan <hasan@ozgan.net> Added Henry Wong <liushuai.wang@elastic.co> Added Horst Rutter <hhrutter@gmail.com> Added Ivan Osadchiy <ivan.osadchii@gmail.com> Added JT Olio <hello@jtolio.com> Added Jacob Blain Christen <dweomer5@gmail.com> Added Jacob Walker <jacobwalker0814@gmail.com> Added James Nugent <james@jen20.com> Added Jannis Andrija Schnitzer <jannis@schnitzer.im> Added Jean-François Bustarret <jf@bustarret.com> Added Jeremy Jay <jeremy@pbnjay.com> Added Jeroen Simonetti <jeroen@simonetti.nl> Added Jingnan Si <jingnan.si@gmail.com> Added Jinkun Zhang <franksnolf@gmail.com> Added John Moore <johnkenneth.moore@gmail.com> Added John Weldon <johnweldon4@gmail.com> Added Jonathon Lacher <jonathon.lacher@gmail.com> Added Jordan Liggitt <liggitt@google.com> Added Joshua M. Clulow <josh.clulow@joyent.com> Added Juraj Sukop <sukop@users.noreply.github.com> Added Justin Li <git@justinli.net> Added Kai Dong <dokia2357@gmail.com> Added Kenichi Tsunokawa <kenichi.tsunokawa@gmail.com> Added Kenta Mori <zoncoen@gmail.com> Added Ketan Parmar <ketanbparmar@gmail.com> Added Kirill Motkov <Motkov.Kirill@gmail.com> Added Kshitij Saraogi <kshitijsaraogi@gmail.com> Added Leonardo Comelli <leonardo.comelli@gmail.com> Added Lorenz Nickel <mail@lorenznickel.de> Added Luka Zitnik <luka.zitnik@gmail.com> Added Luke Champine <luke.champine@gmail.com> Added Madhu Rajanna <madhupr007@gmail.com> Added Marat Khabibullin <marat.khabibullin@jetbrains.com> Added Mark Villacampa <m@markvillacampa.com> Added Max Semenik <maxsem.wiki@gmail.com> Added Maxim Eryomenko <moeryomenko@gmail.com> Added Michael Cook <code@mdcook.net> Added Michael Vogt <mvo@ubuntu.com> Added Mickael KERJEAN <mickael.kerjean@gmail.com> Added Mickey Reiss <mickeyreiss@gmail.com> Added Mihai Moldovan <ionic@ionic.de> Added Mirko Hansen <baaazen@gmail.com> Added Muir Manders <muir@mnd.rs> Added Mykhailo Lesyk <mikhail@lesyk.org> Added Nick Anthony <Liberatys@outlook.com> Added Nikita Kryuchkov <nkryuchkov10@gmail.com> Added Nir Soffer <nirsof@gmail.com> Added Norman B. Lancaster <qbradq@gmail.com> Added Patrick Barker <barkerp@vmware.com> Added Patrik Lundin <patrik@sigterm.se> Added Petr Jediný <petr.jediny@gmail.com> Added Robert Ayrapetyan <robert.ayrapetyan@gmail.com> Added Robert van Gent <rvangent@google.com> Added Rohan Verma <rohanverma2004@gmail.com> Added Romain Baugue <romain.baugue@elwinar.com> Added Sad Pencil <qh06@qq.com> Added Segev Finer <segev208@gmail.com> Added Sergey Dobrodey <sergey.dobrodey@synesis.ru> Added Sergey Yanykin <syanykin@ozon.ru> Added Shawn Elliott <selliott@microsoft.com> Added Shengjing Zhu <zsj950618@gmail.com> Added Shubham Sharma <shubham.sha12@gmail.com> Added Stephan Zuercher <zuercher@gmail.com> Added Steve Mynott <steve.mynott@gmail.com> Added Tai Le <letientai299@gmail.com> Added Todd Kulesza <tkulesza@google.com> Added Tom Anthony <git@tomanthony.co.uk> Added Tooru Takahashi <tooru.takahashi134@gmail.com> Added Udalov Max <re.udalov@gmail.com> Added Valentin Vidic <vvidic@valentin-vidic.from.hr> Added Vivek Sekhar <vsekhar@google.com> Added WEI Xikai <xykwei@gmail.com> Added Wenlei (Frank) He <wlhe@google.com> Added Wenzel Lowe <lowewenzel@gmail.com> Added Yang Tian <linuxty@gmail.com> Added Yasser Abdolmaleki <yasser@yasser.ca> Added Zach Jones <zachj1@gmail.com> Added adarsh ravichandran <adarshravichandran91@gmail.com> Added berkant ipek <41230766+0xbkt@users.noreply.github.com> Added karthik nayak <karthik.188@gmail.com> Added marius a. eriksen <marius@grailbio.com> Added Максадбек Ахмедов <a.maksadbek@gmail.com> Used GitHub User ZZMarquis (7624583) form for ZZMarquis <zhonglingjian3821@163.com> https://github.com/golang/go/commit/b00ef3b865 [go] Used GitHub User alkesh26 (1019076) form for alkesh26 <alkesh26@gmail.com> https://github.com/golang/go/commit/c7f69a2897 [go] Used GitHub User bakape (7851952) form for bakape <bakape@gmail.com> https://github.com/golang/go/commit/27e444d5e6 [go] Used GitHub User frennkie (6499251) form for frennkie <mail@rhab.de> https://github.com/golang/go/commit/ee46250e06 [go] Used GitHub User hengwu0 (41297446) form for hengwu0 <41297446+hengwu0@users.noreply.github.com> https://github.com/golang/go/commit/95d4e6158b [go] Used GitHub User kazyshr (30496953) form for kazyshr <kazyshr0301@gmail.com> https://github.com/golang/tools/commit/0fdf0c73 [tools] Used GitHub User linguohua (3434367) form for linguohua <lghchinaidea@gmail.com> https://github.com/golang/tools/commit/97de5656 [tools] Used GitHub User micnncim (21333876) form for micnncim <micnncim@gmail.com> https://github.com/golang/tools/commit/15d5d381 [tools] Used GitHub name "Akhil Indurti" for smasher164 <aindurti@gmail.com> https://github.com/golang/go/commit/5ca44dc403 [build go] Used GitHub name "Carlos Eduardo" for CarlosEDP <me@carlosedp.com> https://github.com/golang/net/commit/018c4d4 [net] Used GitHub name "Ivan Markin" for nogoegst <nogoegst@users.noreply.github.com> https://github.com/golang/go/commit/a1addf15df [go] Used GitHub name "Jean-François Bustarret" for jfbus <jf@bustarret.com> https://github.com/golang/go/commit/825ff1e317 [go] Used GitHub name "Jinkun Zhang" for smileeye <franksnolf@gmail.com> https://github.com/golang/go/commit/607493bed6 [go] Used GitHub name "John Moore" for guitarbum722 <johnkenneth.moore@gmail.com> https://github.com/golang/go/commit/44c9354c5a [go] Used GitHub name "Keiji Yoshida" for yosssi <yoshida.keiji.84@gmail.com> https://github.com/golang/lint/commit/ac6833c [lint] Used GitHub name "Kenta Mori" for zoncoen <zoncoen@gmail.com> https://github.com/golang/net/commit/fe579d4 [net] Used GitHub name "Kirill Motkov" for Motkov.Kirill <Motkov.Kirill@gmail.com> https://github.com/golang/go/commit/0ff0df8be3 [go] Used GitHub name "Luke Champine" for lukechampine <luke.champine@gmail.com> https://github.com/golang/go/commit/9d40fadb1c [crypto go] Used GitHub name "Michalis Kargakis" for kargakis <mkargaki@redhat.com> https://github.com/golang/go/commit/e243d242d7 [go] Used GitHub name "Nick Anthony" for Liberatys <Liberatys@outlook.com> https://github.com/golang/go/commit/62ddf7d0c5 [go] Used GitHub name "Robert Ayrapetyan" for rayrapetyan <robert.ayrapetyan@gmail.com> https://github.com/golang/sys/commit/bf70e46 [sys] Used GitHub name "Robin Eklind" for mewmew <rnd0x00@gmail.com> https://github.com/golang/go/commit/b8620afb8d [blog go proposal.git] Used GitHub name "Sergey Dobrodey" for sergeydobrodey <sergey.dobrodey@synesis.ru> https://github.com/golang/net/commit/e869164 [net] Used GitHub name "Tai Le" for Tai <letientai299@gmail.com> https://github.com/golang/build/commit/1b388d2 [build tools] Used GitHub name "WEI Xikai" for ShiKaiWi <xykwei@gmail.com> https://github.com/golang/go/commit/518ee55d78 [go] Used GitHub name "Yang Tian" for taoyuanyuan <linuxty@gmail.com> https://github.com/golang/go/commit/5eeb372418 [go] Used GitHub name "Zach Jones" for zdjones <zachj1@gmail.com> https://github.com/golang/go/commit/c178389604 [go] Updates #12042 Change-Id: Ic220d997a0dc3bf4109ab964cbb6a25ea5c0c9da Reviewed-on: https://go-review.googlesource.com/c/go/+/186397Reviewed-by: Alexander Rakoczy <alex@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 16 Jul, 2019 4 commits
-
-
Jay Conrod authored
Changes "was loaded as" to "was required as". This is slightly more precise, since it hints at a requirement edge in the module version graph. Updates #28489 Change-Id: I636268c33f1ea9858c214fe275f271538186ed6d Reviewed-on: https://go-review.googlesource.com/c/go/+/186377 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Cherry Zhang authored
With gccgo, if we generate getg inlined, the backend may cache the address of the TLS variable, which will become invalid after a thread switch. Currently there is no known bug for this. But if we didn't implement this carefully, we may get subtle bugs. This CL adds a test that will fail loudly if this is wrong. (See also https://go.googlesource.com/gofrontend/+/refs/heads/master/libgo/runtime/proc.c#333 and an incorrect attempt CL 185337.) Note: at least on Linux/AMD64, even with an incorrect implementation, this only fails if the test is compiled with -fPIC, which is not the default setting for gccgo test suite. So some manual work is needed. Maybe we could extend the test suite to run the runtime test with more settings (e.g. PIC and static). Change-Id: I459a3b4c31f09b9785c0eca19b7756f80e8ef54c Reviewed-on: https://go-review.googlesource.com/c/go/+/186357 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Bryan C. Mills authored
Do not allow a pseudo-version derived from a canonical tag to refer to the same revision as the tag itself. It's unnecessary (because canonical tags already have a total ordering) and confusing (the pseudo-version appears to come after the tag, but actually refers to the exact same revision). Updates #32879 Updates #27173 Change-Id: I02befedbe89c8819bdd93e470783ce63fc813193 Reviewed-on: https://go-review.googlesource.com/c/go/+/184720 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Jay Conrod authored
This error occurs when a module is loaded with one name (for example, github.com/golang/lint) but declares a different path in its go.mod (golang.org/x/lint). The current text "unexpected module path" is confusing. It doesn't explain why the path was unexpected, and it's not clear what was expected. With this change, the error text includes the module and version containing the go.mod file with the error, the declared module path, and the loaded module path. The paths are vertically aligned so differences are visually obvious. As with other module version errors, the shortest chain of requirements is printed. This change supercedes CL 158477. Fixes #28489 Change-Id: Ieb07d00bcae182376d7be6aad111c84fbf784354 Reviewed-on: https://go-review.googlesource.com/c/go/+/185985 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
- 15 Jul, 2019 6 commits
-
-
Filippo Valsorda authored
Updates #32716 Change-Id: Ia0c03918e8f2da4d9824c49c6d4cfca1b0787b0a Reviewed-on: https://go-review.googlesource.com/c/go/+/184102Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Ian Lance Taylor authored
These functions are compiler generated, and as such are only available in the internal ABI. Doing this avoids generating an alias symbol. Doing that avoids confusion between unmangled and mangled type symbols. Fixes #30768 Change-Id: I197a5ba6403aac11989ffa951dbe35bd0506de91 Reviewed-on: https://go-review.googlesource.com/c/go/+/186077 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
-
Bryan C. Mills authored
If the module path declared in the go.mod file does not match the path we are trying to resolve, a build using that module is doomed to fail. Since we know that the module path does not match in the underlying repo, we also know that the requested module does not exist at the requested version. Therefore, we should reject that version in Stat with a “not exist” error — sooner rather than later — so that modload.Query will continue to check other candidate paths (for example, with a major-version suffix added or removed). Fixes #33099 Change-Id: I43c980f78ed75fa6ace90f237cc3aad46c22d83a Reviewed-on: https://go-review.googlesource.com/c/go/+/186237 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Filippo Valsorda authored
Session resumption is not a reliable TLS behavior: the server can decide to reject a session ticket for a number of reasons, or no reason at all. This makes this non-hermetic test extremely brittle. It's currently broken on the builders for both TLS 1.2 and TLS 1.3, and I could reproduce the issue for TLS 1.3 only. As I was debugging it, it started passing entirely on my machine. In practice, it doesn't get us any coverage as resumption is already tested with the recorded exchange tests, and TestVerifyHostname still provides a smoke test checking that we can in fact talk TLS. Fixes #32978 Change-Id: I63505e22ff7704f25ad700d46e4ff14850ba5d3c Reviewed-on: https://go-review.googlesource.com/c/go/+/186239 Run-TryBot: Filippo Valsorda <filippo@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Bryan C. Mills authored
This is a more minimial fix for the immediate symptom of 32917 and 30590, but does not improve 'list -e' behavior or error messages resulting from other package loading issues. Fixes #32917 Fixes #30590 Change-Id: I6088d14d864410159ebf228d9392d186322fd2a5 Reviewed-on: https://go-review.googlesource.com/c/go/+/185417 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
LE Manh Cuong authored
The go test result must not be cached when each of known variables to go command change. To do this, add all known variables to test metadata. Fixes #32285 Change-Id: I90be6a72f46c42d965aec4fed534c0623244cd3d Reviewed-on: https://go-review.googlesource.com/c/go/+/179040 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
- 14 Jul, 2019 1 commit
-
-
Alberto Donizetti authored
Change-Id: I465f10533cc76d8160e56bc49eabaf8127ac4e61 Reviewed-on: https://go-review.googlesource.com/c/go/+/186137Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
- 12 Jul, 2019 3 commits
-
-
Jay Conrod authored
Add "upgrade" and "patch" to 'go help modules' section 'Module queries'. Also explicitly call out the fact that @v2 will select the latest version starting with v2, not the branch named v2, since this is a common source of confusion. Fixes #33010 Change-Id: I2fe27543b81a160fb6f6b8e8444a7a35f3661433 Reviewed-on: https://go-review.googlesource.com/c/go/+/185979 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Ian Lance Taylor authored
We already skipped rewriting the call if there were fewer args than parameters. But we can also get a cgo crash if there are more args, if at least one of the extra args uses a name qualified with "C.". Skip the rewrite, since the build will fail later anyhow. Fixes #33061 Change-Id: I62ff3518b775b502ad10c2bacf9102db4c9a531c Reviewed-on: https://go-review.googlesource.com/c/go/+/185797 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
Norman B. Lancaster authored
Go 1.14 will no longer run on Native Client (NaCl). Updating the 1.13 release notes to indicate this. See #30439. Fixes #32948 Change-Id: Ia147bb053adc098bd696dbdb01553c23222f8134 Reviewed-on: https://go-review.googlesource.com/c/go/+/185537Reviewed-by: Andrew Bonventre <andybons@golang.org>
-
- 11 Jul, 2019 1 commit
-
-
Cherry Zhang authored
Gccgo generates incorrect type equality functions for some types. CL 185817 fixes it. This CL adds a test. Updates #33062. Change-Id: Id445c5d44a437512c65c46a029e49b7fc32e4d89 Reviewed-on: https://go-review.googlesource.com/c/go/+/185818 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-