1. 20 May, 2014 11 commits
    • Russ Cox's avatar
      build: make nacl pass · 0c2a7274
      Russ Cox authored
      Add nacl.bash, the NaCl version of all.bash.
      It's a separate script because it builds a variant of package syscall
      with a large zip file embedded in it, containing all the input files
      needed for tests.
      
      Disable various tests new since the last round, mostly the ones using os/exec.
      
      Fixes #7945.
      
      LGTM=dave
      R=golang-codereviews, remyoudompheng, dave, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/100590044
      0c2a7274
    • Russ Cox's avatar
      test: test issue 7884 (already fixed) · f374dd30
      Russ Cox authored
      I don't know when the bug was fixed, but empirically it was.
      Make sure it stays fixed by adding a test.
      
      Fixes #7884.
      
      LGTM=adg
      R=golang-codereviews, adg
      CC=golang-codereviews
      https://golang.org/cl/93500043
      f374dd30
    • Russ Cox's avatar
      syscall: fix Write(nil) on NaCl · 82854d7b
      Russ Cox authored
      Fixes #7050.
      
      LGTM=crawshaw, r
      R=golang-codereviews, crawshaw, r
      CC=golang-codereviews
      https://golang.org/cl/91590043
      82854d7b
    • Russ Cox's avatar
      cmd/ld: make lldb happy with Mach-O 6.out files · a4a1fadf
      Russ Cox authored
      Apparently all the __DWARF sections need addresses
      even though they are marked as "do not load from disk".
      Continue the address numbering from the data segment.
      
      With this change:
      
      g% lldb helloworld
      Current executable set to 'helloworld' (x86_64).
      (lldb) b main.main
      Breakpoint 1: where = helloworld`main.main + 25 at helloworld.go:12, address = 0x0000000000002019
      (lldb) r
      Process 68509 launched: '/Users/rsc/g/go/src/cmd/6l/helloworld' (x86_64)
      1 location added to breakpoint 1
      (lldb)
      [KProcess 68509 stopped
      * thread #1: tid = 0x8b7a27, 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12, stop reason = breakpoint 1.2
          frame #0: 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12
         9   	package main
         10
         11  	func main() {
      -> 12  		print("hello, world\n")
         13  	}
      (lldb) bt
      * thread #1: tid = 0x8b7a27, 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12, stop reason = breakpoint 1.2
        * frame #0: 0x0000000000002019 helloworld`main.main + 25 at helloworld.go:12
      (lldb) disas
      helloworld`main.main at helloworld.go:11:
         0x2000:  movq   %gs:0x8a0, %rcx
         0x2009:  cmpq   (%rcx), %rsp
         0x200c:  ja     0x2015                    ; main.main + 21 at helloworld.go:11
         0x200e:  callq  0x20da0                   ; runtime.morestack00_noctxt at atomic_amd64x.c:28
         0x2013:  jmp    0x2000                    ; main.main at helloworld.go:11
         0x2015:  subq   $0x10, %rsp
      -> 0x2019:  leaq   0x2c2e0, %rbx
         0x2021:  leaq   (%rsp), %rbp
         0x2025:  movq   %rbp, %rdi
         0x2028:  movq   %rbx, %rsi
         0x202b:  movsq
         0x202d:  movsq
         0x202f:  callq  0x10300                   ; runtime.printstring at compiler.go:1
         0x2034:  addq   $0x10, %rsp
         0x2038:  ret
         0x2039:  addb   %al, (%rax)
         0x203b:  addb   %al, (%rax)
         0x203d:  addb   %al, (%rax)
      (lldb) quit
      Quitting LLDB will kill one or more processes. Do you really want to proceed: [Y/n] y
      g%
      
      Fixes #7070.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/93510043
      a4a1fadf
    • Andrew Gerrand's avatar
      misc/makerelease: handle update tour file layout · 9cd759ae
      Andrew Gerrand authored
      Fixes #7835.
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/94670044
      9cd759ae
    • Mikio Hara's avatar
      doc/go1.3.html: switch default stack size back to 8kB · 66f72f8a
      Mikio Hara authored
      Update #8030
      
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/94680043
      66f72f8a
    • Elias Naur's avatar
      cmd/cgo: document CC_FOR_TARGET and CXX_FOR_TARGET · 88d07b2c
      Elias Naur authored
      Update #4714
      
      LGTM=iant, minux.ma, rsc
      R=rsc, iant, r, minux.ma
      CC=golang-codereviews
      https://golang.org/cl/100390043
      88d07b2c
    • Russ Cox's avatar
      liblink: fix field tracking · d9c9665f
      Russ Cox authored
      The USEFIELD instructions no longer make it to the linker,
      so we have to do something else to pin the references
      they were pinning. Emit a 0-length relocation of type R_USEFIELD.
      
      Fixes #7486.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews, r
      https://golang.org/cl/95530043
      d9c9665f
    • Russ Cox's avatar
      runtime: switch default stack size back to 8kB · 6aee2964
      Russ Cox authored
      The move from 4kB to 8kB in Go 1.2 was to eliminate many stack split hot spots.
      
      The move back to 4kB was predicated on copying stacks eliminating
      the potential for hot spots.
      
      Unfortunately, the fact that stacks do not copy 100% of the time means
      that hot spots can still happen under the right conditions, and the slowdown
      is worse now than it was in Go 1.2. There is a real program in issue 8030 that
      sees about a 30x slowdown: it has a reflect call near the top of the stack
      which inhibits any stack copying on that segment.
      
      Go back to 8kB until stack copying can be used 100% of the time.
      
      Fixes #8030.
      
      LGTM=khr, dave, iant
      R=iant, khr, r, bradfitz, dave
      CC=golang-codereviews
      https://golang.org/cl/92540043
      6aee2964
    • Russ Cox's avatar
      cmd/gc: fix float32 const conversion and printing of big float consts · 60be4a24
      Russ Cox authored
      The float32 const conversion used to round to float64
      and then use the hardware to round to float32.
      Even though there was a range check before this
      conversion, the double rounding introduced inaccuracy:
      the round to float64 might round the value further away
      from the float32 range, reaching a float64 value that
      could not actually be rounded to float32. The hardware
      appears to give us 0 in that case, but it is probably undefined.
      Double rounding also meant that the wrong value might
      be used for certain border cases.
      
      Do the rounding the float32 ourselves, just as we already
      did the rounding to float64. This makes the conversion
      precise and also makes the conversion match the range check.
      
      Finally, add some code to print very large (bigger than float64)
      floating point constants in decimal floating point notation instead
      of falling back to the precise but human-unreadable binary floating
      point notation.
      
      Fixes #8015.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews, r
      https://golang.org/cl/100580044
      60be4a24
    • Shenghou Ma's avatar
      cmd/ld: abort if (32-bit) address relocation is negative on amd64. · 66129835
      Shenghou Ma authored
      Update #7980
      This CL make the linker abort for the example program. For Go 1.4,
      we need to find a general way to handle large memory model programs.
      
      LGTM=dave, josharian, iant
      R=iant, dave, josharian
      CC=golang-codereviews
      https://golang.org/cl/91500046
      66129835
  2. 19 May, 2014 10 commits
  3. 17 May, 2014 2 commits
  4. 16 May, 2014 11 commits
  5. 15 May, 2014 6 commits
    • Shenghou Ma's avatar
      api: update next.txt · 74fe67f2
      Shenghou Ma authored
      LGTM=bradfitz
      R=golang-codereviews, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/95490043
      74fe67f2
    • Russ Cox's avatar
      cmd/gc: fix two select temporary bugs · 1357f548
      Russ Cox authored
      The introduction of temporaries in order.c was not
      quite right for two corner cases:
      
      1) The rewrite that pushed new variables on the lhs of
      a receive into the body of the case was dropping the
      declaration of the variables. If the variables escape,
      the declaration is what allocates them.
      Caught by escape analysis sanity check.
      In fact the declarations should move into the body
      always, so that we only allocate if the corresponding
      case is selected. Do that. (This is an optimization that
      was already present in Go 1.2. The new order code just
      made it stop working.)
      
      Fixes #7997.
      
      2) The optimization to turn a single-recv select into
      an ordinary receive assumed it could take the address
      of the destination; not so if the destination is _.
      
      Fixes #7998.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/100480043
      1357f548
    • Guillaume J. Charmes's avatar
      archive/tar: Do not panic on Read if uninitialized · 6d63d4f3
      Guillaume J. Charmes authored
      Calling tar.Reader.Read() used to work fine, but without this patch it panics.
      Simply return EOF to indicate the tar.Reader.Next() needs to be called.
      
      LGTM=iant, bradfitz
      R=golang-codereviews, bradfitz, iant, mikioh.mikioh, dominik.honnef
      CC=golang-codereviews
      https://golang.org/cl/94530043
      6d63d4f3
    • Mikio Hara's avatar
      api: update openbsd exceptions · 8c8c260d
      Mikio Hara authored
      This CL restores dropped constants not supported in OpenBSD 5.5
      and tris to keep the promise of API compatibility.
      
      Update #7049
      
      LGTM=jsing, bradfitz
      R=rsc, jsing, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/94950043
      8c8c260d
    • Mikio Hara's avatar
      syscall: regenerate z-files for openbsd · 40e7f649
      Mikio Hara authored
      This CL restores dropped constants not supported in OpenBSD 5.5
      and tris to keep the promise of API compatibility.
      
      Update #7049
      
      LGTM=jsing, bradfitz, rsc
      R=rsc, jsing, robert.hencke, minux.ma, bradfitz, iant
      CC=golang-codereviews
      https://golang.org/cl/96970043
      40e7f649
    • Robert Griesemer's avatar
      container/heap: update example code · b2d1a2b5
      Robert Griesemer authored
      - use Init to establish heap invariant on
        a non-empty heap
      - use Fix to update heap after an element's
        properties have been changed
      
      (The old code used Init where it wasn't needed,
       and didn't use Fix because Fix was added after
       the example was written.)
      
      LGTM=bradfitz
      R=adonovan, bradfitz
      CC=golang-codereviews
      https://golang.org/cl/94520043
      b2d1a2b5