- 18 Mar, 2014 1 commit
-
-
Rob Pike authored
%q quotes each element of a string slice; this was never explained in the docs. Fixes #7015. LGTM=josharian R=golang-codereviews, josharian CC=golang-codereviews https://golang.org/cl/77140044
-
- 17 Mar, 2014 7 commits
-
-
Luka Zakrajšek authored
Fixes #7521. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/76320043
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/77120044
-
Catalin Patulea authored
Request ID reuse is allowed by the FastCGI spec [1]. In particular nginx uses the same request ID, 1, for all requests on a given connection. Because serveRequest does not remove the request from conn.requests, this causes it to treat the second request as a duplicate and drops the connection immediately after beginRequest. This manifests with nginx option 'fastcgi_keep_conn on' as the following message in nginx error log: 2014/03/17 01:39:13 [error] 730#0: *109 recv() failed (104: Connection reset by peer) while reading response header from upstream, client: x.x.x.x, server: example.org, request: "GET / HTTP/1.1", upstream: "fastcgi://127.0.0.1:9001", host: "example.org" Because handleRecord and serveRequest run in different goroutines, access to conn.requests must now be synchronized. [1] http://www.fastcgi.com/drupal/node/6?q=node/22#S3.3 LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/76800043
-
Brad Fitzpatrick authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/76400044
-
Rui Ueyama authored
I believe the original author of this code just forgot to check for error here. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/76760043
-
Rui Ueyama authored
"env" is a valid go command. This patch is to make bash to autocomplete it. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/74660045
-
Brad Fitzpatrick authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/76930044
-
- 16 Mar, 2014 1 commit
-
-
Nathan John Youngman authored
Smooth out the setup process for new contributors. * Remove references $GOROOT (often not defined). * Add a note for contributing to subrepositories. * Emphasize that hg mail also uploads the latest copy. LGTM=adg R=golang-codereviews, iant, adg CC=golang-codereviews https://golang.org/cl/74370043
-
- 15 Mar, 2014 2 commits
-
-
Ian Lance Taylor authored
LGTM=minux.ma R=golang-codereviews, minux.ma CC=golang-codereviews https://golang.org/cl/76270043
-
Mikio Hara authored
See testing.FailNow for further information. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/75900043
-
- 14 Mar, 2014 12 commits
-
-
Rémy Oudompheng authored
It was using the wrong offset and returned random values making "runoutput" compiler tests crash. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/76250043
-
Rémy Oudompheng authored
They were rejected by NaCl due to AES instructions and accesses to %gs:0x8, caused by wrong tlsoffset value. LGTM=iant R=rsc, dave, iant CC=golang-codereviews https://golang.org/cl/76050044
-
Dmitriy Vyukov authored
It's possible that bgsweep constantly does not catch up for some reason, in this case runfinq was not woken at all. R=rsc CC=golang-codereviews https://golang.org/cl/75940043
-
Dmitriy Vyukov authored
The problem was that spans end up in wrong lists after split (e.g. in h->busy instead of h->central->empty). Also the span can be non-swept before split, I don't know what it can cause, but it's safer to operate on swept spans. Fixes #7544. R=golang-codereviews, rsc CC=golang-codereviews, khr https://golang.org/cl/76160043
-
Rémy Oudompheng authored
LGTM=rsc R=rsc, dave, iant, khr CC=golang-codereviews https://golang.org/cl/75820044
-
Dmitriy Vyukov authored
Currently processes crash with obscure message. Say that it's "out of memory". LGTM=rsc R=golang-codereviews CC=golang-codereviews, khr, rsc https://golang.org/cl/75820045
-
Dmitriy Vyukov authored
See the comment for description. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/75670044
-
Dmitriy Vyukov authored
LGTM=rsc R=golang-codereviews CC=golang-codereviews, khr, rsc https://golang.org/cl/76070043
-
Jan Ziak authored
Fixes #7262 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/76110043
-
Jan Ziak authored
Fixes #6405 LGTM=rsc R=rsc, iant CC=golang-codereviews https://golang.org/cl/72920046
-
Shenghou Ma authored
Old versions of DTrace (as those shipped in OS X and FreeBSD) don't support unicode characters in symbol names. Replace '·' to '.' to make DTrace happy. Fixes #7493 LGTM=aram, rsc R=aram, rsc, gobot, iant CC=golang-codereviews https://golang.org/cl/72280043
-
Aram Hăvărneanu authored
The Solaris network poller uses event ports, which are level-triggered. As such, it has to re-arm itself after each wakeup. The arming mechanism (which runs in its own thread) raced with the closing of a file descriptor happening in a different thread. When a network file descriptor is about to be closed, the network poller is awaken to give it a chance to remove its association with the file descriptor. Because the poller always re-armed itself, it raced with code that closed the descriptor. This change makes the network poller check before re-arming if the file descriptor is about to be closed, in which case it will ignore the re-arming request. It uses the per-PollDesc lock in order to serialize access to the PollDesc. This change also adds extensive documentation describing the Solaris implementation of the network poller. Fixes #7410. LGTM=dvyukov, iant R=golang-codereviews, bradfitz, iant, dvyukov, aram.h, gobot CC=golang-codereviews https://golang.org/cl/69190044
-
- 13 Mar, 2014 17 commits
-
-
Keith Randall authored
debug/elf does the same thing, use []byte{} for any missing sections. Fixes #7510 LGTM=rsc R=golang-codereviews, iant CC=golang-codereviews, rsc https://golang.org/cl/75230043
-
Anthony Martin authored
LGTM=rsc R=rsc, 0intro, aram, jeremyjackins, iant CC=golang-codereviews, lucio.dere, minux.ma, paurea, r https://golang.org/cl/9796043
-
Dmitriy Vyukov authored
Mark free memory blocks as unused. On amd64 it allows the process to eat all 128 GB of heap without killing the machine. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/74070043
-
Dmitriy Vyukov authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/75350043
-
Dmitriy Vyukov authored
This check would allowed to easily prevent issue 7511. Update #7511 LGTM=rsc R=rsc, aram CC=golang-codereviews https://golang.org/cl/75260043
-
Dmitriy Vyukov authored
This is especially important for SetPanicOnCrash, but also useful for e.g. nil deref in mallocgc. Panics on such crashes can't lead to anything useful, only to deadlocks, hangs and obscure crashes. This is a copy of broken but already LGTMed https://golang.org/cl/68540043/ TBR=rsc R=rsc CC=golang-codereviews https://golang.org/cl/75320043
-
Dmitriy Vyukov authored
When we copy stack, we check only new size of the top segment. This is incorrect, because we can have other segments below it. LGTM=khr R=golang-codereviews, khr CC=golang-codereviews, rsc https://golang.org/cl/73980045
-
Aram Hăvărneanu authored
Calling runtime·cgocall could trigger a GC in the child while gclock was held by the parent. Fixes #7511 LGTM=bradfitz, dvyukov, dave R=golang-codereviews, bradfitz, dvyukov, dave CC=golang-codereviews, rsc https://golang.org/cl/75210044
-
Rémy Oudompheng authored
The lowering to runtime calls introduces hidden pointers to the arguments of select clauses. When implicit conversions were involved it could end up with incompatible pointers. Since the pointed-to types have the same representation, we can introduce a forced conversion. Fixes #6847. LGTM=rsc R=rsc, iant, khr CC=golang-codereviews https://golang.org/cl/72380043
-
Rémy Oudompheng authored
It was using a REP STOSQ but putting in CX the number of 32-bit words to clear. LGTM=dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/75240043
-
Mikio Hara authored
Fixes #7528. LGTM=jsing R=jsing CC=golang-codereviews https://golang.org/cl/75140045
-
Michael Hudson-Doyle authored
Under some circumstances, gccgoToolchain's ld can pass the path of build outputs that have been deleted to the link command. Fixes #7303. LGTM=rsc R=golang-codereviews, dave, michael.hudson, rsc CC=golang-codereviews https://golang.org/cl/61970044
-
Anthony Martin authored
Otherwise, we won't get a stack trace in some of the early init. Here's one example: http://build.golang.org/log/a96d10f6aee1fa3e3ae51f41da46d414a7ab02de After walking the stack by hand in acid, I was able to determine that the stackalloc inside mpreinit was causing the throw. LGTM=rsc R=rsc, dvyukov CC=golang-codereviews https://golang.org/cl/72450044
-
Anthony Martin authored
The compilers expect to not be interrupted by floating point exceptions. On Plan 9, every process starts with interrupts enabled for invalid operation, stack overflow, and divide by zero exceptions. LGTM=rsc R=rsc, 0intro CC=golang-codereviews https://golang.org/cl/72750043
-
Anthony Martin authored
Previously, we wrote "kill" to the process control file to kill a program. This is problematic because it doesn't let the program gracefully exit. This matters especially if the process we're killing is a Go program. On Unix, sending SIGKILL to a Go program will automatically kill all runtime threads. On Plan 9, there are no threads so when the program wants to exit it has to somehow signal all of the runtime processes. It can't do this if we mercilessly kill it by writing to it's control file. Instead, we now send it a note to invoke it's note handler and let it perform any cleanup before exiting. LGTM=rsc R=rsc, 0intro CC=golang-codereviews https://golang.org/cl/74440044
-
Anthony Martin authored
On Plan 9, the kernel disallows the use of floating point instructions while handling a note. Previously, we worked around this by using a simple loop in place of memmove. When I added that work-around, I verified that all paths from the note handler didn't end up calling memmove. Now that memclr is using SSE instructions, the same process will have to be done again. Instead of doing that, however, this CL just punts and uses unoptimized functions everywhere on Plan 9. LGTM=rsc R=rsc, 0intro CC=golang-codereviews https://golang.org/cl/73830044
-
Anthony Martin authored
Acid can't produce a stack trace without .frame symbols. Of course, it can only unwind through linear stacks but this is still better than nothing. (I wrote an acid func to do the full unwind a long time ago but lost it and haven't worked up the courage to write it again). Note that these will only be present in the native symbol table for Plan 9 binaries. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/72450045
-