Commits · 1331084c3d7ac5f8721a29412e6b0d9ae1436683 · Kirill Smelkov / go

02 Sep, 2010 3 commits

test: Match gccgo error messages. · 1331084c

Ian Lance Taylor authored Sep 01, 2010

bug284.go:33: error: invalid type conversion
bug284.go:36: error: invalid type conversion (cannot use type A2 as type A1)
bug284.go:37: error: invalid type conversion
bug284.go:38: error: invalid type conversion (cannot use type A1 as type A2)
bug284.go:56: error: invalid type conversion
bug284.go:59: error: invalid type conversion (cannot use type S2 as type S1)
bug284.go:60: error: invalid type conversion
bug284.go:61: error: invalid type conversion (cannot use type S1 as type S2)
bug284.go:71: error: invalid type conversion
bug284.go:74: error: invalid type conversion (cannot use type P2 as type P1)
bug284.go:75: error: invalid type conversion
bug284.go:76: error: invalid type conversion (cannot use type P1 as type P2)
bug284.go:96: error: invalid type conversion
bug284.go:99: error: invalid type conversion (cannot use type Q2 as type Q1)
bug284.go:101: error: invalid type conversion (cannot use type Q1 as type Q2)
bug284.go:111: error: invalid type conversion (different parameter types)
bug284.go:114: error: invalid type conversion (different parameter types)
bug284.go:115: error: invalid type conversion (different parameter types)
bug284.go:116: error: invalid type conversion (different parameter types)
bug284.go:134: error: invalid type conversion (incompatible type for method 'f' (different result types))
bug284.go:137: error: invalid type conversion (incompatible type for method 'f' (different result types))
bug284.go:138: error: invalid type conversion (incompatible type for method 'f' (different result types))
bug284.go:139: error: invalid type conversion (incompatible type for method 'f' (different result types))
bug284.go:149: error: invalid type conversion
bug284.go:152: error: invalid type conversion (cannot use type L2 as type L1)
bug284.go:153: error: invalid type conversion
bug284.go:154: error: invalid type conversion (cannot use type L1 as type L2)
bug284.go:164: error: invalid type conversion
bug284.go:167: error: invalid type conversion (cannot use type L2 as type L1)
bug284.go:168: error: invalid type conversion
bug284.go:169: error: invalid type conversion (cannot use type L1 as type L2)
bug284.go:179: error: invalid type conversion
bug284.go:182: error: invalid type conversion (cannot use type C2 as type C1)
bug284.go:183: error: invalid type conversion
bug284.go:184: error: invalid type conversion (cannot use type C1 as type C2)

R=rsc
CC=golang-dev
https://golang.org/cl/2136041

1331084c

test: Recognize gccgo error messages. · c28525a1

Ian Lance Taylor authored Sep 01, 2010

bug278.go:18: error: invalid left hand side of assignment
bug278.go:19: error: array is not addressable
bug278.go:21: error: invalid left hand side of assignment
bug278.go:22: error: invalid left hand side of assignment

R=rsc
CC=golang-dev
https://golang.org/cl/2122042

c28525a1

http: add PostForm function to post url-encoded key/value data. · 2fe0f8da

Andrew Gerrand authored Sep 02, 2010

This is a common task, so it makes sense to have a helper to do it.

(App Engine doesn't like "Transfer-Encoding: chunked" for POST
bodies, which is the default for regular Post.)

R=rsc
CC=golang-dev
https://golang.org/cl/2113041

2fe0f8da

01 Sep, 2010 9 commits

Fix incorrect reporting of error in Scanner.next() when Read reads > 0 bytes but returns os.EOF. · f8a67d79
Kyle Consalus authored Sep 01, 2010
```
R=golang-dev, gri1, gri
CC=golang-dev
https://golang.org/cl/2083042
```
f8a67d79

netchan: rather than 0, make -1 mean infinite, by analogy with strings.Split etc. · 3d76135e

Rob Pike authored Sep 02, 2010

It's unlikely to affect any extant code, but I wanted to make this API change
before digging in for a rewrite.

R=rsc
CC=golang-dev
https://golang.org/cl/2112041

3d76135e

test: Use global variables to defeat gccgo optimizer. · 426275d7

Ian Lance Taylor authored Sep 01, 2010

The gccgo compiler is smart enough to not make something which
is not used.  Use global variables to defeat this
optimization.

R=rsc
CC=golang-dev
https://golang.org/cl/2129041

426275d7

6l/8l: emit DWARF in macho. · 728003e3
Luuk van Dijk authored Sep 01, 2010
```
R=rsc, r, ken2
CC=golang-dev
https://golang.org/cl/2128041
```
728003e3
fmt: fix typo in package comment. · 49b19e1b
Rob Pike authored Sep 01, 2010
```
No semantic change.

R=rsc
CC=golang-dev
https://golang.org/cl/2121041
```
49b19e1b

template: fixed documentation formatting · 825e0dee

Scott Lawrence authored Aug 31, 2010

What was meant to be a list appeared as a paragraph with dashes.

R=golang-dev, gri1, gri
CC=golang-dev
https://golang.org/cl/2100041

825e0dee

spec: delete spurious space (missed fix from previous review) · cb2730e6
Rob Pike authored Sep 01, 2010
```
No semantic change.

R=rsc
CC=golang-dev
https://golang.org/cl/2099041
```
cb2730e6
spec: fix a couple of tiny glitches · 68f1609e
Rob Pike authored Sep 01, 2010
```
R=gri, rsc
CC=golang-dev
https://golang.org/cl/2078041
```
68f1609e

test: Recognize gccgo error messages. · 9bd6b0af

Ian Lance Taylor authored Aug 31, 2010

bug255.go:11: error: array bound truncated to integer
bug255.go:12: error: array bound is not numeric
bug255.go:13: error: array bound is not numeric
bug255.go:14: error: array bound is not constant
bug255.go:15: error: array bound overflows

R=rsc
CC=golang-dev
https://golang.org/cl/2091042

9bd6b0af

31 Aug, 2010 9 commits

test: Match gccgo error messages. · 7a05b0f2

Ian Lance Taylor authored Aug 31, 2010

Another case where gccgo and gc report similar but not
identical errors for a recursive interface.

bug251.go:11: error: invalid recursive interface

R=rsc
CC=golang-dev
https://golang.org/cl/2094041

7a05b0f2

big: added RatString, some simplifications · 9f46962c
Robert Griesemer authored Aug 31, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2095041
```
9f46962c
strconv: fix comment for godoc · 3ad995ea
Robert Griesemer authored Aug 31, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2029042
```
3ad995ea

test: gccgo and gc print the error on different lines. · 09977734

Ian Lance Taylor authored Aug 31, 2010

This introduces GC_ERROR to mark an error only issued by the
gc compiler.  GCCGO_ERROR already exists to mark errors only
issued by the gccgo compiler.  Obviously these should be used
sparingly.

bug195.go:9: error: interface contains embedded non-interface
bug195.go:12: error: interface contains embedded non-interface
bug195.go:15: error: interface contains embedded non-interface
bug195.go:18: error: invalid recursive interface
bug195.go:22: error: invalid recursive interface

R=rsc
CC=golang-dev
https://golang.org/cl/2040043

09977734

test: Match gccgo error messages. · 472cd3af

Ian Lance Taylor authored Aug 31, 2010

gcc conventionally does not upper case in error messages.

char_lit1.go:13: error: invalid unicode code point 0xd800
char_lit1.go:14: error: invalid unicode code point 0xd999
char_lit1.go:15: error: invalid unicode code point 0xdc01
char_lit1.go:16: error: invalid unicode code point 0xdddd
char_lit1.go:17: error: invalid unicode code point 0xdfff
char_lit1.go:20: error: invalid unicode code point 0x110000
char_lit1.go:22: error: invalid unicode code point 0x110000
char_lit1.go:23: error: invalid unicode code point 0xffffffff

R=rsc
CC=golang-dev
https://golang.org/cl/2040042

472cd3af

test: don't assign address of array to slice. · 5309fae1
Ian Lance Taylor authored Aug 31, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2084042
```
5309fae1
misc/bash: add *.go completion for gofmt · 0f61f014
Scott Lawrence authored Aug 30, 2010
```
R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/2039044
```
0f61f014
misc: add zsh completion (using compctl) · 815a6785
Scott Lawrence authored Aug 30, 2010
```
R=golang-dev, rsc1, rsc
CC=golang-dev
https://golang.org/cl/2061042
```
815a6785
doc: add round-robin flag to io2010 balance example. · 724b66fb
Nigel Tao authored Aug 31, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/2050042
```
724b66fb

30 Aug, 2010 7 commits
- proc, eval: Don't assign address of an array to a slice. · 7a2daa7d
  Ian Lance Taylor authored Aug 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2084041
```
  7a2daa7d
- 8l: emit DWARF in ELF. · b433552e
  Luuk van Dijk authored Aug 30, 2010
```
R=rsc, r, ken2
CC=golang-dev
https://golang.org/cl/2004046
```
  b433552e
- build: remove unnecessary references to GOBIN and GOROOT · 5c603dbb
  Christian Himpel authored Aug 30, 2010
```
All scripts and makefiles assume that GOBIN is correctly set
in PATH.

R=rsc
CC=golang-dev
https://golang.org/cl/2043041
```
  5c603dbb
- misc/fraise: syntax highlighting for Fraise.app (OS X) · c1497a05
  Vincent Ambo authored Aug 30, 2010
```
R=golang-dev, adg1, adg
CC=golang-dev
https://golang.org/cl/2075041
```
  c1497a05
- A+C: Vincent Ambo · cc9d2e2d
  Andrew Gerrand authored Aug 30, 2010
```
R=r
CC=golang-dev
https://golang.org/cl/2048043
```
  cc9d2e2d
- regexp: interpret all Go characer escapes \a \b \f \n \r \t \v · ca3b5222
  Rob Pike authored Aug 30, 2010
```
R=rsc
CC=golang-dev
https://golang.org/cl/2042044
```
  ca3b5222
- codereview: Fix uploading for Mercurial 1.6.3 · 9e162aa3
  Evan Shaw authored Aug 29, 2010
```
See:
http://selenic.com/repo/hg/rev/32b213b9b22c
http://selenic.com/repo/hg/rev/2096496b40ec

R=rsc, adg
CC=golang-dev
https://golang.org/cl/2072041
```
  9e162aa3
29 Aug, 2010 3 commits

crypto/tls: Fix doc typo · 3972908e
Evan Shaw authored Aug 30, 2010
```
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/2073041
```
3972908e

doc: various changes for validating HTML · 76dccbc2

Scott Lawrence authored Aug 30, 2010

(Fixes missing tags, extra tags, missing attributes, and such found by tidy -e)

R=golang-dev, adg1, adg
CC=golang-dev
https://golang.org/cl/2039043

76dccbc2

rpc: fix bug that caused private methods to attempt to be registered. · 64cb9b6f
Rob Pike authored Aug 30, 2010
```
Fixes #1056.

R=golang-dev, adg1
CC=golang-dev
https://golang.org/cl/2033043
```
64cb9b6f

27 Aug, 2010 9 commits
- Documentation: Fix a bug in the example in Constants subsection · 089ce170
  James Fysh authored Aug 28, 2010
```
	Not a bug per-se, the issue is that the fmt.Sprintf method inside the
	ByteSize.String() method ends up calling itself to generate the String
	representation of the ByteSize value.  Infinite loops are bad.

    Updated as per review comments

R=r
CC=golang-dev
https://golang.org/cl/1974046
```
  089ce170
- template: finally fix space handling around actions. · b5664ee3
  Rob Pike authored Aug 28, 2010
```
Rewrite the code to express the intention more clearly.

Fixes #1042.

R=rsc
CC=golang-dev
https://golang.org/cl/2011046
```
  b5664ee3
- CLA: Add James Fysh · da25964e
  Rob Pike authored Aug 28, 2010
```
R=gri
CC=James Fysh, golang-dev
https://golang.org/cl/2043042
```
  da25964e
- gofmt: permit omission of first index in slice expression · 8935c848
  Robert Griesemer authored Aug 27, 2010
```
R=rsc
CC=golang-dev, r
https://golang.org/cl/2053041
```
  8935c848
- 8g: use FCHS, not FMUL, for minus float · 9686ab2d
  Russ Cox authored Aug 27, 2010
```
Fixes #1052.

R=ken2
CC=golang-dev
https://golang.org/cl/2055041
```
  9686ab2d
- go/printer: align ImportPaths in ImportDecls if PackageName is given. · 1a0b62a1
  Scott Lawrence authored Aug 26, 2010
```
Fixes #1044.

R=gri
CC=golang-dev
https://golang.org/cl/1958047
```
  1a0b62a1
- doc: fix margins in root.html · 20198d69
  Andrew Gerrand authored Aug 27, 2010
```
R=rsc, r2
CC=golang-dev
https://golang.org/cl/2041041
```
  20198d69
- doc: remove console.log line from root.html · 09924349
  Andrew Gerrand authored Aug 27, 2010
```
R=r, rsc1
CC=golang-dev
https://golang.org/cl/2040041
```
  09924349
- doc: fix wiki codelab title and srcextract.go · 91a14167
  Andrew Gerrand authored Aug 27, 2010
```
R=r, rsc1
CC=golang-dev
https://golang.org/cl/1953048
```
  91a14167