1. 03 Jan, 2018 1 commit
  2. 02 Jan, 2018 4 commits
  3. 01 Jan, 2018 1 commit
  4. 31 Dec, 2017 2 commits
  5. 30 Dec, 2017 1 commit
  6. 27 Dec, 2017 1 commit
  7. 25 Dec, 2017 1 commit
  8. 22 Dec, 2017 1 commit
  9. 21 Dec, 2017 2 commits
  10. 20 Dec, 2017 4 commits
    • Robert Griesemer's avatar
      go/types: document Typ slice · 5ad3c1cd
      Robert Griesemer authored
      Fixes #22628.
      
      Change-Id: Ib7aff8043e477af18c448d6b778f159b23fb5a92
      Reviewed-on: https://go-review.googlesource.com/85075Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      5ad3c1cd
    • Hana Kim's avatar
      cmd/trace: init goroutine info entries with GoCreate event · a58286c2
      Hana Kim authored
      golang.org/cl/81315 attempted to distinguish system goroutines
      by examining the function name in the goroutine stack. It assumes that
      the information would be available when GoSysBlock or GoInSyscall
      events are processed, but it turned out the stack information is
      set too late (when the goroutine gets a chance to run).
      
      This change initializes the goroutine information entry when
      processing GoCreate event which should be one of the very first
      events for the every goroutine in trace.
      
      Fixes #22574
      
      Change-Id: I1ed37087ce2e78ed27c9b419b7d942eb4140cc69
      Reviewed-on: https://go-review.googlesource.com/83595Reviewed-by: default avatarAustin Clements <austin@google.com>
      Run-TryBot: Austin Clements <austin@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      a58286c2
    • Than McIntosh's avatar
      cmd/compile: second attempt at fix for issue 23179 · 841d865a
      Than McIntosh authored
      My previous fix for issue 23179 was incomplete; it turns out that if
      an unnamed parameter is below a specific size threshold, it gets
      register-promoted away by the compiler (hence not encountered during
      some parts of DWARF inline info processing), but if it is sufficiently
      large, it is allocated to the stack as a named variable and treated as
      a regular parameter by DWARF generation. Interestingly, something in
      the ppc64le build of k8s causes an unnamed parameter to be retained
      (where on amd64 it is deleted), meaning that this wasn't caught in my
      amd64 testing.
      
      The fix is to insure that "_" params are treated in the same way that
      "~r%d" return temps are when matching up post-optimization inlined
      routine params with pre-inlining declarations. I've also updated the
      test case to include a "_" parameter with a very large size, which
      also triggers the bug on amd64.
      
      Fixes #23179.
      
      Change-Id: I961c84cc7a873ad3f8f91db098a5e13896c4856e
      Reviewed-on: https://go-review.googlesource.com/84975
      Run-TryBot: Than McIntosh <thanm@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarDavid Chase <drchase@google.com>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Reviewed-by: default avatarHeschi Kreinick <heschi@google.com>
      841d865a
    • elpinal's avatar
      cmd/doc: suppress the error message for *package.ident embedded in struct type · 0504cd68
      elpinal authored
      The current implementation prints a log, "invalid program: unexpected
      type for embedded field", when the form *package.ident is embedded in
      a struct declaration.
      
      Note that since valid qualified identifiers must be exported, the result
      for a valid program does not change.
      
      Change-Id: If8b9d7056c56b6a6c5482eb749168a63c65ef685
      Reviewed-on: https://go-review.googlesource.com/84436Reviewed-by: default avatarRobert Griesemer <gri@golang.org>
      Run-TryBot: Robert Griesemer <gri@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      0504cd68
  11. 19 Dec, 2017 2 commits
  12. 18 Dec, 2017 2 commits
  13. 16 Dec, 2017 1 commit
  14. 15 Dec, 2017 8 commits
  15. 14 Dec, 2017 9 commits
    • Robert Griesemer's avatar
      go/types: collect methods with parenthesized receiver types · 67295d6e
      Robert Griesemer authored
      The existing code simply dropped them on the floor. Don't do that.
      
      Fixes #23130.
      
      Change-Id: I10f20e41f2c466a76519983253f87af7cf6d5e70
      Reviewed-on: https://go-review.googlesource.com/83918Reviewed-by: default avatarMatthew Dempsky <mdempsky@google.com>
      67295d6e
    • Geoff Berry's avatar
      cmd/compile/internal/ssa: group dump files alphabetically · 75f0ad70
      Geoff Berry authored
      Change dump file names to group them alphabetically in directory
      listings, in pass run order.
      
      Change-Id: I8070578a5b4a3a7983dcc527ea1cfdb10a6d7d24
      Reviewed-on: https://go-review.googlesource.com/83958Reviewed-by: default avatarKeith Randall <khr@golang.org>
      Run-TryBot: Keith Randall <khr@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      75f0ad70
    • Russ Cox's avatar
      cmd/vet: limit printf check to known Printf-like functions · 558eeb2d
      Russ Cox authored
      The name-based heuristics fail too often to be on during "go test",
      but we really want the printf vet check in "go test", so change to
      a list of exactly which standard library functions are print-like.
      
      For a later release we'd like to bring back checking for user-defined
      wrappers, but in a completely precise way. Not for Go 1.10, though.
      
      The new, more precise list includes t.Skipf, which caught some
      mistakes in standard library tests.
      
      Fixes #22936.
      
      Change-Id: I110448e3f6b75afd4327cf87b6abb4cc2021fd0d
      Reviewed-on: https://go-review.googlesource.com/83838
      Run-TryBot: Russ Cox <rsc@golang.org>
      Reviewed-by: default avatarRob Pike <r@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      558eeb2d
    • Russ Cox's avatar
      cmd/go: vet support for upcoming cmd/vet fixes · 9006d1f8
      Russ Cox authored
      Two minor changes to allow fixes in cmd/vet's printf checking.
      
      1. Pass package import path in vet config, so that vet knows
      whether it is, for example, vetting "fmt".
      
      2. Add new, but undocumented and for now unsupported
      flag -vettool to control which vet binary is invoked during go vet.
      This lets the cmd/vet tests build and test a throwaway vet.exe
      using cmd/go to ensure type checking information, all without
      installing a potentially buggy cmd/vet.
      
      For #22936.
      
      Change-Id: I18df7c796ebc711361c847c63eb3ee17fb041ff7
      Reviewed-on: https://go-review.googlesource.com/83837
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      9006d1f8
    • Mike Samuel's avatar
      html/template: add srcset content type · c0cda71d
      Mike Samuel authored
      Srcset is largely the same as a URL, but is escaped in URL contexts.
      Inside a srcset attribute, URLs have their commas percent-escaped to
      avoid having the URL be interpreted as multiple URLs.  Srcset is placed
      in a srcset attribute literally.
      
      Fixes #17441
      
      Change-Id: I676b544784c7e54954ddb91eeff242cab25d02c4
      Reviewed-on: https://go-review.googlesource.com/38324Reviewed-by: default avatarKunpei Sakai <namusyaka@gmail.com>
      Reviewed-by: default avatarMike Samuel <mikesamuel@gmail.com>
      Reviewed-by: default avatarRuss Cox <rsc@golang.org>
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      c0cda71d
    • Russ Cox's avatar
      cmd/go: do not let test vet failures stop reporting of later test results · c7b7c433
      Russ Cox authored
      (This only manifested in test vet failures for packages without tests,
      or else we'd probably have seen this sooner.)
      
      Fixes #23047.
      
      Change-Id: I41d09a7780999bbe1951377ffcc811ba86ea5000
      Reviewed-on: https://go-review.googlesource.com/83955
      Run-TryBot: Russ Cox <rsc@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      c7b7c433
    • JBD's avatar
      doc: make it clear which pprof package is used · c4da6101
      JBD authored
      Updates #22027.
      
      Change-Id: I5a5bae77a744c7a2ecb75172846e6461a98ee8af
      Reviewed-on: https://go-review.googlesource.com/83916Reviewed-by: default avatarAndrew Bonventre <andybons@golang.org>
      c4da6101
    • Brad Fitzpatrick's avatar
      doc/go1.10: note that netbsd/arm is definitely broken · 513a4691
      Brad Fitzpatrick authored
      Remove the ambiguity, know that we know it's actually broken,
      per https://github.com/golang/go/issues/23073#issuecomment-351045421
      
      Updates #23073
      
      Change-Id: I9b904da2f4c7105a0727d2a9056aaa6895d3dadc
      Reviewed-on: https://go-review.googlesource.com/83856Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      513a4691
    • Brad Fitzpatrick's avatar
      A+C: automated updates for Go 1.10 · 1fc71e37
      Brad Fitzpatrick authored
      Add Adam Thomason (individual CLA)
      Add Adrian Hesketh (individual CLA)
      Add Aeneas Rekkas (arekkas) (individual CLA)
      Add Afanasev Stanislav (individual CLA)
      Add Agniva De Sarker (individual CLA)
      Add Alexander Pantyukhin (individual CLA)
      Add Alexandre Parentea (individual CLA)
      Add Aman Gupta (individual CLA)
      Add Anand K. Mistry (individual CLA)
      Add Andrii Soldatenko (individual CLA)
      Add Andrii Soluk (individual CLA)
      Add Andrzej Żeżel (individual CLA)
      Add Anthony Alves (individual CLA)
      Add Anthony Sottile (individual CLA)
      Add Ariel Mashraki (individual CLA)
      Add Axel Wagner (individual CLA)
      Add Ben Haines (individual CLA)
      Add Ben Laurie (corporate CLA for Google Inc.)
      Add Ben Schwartz (corporate CLA for Google Inc.)
      Add Blain Smith (individual CLA)
      Add Blake Mesdag (individual CLA)
      Add Borja Clemente (individual CLA)
      Add Brett Merrill (individual CLA)
      Add Brian Kessler (individual CLA)
      Add Burak Guven (individual CLA)
      Add Cholerae Hu (individual CLA)
      Add Chris Ball (individual CLA)
      Add Christian Alexander (individual CLA)
      Add Christopher Henderson (individual CLA)
      Add Christopher Koch (corporate CLA for Google Inc.)
      Add Christos Zoulas (individual CLA)
      Add Daniela Petruzalek (individual CLA)
      Add Danny Rosseau (individual CLA)
      Add Davor Kapsa (individual CLA)
      Add Edan Bedrik (individual CLA)
      Add Elbert Fliek (individual CLA)
      Add Elena Grahovac (individual CLA)
      Add Emerson Lin (individual CLA)
      Add Eric Rescorla (individual CLA)
      Add Evan Jones (individual CLA)
      Add Frank Somers (individual CLA)
      Add Frederic Guillot (individual CLA)
      Add Garret Kelly (corporate CLA for Google Inc.)
      Add Grant Griffiths (individual CLA)
      Add Guilherme Garnier (individual CLA)
      Add Guilherme Rezende (individual CLA)
      Add Hanjun Kim (individual CLA)
      Add Henry Adi Sumarto (individual CLA)
      Add Henry Bubert (individual CLA)
      Add Herbie Ong (corporate CLA for Google Inc.)
      Add Hilko Bengen (individual CLA)
      Add Hiroaki Nakamura (individual CLA)
      Add Ian Kent (individual CLA)
      Add Inanc Gumus (individual CLA)
      Add Iskander Sharipov (corporate CLA for Intel Corporation)
      Add Ivan Bertona (individual CLA)
      Add James Lawrence (individual CLA)
      Add James Treanor (individual CLA)
      Add Jamie Liu (corporate CLA for Google Inc.)
      Add Jared Culp (individual CLA)
      Add Jason Wangsadinata (individual CLA)
      Add Javier Segura (individual CLA)
      Add Jean-Francois Cantin (individual CLA)
      Add Jeet Parekh (individual CLA)
      Add Jelte Fennema (individual CLA)
      Add Jimmy Frasche (individual CLA)
      Add Joshua Rubin (individual CLA)
      Add Juan Carlos (individual CLA)
      Add Jude Pereira (individual CLA)
      Add Karel Pazdera (individual CLA)
      Add Karsten Köhler (individual CLA)
      Add Kenji Yano (individual CLA)
      Add Kevin Ruffin (individual CLA)
      Add Kieran Colford (individual CLA)
      Add Kirk Han (individual CLA)
      Add Kunpei Sakai (individual CLA)
      Add Kyle Shannon (individual CLA)
      Add Kyohei Kadota (individual CLA)
      Add Lakshay Garg (individual CLA)
      Add Lann Martin (corporate CLA for Google Inc.)
      Add Laurent Voisin (individual CLA)
      Add Leigh McCulloch (individual CLA)
      Add Lorenz Bauer (corporate CLA for CloudFlare, Inc.)
      Add Luca Bruno (corporate CLA for CoreOS, Inc)
      Add Luke Granger-Brown (individual CLA)
      Add Lyle Franklin (individual CLA)
      Add Maicon Costa (individual CLA)
      Add Manish Goregaokar (individual CLA)
      Add Mansour Rahimi (individual CLA)
      Add Mark Percival (individual CLA)
      Add Mark Pulford (individual CLA)
      Add Mark Wolfe (individual CLA)
      Add Martins Sipenko (individual CLA)
      Add Mat Byczkowski (individual CLA)
      Add Matej Baćo (individual CLA)
      Add Mateus Amin (individual CLA)
      Add Matt Dee (individual CLA)
      Add Matthew Broberg (individual CLA)
      Add Max Schmitt (individual CLA)
      Add Mayank Kumar (individual CLA)
      Add Michael Brandenburg (individual CLA)
      Add Michael McLoughlin (individual CLA)
      Add Michael Schurter (individual CLA)
      Add Michael Steinert (individual CLA)
      Add Michal Pristas (individual CLA)
      Add Mihail Minaev (individual CLA)
      Add Muhammad Falak R Wani (individual CLA)
      Add Naoki Kanatani (individual CLA)
      Add Nicolas BRULEZ (individual CLA)
      Add Nils Larsgård (individual CLA)
      Add Noble Johnson (individual CLA)
      Add Paul Boyd (individual CLA)
      Add Paul Ruest (individual CLA)
      Add Peter Wu (corporate CLA for CloudFlare, Inc.)
      Add Petrica Voicu (individual CLA)
      Add Pontus Leitzler (individual CLA)
      Add Radek Sohlich (individual CLA)
      Add Rajath Agasthya (individual CLA)
      Add Rajender Reddy Kompally (individual CLA)
      Add Ramazan AYYILDIZ (individual CLA)
      Add RaviTeja Pothana (individual CLA)
      Add Reilly Watson (individual CLA)
      Add Roman Budnikov (individual CLA)
      Add Ross Chater (individual CLA)
      Add Rudi Kramer (individual CLA)
      Add Ryoichi KATO (individual CLA)
      Add Ryuji Iwata (individual CLA)
      Add Scott Crunkleton (individual CLA)
      Add Seiji Takahashi (individual CLA)
      Add Sergey Frolov (corporate CLA for Google Inc.)
      Add Sergey Semin (individual CLA)
      Add Sergiusz Bazanski (individual CLA)
      Add Stanislav Afanasev (individual CLA)
      Add Sukrit Handa (individual CLA)
      Add Sylvain Zimmer (individual CLA)
      Add Tao Wang (individual CLA)
      Add Terin Stock (individual CLA)
      Add Thiago Avelino (individual CLA)
      Add Thomas Wanielista (individual CLA)
      Add Tim Cooper (individual CLA)
      Add Tim Wright (individual CLA)
      Add Tobias Assarsson (individual CLA)
      Add Tom Lanyon (corporate CLA for Google Inc.)
      Add Tom Levy (individual CLA)
      Add Troels Thomsen (individual CLA)
      Add Tugdual Saunier (individual CLA)
      Add Tyler Bui-Palsulich (corporate CLA for Google Inc.)
      Add Wembley G. Leach, Jr (individual CLA)
      Add Will Faught (individual CLA)
      Add Wèi Cōngruì (individual CLA)
      Add Xi Ruoyao (individual CLA)
      Add Yann Salaün (individual CLA)
      Add Yosuke Akatsuka (individual CLA)
      Add Zach Gershman (individual CLA)
      Add Zhengyu He (corporate CLA for Google Inc.)
      Add Zhongtao Chen (individual CLA)
      Add Роман Хавроненко (individual CLA)
      Add Тарас Буник (individual CLA)
      
      Updates #12042
      
      Change-Id: If8fd708d32434b8ba21a0b3ef433b0d176626ce8
      Reviewed-on: https://go-review.googlesource.com/83858Reviewed-by: default avatarAndrew Bonventre <andybons@golang.org>
      1fc71e37