1. 29 Jun, 2018 3 commits
    • David Chase's avatar
      cmd/compile: make OpAddr depend on VarDef in storeOrder · 1a27f048
      David Chase authored
      Given a carefully constructed input, writebarrier would
      split a block with the OpAddr in the first half and the
      VarDef in the second half which ultimately leads to a
      compiler crash because the scheduler is no longer able
      to put them in the proper order.
      
      To fix, recognize the implicit dependence of OpAddr on
      the VarDef of the same symbol if any exists.
      
      This fix was chosen over making OpAddr take a memory
      operand to make the dependence explicit, because this
      change is less invasive at this late part of the 1.11
      release cycle.
      
      Fixes #26105.
      
      Change-Id: I9b65460673af3af41740ef877d2fca91acd336bc
      Reviewed-on: https://go-review.googlesource.com/121436
      Run-TryBot: David Chase <drchase@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      1a27f048
    • Cherry Zhang's avatar
      cmd/compile: check SSAability in handling of INDEX of 1-element array · d21bdf12
      Cherry Zhang authored
      SSA can handle 1-element array, but only when the element type
      is SSAable. When building SSA for INDEX of 1-element array, we
      did not check the element type is SSAable. And when it's not,
      it resulted in an unhandled SSA op.
      
      Fixes #26120.
      
      Change-Id: Id709996b5d9d90212f6c56d3f27eed320a4d8360
      Reviewed-on: https://go-review.googlesource.com/121496
      Run-TryBot: Cherry Zhang <cherryyz@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarJosh Bleecher Snyder <josharian@gmail.com>
      d21bdf12
    • Daniel Martí's avatar
      cmd/vet: don't run buildtag check when in vetxonly mode · 1d1e25fb
      Daniel Martí authored
      The check was running in the loop that read source files in, much before
      any of the other checks ran. Vetxonly makes vet exit early, but after
      all the source files have been read.
      
      To fix this, simply run the buildtag check along with all the other
      checks that get run on specific syntax tree nodes.
      
      Add a cmd/go test with go test -a, to ensure that the issue as reported
      is fixed.
      
      Fixes #26102.
      
      Change-Id: If6e3b9418ffa8166c0f982668b0d10872283776a
      Reviewed-on: https://go-review.googlesource.com/121395
      Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      1d1e25fb
  2. 28 Jun, 2018 10 commits
  3. 27 Jun, 2018 16 commits
  4. 26 Jun, 2018 10 commits
  5. 25 Jun, 2018 1 commit