1. 22 May, 2019 1 commit
  2. 21 May, 2019 10 commits
  3. 20 May, 2019 11 commits
  4. 17 May, 2019 12 commits
  5. 16 May, 2019 6 commits
    • Jay Conrod's avatar
      cmd/go: don't panic when explaining lost upgrades due to downgrades · 97ecc432
      Jay Conrod authored
      If a user runs 'go get mod@vers' where the module transitively
      requires itself at a newer version, 'go get' attempts to perform a
      downgrade, which necessarily excludes the requested version of the
      module.
      
      Previously, we called mvs.BuildList with the requested module
      version as the target. This panicked because BuildList doesn't allow
      the target module (typically the main module) to require a newer
      version of itself.
      
      With this change, when we lose an upgrade due to a downgrade, we call
      mvs.BuildList through a wrapper that treats the lost module version as
      requirement of a synthetic root module, rather than the target
      module. This avoids the panic.
      
      This change also starts reporting errors when an upgraded module is
      lost entirely (downgrades caused the module to be completely removed
      from the build list).
      
      Fixes #31491
      
      Change-Id: I70ca261c20af7553cad2d3b840a1eaf3d18a4191
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177602
      Run-TryBot: Jay Conrod <jayconrod@google.com>
      Reviewed-by: default avatarBryan C. Mills <bcmills@google.com>
      97ecc432
    • Michael Anthony Knyszek's avatar
      runtime: mark newly-mapped memory as scavenged · 4e7bef84
      Michael Anthony Knyszek authored
      On most platforms newly-mapped memory is untouched, meaning the pages
      backing the region haven't been faulted in yet. However, we mark this
      memory as unscavenged which means the background scavenger
      aggressively "returns" this memory to the OS if the heap is small.
      
      The only platform where newly-mapped memory is actually unscavenged (and
      counts toward the application's RSS) is on Windows, since
      (*mheap).sysAlloc commits the reservation. Instead of making a special
      case for Windows, I change the requirements a bit for a sysReserve'd
      region. It must now be both sysMap'd and sysUsed'd, with sysMap being a
      no-op on Windows. Comments about memory allocation have been updated to
      include a more up-to-date mental model of which states a region of memory
      may be in (at a very low level) and how to transition between these
      states.
      
      Now this means we can correctly mark newly-mapped heap memory as
      scavenged on every platform, reducing the load on the background
      scavenger early on in the application for small heaps. As a result,
      heap-growth scavenging is no longer necessary, since any actual RSS
      growth will be accounted for on the allocation codepath.
      
      Finally, this change also cleans up grow a little bit to avoid
      pretending that it's freeing an in-use span and just does the necessary
      operations directly.
      
      Fixes #32012.
      Fixes #31966.
      Updates #26473.
      
      Change-Id: Ie06061eb638162e0560cdeb0b8993d94cfb4d290
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177097
      Run-TryBot: Michael Knyszek <mknyszek@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarAustin Clements <austin@google.com>
      4e7bef84
    • Brad Fitzpatrick's avatar
      net/http: update vendored, bundled x/net/http2 · cb5c82bc
      Brad Fitzpatrick authored
      For:
      
          http2: track reused connections
          https://golang.org/cl/176720 (updates golang/go#31982)
      
      Some x/sys/unix updates come along for the ride too.
      
      I filed #32031 for making the bundling process less difficult and
      error-prone in the future.
      
      Change-Id: Ic822080991ffa2d50352c5f613e45648a327cf16
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177037
      Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      cb5c82bc
    • Bryan C. Mills's avatar
      cmd/go: include "gccgo stdlib" in lost build action check · e1fb8e42
      Bryan C. Mills authored
      Fixes #32060
      
      Change-Id: I49ab48a9bdd64a7ed777a045e2d92d28a37b5c0b
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177600
      Run-TryBot: Bryan C. Mills <bcmills@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      e1fb8e42
    • Bryan C. Mills's avatar
      cmd/go: always add 'go' directive to the go.mod file if missing · 48b7bdd0
      Bryan C. Mills authored
      Updates #30790
      Fixes #31960
      
      Change-Id: Ib3ac074cf1f98fe69f53af82d2a0441582116570
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176925
      Run-TryBot: Bryan C. Mills <bcmills@google.com>
      Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
      48b7bdd0
    • Josh Bleecher Snyder's avatar
      cmd/compile: invalidate CFG when fuseIf triggers · e7b7f874
      Josh Bleecher Snyder authored
      The compiler appears to have a latent bug:
      fusePlain calls invalidateCFG when it changes block structure,
      but fuseIf does not.
      
      Fix this by hoisting the call to invalidateCFG to the top level.
      
      Change-Id: Ic960fb3ac963b15b4a225aad84863d58efa954e6
      Reviewed-on: https://go-review.googlesource.com/c/go/+/177198
      Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarKeith Randall <khr@golang.org>
      e7b7f874