- 06 Jan, 2020 6 commits
-
-
Michael Matloob authored
Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: Ic16a0c6c1eabeba003b9cff620e2911078fd6cf8 Reviewed-on: https://go-review.googlesource.com/c/go/+/212813 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
It doesn't seem to be used anywhere. Change-Id: If979b6d69c9bf5261afd980d96f67991c417d46d Reviewed-on: https://go-review.googlesource.com/c/go/+/213218 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Joel Sing authored
For some reason the existing versions have additional padding - manually resync these structs with those in x/sys/unix, also bringing in pollFd which does not currently exist for linux/riscv64. Cross checked with the output from 'go tool cgo -godefs' on a linux/riscv64 machine. Updates #27532 Change-Id: I9fd2d3ad7222208a138773f4a9153c3c9cad7381 Reviewed-on: https://go-review.googlesource.com/c/go/+/212763 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
Joel Sing authored
linux/riscv64 does not provide a renameat syscall and there is no SYS_RENAMEAT defined in the syscall package. Provide Renameat as a wrapper around renameat2 instead. Updates #27532 Change-Id: I4864bdf0055e4272920583dcfb0efe2fd40adcbc Reviewed-on: https://go-review.googlesource.com/c/go/+/212762 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
Joel Sing authored
RISCV has no instruction to store an immediate value to memory, or to subtract an immediate value. An immediate needs to be moved to a register first, or in the case of $0, the zero value register (ZERO or R0) can be used instead. Restore the original riscv-go code so that it compiles. Updates #27532 Change-Id: I3c60e6f385c59679252a710dbba153357a367516 Reviewed-on: https://go-review.googlesource.com/c/go/+/212761 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
-
Tim Cooper authored
Fixes #36396 Change-Id: I52190f450fa9ac52fbf4ecdc814e954dc29029cd Reviewed-on: https://go-review.googlesource.com/c/go/+/213377Reviewed-by: Daniel Martí <mvdan@mvdan.cc> Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 04 Jan, 2020 4 commits
-
-
Joel Sing authored
ErrorUnresolved attempts to find the missing symbol in another ABI, in order to provide more friendly error messages. However, in doing so it checks the same ABI and can find the symbol reference for the symbol that it is currently reporting the unresolved error for. Avoid this by ignoring SXREF symbols, which is the same behaviour used when linking is performed. Fixes #33979 Change-Id: I3cb2477b2ad4baa7c2007323b983eb29404b0aac Reviewed-on: https://go-review.googlesource.com/c/go/+/192597 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com> Run-TryBot: Joel Sing <joel@sing.id.au>
-
Joel Sing authored
Move the CALL reloc symbol back to p.From.Sym, rather than p.To.Sym - while p.To.Sym is the correct final location, the call to lowerJALR flips the p.To and p.From addresses (and proves that this form of obj.Prog rewriting is not a good idea). Updates #27532 Change-Id: Iaf9fa24b05bda32b963f8d243401c6cd82c1355c Reviewed-on: https://go-review.googlesource.com/c/go/+/212759Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Joel Sing authored
Handle the rewriting of MOV pseudo-instructions in a separate pass. This allows AMOV to be more readily used by other code, including AGETCALLERPC and ARET implementations. Updates #27532 Change-Id: Iea794121210048ed23ed0fb8f3c5e3cd5354a311 Reviewed-on: https://go-review.googlesource.com/c/go/+/212758Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Cherry Zhang authored
R11 a.k.a. REGTMP is the temp register used by the assembler. It may be clobbered if the assembler needs to synthesize instructions. In particular, in nanotime1/walltime1, the load of global variable runtime.iscgo clobbers it. So, avoid using R11 to hold a long-lived value. Fixes #36309. Change-Id: Iec2ab9d664532cad8fbf58da17f580e64a744f62 Reviewed-on: https://go-review.googlesource.com/c/go/+/212641Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Andrew G. Morgan <agm@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 03 Jan, 2020 11 commits
-
-
Daniel Martí authored
It was pointed out to me that the thread sanitizer library has many more flags than the ones documented in this doc page. In particular, I was able to make use of GORACE=atexit_sleep_ms=10 to reduce the amount that 'go test -race' will sleep before finishing. I'm sure that this flag will be useful to others in the future, so add it here. This is still not a complete list, but we can simply add useful flags that work when we think they deserve a mention. Change-Id: If199d36fd80a0945af90055d110519e5dba27361 Reviewed-on: https://go-review.googlesource.com/c/go/+/200863Reviewed-by: Heschi Kreinick <heschi@google.com>
-
Jay Conrod authored
Fixes #36297 Change-Id: I2623e9ee386644eddfa9a348ba368c5f1a81f893 Reviewed-on: https://go-review.googlesource.com/c/go/+/213134 Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>
-
Michael Matloob authored
The literal string match had to be turned into a regexp, otherwise pretty straightforward. Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: I46f62312f02dc9adf83ed91c6f807420d29fbb12 Reviewed-on: https://go-review.googlesource.com/c/go/+/212939 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: Icd62dc8db55bec52ad326bc370ee7e435aae2559 Reviewed-on: https://go-review.googlesource.com/c/go/+/212812 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
This conversion is a bit weird, because the original test runs in the cmd/go directory, while the script test runs in the GOPATH directory. So even though it's not necessary for the new test, it changes dircectory to $WORK, so that its error message regexp can have four components like the original, just changing the old gopath directory 'testdata' the new one 'gopath'. Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: Ie5b029c43dc22167278d3104b37c0b57c61326be Reviewed-on: https://go-review.googlesource.com/c/go/+/212814 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
This test already runs in parallel, but still convert it to the script framework so we can delete the testdata/src directory and remove any ambiguity about which tests can run in parallel. Updates #36320 Change-Id: I6470979bd8bad0631dc6ead0d4eb9c83878356e8 Reviewed-on: https://go-review.googlesource.com/c/go/+/212815 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
The error that's tested in this test is also tested in list_test_err.txt which uses go list -test -deps. Because both commands are just loading packages, the difference is not meaningful. Updates #36320 Updates #17751 Change-Id: Ie712a77d64e8985dd908a1afb515ed3ecc0a9985 Reviewed-on: https://go-review.googlesource.com/c/go/+/212937 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
TestPluginNonMain was broken before this change! (It provided the wrong directory for testdep/p2: testdata/testdep/p2 instead of testdata/src/testdep/p2). Change-Id: Ib815f119bae1d758b500cd8ad82c016cb630d71e Reviewed-on: https://go-review.googlesource.com/c/go/+/212938 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Michael Matloob authored
This includes TestMatchesNoTestsDoesNotOverrideBuildFailure and TestErrorMessageForSyntaxErrorInTestGoFileSaysFAIL. Convert the tests that use the testdata/src/syntaxerror directory to the script framework. Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: I2b2b616e8c124996ae8c8e5b737f15bb493ec588 Reviewed-on: https://go-review.googlesource.com/c/go/+/212816 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Dmitri Shuralyov authored
root.html has been moved to the x/website repo in CL 180959 (commit golang/website@d83058ced3fadc3e8189107d2fb86c333c356b75). conduct.html has been moved to the x/website repo in CL 207437 (commit golang/website@99763cba2e5b53679a96f69725f917feb319b799). There should be only one copy, otherwise it may lead to confusion, or changes made in the wrong place. This CL removes the old copies from this repo since they're no longer used. Updates #29206 Change-Id: I41adfb2c34ed3d870fb7a671f48ccc8f90863feb Reviewed-on: https://go-review.googlesource.com/c/go/+/213157 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Emmanuel T Odeke authored
Found by running the go vet pass 'testinggoroutine' that I started in CL 212920. Change-Id: Ic9462fac85dbafc437fe4a323b886755a67a1efa Reviewed-on: https://go-review.googlesource.com/c/go/+/213097 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 02 Jan, 2020 5 commits
-
-
Katie Hockman authored
Updates #33637 Change-Id: Ia782b3fdc5a8873606b96120a34c9bf194a1a346 Reviewed-on: https://go-review.googlesource.com/c/go/+/211197Reviewed-by: Jay Conrod <jayconrod@google.com>
-
Austin Clements authored
Change-Id: Icd92d115e5d7f00b2100598baf2522ebebcdb223 Reviewed-on: https://go-review.googlesource.com/c/go/+/213125Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Cherry Zhang authored
If a pointer write is not atomic, if the GC is running concurrently, it may observe a partially updated pointer, which may point to unallocated or already dead memory. Most pointer writes, like the store instructions generated by the compiler, are already atomic. But we still need to be careful in places like memmove. In memmove, we don't know which bits are pointers (or too expensive to query), so we ensure that all aligned pointer-sized units are written atomically. Fixes #36101. Change-Id: I1b3ca24c6b1ac8a8aaf9ee470115e9a89ec1b00b Reviewed-on: https://go-review.googlesource.com/c/go/+/212626Reviewed-by: Austin Clements <austin@google.com>
-
Rhys Hiltner authored
When a goroutine yields the remainder of its time to another goroutine during direct semaphore handoff (as in an Unlock of a sync.Mutex in starvation mode), it needs to signal that change to the execution tracer. The discussion in CL 200577 didn't reach consensus on how best to describe that, but pointed out that "traceEvGoSched / goroutine calls Gosched" could be confusing. Emit a "traceEvGoPreempt / goroutine is preempted" event in this case, to allow the execution tracer to find a consistent event ordering without being both specific and inaccurate about why the active goroutine has changed. Fixes #36186 Change-Id: Ic4ade19325126db2599aff6aba7cba028bb0bee9 Reviewed-on: https://go-review.googlesource.com/c/go/+/211797 Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
-
Dmitri Shuralyov authored
Starting with 2014 (golang.org/cl/46660043), we have enjoyed 6 consecutive years of the gopher. Now, the slice¹ of gophers is ready to make its way into the next decade, as 2020 is the new Year of the Gopher. ¹ https://en.wikipedia.org/w/index.php?title=List_of_English_terms_of_venery,_by_animal&oldid=932675028#G Change-Id: I5f9598dbedb373bd13021964193fa9e44c67693e Reviewed-on: https://go-review.googlesource.com/c/go/+/213017 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: David Symonds <dsymonds@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 31 Dec, 2019 1 commit
-
-
Tobias Klauser authored
Use the libc fcntl (via syscall.fcntl) on aix and solaris like it is already done for darwin. For the syscall-based fcntl implementation use FcntlSyscall from internal/syscall/unix in order to get fcntl64 on 32-bit Linux systems. On aix, fcntl with F_DUPFD_CLOEXEC is not supported. Thus, defined F_DUPFD_CLOEXEC = 0 in the syscall package and check its value before calling fcntl(fd, syscall.F_DUPFD_CLOEXEC, 0). On js/wasm, fcntl is not supported thus let its implementation return ENOSYS directly. Updates #36211 Change-Id: I96a2ea79e5c4eed2fefd94d0aefd72c940825682 Reviewed-on: https://go-review.googlesource.com/c/go/+/212278 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 30 Dec, 2019 3 commits
-
-
Tobias Klauser authored
On aix and solaris (like on darwin) use libc fcntl to implement IsNonblock instead of Syscall(SYS_FCNTL, ...) which isn't supported. Change-Id: I989b02aa0c90b7e2dae025572867dda277fef8be Reviewed-on: https://go-review.googlesource.com/c/go/+/212600 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Josh Bleecher Snyder authored
Change-Id: I25fbd63f10ea9892589ad44cc45761926aff0648 Reviewed-on: https://go-review.googlesource.com/c/go/+/212841Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Tobias Klauser authored
Use fcntl64Syscall in forkAndExecInChild1 to get fcntl64 on 32-bit Linux systems. Updates #36211 Change-Id: Id0e34359256beace970e72102fdace7a987ff2b0 Reviewed-on: https://go-review.googlesource.com/c/go/+/212598 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 27 Dec, 2019 3 commits
-
-
Michael Anthony Knyszek authored
This change makes it so that we check whether scavAddr is actually mapped before trying to look at the summary for the fast path, since we may segfault if that that part of the summary is not mapped in. Previously this wasn't a problem because we would conservatively map all memory for the summaries between the lowest mapped heap address and the highest one. This change also adds a test for this case. Change-Id: I2b1d89b5e044dce81745964dfaba829f4becdc57 Reviewed-on: https://go-review.googlesource.com/c/go/+/212637 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Ian Lance Taylor authored
Fixes #36245 Change-Id: I10ce50b0cc28b15f4e7be85b8f12cf9d0e4fac96 Reviewed-on: https://go-review.googlesource.com/c/go/+/212404 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
-
Ian Lance Taylor authored
Updates #36281 Change-Id: I3c4487caaf47566212dc62322b2e884e695ea7f1 Reviewed-on: https://go-review.googlesource.com/c/go/+/212657Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
-
- 26 Dec, 2019 2 commits
-
-
Michael Anthony Knyszek authored
This change disables pageAlloc tests on OpenBSD in short mode because pageAlloc holds relatively large virtual memory reservations and we make two during the pageAlloc tests. The runtime may also be carrying one such reservation making the virtual memory requirement for testing the Go runtime three times as much as just running a Go binary. This causes problems for folks who just want to build and test Go (all.bash) on OpenBSD but either don't have machines with at least 4ish GiB of RAM (per-process virtual memory limits are capped at some constant factor times the amount of physical memory) or their per-process virtual memory limits are low for other reasons. Fixes #36210. Change-Id: I8d89cfde448d4cd2fefff4ad6ffed90de63dd527 Reviewed-on: https://go-review.googlesource.com/c/go/+/212177 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
-
Tobias Klauser authored
Use FcntlSyscall from internal/syscall/unix to get fcntl64 on 32-bit Linux systems. Updates #36211 Change-Id: If48a6e09606ca9f7f6e22f3e8dc9a25fb3ccaf65 Reviewed-on: https://go-review.googlesource.com/c/go/+/212537 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
- 24 Dec, 2019 5 commits
-
-
Ariel Mashraki authored
Package name and documentation link were wrong. Change-Id: I274906afc3cf7a3d88e3da76549cd6ab008fd0c7 Reviewed-on: https://go-review.googlesource.com/c/go/+/212538Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Isfan Azhabil authored
Fix a typo DNS name, it should be [onion.vegetables.com](http://onion.vegetables.com/) Change-Id: I4122a2305b8f5e774a834651e70c75b54e9386bd GitHub-Last-Rev: 9907897944275c5f8c54c79667cbb1ef474539de GitHub-Pull-Request: golang/go#36270 Reviewed-on: https://go-review.googlesource.com/c/go/+/212410Reviewed-by: Ian Lance Taylor <iant@golang.org>
-
Joel Sing authored
Updates #27532 Change-Id: Ib3e44ec524ed20bbfbbaf40df22cec335460f3ef Reviewed-on: https://go-review.googlesource.com/c/go/+/204629 Run-TryBot: Joel Sing <joel@sing.id.au> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Joel Sing authored
Based on riscv-go port. Updates #27532 Change-Id: I5e7f45955e1dfdb9d09cc6a4e6f3ce81216d411d Reviewed-on: https://go-review.googlesource.com/c/go/+/204628Reviewed-by: Cherry Zhang <cherryyz@google.com>
-
Joel Sing authored
Also provide REG_LR to more clearly define the link register. Based on the riscv-go port. Updates #27532 Change-Id: I0805f373682f93b3918a01c21d4ef34eb3817c75 Reviewed-on: https://go-review.googlesource.com/c/go/+/204627Reviewed-by: Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-