1. 21 Oct, 2017 4 commits
    • Joe Tsai's avatar
      encoding/csv: add ParseError.RecordLine · 29ea82d0
      Joe Tsai authored
      CL 72150 fixes #22352 by reverting the problematic parts of that CL
      where the line number and column number were inconsistent with each other.
      This CL adds back functionality to address the issue that CL 72150
      was trying to solve in the first place. That is, it reports the starting
      line of the record, so that users have a frame of reference to start with
      when debugging what went wrong.
      
      In the event of gnarly CSV files with multiline quoted strings, a parse
      failure likely occurs somewhere between the start of the record and
      the point where the parser finally detected an error.
      Since ParserError.{Line,Column} reports where the *error* occurs, we
      add a RecordLine field to report where the record starts.
      
      Also take this time to cleanup and modernize TestRead.
      
      Fixes #19019
      Fixes #22352
      
      Change-Id: I16cebf0b81922c35f75804c7073e9cddbfd11a04
      Reviewed-on: https://go-review.googlesource.com/72310Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      29ea82d0
    • David Crawshaw's avatar
      cmd/link: move Headtype global to ctxt · 38cfeb9c
      David Crawshaw authored
      For #22095
      
      Change-Id: Idcfdfe8a94db8626392658bb93429454238f648a
      Reviewed-on: https://go-review.googlesource.com/70835
      Run-TryBot: David Crawshaw <crawshaw@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      38cfeb9c
    • Cherry Zhang's avatar
      runtime: support cgo traceback on PPC64LE · 6fd1f825
      Cherry Zhang authored
      Code essentially mirrors AMD64 implementation.
      
      Change-Id: I39f7f099ce11fdc3772df039998cc11947bb22a2
      Reviewed-on: https://go-review.googlesource.com/72270
      Run-TryBot: Cherry Zhang <cherryyz@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      6fd1f825
    • Alex Brainman's avatar
      os: simplify windows Pipe · 6407b3c8
      Alex Brainman authored
      windows version of Pipe function is implemented by calling
      syscall.Pipe which returns handles inheritable by client process,
      and then adjusting returned handles with syscall.CloseOnExec.
      
      Just create non-inheritable handles in the first place.
      Now that we don't have a race window in the code, drop use
      of syscall.ForkLock.
      
      Change-Id: Ie325da7c2397b5995db4a5ddb0117e2ce1745187
      Reviewed-on: https://go-review.googlesource.com/72010Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      6407b3c8
  2. 20 Oct, 2017 13 commits
  3. 19 Oct, 2017 12 commits
  4. 18 Oct, 2017 10 commits
  5. 17 Oct, 2017 1 commit