Commits · 3180137b86fa0fd529bbaeb9bcd873331e0fb183 · Kirill Smelkov / go

15 Apr, 2012 1 commit
- text/template/parse: fix doc comment · 3180137b
  Shenghou Ma authored Apr 15, 2012
```
    Fixes #3529.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6037046
```
  3180137b
14 Apr, 2012 2 commits

strconv: make malloc tests more reliable · 84ef97b5

Dave Cheney authored Apr 14, 2012

Fixes #3495.

I adapted fmt.TestCountMallocs to fix the
existing tests. As the resulting tests did not
appear to belong to either itoa or ftoa I moved
them into their own file.

R=bradfitz, fullung
CC=golang-dev
https://golang.org/cl/5985072

84ef97b5

doc: update Mercurial installation instructions · 0e596024
Andrew Gerrand authored Apr 14, 2012
```
R=r
CC=golang-dev
https://golang.org/cl/6031046
```
0e596024

13 Apr, 2012 3 commits
- cmd/6g: restore magic multiply for /=, %=. · 061061e7
  Rémy Oudompheng authored Apr 13, 2012
```
Also enables turning /= 2 in a right shift.

Part of issue 2230.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6012049
```
  061061e7
- doc/effective_go.html: fixed the Request channel parameter · 08f919f4
  Jongmin Kim authored Apr 13, 2012
```
R=golang-dev, r
CC=golang-dev, gri
https://golang.org/cl/6010051
```
  08f919f4
- time: panic if UnixNano is out of range · e4389c1d
  Gustavo Niemeyer authored Apr 12, 2012
```
R=golang-dev, remyoudompheng, dsymonds, gustavo, dchest, r, rsc
CC=golang-dev
https://golang.org/cl/5985059
```
  e4389c1d
12 Apr, 2012 6 commits

fmt: fix crash of %b on huge negative int64 · a662d3d9

Rob Pike authored Apr 13, 2012

The buffer had 64 bytes but needs one more for the sign.

Fixes #3510.

R=golang-dev, dave, dsymonds
CC=golang-dev
https://golang.org/cl/6011057

a662d3d9

crypto/tls: don't always use the default private key. · e6e8b723

Adam Langley authored Apr 12, 2012

When SNI based certificate selection is enabled, we previously used
the default private key even if we selected a non-default certificate.

Fixes #3367.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5987058

e6e8b723

encoding/pem: ignore spaces and tabs at the end of header lines. · 55af51d5
Adam Langley authored Apr 12, 2012
```
Fixes #3502.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6011046
```
55af51d5

runtime: speedup GC sweep phase (batch free) · 4945fc8e

Dmitriy Vyukov authored Apr 12, 2012

benchmark old ns/op new ns/op delta
garbage.BenchmarkParser 4370050250 3779668750 -13.51%
garbage.BenchmarkParser-2 3713087000 3628771500 -2.27%
garbage.BenchmarkParser-4 3519755250 3406349750 -3.22%
garbage.BenchmarkParser-8 3386627750 3319144000 -1.99%

garbage.BenchmarkTree 493585529 408102411 -17.32%
garbage.BenchmarkTree-2 500487176 402285176 -19.62%
garbage.BenchmarkTree-4 473238882 361484058 -23.61%
garbage.BenchmarkTree-8 486977823 368334823 -24.36%

garbage.BenchmarkTree2 31446600 31203200 -0.77%
garbage.BenchmarkTree2-2 21469000 21077900 -1.82%
garbage.BenchmarkTree2-4 11007600 10899100 -0.99%
garbage.BenchmarkTree2-8 7692400 7032600 -8.58%

garbage.BenchmarkParserPause 241863263 163249450 -32.50%
garbage.BenchmarkParserPause-2 120135418 112981575 -5.95%
garbage.BenchmarkParserPause-4 83411552 64580700 -22.58%
garbage.BenchmarkParserPause-8 51870697 42207244 -18.63%

garbage.BenchmarkTreePause 20940474 13147011 -37.22%
garbage.BenchmarkTreePause-2 20115124 11146715 -44.59%
garbage.BenchmarkTreePause-4 17217584 7486327 -56.52%
garbage.BenchmarkTreePause-8 18258845 7400871 -59.47%

garbage.BenchmarkTree2Pause 174067190 172674190 -0.80%
garbage.BenchmarkTree2Pause-2 131175809 130615761 -0.43%
garbage.BenchmarkTree2Pause-4 95406666 93972047 -1.50%
garbage.BenchmarkTree2Pause-8 86056095 85334952 -0.84%

garbage.BenchmarkParserLastPause 329932000 324790000 -1.56%
garbage.BenchmarkParserLastPause-2 209383000 210456000 +0.51%
garbage.BenchmarkParserLastPause-4 113981000 112921000 -0.93%
garbage.BenchmarkParserLastPause-8 77967000 76625000 -1.72%

garbage.BenchmarkTreeLastPause 29752000 18444000 -38.01%
garbage.BenchmarkTreeLastPause-2 24274000 14766000 -39.17%
garbage.BenchmarkTreeLastPause-4 19565000 8726000 -55.40%
garbage.BenchmarkTreeLastPause-8 21956000 10530000 -52.04%

garbage.BenchmarkTree2LastPause 314411000 311945000 -0.78%
garbage.BenchmarkTree2LastPause-2 214641000 210836000 -1.77%
garbage.BenchmarkTree2LastPause-4 110024000 108943000 -0.98%
garbage.BenchmarkTree2LastPause-8 76873000 70263000 -8.60%

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5991049

4945fc8e

runtime: add lock-free stack · a5dc7793

Dmitriy Vyukov authored Apr 12, 2012

This is factored out part of the:
https://golang.org/cl/5279048/
(parallel GC)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5993043

a5dc7793

text/template: catch unexported fields during parse · 2d0d3d8f

Rob Pike authored Apr 12, 2012

It's a common error to reference unexported field names in templates,
especially for newcomers. This catches the error at parse time rather than
execute time so the rare few who check errors will notice right away.

These were always an error, so the net behavior is unchanged.
Should break no existing code, just identify the error earlier.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6009048

2d0d3d8f

11 Apr, 2012 8 commits

misc/dashboard: cope with removed Package fields. · e6c5e2a3

David Symonds authored Apr 12, 2012

adg removed some now-unwanted fields in Package a while ago,
but there are still datastore entities with those fields,
so we must explicitly check for ErrFieldMismatch and ignore it.

R=golang-dev, rsc
CC=adg, golang-dev
https://golang.org/cl/6007043

e6c5e2a3

html, exp/html: escape ' and " as ' and ", since IE8 and · 6277656d

Nigel Tao authored Apr 12, 2012

below do not support &apos;.

This makes package html consistent with package text/template's
HTMLEscape function.

Fixes #3489.

R=rsc, mikesamuel, dsymonds
CC=golang-dev
https://golang.org/cl/5992071

6277656d

crypto/rsa: fix Verify for multi-prime keys. · 772e8ff4

Adam Langley authored Apr 11, 2012

The least common multiple is not totient/gcd.

R=remyoudompheng
CC=golang-dev
https://golang.org/cl/5990045

772e8ff4

crypto/tls: update how we create testing scripts. · 7247dcab

Adam Langley authored Apr 11, 2012

crypto/tls is tested, in part, by replaying recorded TLS connections
and checking that the bytes sent by the Go code haven't changed.

Previously we used GnuTLS's debug output and extracted the bytes of
the TLS connection using a Python script. That wasn't great, and I
think GnuTLS removed that level of debugging in a more current
release.

This change records the connection with Go code and adds a test for
ECDHE-AES clients generating using this method.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5988048

7247dcab

exp/norm: exposed runeInfo type in API. · 98aa4968

Marcel van Lohuizen authored Apr 11, 2012

For completeness, we also expose the Canonical Combining Class of a rune.
This does not increase the data size.

R=r
CC=golang-dev
https://golang.org/cl/5931043

98aa4968

runtime: add interface microbenchmarks · d8e9b04c

Dave Cheney authored Apr 11, 2012

2011 Mac Mini, Core i5 @ 2.3Ghz

BenchmarkConvT2E        50000000                40.4 ns/op
BenchmarkConvT2EBig     20000000               107 ns/op
BenchmarkConvT2I        100000000               28.9 ns/op
BenchmarkConvI2E        500000000                5.93 ns/op
BenchmarkConvI2I        100000000               19.0 ns/op
BenchmarkAssertE2T      100000000               14.1 ns/op
BenchmarkAssertE2TBig   100000000               17.8 ns/op
BenchmarkAssertE2I      100000000               21.3 ns/op
BenchmarkAssertI2T      100000000               14.3 ns/op
BenchmarkAssertI2I      100000000               20.8 ns/op
BenchmarkAssertI2E      500000000                5.58 ns/op

Pandaboard, 2 x Omap4 @ 1.2Ghz

BenchmarkConvT2E        10000000               215 ns/op
BenchmarkConvT2EBig      1000000              3697 ns/op
BenchmarkConvT2I         5000000               666 ns/op
BenchmarkConvI2E        50000000                42.4 ns/op
BenchmarkConvI2I         5000000               489 ns/op
BenchmarkAssertE2T      20000000                90.0 ns/op
BenchmarkAssertE2TBig   20000000                91.6 ns/op
BenchmarkAssertE2I       5000000               515 ns/op
BenchmarkAssertI2T      20000000               124 ns/op
BenchmarkAssertI2I       5000000               517 ns/op
BenchmarkAssertI2E      50000000                47.2 ns/op
BenchmarkAssertE2E      50000000                42.7 ns/op

R=minux.ma, rsc, fullung, bsiegert, dsymonds
CC=golang-dev
https://golang.org/cl/5777048

d8e9b04c

runtime: update openbsd thread related syscalls to match kernel · 8cea1bf1

Joel Sing authored Apr 11, 2012

Update the threxit and thrsleep syscalls to match the ABI of the
OpenBSD 5.1 kernel. These changes are backwards compatible with
older kernels.

Fixes #3311.

R=golang-dev, rsc, devon.odell
CC=golang-dev
https://golang.org/cl/5777079

8cea1bf1

doc: fix minor typo in Go 1 release notes · d7bc644b
Dave Cheney authored Apr 11, 2012
```
Fixes #3478.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5986074
```
d7bc644b

10 Apr, 2012 16 commits

5l, runtime: remove softfloat emulation code when not used · 1a59e623

Shenghou Ma authored Apr 11, 2012

This leads to ~30kB improvement on code size for ARM machines with VFP/NEON.
Example: go test -c math
       GOARM=5  GOARM=6
  Old: 1884200  1839144
  New: 1884165  1805245
  -:        35    33899

R=rsc, bradfitz, dave, kai.backman
CC=golang-dev
https://golang.org/cl/5975060

1a59e623

5a, 5l: add PLD (preload data) instruction · 2031252f

Shenghou Ma authored Apr 11, 2012

        Supported in ARMv5TE and above, excluding ARMv5TExP.
        For CL 5990066.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5999044

2031252f

hash: more efficient memory allocation · 9feddd0b

Pascal S. de Kloe authored Apr 10, 2012

Feed append the complete content at once.

BenchmarkAdler32KB       1000000              2534 ns/op         404.05 MB/s
BenchmarkCrc32KB          500000              4757 ns/op         215.26 MB/s
BenchmarkCrc64KB          500000              4769 ns/op         214.70 MB/s
BenchmarkFnv32KB         1000000              2417 ns/op         423.64 MB/s
BenchmarkFnv32aKB        1000000              2408 ns/op         425.23 MB/s
BenchmarkFnv64KB          500000              4262 ns/op         240.21 MB/s
BenchmarkFnv64aKB         500000              4234 ns/op         241.83 MB/s

R=iant, rsc, r, minux.ma
CC=golang-dev
https://golang.org/cl/5937053

9feddd0b

runtime: fix floating point exception on Plan 9 · 7056ec6b

Akshat Kumar authored Apr 10, 2012

Change 5660047 moved an FLDCW instruction
that disables invalid operand traps into
runtime·asminit, which is called from
runtime·mstart. Thus, runtime·check is being
called prior to setting the appropriate control bits,
which on any QNaN comparison will cause Plan 9
to take an invalid operand trap. This change loads
the control bits (for Plan 9) prior to runtime·check.
Ideally, this should be done before the QNaN checks
on any system, but possibly other kernels simply
don't ever trap on invalid operands.

R=golang-dev, rminnich
CC=golang-dev, john, rsc
https://golang.org/cl/5939045

7056ec6b

A+C: Akshat Kumar (individual CLA) · c9ad57ff
Russ Cox authored Apr 10, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6004043
```
c9ad57ff
runtime: unregister the SIGILL handler after ARM EABI test · e133ee95
Quan Yong Zhai authored Apr 10, 2012
```
Part of issue 3381

R=rsc, minux.ma, dave
CC=golang-dev
https://golang.org/cl/5969064
```
e133ee95

6c, 6g, 6l: add MOVQL to make truncation explicit · e530d6a1

Russ Cox authored Apr 10, 2012

Without an explicit signal for a truncation, copy propagation
will sometimes propagate a 32-bit truncation and end up
overwriting uses of the original 64-bit value.

The case that arose in practice is in C but I believe
that the same could plausibly happen in Go.
The main reason we didn't run into the same in Go
is that I (perhaps incorrectly?) drop MOVL AX, AX
during gins, so the truncation was never generated, so
it didn't confuse the optimizer.

Fixes #1315.
Fixes #3488.

R=ken2
CC=golang-dev
https://golang.org/cl/6002043

e530d6a1

cmd/6c: fix probable code gen bug · b72c7e94

Russ Cox authored Apr 10, 2012

This is a pointer being copied; MOVL can't possibly be right.

R=ken2
CC=golang-dev
https://golang.org/cl/5999043

b72c7e94

cmd/8c: fix store to complex uint64 ptr · 30bc5d7b

Russ Cox authored Apr 10, 2012

Assignment of a computed uint64 value to an
address derived with a function call was executing
the call after computing the value, which trashed
the value (held in registers).

long long *f(void) { return 0; }
void g(int x, int y) {
        *f() = (long long)x | (long long)y<<32;
}

Before:

(x.c:3)	TEXT	g+0(SB),(gok(71))
...
(x.c:4)	ORL	AX,DX
(x.c:4)	ORL	CX,BX
(x.c:4)	CALL	,f+0(SB)
(x.c:4)	MOVL	DX,(AX)
(x.c:4)	MOVL	BX,4(AX)

After:
(x.c:3)	TEXT	g+0(SB),(gok(71))
(x.c:4)	CALL	,f+0(SB)
...
(x.c:4)	ORL	CX,BX
(x.c:4)	ORL	DX,BP
(x.c:4)	MOVL	BX,(AX)
(x.c:4)	MOVL	BP,4(AX)

Fixes #3501.

R=ken2
CC=golang-dev
https://golang.org/cl/5998043

30bc5d7b

syscall: support Getpid() on Windows · ae382129

Shenghou Ma authored Apr 10, 2012

        Fixes #3379.

R=golang-dev, alex.brainman, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5909043

ae382129

cmd/api: allow addition of API · edf8b03f
Shenghou Ma authored Apr 10, 2012
```
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5991081
```
edf8b03f
8a, 8l: add PREFETCH instructions · 3d462449
Russ Cox authored Apr 10, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/5992082
```
3d462449
6a, 6l: add PREFETCH instructions · 35d260fa
Russ Cox authored Apr 10, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/5989073
```
35d260fa

runtime: block signals during thread creation on openbsd · 098b9dcf

Joel Sing authored Apr 10, 2012

Block signals during thread creation, otherwise the new thread can
receive a signal prior to initialisation completing.

Fixes #3102.

R=golang-dev, rsc, devon.odell, minux.ma
CC=golang-dev
https://golang.org/cl/5757064

098b9dcf

test/bench/shootout: update timing.log to Go 1 · caedc603
Rob Pike authored Apr 10, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5989063
```
caedc603
os: fix IsPermission on windows · 8e109af8
Alex Brainman authored Apr 10, 2012
```
Fixes #3482.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5987070
```
8e109af8

09 Apr, 2012 4 commits

runtime.Callers: make documentation match code · 6849c4db

Rob Pike authored Apr 10, 2012

It is a bug that Caller and Callers disagree about the offset of the skip
parameter. Document the bug.

R=rsc, dsymonds, r, iant
CC=golang-dev
https://golang.org/cl/5976064

6849c4db

cmd/dist: don't fail when Mercurial is a batch file on Windows · 0669261a

Alexey Borzenkov authored Apr 09, 2012

On windows Mercurial installed with easy_install typically creates
an hg.bat batch file in Python Scripts directory, which cannot be used
with CreateProcess unless full path is specified. Work around by
launching hg via cmd.exe /c.

Additionally, fix a rare FormatMessageW crash.

Fixes #3093.

R=golang-dev, rsc, alex.brainman, aram, jdpoirier, mattn.jp
CC=golang-dev
https://golang.org/cl/5937043

0669261a

cmd/yacc: spring cleaning for units.y · f6d582db

Benny Siegert authored Apr 09, 2012

* sort imports
* use runtime.GOROOT
* fix some typos

R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5987054

f6d582db

debug/gosym: in test, use temp binary name in /tmp, and clean up. · 494fe3b0
Brad Fitzpatrick authored Apr 09, 2012
```
This fixes all.bash on shared machines.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5992078
```
494fe3b0