- 09 Sep, 2011 3 commits
-
-
Yasuhiro Matsumoto authored
Fixes #2201 R=golang-dev, r, rsc, alex.brainman, robert.hencke, jp CC=golang-dev https://golang.org/cl/4950051
-
Mike Samuel authored
Augments type context and adds grammatical rules to handle special HTML constructs: <!-- comments --> <script>raw text</script> <textarea>no tags here</textarea> This CL does not elide comment content. I recommend we do that but have not done it in this CL. I used a codesearch tool over a codebase in another template language. Based on the below I think we should definitely recognize <script>, <style>, <textarea>, and <title> as each of these appears frequently enough that there are few template using apps that do not use most of them. Of the other special tags, <xmp>, <noscript> are used but infrequently, and <noframe> and friend, <listing> do not appear at all. We could support <xmp> even though it is obsolete in HTML5 because we already have the machinery, but I suggest we do not support noscript since it is a normal tag in some browser configurations. I suggest recognizing and eliding <!-- comments --> (but not escaping text spans) as they are widely used to embed comments in template source. Not eliding them increases the size of content sent over the network, and risks leaking code and project internal details. The template language I tested elides them so there are no instance of IE conditional compilation directives in the codebase but that could be a source of confusion. The codesearch does the equivalent of $ find . -name \*.file-extension \ | perl -ne 'print "\L$1\n" while s@<([a-z][a-z0-9])@@i' \ | sort | uniq -c | sort The 5 uses of <plaintext> seem to be in tricky code and can be ignored. The 2 uses of <xmp> appear in the same tricky code and can be ignored. I also ignored end tags to avoid biasing against unary elements and threw out some nonsense names since since the long tail is dominated by uses of < as a comparison operator in the template languages expression language. I have added asterisks next to abnormal elements. 26765 div 7432 span 7414 td 4233 a 3730 tr 3238 input 2102 br 1756 li 1755 img 1674 table 1388 p 1311 th 1064 option 992 b 891 label 714 script * 519 ul 446 tbody 412 button 381 form 377 h2 358 select 353 strong 318 h3 314 body 303 html 266 link 262 textarea * 261 head 258 meta 225 title * 189 h1 176 col 156 style * 151 hr 119 iframe 103 h4 101 pre 100 dt 98 thead 90 dd 83 map 80 i 69 object 66 ol 65 em 60 param 60 font 57 fieldset 51 string 51 field 51 center 44 bidi 37 kbd 35 legend 30 nobr 29 dl 28 var 26 small 21 cite 21 base 20 embed 19 colgroup 12 u 12 canvas 10 sup 10 rect 10 optgroup 10 noscript * 9 wbr 9 blockquote 8 tfoot 8 code 8 caption 8 abbr 7 msg 6 tt 6 text 6 h5 5 svg 5 plaintext * 5 article 4 shortquote 4 number 4 menu 4 ins 3 progress 3 header 3 content 3 bool 3 audio 3 attribute 3 acronym 2 xmp * 2 overwrite 2 objects 2 nobreak 2 metadata 2 description 2 datasource 2 category 2 action R=nigeltao CC=golang-dev https://golang.org/cl/4964045
-
Robert Griesemer authored
R=r, adg CC=golang-dev https://golang.org/cl/4995041
-
- 08 Sep, 2011 18 commits
-
-
Jaroslavas Počepko authored
R=alex.brainman CC=golang-dev https://golang.org/cl/4983053
-
Robert Griesemer authored
Also: fix layout of textual search results and fix a field reference in the respective template. Fixes #1987. R=rsc, r CC=golang-dev https://golang.org/cl/4962061
-
Mike Samuel authored
This does not wire up <style> elements as that is pending support for raw text content in CL https://golang.org/cl/4964045/ This CL allows actions to appear in contexts like selectors: {{.Tag}}{{.Class}}{{.Id}} property names: border-{{.BidiLeadingEdge}} property values: color: {{.Color}} strings: font-family: "{{font-name}}" URL strings: background: "/foo?image={{.ImgQuery}}" URL literals: background: url("{{.Image}}") but disallows actions inside CSS comments and disallows embedding of JS in CSS entirely. It is based on the CSS3 lexical grammar with affordances for common browser extensions including line comments. R=nigeltao CC=golang-dev https://golang.org/cl/4968058
-
Russ Cox authored
R=r CC=golang-dev https://golang.org/cl/4962060
-
Russ Cox authored
R=r CC=golang-dev https://golang.org/cl/4967060
-
Russ Cox authored
R=r CC=golang-dev https://golang.org/cl/4952061
-
Mikio Hara authored
R=golang-dev CC=golang-dev https://golang.org/cl/4956069
-
Robert Griesemer authored
- fix suggested by rodrigo.moraes Fixes #1755. R=rsc CC=golang-dev https://golang.org/cl/4977057
-
Russ Cox authored
Not exposed in the API yet, but passes tests. R=r CC=golang-dev https://golang.org/cl/4967059
-
Russ Cox authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/4969063
-
Dmitriy Vyukov authored
R=rsc CC=golang-dev https://golang.org/cl/4977054
-
Jaroslavas Počepko authored
os.Lstat can return ENOTDIR as well. R=golang-dev, r, alex.brainman CC=golang-dev, rsc https://golang.org/cl/4984051
-
Paul Lalonde authored
I don't know the protocol regarding the zsyscall files which appear to be hand-generated, so I've re-done them and added them to the change. R=rsc, alex.brainman, nigeltao CC=golang-dev https://golang.org/cl/4975060
-
Nigel Tao authored
R=dsymonds CC=golang-dev https://golang.org/cl/4961073
-
Alex Brainman authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/4962057
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4973070
-
Andrew Gerrand authored
R=dsymonds, r, rsc CC=golang-dev https://golang.org/cl/4981047
-
Andrew Gerrand authored
R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/4978057
-
- 07 Sep, 2011 17 commits
-
-
Andrew Gerrand authored
R=r CC=golang-dev https://golang.org/cl/4991043
-
Andrew Gerrand authored
R=dsymonds, rsc, r CC=golang-dev https://golang.org/cl/4968070
-
Robert Griesemer authored
API change. Needs further reflection. ««« original CL description path/filepath: Simplify Walk interface The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes #2237. R=golang-dev, gri, r CC=golang-dev https://golang.org/cl/4964067 »»» R=r CC=golang-dev https://golang.org/cl/4974065
-
Gustavo Niemeyer authored
The last argument of filepath.Walk was removed, and the Visitor interface now contains an Error method that is called on errors. Fixes #2237. R=golang-dev, gri, r CC=golang-dev https://golang.org/cl/4964067
-
Russ Cox authored
The linker would catch them if gc succeeded, but too often the cycle manifests as making the current package and the imported copy of itself appear as different packages, which result in type signature mismatches that confuse users. As a crutch, add the -p flag to say 'if you see an import of this package, give up early'. Results in messages like (during gotest in sort): export_test.go:7: import "sort" while compiling that package (import cycle) export_test.go:7: import "container/heap": package depends on "sort" (import cycle) Fixes #2042. R=ken CC=bradfitz, dsymonds, golang-dev https://golang.org/cl/4972057
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4961069
-
Hector Chu authored
Verified with objdump -W. R=alex.brainman, rsc CC=golang-dev https://golang.org/cl/4974061
-
Russ Cox authored
Also add exp/regexp to build (forgot before). At this point I am very confident in exp/regexp's behavior. It should be usable as a drop-in replacement for regexp now. Later CLs could introduce a CompilePOSIX to get at traditional POSIX ``extended regular expressions'' as in egrep and also an re.MatchLongest method to change the matching mode to leftmost longest instead of leftmost first. On the other hand, I expect very few people to use either. R=r, r, gustavo CC=golang-dev https://golang.org/cl/4990041
-
Mikio Hara authored
Note that this CL will break your existing code which uses ParseCIDR. This CL changes ParseCIDR("172.16.253.121/28") to return the IP address "172.16.253.121", the network implied by the network number "172.16.253.112" and mask "255.255.255.240". R=rsc, borman CC=golang-dev https://golang.org/cl/4749043
-
Lucio De Re authored
R=golang-dev CC=golang-dev, rsc https://golang.org/cl/4975055
-
Ziad Hatahet authored
See http://research.swtch.com/2008/01/killing-quicksort.html for more info. Fixes #467. R=r, rsc CC=golang-dev https://golang.org/cl/4591051
-
Hector Chu authored
Extract Windows filenames correctly. Don't remove receivers from method names. Fixes #2227. R=rsc CC=golang-dev https://golang.org/cl/4969059
-
Russ Cox authored
R=golang-dev, r CC=golang-dev https://golang.org/cl/4964066
-
Dmitriy Vyukov authored
R=rsc CC=golang-dev https://golang.org/cl/4950060
-
Russ Cox authored
R=nigeltao CC=golang-dev https://golang.org/cl/4987041
-
Luuk van Dijk authored
Fixes #2225 R=rsc, nigeltao, dave CC=bradfitz, golang-dev, mikioh.mikioh https://golang.org/cl/4972056
-
David Symonds authored
It actually occurred with the previous weekly snapshot. R=golang-dev, adg CC=golang-dev https://golang.org/cl/4961066
-
- 06 Sep, 2011 2 commits
-
-
Robert Griesemer authored
R=r CC=golang-dev https://golang.org/cl/4984052
-
Rob Pike authored
R=golang-dev, rsc CC=golang-dev https://golang.org/cl/4951066
-