- 07 Jun, 2018 6 commits
-
-
Russ Cox authored
These got lost because I violated the cardinal rule of Gerrit which is never click the Submit button in the web UI. Change-Id: I8ccdfb5d8691960f244941036d33fb5a5a3f0c9a Reviewed-on: https://go-review.googlesource.com/117015Reviewed-by:
Russ Cox <rsc@golang.org>
-
Agniva De Sarker authored
This is needed when we are re-building to the wasm target. Fixes #25774 Change-Id: I5dc47bd7e56c8570b8d2485273ef0d10f2feac6f Reviewed-on: https://go-review.googlesource.com/116915Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Russ Cox authored
We want package analysis tools to be able to ask cmd/go for cgo-translated files and for the names of files holding export type information, instead of reinventing that logic themselves. Allow them to do so, with the new list -cgo and -export flags. Change-Id: I860df530d8dcc130f1f328413381b5664cc81c3b Reviewed-on: https://go-review.googlesource.com/108156 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by:
Bryan C. Mills <bcmills@google.com>
-
Tobias Klauser authored
They are unused since CL 114799. Also remove consts _CTL_KERN and _KERN_OSRELEASE previously used by getDarwinVersion. Change-Id: I51b701e8effbe4dd4301b0e6d52e8885469032f4 Reviewed-on: https://go-review.googlesource.com/116955 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
hellozee authored
Removing the colon will make the "Usage" and "Command line flag syntax" in the docs, a header when interpreted by godoc. Fixes #25749 Change-Id: Ifc5572e171db1aaef9775b1d6c86091a8f2528fd GitHub-Last-Rev: 1b579734308cbcb96f17d945b9c7af70e259cb5b GitHub-Pull-Request: golang/go#25750 Reviewed-on: https://go-review.googlesource.com/116555Reviewed-by:
Rob Pike <r@golang.org>
-
212472270 authored
This function was added during the Go 1.11 dev cycle and isn't part of the API compatibility promise yet. In the previous implementation, NewGCMWithNonceAndTagSize was being used as a helper function for NewGCM, NewGCMWithTagSize, and NewGCMWithNonceSize. With the removal of Nonce size from the name and parameters, we needed to add an unexported helper function newGCMWithNonceAndTagSize. Fixes #24977 Change-Id: Ie70f2a192d0556c4f890deb62e68cff6bbbccd33 Reviewed-on: https://go-review.googlesource.com/116435Reviewed-by:
Filippo Valsorda <filippo@golang.org> Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 06 Jun, 2018 14 commits
-
-
David Chase authored
This line of the inlining tuning experiment https://go-review.googlesource.com/c/go/+/109918/1/src/cmd/compile/internal/gc/inl.go#347 was incorrectly rewritten in a later patch to use the call cost, not the panic cost, and thus the inlining of panic didn't occur when it should. I discovered this when I realized that tests should have failed, but didn't. Fix is to make the correct change, and also to modify the tests that this causes to fail. One test now asserts the new normal, the other calls "ppanic" instead which is designed to behave like panic but not be inlined. Change-Id: I423bb7f08bd66a70d999826dd9b87027abf34cdf Reviewed-on: https://go-review.googlesource.com/116656 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Keith Randall <khr@golang.org>
-
https://golang.org/cl/116735Robert Griesemer authored
Missed this in the prior submit. For #24182. Change-Id: If8349d39c80b7ff57bc0c857985f9e52241321b8 Reviewed-on: https://go-review.googlesource.com/116775 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
-
Robert Griesemer authored
Such errors are likely spurious and caused by previously reported errors; they don't add valuable information. Simply drop them. Fixes #24182. Change-Id: I0ac48c41647c628aa7636b29eaedfd9d01913762 Reviewed-on: https://go-review.googlesource.com/116735Reviewed-by:
Alan Donovan <adonovan@google.com>
-
Eugene Kalinin authored
Fixes #25330 Change-Id: I41b5b3459ed7808d18112ec02d734e2268099a81 Reviewed-on: https://go-review.googlesource.com/116596Reviewed-by:
Daniel Theophanes <kardianos@gmail.com>
-
Suriyaa Sundararuban authored
Change-Id: I77e31954f6d92f769934843bbba9f990f330f50a Reviewed-on: https://go-review.googlesource.com/116675Reviewed-by:
-
Tobias Klauser authored
SecKeychainItemExport is deprecated as of macOS 10.7. The minimum supported version is macOS 10.10, so use SecItemExport instead. While at it also bump macosx-version-min to 10.10 and __MAC_OS_X_VERSION_MAX_ALLOWED to 101300 (for macOS 10.13). Tested on macOS 10.10, 10.11 and 10.12. Updates #23122 Change-Id: Id4cd6a5cea93315791253dc248e40e5615760a6c Reviewed-on: https://go-review.googlesource.com/116396Reviewed-by:
-
Yury Smolsky authored
Every action has a short annotation. The errorCheck function has a comment adapted from errchk script. Removed redundant assigments to tmpDir. Change-Id: Ifdd1284de046a0ce2aad26bd8da8a8e6a7707a8e Reviewed-on: https://go-review.googlesource.com/115856 Run-TryBot: Yury Smolsky <yury@smolsky.by> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Richard Musiol authored
The wasm archtecture was missing a rule to handle OffPtr with a negative offset. This commit makes it so OffPtr always gets lowered to I64AddConst. Fixes #25741 Change-Id: I1d48e2954e3ff31deb8cba9a9bf0cab7c4bab71a Reviewed-on: https://go-review.googlesource.com/116595Reviewed-by:
Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com>
-
Ian Lance Taylor authored
Updates #25284 Change-Id: I8ca382dd85b428ad6899d9277cf7f3ce34e35e9a Reviewed-on: https://go-review.googlesource.com/116416 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Than McIntosh <thanm@google.com>
-
Brad Fitzpatrick authored
Also, add a benchmark variant ("SkipServe") that only benchmarks the ServeMux handler selection path. name old time/op new time/op delta ServeMux_SkipServe-4 74.2µs ± 2% 60.6µs ± 1% -18.31% (p=0.000 n=10+9) name old alloc/op new alloc/op delta ServeMux_SkipServe-4 2.62kB ± 0% 0.00kB ±NaN% -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ServeMux_SkipServe-4 180 ± 0% 0 ±NaN% -100.00% (p=0.000 n=10+10) Updates #25383 Change-Id: Icfbb3b977e309093d032e922d1b4f254df6f5955 Reviewed-on: https://go-review.googlesource.com/116378 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:Emmanuel Odeke <emm.odeke@gmail.com>
-
Dennis Kuhnert authored
When using test -cover or -coverprofile the output for "no test files" is the same format as for "no tests to run". Fixes #24570 Change-Id: If05609411676d42d94c1feac4bc839974fae2cc1 Reviewed-on: https://go-review.googlesource.com/115095 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Ian Lance Taylor <iant@golang.org>
-
Robert Griesemer authored
There is no benefit in continuing compilation if there are type-checking errors. This will increase robustness of the compiler in the presence of errors. Fixes #22909. Change-Id: I1c70c667e5927646ba3d0f370e33705165620f12 Reviewed-on: https://go-review.googlesource.com/116335Reviewed-by:
-
Filippo Valsorda authored
Change-Id: Ifc774bb9267baa773e91c617204329d3e04bd4b7 Reviewed-on: https://go-review.googlesource.com/116363Reviewed-by:
-
Filippo Valsorda authored
Change-Id: I10dededb41162a99dbc42792a9d314c6dabddcca Reviewed-on: https://go-review.googlesource.com/116362Reviewed-by:
-
- 05 Jun, 2018 9 commits
-
-
Robert Griesemer authored
Found while tracking down another issue. Change-Id: If06eee72ce3e3f45dc00b3b68670e1e4d99c87a7 Reviewed-on: https://go-review.googlesource.com/116455 Run-TryBot: Robert Griesemer <gri@golang.org> Reviewed-by:
-
Brad Fitzpatrick authored
Fixes #25019 Change-Id: I715e3bb560b2a0301240cecb09a5126ab04a666e Reviewed-on: https://go-review.googlesource.com/116375Reviewed-by:
-
Robert Griesemer authored
In the old binary export format, parameter names for parameter lists which contained only types where never written, so this problem didn't come up. Fixes #25101. Change-Id: Ia8b817f7f467570b05f88d584e86b6ef4acdccc6 Reviewed-on: https://go-review.googlesource.com/116376Reviewed-by:
Matthew Dempsky <mdempsky@google.com>
-
Ian Lance Taylor authored
gccgo fails this test before CL 115577. Updates #25284 Change-Id: Id4550b7b3e268f3c294420ed31c57ad3f1002b5e Reviewed-on: https://go-review.googlesource.com/115635 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
isharipo authored
For given program with 2 undefined relocations (main and undefined): package main func undefined() func defined() int { undefined() undefined() return 0 } var x = defined() "go tool link" produces these errors: main.defined: relocation target main.undefined not defined main.defined: relocation target main.undefined not defined runtime.main_main·f: relocation target main.main not defined main.defined: undefined: "main.undefined" main.defined: undefined: "main.undefined" runtime.main_main·f: undefined: "main.main" After this CL is applied: main.defined: relocation target main.undefined not defined runtime.main_main·f: function main is undeclared in the main package Fixes #10978 Improved error message for main proposed in #24809. Change-Id: I4ba8547b1e143bbebeb4d6e29ea05d932124f037 Reviewed-on: https://go-review.googlesource.com/113955 Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Eugene Kalinin authored
If an error occurs, delete the newly created directory. Change-Id: I97e960d24af32f027fb23d5ce3f61959e73f6fb0 Reviewed-on: https://go-review.googlesource.com/115715 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bill Zissimopoulos authored
Adds an extra M in mstartm0 and accounts for it in checkdead. This allows Windows callbacks created with syscall.NewCallback and syscall.NewCallbackCDecl to be called on a non-Go thread. Fixes #6751 Change-Id: I57626bc009a6370b9ca0827ab64b14b01dec39d4 GitHub-Last-Rev: d429e3eed923640edab580bdb47fcb81e75dbfe8 GitHub-Pull-Request: golang/go#25575 Reviewed-on: https://go-review.googlesource.com/114802Reviewed-by:
Alex Brainman <alex.brainman@gmail.com> Reviewed-by:
-
Robert Griesemer authored
Fixes #23094. Change-Id: I9aa36046488baa5f55cf2099e10cfb39ecd17b06 Reviewed-on: https://go-review.googlesource.com/116256 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Robert Griesemer authored
Fixes #18911. Change-Id: Ice10f37460a4f0a66cddeacfe26c28045f5e60fe Reviewed-on: https://go-review.googlesource.com/116255 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 04 Jun, 2018 11 commits
-
-
Rebecca Stambler authored
The existing implementation panics on malformed input of an empty string. strconv.Unquote validates the length of the inputs, but calling UnquoteChar directly with an empty string leads to a panic, so add a check for length. Also, add a test to go/constant to ensure that MakeFromLiteral does not panic on malformed input such as "const x = ''". Change-Id: I4217e38db48a09a21ec414bbfb3087709da62904 Reviewed-on: https://go-review.googlesource.com/116215 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Robert Griesemer <gri@golang.org>
-
Tobias Klauser authored
Updates #23122 Change-Id: Ia2c869a140c8ee01b5861897e4706389950d387e Reviewed-on: https://go-review.googlesource.com/116156 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by:
-
Ian Lance Taylor authored
If we run into data corruption due to the program accessing timers in a racy way, do a normal panic rather than a hard crash with "panic holding locks". The hope is to make the problem less confusing for users. Fixes #25686 Change-Id: I863417adf21f7f8c088675b67a3acf49a0cdef41 Reviewed-on: https://go-review.googlesource.com/115815Reviewed-by:
Austin Clements <austin@google.com>
-
Josh Bleecher Snyder authored
These were added in CL 106979. I got them wrong. They were fixed in CL 111643. They were still wrong. Hopefully this change will be the last fix. With this fix, CL 106979 is allocation-neutral for BenchmarkRagged. The performance results for BenchmarkPyramid reported in CL 111643 stand. Change-Id: Id6a522e6602e5df31f504adf5a3bec9969c18649 Reviewed-on: https://go-review.googlesource.com/116015 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Richard Musiol authored
This commit adds the js/wasm architecture to the net package. The net package is not supported by js/wasm, but a simple fake networking is available so tests of other packages that require basic TCP sockets can pass. The tests of the net package itself are mostly disabled. Updates #18892 Change-Id: Id287200c39f0a3e23d20ef17260ca15ccdcca032 Reviewed-on: https://go-review.googlesource.com/109995 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
cch123 authored
Change-Id: Ie8d563d39b88ab1631bc150d7d5bdbf1aa400f76 GitHub-Last-Rev: d092c8c8eb886fd9abad9bdaed7330a6cbd7f9a4 GitHub-Pull-Request: golang/go#25716 Reviewed-on: https://go-review.googlesource.com/116115Reviewed-by:
Daniel Martí <mvdan@mvdan.cc>
-
Bryan C. Mills authored
These were generated using the racebuild configuration from https://golang.org/cl/115375, with the LLVM compiler-rt repository at commit fe2c72c59aa7f4afa45e3f65a5d16a374b6cce26 for most platforms. The Windows build is from an older compiler-rt revision, because the compiler-rt build script for the Go race detector has been broken since January 2017 (https://reviews.llvm.org/D28596). Updates #24354. Change-Id: Ica05a5d0545de61172f52ab97e7f8f57fb73dbfd Reviewed-on: https://go-review.googlesource.com/112896Reviewed-by:
-
Wei Xiao authored
The SYS_EPOLL_WAIT syscall doesn't exist on arm64. This CL implements EpollWait with SYS_EPOLL_PWAIT syscall. Change-Id: Ica9107a58d7da45351fe2e900f59bec5b7b18f39 Reviewed-on: https://go-review.googlesource.com/115735 Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by:
-
Johan Brandhorst authored
The in-progress WASM port does not yet have sufficient automatic testing performed against it, so these errors slipped through when adding the new Fetch API backed http.Roundtripper. Updates #25506 Change-Id: I84c5832452e3e6067a02d926f67d01aaca66b837 GitHub-Last-Rev: 064062b5fd256e7fce961a13a8ac00a135f60221 GitHub-Pull-Request: golang/go#25714 Reviewed-on: https://go-review.googlesource.com/116076Reviewed-by:
-
Russ Cox authored
CL 109340 added “minimal module-awareness for legacy operation.” One part of that is reinterpreting imports inside code trees with go.mod files as using semantic import versioning, and converting them back to legacy import paths by stripping the major version element (for example, interpreting import "x.com/foo/v2/bar" as import "x.com/foo/bar"). This rewrite was not being applied during "go get", with the effect that once you had the target code downloaded already, everything was fine, but it didn't download and build successfully the first time. Fixes #25687. Change-Id: I3e122efdc8fd9a0a4e66f5aa3e6a99f90c7df779 Reviewed-on: https://go-review.googlesource.com/115797 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Iskander Sharipov authored
These tests were meant to be included into https://golang.org/cl/113315, but were lost somewhere in the middle. This CL adds hand-written AVX-512 tests that complement auto-generated test suite. It's worth including it, because: - It covers every new Z-case explicitly - Does checks every opcode suffix encoding Change-Id: Id6da5f58773e07bef3d532fc3ca5db391d380ebf Reviewed-on: https://go-review.googlesource.com/115858 Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
