An error occurred fetching the project authors.
  1. 13 Nov, 2015 1 commit
  2. 23 Sep, 2015 1 commit
    • Joe Tsai's avatar
      archive/tar: remove dead code with USTAR path splitting · d1b1487a
      Joe Tsai authored
      Convert splitUSTARPath to return a bool rather than an error since
      the caller never ever uses the error other than to check if it is
      nil. Thus, we can remove errNameTooLong as well.
      
      Also, fold the checking of the length <= fileNameSize and whether
      the string is ASCII into the split function itself.
      
      Lastly, remove logic to set the MAGIC since that's already done on
      L200. Thus, setting the magic is redundant.
      
      There is no overall logic change.
      
      Updates #12638
      
      Change-Id: I26b6992578199abad723c2a2af7f4fc078af9c17
      Reviewed-on: https://go-review.googlesource.com/14723Reviewed-by: default avatarDavid Symonds <dsymonds@golang.org>
      Run-TryBot: David Symonds <dsymonds@golang.org>
      d1b1487a
  3. 26 Jun, 2015 1 commit
  4. 04 May, 2015 1 commit
  5. 08 Sep, 2014 1 commit
  6. 17 Jul, 2014 1 commit
    • Cristian Staretu's avatar
      archive/tar: fix writing of pax headers · 7a9e7c0a
      Cristian Staretu authored
      "archive/tar: reuse temporary buffer in writeHeader" introduced a
      change which was supposed to help lower the number of allocations from
      512 bytes for every call to writeHeader. This change broke the writing
      of PAX headers.
      
      writeHeader calls writePAXHeader and writePAXHeader calls writeHeader
      again. writeHeader will end up writing the PAX header twice.
      
      example broken header:
      PaxHeaders.4007/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021512 xustar0000000000000000
      PaxHeaders.4007/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021512 xustar0000000000000000
      
      example correct header:
      PaxHeaders.4290/NetLock_Arany_=Class_Gold=_Ftanstvny.crt0000000000000000000000000000007112301216634021516 xustar0000000000000000
      0100644000000000000000000000270412301216634007250 0ustar0000000000000000
      
      This commit adds a dedicated buffer for pax headers to the Writer
      struct. This change increases the size of the struct by 512 bytes, but
      allows tar/writer to avoid allocating 512 bytes for all written
      headers and it avoids allocating 512 more bytes for pax headers.
      
      LGTM=dsymonds
      R=dsymonds, dave, iant
      CC=golang-codereviews
      https://golang.org/cl/110480043
      7a9e7c0a
  7. 14 May, 2014 1 commit
    • Guillaume J. Charmes's avatar
      archive/tar: Fix bug preventing untar · 51f3cbab
      Guillaume J. Charmes authored
      Do not use ustar format if we need the GNU one.
      Change \000 to \x00 for consistency
      Check for "ustar\x00" instead of "ustar\x00\x00" for conistency with tar
      and compatiblity with archive generated with older code (which was ustar\x00\x20\x00)
      Add test for long name + big file.
      
      LGTM=iant
      R=golang-codereviews, iant
      CC=golang-codereviews
      https://golang.org/cl/99050043
      51f3cbab
  8. 13 Feb, 2014 1 commit
  9. 06 Sep, 2013 1 commit
    • Marco Hennings's avatar
      archive/tar: fix a case where USTAR-split is not working correctly. · 4e998d71
      Marco Hennings authored
      For some long filenames the USTAR-split code does not work
      correctly. It is wrongly assumed that the path would not be too long,
      but it is.
      
      The user visible result was that a filename was split, but it still
      caused an error.
      
      The cause was a wrongly calculated nlen. In addition I noticed that
      at this place it is also seems necessary to check if the prefix will
      fit in the 155 chars available for the prefix.
      
      R=dsymonds, rsc
      CC=golang-dev
      https://golang.org/cl/13300046
      4e998d71
  10. 19 Aug, 2013 1 commit
    • Marco Hennings's avatar
      archive/tar: Fix support for long links and improve PAX support. · a07c95a5
      Marco Hennings authored
      The tar/archive code from golang has a problem with linknames with length >
      100. A pax header is added but the original header still written with a too
      long field length.
      
      As it is clear that pax support is incomplete I have added missing
      implementation parts.
      
      This commit contains code from the golang project in the folder tar/archiv.
      
      The following pax header records are now automatically written:
      
      - gname)
      - linkpath
      - path
      - uname
      
      The following fields can be written with PAX, but the default is to use the
      star binary extension.
      
      - gid  (value > 2097151)
      - size (value > 8589934591)
      - uid (value > 2097151)
      
      The string fields are written when the value is longer as the field or if the
      string contains a char that is not encodable as 7-bit ASCII value.
      
      The change was tested against a current ubuntu-cloud image tarball comparing
      the compressed result.
      
      + added some automated tests for the new functionality.
      
      Fixes #6056.
      
      R=dsymonds
      CC=golang-dev
      https://golang.org/cl/12561043
      a07c95a5
  11. 11 Feb, 2013 1 commit
    • Shane Hansen's avatar
      archive/tar: read/write extended pax/gnu tar archives · 10682799
      Shane Hansen authored
      Support reading pax archives and applying extended attributes
      like long names, subsecond mtime resolutions, etc. Default to
      writing pax archives for long file and link names.
      Support reading gnu archives using the ././@LongLink extended
      header for file name and link target.
      
      Fixes #3300
      
      R=dsymonds, dave, rogpeppe, remyoudompheng, chressie, rsc
      CC=golang-dev
      https://golang.org/cl/6700047
      10682799
  12. 12 Mar, 2012 1 commit
  13. 02 Dec, 2011 1 commit
  14. 30 Nov, 2011 1 commit
  15. 29 Aug, 2011 1 commit
  16. 26 Mar, 2011 1 commit
  17. 08 Dec, 2010 1 commit
  18. 02 Mar, 2010 1 commit
  19. 15 Dec, 2009 1 commit
    • Robert Griesemer's avatar
      1) Change default gofmt default settings for · 5a1d3323
      Robert Griesemer authored
                        parsing and printing to new syntax.
      
                        Use -oldparser to parse the old syntax,
                        use -oldprinter to print the old syntax.
      
                     2) Change default gofmt formatting settings
                        to use tabs for indentation only and to use
                        spaces for alignment. This will make the code
                        alignment insensitive to an editor's tabwidth.
      
                        Use -spaces=false to use tabs for alignment.
      
                     3) Manually changed src/exp/parser/parser_test.go
                        so that it doesn't try to parse the parser's
                        source files using the old syntax (they have
                        new syntax now).
      
                     4) gofmt -w src misc test/bench
      
      	       1st set of files.
      
      R=rsc
      CC=agl, golang-dev, iant, ken2, r
      https://golang.org/cl/180047
      5a1d3323
  20. 03 Dec, 2009 1 commit
  21. 20 Nov, 2009 1 commit
  22. 10 Nov, 2009 1 commit
  23. 09 Nov, 2009 1 commit
  24. 05 Nov, 2009 1 commit
  25. 05 Oct, 2009 1 commit
  26. 17 Sep, 2009 1 commit
  27. 16 Sep, 2009 1 commit
  28. 15 Sep, 2009 1 commit
    • Russ Cox's avatar
      more "declared and not used". · ca6a0fee
      Russ Cox authored
      the last round omitted := range and only
      checked 1 out of N vars in a multi-var :=
      
      R=r
      OCL=34624
      CL=34638
      ca6a0fee
  29. 12 Aug, 2009 1 commit
  30. 09 Jul, 2009 2 commits
    • David Symonds's avatar
      archive/tar cleanups: · 600d7828
      David Symonds authored
        - rename untar{,_test}.go to reader{,_test}.go.
        - fix up some comments.
        - improve test output if it fails.
      
      R=rsc
      APPROVED=rsc
      DELTA=821  (400 added, 392 deleted, 29 changed)
      OCL=31376
      CL=31378
      600d7828
    • David Symonds's avatar
      Basic POSIX-compatible tar writer. · d6d0a390
      David Symonds authored
      R=rsc
      APPROVED=rsc
      DELTA=456  (382 added, 66 deleted, 8 changed)
      OCL=31246
      CL=31372
      d6d0a390