1. 10 May, 2019 5 commits
    • Jay Conrod's avatar
      cmd/go: force -coverpkg main packages to be built as libraries · 3b8c8041
      Jay Conrod authored
      This fixes TestScript/cover_pkgall_multiple_mains, which started
      failing after CL 174657.
      
      When compiling main packages with coverage instrumentation
      (e.g., for -coverpkg all), we now pass -p with the full import path
      instead of '-p main'. This avoids link errors
      'duplicate symbol main.main (types 1 and 1)'.
      
      Fixes #31946
      
      Change-Id: Id147527b1dbdc14bb33ac133c30d50c250b4365c
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176558
      Run-TryBot: Jay Conrod <jayconrod@google.com>
      Reviewed-by: default avatarCherry Zhang <cherryyz@google.com>
      Reviewed-by: default avatarBryan C. Mills <bcmills@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      3b8c8041
    • Russ Cox's avatar
      runtime: fix windows-amd64-2012 build · ef4666ec
      Russ Cox authored
      I forgot that in Go assembly, x+16(SP) is not the same as 16(SP).
      The former is the virtual stack pointer (one word below FP on x86)
      while the latter is the actual stack pointer.
      
      Change-Id: Ibb7012bb97261949f5e1a0dc70869d9a6f50aa99
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176557
      Run-TryBot: Russ Cox <rsc@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      ef4666ec
    • Bryan C. Mills's avatar
      cmd/go/testdata/script: remove skips and clarify comments in mod_*_upgrade_pseudo tests · 1d1ff469
      Bryan C. Mills authored
      These tests were added in CL 174206.
      
      They required a 'git' binary and network access in an earlier draft,
      but now use the test-local module proxy instead, so no longer need to
      be skipped when those resources are not present.
      
      Updates #30634
      
      Change-Id: I5f36c6c776209a89bc45d133847df5052b55da59
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176537
      Run-TryBot: Bryan C. Mills <bcmills@google.com>
      Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      1d1ff469
    • Jay Conrod's avatar
      cmd/go: move two vcs test repos to vcs-test.golang.org · 2aa89719
      Jay Conrod authored
      Follow-up to CL 174061. This also fixes a break after GOSUMDB
      was introduced.
      
      Updates #31946
      Updates #31673
      Updates #31287
      Updates #27171
      
      Change-Id: I8e91e857f301b6b73cc90f2f2c68523412e22b46
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176417
      Run-TryBot: Jay Conrod <jayconrod@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      2aa89719
    • Josh Bleecher Snyder's avatar
      cmd/compile: re-use regalloc's []valState · 4ae31dc8
      Josh Bleecher Snyder authored
      Updates #27739: reduces package ssa's allocated space by 3.77%.
      
      maxrss is harder to measure, but using best-of-three-runs
      as reported by /usr/bin/time -l, I see ~2% reduction in maxrss.
      
      We still have a long way to go, though; the new maxrss is still 1.1gb.
      
      name        old alloc/op      new alloc/op      delta
      Template         38.8MB ± 0%       37.7MB ± 0%  -2.77%  (p=0.008 n=5+5)
      Unicode          28.2MB ± 0%       28.1MB ± 0%  -0.20%  (p=0.008 n=5+5)
      GoTypes           131MB ± 0%        127MB ± 0%  -2.94%  (p=0.008 n=5+5)
      Compiler          606MB ± 0%        587MB ± 0%  -3.21%  (p=0.008 n=5+5)
      SSA              2.14GB ± 0%       2.06GB ± 0%  -3.77%  (p=0.008 n=5+5)
      Flate            24.0MB ± 0%       23.3MB ± 0%  -3.00%  (p=0.008 n=5+5)
      GoParser         28.8MB ± 0%       28.1MB ± 0%  -2.61%  (p=0.008 n=5+5)
      Reflect          83.8MB ± 0%       81.5MB ± 0%  -2.71%  (p=0.008 n=5+5)
      Tar              36.4MB ± 0%       35.4MB ± 0%  -2.73%  (p=0.008 n=5+5)
      XML              47.9MB ± 0%       46.7MB ± 0%  -2.49%  (p=0.008 n=5+5)
      [Geo mean]       84.6MB            82.4MB       -2.65%
      
      name        old allocs/op     new allocs/op     delta
      Template           379k ± 0%         379k ± 0%  -0.05%  (p=0.008 n=5+5)
      Unicode            340k ± 0%         340k ± 0%    ~     (p=0.151 n=5+5)
      GoTypes           1.36M ± 0%        1.36M ± 0%  -0.06%  (p=0.008 n=5+5)
      Compiler          5.49M ± 0%        5.48M ± 0%  -0.03%  (p=0.008 n=5+5)
      SSA               17.5M ± 0%        17.5M ± 0%  -0.03%  (p=0.008 n=5+5)
      Flate              235k ± 0%         235k ± 0%  -0.04%  (p=0.008 n=5+5)
      GoParser           302k ± 0%         302k ± 0%  -0.04%  (p=0.008 n=5+5)
      Reflect            976k ± 0%         975k ± 0%  -0.10%  (p=0.008 n=5+5)
      Tar                352k ± 0%         352k ± 0%  -0.06%  (p=0.008 n=5+5)
      XML                436k ± 0%         436k ± 0%  -0.03%  (p=0.008 n=5+5)
      [Geo mean]         842k              841k       -0.04%
      
      Change-Id: I0ab6631b5a0bb6303c291dcb0367b586a4e584fb
      Reviewed-on: https://go-review.googlesource.com/c/go/+/176221
      Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      4ae31dc8
  2. 09 May, 2019 29 commits
  3. 08 May, 2019 6 commits