Commits · 3e79c958c4586d2bd70b0e5fd752c74565db6b30 · Kirill Smelkov / go

22 Jul, 2011 1 commit

exp/template: plain actions with declarations should produce no output. · 3e79c958

Rob Pike authored Jul 22, 2011

This is already the behavior for pipelines producing values for if, with, and range.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4808050

3e79c958

21 Jul, 2011 18 commits

exp/template: fix action variable declarations inside range · 47647b98
Roger Peppe authored Jul 22, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4807043
```
47647b98
big: minor comment adjustments · e109a2bb
Robert Griesemer authored Jul 21, 2011
```
R=mtj, r
CC=golang-dev
https://golang.org/cl/4814044
```
e109a2bb

big: refine printf formatting and optimize string conversion · 12c73615

Michael T. Jones authored Jul 21, 2011

Now handles standard precision specifications, standard interactions of
redundant specifications (such as precision and zero-fill), handles the
special case of precision specified but equal to zero, and generates the
output without recursive calls to format/printf to be clearer and faster.

R=gri, mtj, gri
CC=golang-dev
https://golang.org/cl/4703050

12c73615

http: fix chunking bug during content sniffing · 301d8a6d
Russ Cox authored Jul 21, 2011
```
R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/4807044
```
301d8a6d
gc: select functions are no longer special · 22853098
Russ Cox authored Jul 21, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/4794049
```
22853098

runtime: faster select · 6b2ec065

Dmitriy Vyukov authored Jul 21, 2011

Make selectsend() accept pointer to the element,
it makes it possible to make Scase fixed-size
and allocate/free Select, all Scase's and all SudoG at once.
As a consequence SudoG freelist die out.

benchmark                       old,ns/op  new,ns/op
BenchmarkSelectUncontended	     1080        558
BenchmarkSelectUncontended-2	      675        264
BenchmarkSelectUncontended-4	      459        205
BenchmarkSelectContended	     1086        560
BenchmarkSelectContended-2	     1775       1672
BenchmarkSelectContended-4	     2668       2149
(on Intel Q6600, 4 cores, 2.4GHz)

benchmark                       old ns/op    new ns/op    delta
BenchmarkSelectUncontended         517.00       326.00  -36.94%
BenchmarkSelectUncontended-2       281.00       166.00  -40.93%
BenchmarkSelectUncontended-4       250.00        83.10  -66.76%
BenchmarkSelectUncontended-8       107.00        47.40  -55.70%
BenchmarkSelectUncontended-16       67.80        41.30  -39.09%
BenchmarkSelectContended           513.00       325.00  -36.65%
BenchmarkSelectContended-2         699.00       628.00  -10.16%
BenchmarkSelectContended-4        1085.00      1092.00   +0.65%
BenchmarkSelectContended-8        3253.00      2477.00  -23.85%
BenchmarkSelectContended-16       5313.00      5116.00   -3.71%
(on Intel E5620, 8 HT cores, 2.4 GHz)

R=rsc, ken
CC=golang-dev
https://golang.org/cl/4811041

6b2ec065

undo CL 4808044 / 1bd754e69ce7 · 17d9093b

Russ Cox authored Jul 21, 2011

ServeMux depends on having a URL
in order to mux.  It might be that the right
fix is to have CONNECT handlers just not
look at URL.

««« original CL description
http: do not parse req.URL for CONNECT

CONNECT's argument is not a URL.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4808044

»»»

TBR=bradfitz
CC=golang-dev
https://golang.org/cl/4798046

17d9093b

http: do not parse req.URL for CONNECT · bf5ec12d

Yasuhiro Matsumoto authored Jul 21, 2011

CONNECT's argument is not a URL.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4808044

bf5ec12d

testing: output benchmark name before executing it · c3a86dab

Dmitriy Vyukov authored Jul 21, 2011

It makes it clear what benchmark is currently running.
Especially useful in case of hangup or crash.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4816043

c3a86dab

sync: improve Once fast path · d2ab2b9f

Dmitriy Vyukov authored Jul 21, 2011

Use atomic.LoadUint32(&done) instead of
atomic.AddInt32(&done, 0) on fast path.

benchmark            old ns/op    new ns/op    delta
BenchmarkOnce            13.40         7.26  -45.82%
BenchmarkOnce-2          22.90         4.04  -82.36%
BenchmarkOnce-4          25.60         2.16  -91.56%
BenchmarkOnce-8          25.80         1.38  -94.65%
BenchmarkOnce-16         24.40         1.33  -94.55%

(on HP Z600, 2 x Intel Xeon E5620, 8 HT cores, 2.4 GHz)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4787041

d2ab2b9f

runtime: replace centralized ncgocall counter with a distributed one · d6ed1b70
Dmitriy Vyukov authored Jul 21, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4809042
```
d6ed1b70

http: disable sniffer for now. · 6c46afdf

David Symonds authored Jul 21, 2011

Something is broken, and investigation is underway.
In the meantime, godoc is broken, so disable sniffing for now
by reverting to the pre-sniffer state.

R=r
CC=golang-dev
https://golang.org/cl/4809046

6c46afdf

ld: fix freebsd build reverting .interp move · 14eba969
Gustavo Niemeyer authored Jul 21, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4794046
```
14eba969

fmt: handle precision 0 format stings in standard way · 8cdee891

Michael T. Jones authored Jul 21, 2011

The C-stdlib heritage of printf/fprintf/sprintf has two odd
aspects for precisions of zero with integers. First, the zero
can be specified in any of these ways, "%4.0d", "%.0d" and
"%.d" which was not previously supported here. Secondly, the
seemingly universal interpretation of precision for integers
is that precision==0 and value==0 means print nothing at all.
The code here now handles this for integers just as the code
in big/int.c does the same for the Int type. New tests are
added to fmt_test.go to verify these changes.

R=r, r
CC=golang-dev
https://golang.org/cl/4717045

8cdee891

exp/template: A template can be in one set only. · 0f7a1951

Rob Pike authored Jul 21, 2011

This simplifies the API and makes it easier to make the template
invocation statically secure, at the cost of some minor flexibility.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/4794045

0f7a1951

html: sync html/testdata/webkit with upstream WebKit. · 5f134f9b

Nigel Tao authored Jul 21, 2011

As $GOROOT/src/pkg/html/testdata/webkit/README says, we're pulling from
$WEBKITROOT/LayoutTests/html5lib/resources.

R=r
CC=golang-dev
https://golang.org/cl/4810043

5f134f9b

html: parse misnested formatting tags according to the HTML5 spec. · 5a141064

Nigel Tao authored Jul 21, 2011

This is the "adoption agency" algorithm.

The test case input is "<a><p>X<a>Y</a>Z</p></a>". The correct parse is:
| <html>
|   <head>
|   <body>
|     <a>
|     <p>
|       <a>
|         "X"
|       <a>
|         "Y"
|       "Z"

R=gri
CC=golang-dev
https://golang.org/cl/4771042

5a141064

gob: send empty but non-nil maps. · d11c0f1d

Rob Pike authored Jul 21, 2011

Fixes #2082.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/4798042

d11c0f1d

20 Jul, 2011 16 commits

godoc: fix zip file directory lookup · 4c03bf9c

Robert Griesemer authored Jul 20, 2011

Also: remove left-over println calls.

R=bradfitz
CC=golang-dev
https://golang.org/cl/4807042

4c03bf9c

html: handle character entities without semicolons · 816c972f

Andrew Balholm authored Jul 21, 2011

Fix the TODO: unescape("&notit;") should be "¬it;"

Also accept digits in entity names.

R=nigeltao
CC=golang-dev, rsc
https://golang.org/cl/4781042

816c972f

http: sniffing algorithm. · 78c89d21

David Symonds authored Jul 21, 2011

This follows draft-ietf-websec-mime-sniff-03 in its intent,
though not its algorithmic specification.

R=rsc
CC=golang-dev
https://golang.org/cl/4746042

78c89d21

io/ioutil: improve performance of ioutil.Discard · 7911965f
Mike Solomon authored Jul 20, 2011
```
Fixes #2084.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4817041
```
7911965f
CONTRIBUTORS: add Mike Solomon (Google CLA) · 125419a2
Brad Fitzpatrick authored Jul 20, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4818041
```
125419a2
os: point readers at the exec package · bf768294
Brad Fitzpatrick authored Jul 20, 2011
```
R=golang-dev, evan, rsc
CC=golang-dev
https://golang.org/cl/4802046
```
bf768294

runtime: apply minor tweaks to channels · 102b5b34

Dmitriy Vyukov authored Jul 20, 2011

Remove complicated PRNG algorithm
(argument is limited by uint16 and can't be <= 1).
Do not require chansend/chanrecv selgen to be bumped with CAS.

R=rsc, ken
CC=golang-dev
https://golang.org/cl/4816041

102b5b34

runtime: improve performance of sync channels · 90f3cb13

Dmitriy Vyukov authored Jul 20, 2011

1. SudoG always contains a pointer to the element
(thus no variable size, and less copying).
2. chansend/chanrecv allocate SudoG on the stack.
3. Copying of elements and gorotuine notifications
are moved out of critical sections.

benchmark                        old ns/op    new ns/op    delta
BenchmarkSelectUncontended          515.00       514.00   -0.19%
BenchmarkSelectUncontended-2        291.00       281.00   -3.44%
BenchmarkSelectUncontended-4        213.00       189.00  -11.27%
BenchmarkSelectUncontended-8         78.30        79.00   +0.89%
BenchmarkSelectContended            518.00       514.00   -0.77%
BenchmarkSelectContended-2          655.00       631.00   -3.66%
BenchmarkSelectContended-4         1026.00      1051.00   +2.44%
BenchmarkSelectContended-8         2026.00      2128.00   +5.03%
BenchmarkSelectNonblock             175.00       173.00   -1.14%
BenchmarkSelectNonblock-2            85.10        87.70   +3.06%
BenchmarkSelectNonblock-4            60.10        43.30  -27.95%
BenchmarkSelectNonblock-8            37.60        25.50  -32.18%
BenchmarkChanUncontended            109.00       114.00   +4.59%
BenchmarkChanUncontended-2           54.60        57.20   +4.76%
BenchmarkChanUncontended-4           27.40        28.70   +4.74%
BenchmarkChanUncontended-8           14.60        15.10   +3.42%
BenchmarkChanContended              108.00       114.00   +5.56%
BenchmarkChanContended-2            621.00       617.00   -0.64%
BenchmarkChanContended-4            759.00       677.00  -10.80%
BenchmarkChanContended-8           1635.00      1517.00   -7.22%
BenchmarkChanSync                   299.00       256.00  -14.38%
BenchmarkChanSync-2                5055.00      4624.00   -8.53%
BenchmarkChanSync-4                4998.00      4680.00   -6.36%
BenchmarkChanSync-8                5019.00      4760.00   -5.16%
BenchmarkChanProdCons0              316.00       274.00  -13.29%
BenchmarkChanProdCons0-2           1280.00       617.00  -51.80%
BenchmarkChanProdCons0-4           2433.00      1332.00  -45.25%
BenchmarkChanProdCons0-8           3651.00      1934.00  -47.03%
BenchmarkChanProdCons10             153.00       152.00   -0.65%
BenchmarkChanProdCons10-2           626.00       581.00   -7.19%
BenchmarkChanProdCons10-4          1440.00      1323.00   -8.12%
BenchmarkChanProdCons10-8          2036.00      2017.00   -0.93%

R=rsc, ken
CC=golang-dev
https://golang.org/cl/4790042

90f3cb13

ld: remove overlap of ELF sections on dynamic binaries · ba2e3af1

Gustavo Niemeyer authored Jul 20, 2011

The dynamic ELF sections were pointing to the proper data,
but that data was already owned by the rodata and text sections.
Some ELF references explicitly prohibit multiple sections from
owning the same data, and strip behaves accordingly.

The data for these sections was moved out and their ranges are
now owned by their respective sections.  This change makes strip
happy both with and without -s being provided at link time.

A test was added in debug/elf to ensure there are no regressions
on this area in the future.

Fixes #1242.
Fixes #2022.

NOTE: Tested on Linux amd64/386/arm only.

R=rsc
CC=golang-dev
https://golang.org/cl/4808043

ba2e3af1

net/textproto: fix build · 971459e8
Russ Cox authored Jul 20, 2011
```
R=bradfitz
CC=golang-dev
https://golang.org/cl/4815041
```
971459e8
net/textproto: avoid 1 copy in ReadLine, ReadContinuedLine · 27a3dcd0
Russ Cox authored Jul 20, 2011
```
Fixes #2083.

R=msolo, bradfitz
CC=golang-dev
https://golang.org/cl/4812042
```
27a3dcd0
exp/norm: API for normalization library. · df07b6d1
Marcel van Lohuizen authored Jul 20, 2011
```
R=r, r, mpvl, rsc
CC=golang-dev
https://golang.org/cl/4678041
```
df07b6d1
gobuilder: goinstall with -dashboard=false instead of -log=false · dbba5ccf
Andrew Gerrand authored Jul 20, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4801043
```
dbba5ccf
tag weekly.2011-07-19 · 40462453
Andrew Gerrand authored Jul 20, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/4802043
```
40462453

weekly.2011-07-19 · 50ddb98b

Andrew Gerrand authored Jul 20, 2011

R=golang-dev, nigeltao, dsymonds, r
CC=golang-dev
https://golang.org/cl/4801042

50ddb98b

misc/dashboard: center align build results · 48d1240e
Andrew Gerrand authored Jul 20, 2011
```
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/4806041
```
48d1240e

19 Jul, 2011 5 commits

sync/atomic: delete workaround · 62f618a2

Rob Pike authored Jul 20, 2011

Load seems to work on arm now.

R=dsymonds
CC=golang-dev
https://golang.org/cl/4795042

62f618a2

godoc: implement http.FileSystem for zip files · 8930ce2d
Robert Griesemer authored Jul 19, 2011
```
R=rsc, adg, bradfitz
CC=golang-dev
https://golang.org/cl/4750047
```
8930ce2d

runtime: make goc2c build on Plan 9 · b546f507

Lucio De Re authored Jul 19, 2011

pkg/runtime/Makefile:
. Adjusted so "goc2c.c" is built using the Plan 9 libraries.

pkg/runtime/goc2c.c:
. Added/subtracted #include headers to correspond to Plan 9
  toolkit.
. Changed fprintf(stderr,...)/exit() combinations to
  sysfatal() calls, adjusted the "%u" format to "%ud".
. Added exits(0) at the end of main().
. Made main() a void-returning function and removed the
  "return 0" at the end of it.

Tested on UBUNTU and Plan 9 only.

R=r, rsc
CC=golang-dev
https://golang.org/cl/4626093

b546f507

runtime: faster entersyscall, exitsyscall · 025abd53

Russ Cox authored Jul 19, 2011

Uses atomic memory accesses to avoid the need to acquire
and release schedlock on fast paths.

benchmark                            old ns/op    new ns/op    delta
runtime_test.BenchmarkSyscall               73           31  -56.63%
runtime_test.BenchmarkSyscall-2            538           74  -86.23%
runtime_test.BenchmarkSyscall-3            508          103  -79.72%
runtime_test.BenchmarkSyscall-4            721           97  -86.52%
runtime_test.BenchmarkSyscallWork          920          873   -5.11%
runtime_test.BenchmarkSyscallWork-2        516          481   -6.78%
runtime_test.BenchmarkSyscallWork-3        550          343  -37.64%
runtime_test.BenchmarkSyscallWork-4        632          263  -58.39%

(Intel Core i7 L640 2.13 GHz-based Lenovo X201s)

Reduced a less artificial server benchmark
from 11.5r 12.0u 8.0s to 8.3r 9.1u 1.0s.

R=dvyukov, r, bradfitz, r, iant, iant
CC=golang-dev
https://golang.org/cl/4723042

025abd53

cgo: windows amd64 port · 9f636598
Wei Guangjing authored Jul 19, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4725041
```
9f636598