Commits · 465aba66c1080b44bc669dd60aa1dc29e01c4a6f · Kirill Smelkov / go

14 Dec, 2011 18 commits

strconv: even faster int conversion · 465aba66

Robert Griesemer authored Dec 14, 2011

benchmark                           old ns/op    new ns/op    delta
strconv_test.BenchmarkFormatInt         10038         8217  -18.14%
strconv_test.BenchmarkAppendInt          6822         4969  -27.16%
strconv_test.BenchmarkFormatUint         2811         1814  -35.47%
strconv_test.BenchmarkAppendUint         2349         1360  -42.10%

R=rsc
CC=golang-dev
https://golang.org/cl/5488083

465aba66

undo CL 5477092 / c3c6e72d7cc5 · 25e94154

Robert Griesemer authored Dec 14, 2011

The obvious fix is breaking the build in non-obvious ways.
Reverting while waiting for the correct fix, if any is needed.

««« original CL description
net/http: fix bug in error checking

Thanks to josef86@gmail.com for pointing this out.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5477092
»»»

R=iant
CC=golang-dev
https://golang.org/cl/5488085

25e94154

net/http: fix bug in error checking · c0421d92

Robert Griesemer authored Dec 14, 2011

Thanks to josef86@gmail.com for pointing this out.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5477092

c0421d92

gc: use inferred type rather than original one when reporting non-assignability. · e14d1d7e
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2451

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5372105
```
e14d1d7e
crypto/tls: make compatible with go/build · d842acd5
Russ Cox authored Dec 14, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5484073
```
d842acd5
hash/crc32: make compatible with go/build · 23cd4064
Russ Cox authored Dec 14, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5486060
```
23cd4064
go/build: make compatible with go/build · 576311d7
Russ Cox authored Dec 14, 2011
```
The irony!

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5482062
```
576311d7
gc: add forgotten typecheck in a lonely corner of sinit · 1f6d130b
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2549

R=rsc
CC=golang-dev
https://golang.org/cl/5484060
```
1f6d130b

gc: inlining (disabled without -l) · a62722bb

Luuk van Dijk authored Dec 14, 2011

Cross- and intra package inlining of single assignments or return <expression>.
Minus some hairy cases, currently including other calls, expressions with closures and ... arguments.

R=rsc, rogpeppe, adg, gri
CC=golang-dev
https://golang.org/cl/5400043

a62722bb

html: close <button> element before opening a new one · e25a83d0

Andrew Balholm authored Dec 14, 2011

Pass tests6.dat, test 13:
<button><button>

| <html>
|   <head>
|   <body>
|     <button>
|     <button>

Also pass tests through test 25:
<table><colgroup>foo

R=nigeltao
CC=golang-dev
https://golang.org/cl/5487072

e25a83d0

gc: Use %#F in error messages instead of %F. · 3c638f28
Luuk van Dijk authored Dec 14, 2011
```
Fixes #2520

R=rsc
CC=golang-dev
https://golang.org/cl/5482056
```
3c638f28
gc: suppress non-root cause message for bad receivers. · 6a401339
Luuk van Dijk authored Dec 14, 2011
```
Fixed issue 2500

R=rsc
CC=golang-dev
https://golang.org/cl/5485053
```
6a401339

undo CL 5485063 / 21595dc0395a · c8a5f884

Russ Cox authored Dec 14, 2011

breaks 64-bit build

««« original CL description
8c: handle 64-bit switch value
Cases must still be 32-bit values, but one thing at a time.

R=ality, ken2, ken
CC=golang-dev
https://golang.org/cl/5485063
»»»

R=ken2
CC=golang-dev
https://golang.org/cl/5488075

c8a5f884

runtime: bump gc 'extra bytes' check · 1e63a4e4

Christopher Wedgwood authored Dec 13, 2011

(needed for non-zero GOMAXPROCS)

R=iant, rsc
CC=go.peter.90, golang-dev
https://golang.org/cl/5486059

1e63a4e4

8c: handle 64-bit switch value · 6481e37d

Russ Cox authored Dec 14, 2011

Cases must still be 32-bit values, but one thing at a time.

R=ality, ken2, ken
CC=golang-dev
https://golang.org/cl/5485063

6481e37d

encoding/gob: better error messages when types mismatch · ba576b2b

Rob Pike authored Dec 13, 2011

The transmitter must encode an interface value if it is to be decoded
into an interface value, but it's a common and confusing error to
encode a concrete value and attempt to decode it into an interface,
particularly *interface{}. This CL attempts to explain things better.

Fixes #2367.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5485072

ba576b2b

exp/winfsnotify: fix build. · 1c50c32a
Yasuhiro Matsumoto authored Dec 14, 2011
```
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5483057
```
1c50c32a
spec: values of underlying type uintptr can be converted to unsafe.Pointer · 599c18fa
Robert Griesemer authored Dec 13, 2011
```
Not a language change, just stating the facts.

Fixes #1793.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5488071
```
599c18fa

13 Dec, 2011 22 commits

syscall: regenerate z-files for openbsd · 7b5ae29a
Joel Sing authored Dec 14, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5414053
```
7b5ae29a

runtime: Make gc_test test extra allocated space, not total space. · 26239417

Ian Lance Taylor authored Dec 13, 2011

Testing total space fails for gccgo when not using split
stacks, because then each goroutine has a large stack, and so
the total memory usage is large.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487068

26239417

bufio: make the minimum read buffer size 16 bytes. · 64776da4
Rob Pike authored Dec 13, 2011
```
R=gri, rsc
CC=golang-dev
https://golang.org/cl/5485067
```
64776da4

test/garbage: move to test/bench/garbage · 5fe96c64

Russ Cox authored Dec 13, 2011

(These are benchmarks for the garbage collector, not tests.)

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5484070

5fe96c64

fix build, sorry · 1161e117
Russ Cox authored Dec 13, 2011
```
TBR=r
CC=golang-dev
https://golang.org/cl/5488066
```
1161e117
strconv: some allocation tests · 39213c1f
Brad Fitzpatrick authored Dec 13, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5477084
```
39213c1f
test/bench: move to test/bench/shootout · bcbb2f93
Russ Cox authored Dec 13, 2011
```
R=golang-dev, r, gri, bradfitz
CC=golang-dev
https://golang.org/cl/5487067
```
bcbb2f93

contribute.html: do not fill in the reviewer field · b1175beb

Florian Weimer authored Dec 13, 2011

The golang-dev mailing list is added automatically.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5482060

b1175beb

A+C: Florian Weimer (individual CLA) · f4b430c9
Russ Cox authored Dec 13, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5486056
```
f4b430c9

math: delete non-Sqrt-based Hypot · 25728038

Russ Cox authored Dec 13, 2011

I was confused by the existence of two portable Hypot
routines in the tree when I cleaned things up, and I made
ARM use the wrong (imprecise) one.  Use the right one,
and delete the wrong one.

Fixes arm build.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5485065

25728038

undo CL 5414048 / f6b994f33cf4 · 2c6d3eaf

Russ Cox authored Dec 13, 2011

breaks build

««« original CL description
http: close connection after printing panic stack trace
In a testing situation, it's possible for a local http
server to panic and the test exit without the stack trace
ever being printed.
Fixes #2480.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5414048

»»»

R=bradfitz
CC=golang-dev
https://golang.org/cl/5482061

2c6d3eaf

go/printer, godoc: print comments in example code · 5fb7e5b4

Robert Griesemer authored Dec 13, 2011

- go/printer: support for printing CommentedNodes
- go/doc: collect comments from examples

Fixes #2429.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5482052

5fb7e5b4

gofmt: simplify flags · fe746335

Robert Griesemer authored Dec 13, 2011

-tabs replaces -tabindent
-spaces has been removed

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/5487066

fe746335

gofix: add googlecode module for rewriting Google Code imports · 0b0a6ec7
Andrew Gerrand authored Dec 14, 2011
```
goinstall: disallow googlecode.com import paths

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5421049
```
0b0a6ec7

http: close connection after printing panic stack trace · 51616805

Roger Peppe authored Dec 13, 2011

In a testing situation, it's possible for a local http
server to panic and the test exit without the stack trace
ever being printed.
Fixes #2480.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5414048

51616805

gofix: add fix httputil · 19d064f6
Yasuhiro Matsumoto authored Dec 13, 2011
```
R=r, rsc, adg
CC=golang-dev
https://golang.org/cl/5364056
```
19d064f6
codereview: fix path slash issue. · e62b4034
Yasuhiro Matsumoto authored Dec 13, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487057
```
e62b4034
archive/tar: (test) structure comparison not reflect.DeepEqual · 0e9ee93c
Christopher Wedgwood authored Dec 14, 2011
```
R=dsymonds
CC=golang-dev
https://golang.org/cl/5487064
```
0e9ee93c

math: regularize build · dd8dc6f0

Russ Cox authored Dec 13, 2011

This will be nicer to the automatic tools.
It requires a few more assembly stubs
but fewer Go files.

There are a few instances where it looks like
there are new blobs of code, but they are just
being copied out of deleted files.

There is no new code here.

Suppose you have a portable implementation for Sin
and a 386-specific assembly one.  The old way to
do this was to write three files

sin_decl.go
   func Sin(x float64) float64  // declaration only
sin_386.s
   assembly implementation

sin_port.go
   func Sin(x float64) float64 { ... }  // pure-Go impl

and then link in either sin_decl.go+sin_386.s or
just sin_port.go.  The Makefile actually did the magic
of linking in only the _port.go files for those without
assembly and only the _decl.go files for those with
assembly, or at least some of that magic.

The biggest problem with this, beyond being hard
to explain to the build system, is that once you do
explain it to the build system, godoc knows which
of sin_port.go or sin_decl.go are involved on a given
architecture, and it (correctly) ignores the other.
That means you have to put identical doc comments
in both files.

The new approach, which is more like what we did
in the later packages math/big and sync/atomic,
is to have

sin.go
   func Sin(x float64) float64  // decl only
   func sin(x float64) float64 {...}  // pure-Go impl

sin_386.s
   // assembly for Sin (ignores sin)
sin_amd64.s
   // assembly for Sin: jmp sin
sin_arm.s
   // assembly for Sin: jmp sin

Once we abandon Makefiles we can put all the assembly
stubs in one source file, so the number of files will
actually go down.

Chris asked whether the branches cost anything.
Given that they are branching to pure-Go implementations
that are not typically known for their speed, the single
direct branch is not going to be noticeable.  That is,
it's on the slow path.

An alternative would have been to preserve the old
"only write assembly files when there's an implementation"
and still have just one copy of the declaration of Sin
(and thus one doc comment) by doing:

sin.go
   func Sin(x float64) float64 { return sin(x) }

sin_decl.go
   func sin(x float64) float64 // declaration only
sin_386.s
   // assembly for sin

sin_port.go
   func sin(x float64) float64 { portable code }

In this version everyone would link in sin.go and
then either sin_decl.go+sin_386.s or sin_port.go.

This has an extra function call on all paths, including
the "fast path" to get to assembly, and it triples the
number of Go files involved compared to what I did
in this CL.  On the other hand you don't have to
write assembly stubs.  After starting down this path
I decided that the assembly stubs were the easier
approach.

As for generating the assembly stubs on the fly, much
of the goal here is to eliminate magic from the build
process, so that zero-configuration tools like goinstall
or the new go tool can handle this package.

R=golang-dev, r, cw, iant, r
CC=golang-dev
https://golang.org/cl/5488057

dd8dc6f0

cypto/ocsp: fix tests · 6f975fbb

Christopher Wedgwood authored Dec 13, 2011

Actually compare the result with expected not itself

R=agl, bradfitz
CC=golang-dev, rsc
https://golang.org/cl/5477079

6f975fbb

go: implement doc, fmt, fix, list, vet · 6e2c3ef4

Russ Cox authored Dec 13, 2011

This CL is concerned with the basic Package structure
and applies it to the (trivial) implementations of the
doc, fmt, fix, list, and vet commands.

The command as a whole is still very much a work in progress.
In particular, work making the error messages look nice
is deferred to a future CL.

R=golang-dev, adg, dsymonds, r
CC=golang-dev
https://golang.org/cl/5482048

6e2c3ef4

build: disable cgo on Windows/amd64 · 969b71d9

Russ Cox authored Dec 13, 2011

Apparently it is broken.  Disable so that dashboard
will let us see other breakages on Windows.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5477081

969b71d9