- 17 Jun, 2014 9 commits
-
-
Robert Griesemer authored
Fixes #8207. LGTM=gordon.klaus, bradfitz R=golang-codereviews, wandakkelly, gordon.klaus, bradfitz CC=golang-codereviews https://golang.org/cl/106010046
-
Keith Randall authored
The go:nosplit change wasn't the problem, reinstating. ««« original CL description undo CL 93380044 / 7f0999348917 Partial undo, just of go:nosplit annotation. Somehow it is breaking the windows builders. TBR=bradfitz ««« original CL description runtime: implement string ops in Go Also implement go:nosplit annotation. Not really needed for now, but we'll definitely need it for other conversions. benchmark old ns/op new ns/op delta BenchmarkRuneIterate 534 474 -11.24% BenchmarkRuneIterate2 535 470 -12.15% LGTM=bradfitz R=golang-codereviews, dave, bradfitz, minux CC=golang-codereviews https://golang.org/cl/93380044 »»» TBR=bradfitz CC=golang-codereviews https://golang.org/cl/105260044 »»» TBR=bradfitz R=bradfitz, golang-codereviews CC=golang-codereviews https://golang.org/cl/103490043
-
Keith Randall authored
TBR=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/105280045
-
Keith Randall authored
Fixes windows builds (hopefully). LGTM=bradfitz R=golang-codereviews, bradfitz, alex.brainman CC=golang-codereviews https://golang.org/cl/103470045
-
Keith Randall authored
Partial undo, just of go:nosplit annotation. Somehow it is breaking the windows builders. TBR=bradfitz ««« original CL description runtime: implement string ops in Go Also implement go:nosplit annotation. Not really needed for now, but we'll definitely need it for other conversions. benchmark old ns/op new ns/op delta BenchmarkRuneIterate 534 474 -11.24% BenchmarkRuneIterate2 535 470 -12.15% LGTM=bradfitz R=golang-codereviews, dave, bradfitz, minux CC=golang-codereviews https://golang.org/cl/93380044 »»» TBR=bradfitz CC=golang-codereviews https://golang.org/cl/105260044
-
Shenghou Ma authored
LGTM=bradfitz R=rsc, iant CC=golang-codereviews https://golang.org/cl/107160046
-
Keith Randall authored
Also implement go:nosplit annotation. Not really needed for now, but we'll definitely need it for other conversions. benchmark old ns/op new ns/op delta BenchmarkRuneIterate 534 474 -11.24% BenchmarkRuneIterate2 535 470 -12.15% LGTM=bradfitz R=golang-codereviews, dave, bradfitz, minux CC=golang-codereviews https://golang.org/cl/93380044
-
Keith Randall authored
BenchmarkCompareStringEqual 10.4 7.33 -29.52% BenchmarkCompareStringIdentical 3.99 3.67 -8.02% BenchmarkCompareStringSameLength 9.80 6.84 -30.20% BenchmarkCompareStringDifferentLength 1.09 0.95 -12.84% BenchmarkCompareStringBigUnaligned 75220 76071 +1.13% BenchmarkCompareStringBig 69843 74746 +7.02% LGTM=bradfitz, josharian R=golang-codereviews, bradfitz, josharian, dave, khr CC=golang-codereviews https://golang.org/cl/105280044
-
Rui Ueyama authored
We don't need to shift array elements to shuffle them. We just have to swap a selected element with 0th element. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/91750044
-
- 16 Jun, 2014 3 commits
-
-
Robert Griesemer authored
LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/108030044
-
Matthew Dempsky authored
LGTM=r R=golang-codereviews, bradfitz, r CC=golang-codereviews https://golang.org/cl/109020043
-
Rob Pike authored
Printf("%x", "abc") was "0x610x620x63"; is now "0x616263", which is surely better. Printf("% #x", "abc") is still "0x61 0x62 0x63". Fixes #8080. LGTM=bradfitz, gri R=golang-codereviews, bradfitz, gri CC=golang-codereviews https://golang.org/cl/106990043
-
- 14 Jun, 2014 3 commits
-
-
Alex Brainman authored
Fixes build. LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/105140047
-
Alan Shreve authored
Also added a test to verify os.Getppid() works across all platforms LGTM=alex.brainman R=golang-codereviews, alex.brainman, shreveal, iant CC=golang-codereviews https://golang.org/cl/102320044
-
Ian Lance Taylor authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/102410044
-
- 13 Jun, 2014 11 commits
-
-
Ian Lance Taylor authored
Reportedly in the Linux 3.16 kernel the VDSO will not have section headers or a normal symbol table. Too late for 1.3 but perhaps for 1.3.1, if there is one. Fixes #8197. LGTM=rsc R=golang-codereviews, mattn.jp, rsc CC=golang-codereviews https://golang.org/cl/101260044
-
Nigel Tao authored
algorithm. See https://golang.org/cl/105750045/ for an implementation of TIFF's LZW. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/102940043
-
Nigel Tao authored
bufio.Scanner.Scan returns whether the scan succeeded, not whether it is done, so the test was mistakenly breaking early. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/93670045
-
Andrew Gerrand authored
LGTM=minux R=golang-codereviews, minux CC=golang-codereviews https://golang.org/cl/102340044
-
Russ Cox authored
makes windows-amd64-race benchmarks slower ««« original CL description testing: make benchmarking faster Allow the number of benchmark iterations to grow faster for fast benchmarks, and don't round up twice. Using the default benchtime, this CL reduces wall clock time to run benchmarks: net/http 49s -> 37s (-24%) runtime 8m31s -> 5m55s (-30%) bytes 2m37s -> 1m29s (-43%) encoding/json 29s -> 21s (-27%) strings 1m16s -> 53s (-30%) LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://golang.org/cl/101970047 »»» TBR=josharian CC=golang-codereviews https://golang.org/cl/105950044
-
Andrew Gerrand authored
LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/101270043
-
Russ Cox authored
It appears that something about Go on Windows cannot handle the fault cause by a jump to address 0. The way Go represents and calls functions, this never happened at all, until CL 105140044. This CL changes the code added in CL 105140044 to make jump to 0 impossible once again. Fixes #8047. (again, on Windows) TBR=bradfitz R=golang-codereviews, dave CC=adg, golang-codereviews, iant, r https://golang.org/cl/105120044
-
Rob Pike authored
R=rsc CC=golang-codereviews https://golang.org/cl/105930043
-
Russ Cox authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/108950046
-
Russ Cox authored
CC=golang-codereviews https://golang.org/cl/103340046
-
Rob Pike authored
'u' is not micro, µ (U+00B5) is. LGTM=gri, bradfitz R=golang-codereviews, bradfitz, gri CC=golang-codereviews https://golang.org/cl/105030046
-
- 12 Jun, 2014 14 commits
-
-
Russ Cox authored
Rob asked for this change to make maintaining go1.4.txt easier. If you are not sure of a change, it is still okay to send for review. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/109880044
-
Russ Cox authored
jmpdefer modifies PC, SP, and LR, and not atomically, so walking past jmpdefer will often end up in a state where the three are not a consistent execution snapshot. This was causing warning messages a few frames later when the traceback realized it was confused, but given the right memory it could easily crash instead. Update #8153 LGTM=minux, iant R=golang-codereviews, minux, iant CC=golang-codereviews, r https://golang.org/cl/107970043
-
Russ Cox authored
Fixes #8047. LGTM=r, iant R=golang-codereviews, r, iant CC=dvyukov, golang-codereviews, khr https://golang.org/cl/105140044
-
Rob Pike authored
The test requires that timerproc runs, but busy loops and starves the scheduler so that, with high probability, timerproc doesn't run. Avoid the issue by expecting the test to succeed; if not, a major outside timeout will kill it and let us know. As you can see from the diffs, there have been several attempts to fix this with chicanery, but none has worked. Don't bother trying any more. Fixes #8136. LGTM=rsc R=rsc, josharian CC=golang-codereviews https://golang.org/cl/105140043
-
Brad Fitzpatrick authored
It should've been removed in https://golang.org/cl/9365044 Thanks to Jacek Masiulaniec for noticing. LGTM=ruiu R=ruiu CC=golang-codereviews https://golang.org/cl/109880043
-
Josh Bleecher Snyder authored
Allow the number of benchmark iterations to grow faster for fast benchmarks, and don't round up twice. Using the default benchtime, this CL reduces wall clock time to run benchmarks: net/http 49s -> 37s (-24%) runtime 8m31s -> 5m55s (-30%) bytes 2m37s -> 1m29s (-43%) encoding/json 29s -> 21s (-27%) strings 1m16s -> 53s (-30%) LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://golang.org/cl/101970047
-
Alan Donovan authored
Contains a link to /lib/godoc/analysis/help.html which is not yet live. LGTM=r R=r, adg CC=golang-codereviews https://golang.org/cl/88560044
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/105890044
-
Rui Ueyama authored
Optimize IP.String, IPMask.String and ParseIP. benchmark old ns/op new ns/op delta BenchmarkParseIP 2216 1849 -16.56% BenchmarkIPString 7828 2486 -68.24% BenchmarkIPMaskString 3872 659 -82.98% LGTM=mikioh.mikioh, dave, bradfitz R=golang-codereviews, mikioh.mikioh, dave, bradfitz CC=golang-codereviews https://golang.org/cl/95750043
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/104080043
-
Andrew Gerrand authored
Fixes #8168. TBR=bradfitz R=golang-codereviews CC=golang-codereviews https://golang.org/cl/107950043
-
Andrew Gerrand authored
TBR=bradfitz R=golang-codereviews CC=golang-codereviews https://golang.org/cl/104090044
-
Rui Ueyama authored
Call copy with as large buffer as possible to reduce the number of function calls. benchmark old ns/op new ns/op delta BenchmarkBytesRepeat 540 162 -70.00% BenchmarkStringsRepeat 563 177 -68.56% LGTM=josharian R=golang-codereviews, josharian, dave, dvyukov CC=golang-codereviews https://golang.org/cl/90550043
-
Rui Ueyama authored
Remove unnecessary blank line. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/105040045
-