1. 19 Sep, 2014 3 commits
    • Russ Cox's avatar
      runtime: show frames for exported runtime functions · 54245cba
      Russ Cox authored
      The current Windows build failure happens because by
      default runtime frames are excluded from stack traces.
      Apparently the Windows breakpoint path dies with an
      ordinary panic, while the Unix path dies with a throw.
      Breakpoint is a strange function and I don't mind that it's
      a little different on the two operating systems.
      
      The panic squelches runtime frames but the throw shows them,
      because throw is considered something that shouldn't have
      happened at all, so as much detail as possible is wanted.
      
      The runtime exclusion is meant to prevents printing too much noise
      about internal runtime details. But exported functions are
      not internal details, so show exported functions.
      If the program dies because you called runtime.Breakpoint,
      it's okay to see that frame.
      This makes the Breakpoint test show Breakpoint in the
      stack trace no matter how it is handled.
      
      Should fix Windows build.
      Tested on Unix by changing Breakpoint to fault instead
      of doing a breakpoint.
      
      TBR=brainman
      CC=golang-codereviews
      https://golang.org/cl/143300043
      54245cba
    • Ian Lance Taylor's avatar
      lib9, cmd/ld: fixes for cross-linking on a Windows host · 5a40b568
      Ian Lance Taylor authored
      This fixes a couple of problems that occur when the linker
      removes its temporary directory on Windows.  The linker only
      creates and removes a temporary directory when doing external
      linking.  Windows does not yet support external linking.
      Therefore, these problems are only seen when using a
      cross-compiler hosted on Windows.
      
      In lib9, FindFirstFileW returns just the file name, not the
      full path name.  Don't assume that we will find a slash.
      Changed the code to work either way just in case.
      
      In ld, Windows requires that files be closed before they are
      removed, so close the output file before we might try to
      remove it.
      
      Fixes #8723.
      
      LGTM=alex.brainman
      R=golang-codereviews, alex.brainman
      CC=golang-codereviews
      https://golang.org/cl/141690043
      5a40b568
    • Russ Cox's avatar
      os: skip TestRemoveAllRace on Windows · 84f9c42b
      Russ Cox authored
      It's just fundamentally incompatible with
      Windows' pickiness about removing things
      that are in use.
      
      TBR=brainman
      CC=golang-codereviews
      https://golang.org/cl/142270043
      84f9c42b
  2. 18 Sep, 2014 14 commits
  3. 17 Sep, 2014 13 commits
  4. 16 Sep, 2014 10 commits