1. 02 Nov, 2019 3 commits
  2. 01 Nov, 2019 13 commits
  3. 31 Oct, 2019 18 commits
  4. 30 Oct, 2019 6 commits
    • Ian Lance Taylor's avatar
      runtime: switch to using new timer code · 6becb033
      Ian Lance Taylor authored
      No big changes in the runtime package benchmarks.
      
      Changes in the time package benchmarks:
      
      name                      old time/op  new time/op  delta
      AfterFunc-12              1.57ms ± 1%  0.07ms ± 1%  -95.42%  (p=0.000 n=10+8)
      After-12                  1.63ms ± 3%  0.11ms ± 1%  -93.54%  (p=0.000 n=9+10)
      Stop-12                   78.3µs ± 3%  73.6µs ± 3%   -6.01%  (p=0.000 n=9+10)
      SimultaneousAfterFunc-12   138µs ± 1%   111µs ± 1%  -19.57%  (p=0.000 n=10+9)
      StartStop-12              28.7µs ± 1%  31.5µs ± 5%   +9.64%  (p=0.000 n=10+7)
      Reset-12                  6.78µs ± 1%  4.24µs ± 7%  -37.45%  (p=0.000 n=9+10)
      Sleep-12                   183µs ± 1%   125µs ± 1%  -31.67%  (p=0.000 n=10+9)
      Ticker-12                 5.40ms ± 2%  0.03ms ± 1%  -99.43%  (p=0.000 n=10+10)
      Sub-12                     114ns ± 1%   113ns ± 3%     ~     (p=0.069 n=9+10)
      Now-12                    37.2ns ± 1%  36.8ns ± 3%     ~     (p=0.287 n=8+8)
      NowUnixNano-12            38.1ns ± 2%  37.4ns ± 3%   -1.87%  (p=0.020 n=10+9)
      Format-12                  252ns ± 2%   195ns ± 3%  -22.61%  (p=0.000 n=9+10)
      FormatNow-12               234ns ± 1%   177ns ± 2%  -24.34%  (p=0.000 n=10+10)
      MarshalJSON-12             320ns ± 2%   250ns ± 0%  -21.94%  (p=0.000 n=8+8)
      MarshalText-12             320ns ± 2%   245ns ± 2%  -23.30%  (p=0.000 n=9+10)
      Parse-12                   206ns ± 2%   208ns ± 4%     ~     (p=0.084 n=10+10)
      ParseDuration-12          89.1ns ± 1%  86.6ns ± 3%   -2.78%  (p=0.000 n=10+10)
      Hour-12                   4.43ns ± 2%  4.46ns ± 1%     ~     (p=0.324 n=10+8)
      Second-12                 4.47ns ± 1%  4.40ns ± 3%     ~     (p=0.145 n=9+10)
      Year-12                   14.6ns ± 1%  14.7ns ± 2%     ~     (p=0.112 n=9+9)
      Day-12                    20.1ns ± 3%  20.2ns ± 1%     ~     (p=0.404 n=10+9)
      
      Updates #6239
      Updates #27707
      
      Change-Id: I51e25a90f941574f1a9cf83a22e84ac8c678537d
      Reviewed-on: https://go-review.googlesource.com/c/go/+/171883
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      Reviewed-by: default avatarMichael Knyszek <mknyszek@google.com>
      Reviewed-by: default avatarEmmanuel Odeke <emm.odeke@gmail.com>
      6becb033
    • Damien Neil's avatar
      testing: provide additional information when test funcs panic · 81a74b4e
      Damien Neil authored
      Flush the output log up to the root when a test panics. Prior to
      this change, only the current test's output log was flushed to its
      parent, resulting in no output when a subtest panics.
      
      For the following test function:
      
      	func Test(t *testing.T) {
      		for i, test := range []int{1, 0, 2} {
      			t.Run(fmt.Sprintf("%v/%v", i, test), func(t *testing.T) {
      				_ = 1 / test
      			})
      		}
      	}
      
      Output before this change:
      
      	panic: runtime error: integer divide by zero [recovered]
      		panic: runtime error: integer divide by zero
      	(stack trace follows)
      
      Output after this change:
      
      	--- FAIL: Test (0.00s)
      	    --- FAIL: Test/1/0 (0.00s)
      	panic: runtime error: integer divide by zero [recovered]
      	(stack trace follows)
      
      Fixes #32121
      
      Change-Id: Ifee07ccc005f0493a902190a8be734943123b6b7
      Reviewed-on: https://go-review.googlesource.com/c/go/+/179599
      Run-TryBot: Damien Neil <dneil@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      81a74b4e
    • Filippo Valsorda's avatar
      crypto/tls: improve error messages for invalid certificates and signatures · cd18da45
      Filippo Valsorda authored
      Also, fix the alert value sent when a signature by a client certificate
      is invalid in TLS 1.0-1.2.
      
      Fixes #35190
      
      Change-Id: I2ae1d5593dfd5ee2b4d979664aec74aab4a8a704
      Reviewed-on: https://go-review.googlesource.com/c/go/+/204157Reviewed-by: default avatarKatie Hockman <katie@golang.org>
      cd18da45
    • Sam Whited's avatar
      encoding/xml: fix token decoder on early EOF · a0593463
      Sam Whited authored
      The documentation for TokenReader suggests that implementations of the
      interface may return a token and io.EOF together, indicating that it is
      the last token in the stream. This is similar to io.Reader. However, if
      you wrap such a TokenReader in a Decoder it complained about the EOF.
      A test was added to ensure this behavior on Decoder's.
      
      Change-Id: I9083c91d9626180d3bcf5c069a017050f3c7c4a8
      Reviewed-on: https://go-review.googlesource.com/c/go/+/130556
      Run-TryBot: Sam Whited <sam@samwhited.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      a0593463
    • Ian Lance Taylor's avatar
      runtime: clear js idle timeout before new one and after event handler · cf6e6abc
      Ian Lance Taylor authored
      Updates #6239
      Updates #27707
      
      Change-Id: I0a62c1374db485dd830bf02e59625997d9247fc3
      Reviewed-on: https://go-review.googlesource.com/c/go/+/203890
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarBrad Fitzpatrick <bradfitz@golang.org>
      cf6e6abc
    • Clément Chigot's avatar
      runtime: fix nbpipe_test for AIX · cc4b824e
      Clément Chigot authored
      Fcntl can't be called using syscall.Syscall as it doesn't work on AIX.
      Moreover, fcntl isn't exported by syscall package.
      
      However, it can be accessed by exporting it from runtime package
      using export_aix_test.go.
      
      Change-Id: Ib6af66d9d7eacb9ca0525ebc4cd4c92951735f1a
      Reviewed-on: https://go-review.googlesource.com/c/go/+/204059
      Run-TryBot: Ian Lance Taylor <iant@golang.org>
      Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      cc4b824e