1. 14 Feb, 2012 17 commits
    • Russ Cox's avatar
      runtime: use startpanic so that only one thread handles an incoming SIGQUIT · 55a54691
      Russ Cox authored
      Typing ^\ delivers the SIGQUIT to all threads, it appears.
      
      R=golang-dev, r, iant
      CC=golang-dev
      https://golang.org/cl/5657044
      55a54691
    • Russ Cox's avatar
      runtime/debug: fix build · 0995aba9
      Russ Cox authored
      TBR=r
      CC=golang-dev
      https://golang.org/cl/5661053
      0995aba9
    • Brad Fitzpatrick's avatar
      net/http: don't spin on temporary accept failure · 913abfee
      Brad Fitzpatrick authored
      R=golang-dev, rsc
      CC=golang-dev
      https://golang.org/cl/5658049
      913abfee
    • Russ Cox's avatar
      build: fix windows build · 11f6f7af
      Russ Cox authored
      TBR=golang-dev
      CC=golang-dev
      https://golang.org/cl/5656051
      11f6f7af
    • Rob Pike's avatar
      testing: let runtime catch the panic. · bf283833
      Rob Pike authored
      It's not as pretty, but it deletes some irrelevant information from the
      printout and avoids a dependency.
      It also means the test binary will stop if a test panics. That's a feature,
      not a bug.
      Any output printed by the test appears before the panic traceback.
      
      before:
      
      --- FAIL: TestPanic (0.00 seconds)
              fmt_test.go:19: HI
              testing.go:257: runtime error: index out of range
                      /Users/r/go/src/pkg/testing/testing.go:257 (0x23998)
                              _func_003: t.Logf("%s\n%s", err, debug.Stack())
                      /Users/r/go/src/pkg/runtime/proc.c:1388 (0x10d2d)
                              panic: reflect·call(d->fn, d->args, d->siz);
                      /Users/r/go/src/pkg/runtime/runtime.c:128 (0x119b0)
                              panicstring: runtime·panic(err);
                      /Users/r/go/src/pkg/runtime/runtime.c:85 (0x11857)
                              panicindex: runtime·panicstring("index out of range");
                      /Users/r/go/src/pkg/fmt/fmt_test.go:21 (0x23d72)
                              TestPanic: a[10]=1
                      /Users/r/go/src/pkg/testing/testing.go:264 (0x21b75)
                              tRunner: test.F(t)
                      /Users/r/go/src/pkg/runtime/proc.c:258 (0xee9e)
                              goexit: runtime·goexit(void)
      FAIL
      
      after:
      
      --- FAIL: TestPanic (0.00 seconds)
              fmt_test.go:19: HI
      panic: runtime error: index out of range [recovered]
              panic: (*testing.T) (0xec3b0,0xf8400001c0)
      
      goroutine 2 [running]:
      testing._func_003(0x21f5fa8, 0x21f5100, 0x21f5fb8, 0x21f5e88)
              /Users/r/go/src/pkg/testing/testing.go:259 +0x108
      ----- stack segment boundary -----
      fmt_test.TestPanic(0xf8400001c0, 0x27603728)
              /Users/r/go/src/pkg/fmt/fmt_test.go:21 +0x6b
      testing.tRunner(0xf8400001c0, 0x18edb8, 0x0, 0x0)
              /Users/r/go/src/pkg/testing/testing.go:264 +0x6f
      created by testing.RunTests
              /Users/r/go/src/pkg/testing/testing.go:343 +0x76e
      
      goroutine 1 [chan receive]:
      testing.RunTests(0x2000, 0x18edb8, 0x2400000024, 0x100000001, 0x200000001, ...)
              /Users/r/go/src/pkg/testing/testing.go:344 +0x791
      testing.Main(0x2000, 0x18edb8, 0x2400000024, 0x188a58, 0x800000008, ...)
              /Users/r/go/src/pkg/testing/testing.go:275 +0x62
      main.main()
              /var/folders/++/+++Fn+++6+0++4RjPqRgNE++2Qk/-Tmp-/go-build743922747/fmt/_test/_testmain.go:129 +0x91
      exit status 2
      
      R=rsc, dsymonds
      CC=golang-dev
      https://golang.org/cl/5658048
      bf283833
    • Andrew Gerrand's avatar
      godoc: list examples in index · 5ab935f6
      Andrew Gerrand authored
      Fixes #2897.
      
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/5658047
      5ab935f6
    • Robert Griesemer's avatar
      go/parser: better error messages for missing commas · e3f11b3f
      Robert Griesemer authored
      Fixes #3008.
      
      R=rsc
      CC=golang-dev
      https://golang.org/cl/5660046
      e3f11b3f
    • Russ Cox's avatar
      build: set $PATH during make.bash · 982e6c44
      Russ Cox authored
      Should fix build breakage.
      
      TBR=golang-dev
      CC=golang-dev
      https://golang.org/cl/5656050
      982e6c44
    • Russ Cox's avatar
      cmd/dist: cross-compiling fixes · 7b848c69
      Russ Cox authored
      This CL makes it possible to run make.bash with
      GOOS and GOARCH set to something other than
      the native host GOOS and GOARCH.
      
      As part of the CL, the tool directory moves from bin/tool/
      to pkg/tool/goos_goarch where goos and goarch are
      the values for the host system (running the build), not
      the target.  pkg/ is not technically appropriate, but C objects
      are there now tool (pkg/obj/) so this puts all the generated
      binaries in one place (rm -rf $GOROOT/pkg cleans everything).
      Including goos_goarch in the name allows different systems
      to share a single $GOROOT on a shared file system.
      
      Fixes #2920.
      
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/5645093
      7b848c69
    • Russ Cox's avatar
      net/http: disable buggy test · 569ef7d4
      Russ Cox authored
      Generates an infinite stream (at least >1GB) of:
      
      === RUN TestTransportPersistConnLeak
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      2012/02/13 22:20:19 http: Accept error: accept tcp 127.0.0.1:63972:
      too many open files
      
      R=bradfitz
      CC=golang-dev
      https://golang.org/cl/5661052
      569ef7d4
    • Alex Brainman's avatar
      runtime, syscall, os/signal: fix windows build · 07a2989d
      Alex Brainman authored
      R=golang-dev, bradfitz
      CC=golang-dev
      https://golang.org/cl/5656048
      07a2989d
    • Mikio Hara's avatar
      syscall: update BSD variants to sync with new os/signal · adc1e0bc
      Mikio Hara authored
      R=golang-dev, adg
      CC=golang-dev
      https://golang.org/cl/5661051
      adc1e0bc
    • Brad Fitzpatrick's avatar
      net/http: fix client goroutine leak with persistent connections · d0a7d01f
      Brad Fitzpatrick authored
      Thanks to Sascha Matzke & Florian Weimer for diagnosing.
      
      R=golang-dev, adg, bradfitz, kevlar
      CC=golang-dev
      https://golang.org/cl/5656046
      d0a7d01f
    • Brad Fitzpatrick's avatar
      mime: unexport some internal details · 9df6fdcc
      Brad Fitzpatrick authored
      Fixes #2941
      
      R=golang-dev, rsc, adg
      CC=golang-dev
      https://golang.org/cl/5663046
      9df6fdcc
    • Nigel Tao's avatar
      cmd/api: fix typo. · e8d30eb4
      Nigel Tao authored
      R=gri, r
      CC=golang-dev
      https://golang.org/cl/5659048
      e8d30eb4
    • Shenghou Ma's avatar
      fix build for Linux/ARM. · 31ab16f9
      Shenghou Ma authored
              1, IMO, the fatal error "regfree: not a register" from 5g when
               compiling runtime/debug.go is due to gcc miscompile, it doesn't
               show up when compiled with -O0. But I still haven't thought of
               a way to fix this, should all ARM builds be built with -O0?
              2, fixed mksysnum_linux.pl, so zsysnum_linux_arm.go no longer
              needs to be hand-generated.
              3, regen all in pkg syscall for Linux/ARM on Debian 6.0
      This CL is somewhat big, I'd like to split it if necessary.
      
      R=rsc, dave
      CC=golang-dev
      https://golang.org/cl/5659044
      31ab16f9
    • Andrew Gerrand's avatar
      doc: color comments · 763716ae
      Andrew Gerrand authored
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/5657047
      763716ae
  2. 13 Feb, 2012 23 commits