1. 13 Dec, 2018 16 commits
  2. 12 Dec, 2018 21 commits
  3. 11 Dec, 2018 3 commits
    • Bryan C. Mills's avatar
      cmd/go: fix 'go test' and 'go fmt' with files outside a module · cee9dfc3
      Bryan C. Mills authored
      Use the actual loader result in findModule instead of making
      assumptions about nesting in the build list.
      As a side-effect, this produces much clearer error messages for
      packages that (for one reason or another) failed to load.
      
      Adjust the package and module path outside a module to
      "command-line-arguments". That string already appears in the output of
      a number of (module-mode and GOPATH-mode) commands for file arguments,
      and as far as I can tell operation outside a module is currently the
      only case in which the module path of a package is not actually a
      prefix of the import path.
      
      Fixes #28011
      Fixes #27099
      Fixes #28943
      Updates #27102
      Updates #28459
      Updates #27063
      
      Change-Id: I61d5556df7b1b7d1efdaffa892f0e3e95b612d87
      Reviewed-on: https://go-review.googlesource.com/c/153459
      Run-TryBot: Bryan C. Mills <bcmills@google.com>
      TryBot-Result: Gobot Gobot <gobot@golang.org>
      Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
      cee9dfc3
    • Bryan C. Mills's avatar
      cmd/go/internal/modfetch/codehost: return VCSError for unimplemented functions... · 353ebe72
      Bryan C. Mills authored
      cmd/go/internal/modfetch/codehost: return VCSError for unimplemented functions and malformed responses
      
      Updates #28943
      Updates #26092
      
      Change-Id: I07af2731ef5af046b9f7c7280ccb3976cdf41ca4
      Reviewed-on: https://go-review.googlesource.com/c/153458
      Run-TryBot: Bryan C. Mills <bcmills@google.com>
      Reviewed-by: default avatarJay Conrod <jayconrod@google.com>
      353ebe72
    • Keith Randall's avatar
      cmd/compile: use innermost line number for -S · 01a1eaa1
      Keith Randall authored
      When functions are inlined, for instructions in the inlined body, does
      -S print the location of the call, or the location of the body? Right
      now, we do the former. I'd like to do the latter by default, it makes
      much more sense when reading disassembly. With mid-stack inlining
      enabled in more cases, this quandry will come up more often.
      
      The original behavior is still available with -S=2. Some tests
      use this mode (so they can find assembly generated by a particular
      source line).
      
      This helped me with understanding what the compiler was doing
      while fixing #29007.
      
      Change-Id: Id14a3a41e1b18901e7c5e460aa4caf6d940ed064
      Reviewed-on: https://go-review.googlesource.com/c/153241Reviewed-by: default avatarDavid Chase <drchase@google.com>
      01a1eaa1