Commits · 5a0333764b1de9c46b2e7fec4cb31a8cadeedb0b · Kirill Smelkov / go

22 May, 2012 16 commits

net/http: improve TestServerExpect · 5a033376

Brad Fitzpatrick authored May 22, 2012

Fail more usefully, and Logf in one place instead of Errorf where
an error is acceptable.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6221059

5a033376

go/parser: fix comment grouping (day 1 bug) · f26d6173

Robert Griesemer authored May 22, 2012

Comment groups must end at the end of a line (or the
next non-comment token) if the group started on a line
with non-comment tokens.

This is important for correct computation of "lead"
and "line" comments (Doc and Comment fields in AST nodes).

Without this fix, the "line" comment for F1 in the
following example:

type T struct {
     F1 int // comment1
     // comment2
     F2 int
}

is "// comment1// comment2" rather than just "// comment1".

This bug was present from Day 1 but only visible when
looking at export-filtered ASTs where only comments
associated with AST nodes are printed, and only in rare
cases (e.g, in the case above, if F2 where not exported,
godoc would show "// comment2" anyway because it was
considered part of the "line" comment for F1).

The bug fix is very small (parser.go). The bulk of the
changes are additional test cases (parser_test.go).

The fix exposed a caching bug in go/printer via one of the
existing tests, hence the changes to printer.go.

As an aside, the fix removes the the need for empty lines
before an "// Output" comment for some special cases of
code examples (e.g.: src/pkg/strings/example_test.go, Count
example).

No impact on gofmt formatting of src, misc.

Fixes #3139.

R=rsc
CC=golang-dev
https://golang.org/cl/6209080

f26d6173

godoc: slightly smarter synopsis extraction · f596eb5d

Robert Griesemer authored May 22, 2012

Ignore synopses that start with
"Copyright", "All rights", and "Author".

R=rsc
CC=golang-dev
https://golang.org/cl/6218047

f596eb5d

go/scanner: strip carriage returns from commments · 7b9a6d8d

Robert Griesemer authored May 22, 2012

Also:
- cleaned up and simplified TestScan
- added tests for comments containing carriage returns

Fixes #3647.

R=rsc
CC=golang-dev
https://golang.org/cl/6225047

7b9a6d8d

net/url: better parsing of urls with @ symbol in authority · f7277dac
Alexey Borzenkov authored May 22, 2012
```
Fixes #3439

R=r, rsc, dsymonds, n13m3y3r
CC=golang-dev
https://golang.org/cl/6206090
```
f7277dac
cmd/6a: delete dead code · 6a22e2fb
Russ Cox authored May 22, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6223060
```
6a22e2fb

syscall: implement nametomib() on netbsd · 495a9dc2

Joel Sing authored May 23, 2012

Implement nametomib() on NetBSD using the CTL_QUERY node discovery
mechanism.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6211071

495a9dc2

crypto/x509: Add ECDSA support · 5c6162cd
Benjamin Black authored May 22, 2012
```
R=golang-dev, agl, rsc
CC=golang-dev
https://golang.org/cl/6208087
```
5c6162cd

crypto/ecdsa: add full set of NIST test vectors. · 5759c602

Adam Langley authored May 22, 2012

This includes the NIST test suite for ECDSA and alters the test to
parse and evaluate it.

R=golang-dev, bradfitz, rsc, b
CC=golang-dev
https://golang.org/cl/6219058

5759c602

crypto/ecdsa: fix case where p != 0 mod 8 and the hash length < p. · 477d7b16
Adam Langley authored May 22, 2012
```
I made a typo which breaks P-521.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6219057
```
477d7b16

exp/html: adjust inSelectIM to match spec · 8f66d7dc

Andrew Balholm authored May 22, 2012

Simplify the flow of control.

Handle EOF, null bytes, <html>, <input>, <keygen>, <textarea>, <script>.

Pass 5 more tests.

R=golang-dev, rsc, nigeltao
CC=golang-dev
https://golang.org/cl/6220062

8f66d7dc

cmd/8a, cmd/8l: add BSWAPL · c4ea1c95
Russ Cox authored May 22, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6208093
```
c4ea1c95
cmd/6a, cmd/6l: add BSWAPL, BSWAPQ · ed480128
Russ Cox authored May 22, 2012
```
R=ken2
CC=golang-dev
https://golang.org/cl/6209087
```
ed480128

runtime: relax TestGcSys · 85266dfd

Russ Cox authored May 22, 2012

This fixes occasional 64-bit failures.
Maybe it will fix the 32-bit failures too,
so re-enable on 32-bit for now.

R=golang-dev, bradfitz, r, dvyukov
CC=golang-dev
https://golang.org/cl/6218050

85266dfd

debug/elf: Expose entry point from Header in File struct. · 875f34fd
Matthew Horsnell authored May 21, 2012
```
Fixes #3470.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/6195074
```
875f34fd

exp/html: adjust inCellIM to match spec · 7648f61c

Andrew Balholm authored May 22, 2012

Clean up flow of control.

Ignore </table>, </tbody>, </tfoot>, </thead>, </tr> if there is not
an appropriate element in table scope.

Pass 3 more tests.

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/6206093

7648f61c

21 May, 2012 5 commits

crypto/rsa: add SHA-224 hash prefix · 053e4edd

Russ Cox authored May 21, 2012

http://www.rsa.com/rsalabs/node.asp?id=2125:

NOTE: A new OID has been defined for the combination
of the v1.5 signature scheme and the SHA-224 hash function:
        sha224WithRSAEncryption OBJECT IDENTIFIER ::=
Like the other sha*WithRSAEncryption OIDs in PKCS #1 v2.1,
this OID has NULL parameters.
The DigestInfo encoding for SHA-224 (see Section 9.2, Note 1) is:
        (0x)30 2d 30 0d 06 09 60 86 48 01 65 03 04 02 04 05 00 04 1c || H

R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/6208076

053e4edd

net/http: fix duplicate status code in Response.Write · d45f22e3
Brad Fitzpatrick authored May 21, 2012
```
Fixes #3636

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6203094
```
d45f22e3

net/http: add cookies from jar to POST request. · b4456df6

Volker Dobler authored May 21, 2012

The main content of this CL is a test case checking the reported
issue 3511 and a tiny fix for it.  A subsequent CL will refactor
the fix as proposed issue 3511.

Fixes #3511.

R=golang-dev, steven.hartland, bradfitz
CC=golang-dev
https://golang.org/cl/6013049

b4456df6

net/http: fix regression and mute known test failure for now · 30c0d231

Brad Fitzpatrick authored May 21, 2012

Two tests added in 820ffde8c are expected to fail until the fix
for Issue 3540 goes back in (pending Windows net fixes), so
make those tests just Logf for now, with a TODO to re-enable.

Add a new client test.

Rearrange the transport code to be more readable, and fix the
bug from 820ffde8c where the persistConn was being closed before
the body was fully ready.

Fixes #3644
Updates #1967 (not yet fixed, but should be after Issue 3540)

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6211069

30c0d231

cmd/6g: allow use of R14, R15 now · 8f8640a0

Russ Cox authored May 21, 2012

We stopped reserving them in 2009 or so.

R=ken
CC=golang-dev
https://golang.org/cl/6215061

8f8640a0

20 May, 2012 3 commits

net: reduce dial tests on netbsd · 40b31070

Joel Sing authored May 21, 2012

Add NetBSD to the list of operating systems that have a reduced set
of dial tests.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6208083

40b31070

syscall: fix SockaddrDatalink on netbsd · 67a0c4f7

Joel Sing authored May 21, 2012

RawSockaddrDatalink and SockaddrDatalink need to match - make Data
have length 12 for both.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6223051

67a0c4f7

exp/html: adjust inRowIM to match spec · 4973c1fc

Andrew Balholm authored May 20, 2012

Delete cases that just fall down to "anything else" action.

Handle </tbody>, </tfoot>, and </thead>.

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/6203061

4973c1fc

19 May, 2012 1 commit

net: fix leak in test · ba57c880

Mikio Hara authored May 19, 2012

Also change the Listner variable name from l to ln.

R=golang-dev, rsc, dave
CC=golang-dev
https://golang.org/cl/5918046

ba57c880

18 May, 2012 5 commits

syscall: add comment · 9cfb845a
Mikio Hara authored May 19, 2012
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6215046
```
9cfb845a

net/http: non-keepalive connections close successfully · ccd63c3c

James Gray authored May 18, 2012

Connections did not close if Request.Close or Response.Close was true. This meant that if the user wanted the connection to close, or if the server requested it via "Connection: close", the connection would not be closed.

Fixes #1967.

R=golang-dev, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6201044

ccd63c3c

A+C: add James Gray (Individual CLA) · 434625d1
Brad Fitzpatrick authored May 18, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6213055
```
434625d1
tls: add AES256 ciphers · 57557c0d
Benjamin Black authored May 18, 2012
```
R=golang-dev, rsc, agl
CC=golang-dev
https://golang.org/cl/6188061
```
57557c0d
A+C: b@b3k.us · 6f682de3
Adam Langley authored May 18, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6220050
```
6f682de3

17 May, 2012 8 commits

go/build: fix some comments · 54c9fe88
Maxim Pimenov authored May 17, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6217044
```
54c9fe88

exp/locale/collate: implementation of main collation functionality for · ec099b2b

Marcel van Lohuizen authored May 17, 2012

key and simple comparisson. Search is not yet implemented in this CL.
Changed some of the types of table_test.go to allow reuse in the new test.
Also reduced number of primary values for illegal runes to 1 (both map to
the same).

R=r
CC=golang-dev
https://golang.org/cl/6202062

ec099b2b

api: undo go1.txt additions made by 27d0a516b7eb · a2004546
Andrew Gerrand authored May 17, 2012
```
We don't change go1.txt.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6206080
```
a2004546
net: avoid the Mac firewall (again) · 1171dbdd
Russ Cox authored May 17, 2012
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6209072
```
1171dbdd

cmd/go: fix typo · 9815515d

Russ Cox authored May 17, 2012

Fixes #3619.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6211055

9815515d

encoding/xml: fix decoding of unknown entities in non-strict mode · fdc45367
Gustavo Niemeyer authored May 17, 2012
```
Fixes #3447.

R=rsc, gustavo
CC=golang-dev
https://golang.org/cl/6039045
```
fdc45367

encoding/xml: handle anonymous pointer fields · 9242a90a

Gustavo Niemeyer authored May 16, 2012

This CL makes

    type T struct { *U }

behave in a similar way to:

    type T struct { U }

Fixes #3108.

R=golang-dev, rsc, gustavo
CC=golang-dev
https://golang.org/cl/5694044

9242a90a

runtime: disable gc test on non-amd64 systems · 283a3dda
Andrew Gerrand authored May 17, 2012
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6210062
```
283a3dda

16 May, 2012 2 commits

pkg/runtime: Fix semasleep on Plan 9 · f5752848

Akshat Kumar authored May 16, 2012

With the timed semacquire patch
(kernel-tsemacquire) for Plan 9,
we can now properly do a timed
wait for the semaphore, in
semasleep.

R=golang-dev, rsc, rminnich, ality, r
CC=0intro, golang-dev, john, mirtchovski
https://golang.org/cl/6197046

f5752848

misc/chrome/gophertool: lower CL number's lower bound and fix input focus on Mac · 6dfe0162

Shenghou Ma authored May 17, 2012

As our CL number could be as small as 152046, changed CL number's lower bound
to 150000. Hopefully our issue count won't reach 150000 any time soon.
Chrome on Mac OS X has very strange behavior regarding the focus, although we
force the focus to the input box on load, the page still come up with focus on
"issue". Set the tabindex of the input box as a workaround.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6212055

6dfe0162