Commits · 631a575fd92b711854930f3b03b40a2bf66bbd29 · Kirill Smelkov / go

13 Nov, 2011 1 commit

html: store the current insertion mode in the parser · 631a575f

Andrew Balholm authored Nov 13, 2011

Currently, the state transition functions in the HTML parser
return the next insertion mode and whether the token is consumed.
This works well except for when one insertion mode needs to use
the rules for another insertion mode. Then the useTheRulesFor
function needs to patch things up. This requires comparing functions
for equality, which is going to stop working.

Adding a field to the parser structure to store the current
insertion mode eliminates the need for useTheRulesFor;
one insertion mode function can now just call the other
directly. The insertion mode will be changed only if it needs to be.

This CL is an alternative to CL 5372078.

R=nigeltao, rsc
CC=golang-dev
https://golang.org/cl/5372079

631a575f

12 Nov, 2011 5 commits

runtime: remove no longer used enums for openbsd · 13dc5305

Joel Sing authored Nov 13, 2011

The code that used these has been moved to lock_sema.c.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5376062

13dc5305

gc: look at cumulative error count, not just per-function. · 3208917d

Luuk van Dijk authored Nov 12, 2011

Not sure if this is what you'd really want.  Maybe with a higher limit than 10
or perhaps keep checking nerrors > 10 per yyerror, but check the cumulative
after each function?

R=rsc
CC=golang-dev
https://golang.org/cl/5376064

3208917d

godoc: document -templates flag · 9192548f
Robert Griesemer authored Nov 11, 2011
```
Fixes #2441.

R=r
CC=golang-dev
https://golang.org/cl/5376078
```
9192548f

html: handle end tags in strange places · 3df05124

Andrew Balholm authored Nov 12, 2011

Pass tests1.dat, test 111:
</strong></b></em></i></u></strike></s></blink></tt></pre></big></small></font></select></h1></h2></h3></h4></h5></h6></body></br></a></img></title></span></style></script></table></th></td></tr></frame></area></link></param></hr></input></col></base></meta></basefont></bgsound></embed></spacer></p></dd></dt></caption></colgroup></tbody></tfoot></thead></address></blockquote></center></dir></div></dl></fieldset></listing></menu></ol></ul></li></nobr></wbr></form></button></marquee></object></html></frameset></head></iframe></image></isindex></noembed></noframes></noscript></optgroup></option></plaintext></textarea>

| <html>
|   <head>
|   <body>
|     <br>
|     <p>

Also pass all the remaining tests in tests1.dat.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5372066

3df05124

godoc: fix remote search (use correct URL) · e8188c16

Robert Griesemer authored Nov 11, 2011

Also works now together with -html, as in:
godoc -html -q Sin
for an html result.

Fixes #2435.

R=iant
CC=golang-dev
https://golang.org/cl/5375074

e8188c16

11 Nov, 2011 16 commits

runtime: remove declarations of nonexistent functions · 3f2d787c
Ian Lance Taylor authored Nov 11, 2011
```
R=rsc, r
CC=golang-dev
https://golang.org/cl/5369089
```
3f2d787c

gofmt: leave nil nodes of the AST unchanged. · 2ba07986

Rémy Oudompheng authored Nov 11, 2011

Without this check, gofmt panics when trying to apply
the identity transformation on "item.field" expressions.
Fixes #2410.

R=rsc, gri
CC=golang-dev, remy
https://golang.org/cl/5376061

2ba07986

gc: remove m[k] = x, false · 5fc3771b
Russ Cox authored Nov 11, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5376076
```
5fc3771b

build: fix check for selinux's allow_execstack on Fedora 16 · 90c50700

Bobby Powers authored Nov 11, 2011

Fedora 16 mounts selinux at /sys/fs/selinux, instead of the
traditional /selinux.  Check both locations for the selinux
filesystem in make.bash

Fixes #2448.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5373077

90c50700

6a, 8a: allow $(-1) for consistency with $1, $(1), $-1. · 6d9c02ae
Russ Cox authored Nov 11, 2011
```
R=ken2
CC=golang-dev
https://golang.org/cl/5373074
```
6d9c02ae

env.bash: Check for presence of make/gmake · 351daf87

Scott Lawrence authored Nov 11, 2011

Without this, a missing gmake will result in bogus error "Did not find
Go environment variables".

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5369066

351daf87

net, io/ioutil: remove use of os.Time · a6c501e4

Anthony Martin authored Nov 11, 2011

I had to replace the single use of io/ioutil
in the time package with a bytes.Buffer since
there would've been a dependency cycle.

There are no other uses of os.Time.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5372054

a6c501e4

ld: fix .bss for ldpe. · 3199a6ca

Wei Guangjing authored Nov 11, 2011

Fixes #2409.

R=mattn.jp, rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/5334046

3199a6ca

exp/terminal: rename shell to terminal and add SetSize · 252ef18d

Adam Langley authored Nov 11, 2011

It was never really a shell, but the name carried
over from SSH's ServerShell.

Two small functional changes:

Add SetSize, which allows the size of the terminal
to be changed in response, say, to an SSH message.

Don't write the prompt if there's already something
on the current line.

R=rsc
CC=golang-dev
https://golang.org/cl/5376066

252ef18d

syscall: fix zerrors for openbsd 386 · 791aef18
Joel Sing authored Nov 12, 2011
```
R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5369076
```
791aef18

exp/terminal: rename terminal.go to util.go · d08f57e6

Adam Langley authored Nov 11, 2011

(This is part of removing the duplicate code between exp/terminal and
exp/ssh, but hg is having a very hard time keeping up so I'm doing it
in small steps.)

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5373061

d08f57e6

syscall: regenerate z-files for freebsd, openbsd · ca4708fa
Mikio Hara authored Nov 12, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5375057
```
ca4708fa

html: ignore <col> tag outside tables · 0a61c846

Andrew Balholm authored Nov 11, 2011

Pass tests1.dat, test 109:
<table><col><tbody><col><tr><col><td><col></table><col>

| <html>
|   <head>
|   <body>
|     <table>
|       <colgroup>
|         <col>
|       <tbody>
|       <colgroup>
|         <col>
|       <tbody>
|         <tr>
|       <colgroup>
|         <col>
|       <tbody>
|         <tr>
|           <td>
|       <colgroup>
|         <col>

Also pass test 110:
<table><colgroup><tbody><colgroup><tr><colgroup><td><colgroup></table><colgroup>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5369069

0a61c846

html: parse column groups · 83f61a27

Andrew Balholm authored Nov 11, 2011

Pass tests1.dat, test 108:
<table><colgroup><col><colgroup><col><col><col><colgroup><col><col><thead><tr><td></table>

| <html>
|   <head>
|   <body>
|     <table>
|       <colgroup>
|         <col>
|       <colgroup>
|         <col>
|         <col>
|         <col>
|       <colgroup>
|         <col>
|         <col>
|       <thead>
|         <tr>
|           <td>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5369061

83f61a27

runtime, syscall: convert from godefs to cgo · dd2abe51
Russ Cox authored Nov 10, 2011
```
R=golang-dev, mikioh.mikioh, r
CC=golang-dev
https://golang.org/cl/5348052
```
dd2abe51

godefs: delete, replaced by cgo -godefs · 879a1c6a

Russ Cox authored Nov 10, 2011

Godefs was a C program that ran gcc and then parsed the
stabs debugging information in the resulting object file to
generate C or Go code for bootstrapping as part of
package runtime or package syscall.

Cgo does the same work, but using the dwarf debugging
information.  Add -godefs and -cdefs options to cgo that
mimic godefs's output, albeit with different input
(a Go program, not a C program).

This has been a "nice to have" for a while but was forced
by Apple removing stabs debugging output from their
latest compilers.

Fixes #835.
Fixes #2338.

R=golang-dev, bradfitz, r, dave, iant
CC=golang-dev
https://golang.org/cl/5367043

879a1c6a

10 Nov, 2011 8 commits

tutorial: describe unidirectional channels · a50ee009
Rob Pike authored Nov 10, 2011
```
R=golang-dev, adg, gri
CC=golang-dev
https://golang.org/cl/5370058
```
a50ee009

time: add ISOWeek method to Time · d9897096

Volker Dobler authored Nov 10, 2011

As the ISO 8601 week number is untrivial to compute a new method
on *Time provides year and number of week.

R=golang-dev, rsc, r, r
CC=golang-dev
https://golang.org/cl/5316074

d9897096

testing: add file:line stamps to messages. · 2c39ca08

Rob Pike authored Nov 10, 2011

A single-line error looks like this:
--- FAIL: foo_test.TestFoo (0.00 seconds)
        foo_test.go:123: Foo(8) = "10" want "100"

A multi-line error looks like this:
--- FAIL: foo_test.TestFoo (0.00 seconds)
        foo_test.go:456: Foo(88) = "100"
                want "1000"

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5376057

2c39ca08

runtime: fix semasleep() duration for openbsd · 85b74192

Joel Sing authored Nov 10, 2011

The timespec passed to thrsleep() needs to be an absolute/realtime
value, so add the current nanotime to ns.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5374048

85b74192

math/big: Correcting typo in SetBit() documentation · 120f3b7b
David G. Andersen authored Nov 10, 2011
```
z is set to x+bit change, not z+bit change

R=golang-dev
CC=golang-dev
https://golang.org/cl/5374056
```
120f3b7b

html: parse framesets · e9e874b7

Andrew Balholm authored Nov 10, 2011

Pass tests1.dat, test 106:
<frameset><frame><frameset><frame></frameset><noframes></noframes></frameset>

| <html>
|   <head>
|   <frameset>
|     <frame>
|     <frameset>
|       <frame>
|     <noframes>

Also pass test 107:
<h1><table><td><h3></table><h3></h1>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5373050

e9e874b7

runtime: fix freebsd build · be802560
Mikio Hara authored Nov 10, 2011
```
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5370050
```
be802560
effective_go: a little more about comma ok and type assertion · bb661645
Rob Pike authored Nov 09, 2011
```
Fixes #2416.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5370049
```
bb661645

09 Nov, 2011 10 commits

misc/windows: Go for Windows installer in MSI format · e4eacf39

Joe Poirier authored Nov 09, 2011

Requesting suggestions for the comment and description strings in installer.wxs.
Fixes #2394.

R=rsc, alex.brainman, tjyang2001
CC=golang-dev
https://golang.org/cl/5339046

e4eacf39

effective_go: fix up the description of cipher blocks and streams · a9aef26a
Rob Pike authored Nov 09, 2011
```
R=golang-dev, r, agl, dsymonds
CC=golang-dev
https://golang.org/cl/5374046
```
a9aef26a
crypto: update incorrect references to Cipher interface; should be Block. · 217408ab
Rob Pike authored Nov 09, 2011
```
R=gri, rsc, r
CC=golang-dev
https://golang.org/cl/5372050
```
217408ab
os/exec: Fix documentation references to os.DevNull · 6c10aa19
Scott Lawrence authored Nov 09, 2011
```
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5372049
```
6c10aa19
FAQ: rearrange and expand the discussion of testing · f6615f1b
Rob Pike authored Nov 09, 2011
```
R=gri, r, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5369052
```
f6615f1b

html: don't emit text token for empty raw text elements. · ddc5ec64

Andrew Balholm authored Nov 10, 2011

Pass tests1.dat, test 99:
<script></script></div><title></title><p><p>

| <html>
|   <head>
|     <script>
|     <title>
|   <body>
|     <p>
|     <p>

Also pass tests through test 105:
<ul><li><ul></li><li>a</li></ul></li></ul>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5373043

ddc5ec64

cgo: print error instead of panic on undeclared enums/structs · 23ffbe61

Rémy Oudompheng authored Nov 09, 2011

Types are left as nil if no DWARF information is found and
checking in the rewriting pass so that appropriate errors
with line numbers can be printed.
Fixes #2408.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/5336041

23ffbe61

6l: add MOVQ xmm_reg, xmm_reg · 17105870

Michał Derkacz authored Nov 09, 2011

Added handler for:
        MOVQ xmm_reg, xmm_reg/mem64
        MOVQ xmm_reg/mem64, xmm_reg
using native MOVQ (it take precedence above REX.W MOVD)
I don't understood 6l code enough to be sure that my small changes
didn't broke it. But now 6l works with MOVQ xmm_reg, xmm_reg and
all.bash reports "0 unexpected bugs".

There is test assembly source:
MOVQ    X0, X1
MOVQ    AX, X1
MOVQ    X1, AX
MOVQ    xxx+8(FP), X2
MOVQ    X2, xxx+8(FP)

and generated code (gdb disassemble /r):

0x000000000040f112 <+0>:   f3 0f 7e c8        movq  %xmm0,%xmm1
0x000000000040f116 <+4>:   66 48 0f 6e c8     movq  %rax,%xmm1
0x000000000040f11b <+9>:   66 48 0f 7e c8     movq  %xmm1,%rax
0x000000000040f120 <+14>:  f3 0f 7e 54 24 10  movq  0x10(%rsp),%xmm2
0x000000000040f126 <+20>:  66 0f d6 54 24 10  movq  %xmm2,0x10(%rsp)

Fixes #2418.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5316076

17105870

6l: Fixes opcode for PSLLQ imm8, xmm_reg · c8a2be8c
Michał Derkacz authored Nov 09, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5340056
```
c8a2be8c
A+C: Michał Derkacz (individual CLA) · 7be2a7d9
Russ Cox authored Nov 09, 2011
```
R=golang-dev
CC=golang-dev
https://golang.org/cl/5375046
```
7be2a7d9