Commits · 63f0aac58681efdb864a7bc6988cfb835734a278 · Kirill Smelkov / go

17 Dec, 2015 40 commits

Shenghou Ma authored Dec 17, 2015

Change-Id: Ie8ec4cfc68abef51e52090a75245f96af874c74a
Reviewed-on: https://go-review.googlesource.com/18000Reviewed-by: Ian Lance Taylor <iant@golang.org>

63f0aac5

go/types: add link to tutorial · a7501495

Alan Donovan authored Dec 17, 2015

Change-Id: Ic4f4bc7ea7478908716b951815280e394c55310b
Reviewed-on: https://go-review.googlesource.com/17975Reviewed-by: Robert Griesemer <gri@golang.org>

a7501495

api: create go1.6.txt · 8db371b3

Brad Fitzpatrick authored Dec 17, 2015

Change-Id: If2b30ab412d6799c8be01eb007462d6b58660ece
Reviewed-on: https://go-review.googlesource.com/18014Reviewed-by: Chris Broadfoot <cbro@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

8db371b3

src: remove reference to since-deleted dist -s flag · 4577cfcb

Brad Fitzpatrick authored Dec 17, 2015

(Found while debugging release problems with go1.6beta1)

Updates #12002

Change-Id: Iec197a754205e7fd28be154f27f17f3315886364
Reviewed-on: https://go-review.googlesource.com/18011Reviewed-by: Chris Broadfoot <cbro@golang.org>

4577cfcb

doc: change go1.6 http heading · 41af93f6

Brad Fitzpatrick authored Dec 17, 2015

Change-Id: Iae05082530891175e9c86da244e610bc92759561
Reviewed-on: https://go-review.googlesource.com/17918Reviewed-by: Chris Broadfoot <cbro@golang.org>

41af93f6

doc: Americanise spelling of wilful · a12ba4b8

Brad Fitzpatrick authored Dec 17, 2015

Fixes #13660

Change-Id: I05bcb4efcb865192a1ef6756e9dccef83505934c
Reviewed-on: https://go-review.googlesource.com/17990Reviewed-by: Chris Broadfoot <cbro@golang.org>

a12ba4b8

net/http: document ResponseWriter and Handler more; add test · c70df74a

Brad Fitzpatrick authored Dec 17, 2015

Update docs on ResponseWriter and Handler around concurrency.

Also add a test.

The Handler docs were old and used "object" a lot. It was also too
ServeMux-centric.

Fixes #13050
Updates #13659 (new issue found in http2 while writing the test)

Change-Id: I25f53d5fa54f1c9d579d3d0f191bf3d94b1a251b
Reviewed-on: https://go-review.googlesource.com/17982Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

c70df74a

cmd/link: reject non-package main toplevel.a file, remove dead code · c7b1ef99

Russ Cox authored Dec 17, 2015

The test for non-package main top-level inputs is done while parsing
the export data. Issue #13468 happened because we were not parsing
the export data when using compiler-generated archives
(that is, when using go tool compile -pack).

Fix this by parsing the export data even for archives.

However, that turns up a different problem: the export data check
reports (one assumes spurious) skew errors now, because it has
not been run since Go 1.2.
(Go 1.3 was the first release to use go tool compile -pack.)

Since the code hasn't run since Go 1.2, it can't be that important.
Since it doesn't work today, just delete it.

Figuring out how to make this code work with Robert's export
format was one of the largest remaining TODOs for that format.
Now we don't have to.

Fixes #13468 and makes the world a better place.

Change-Id: I40a4b284cf140d49d48b714bd80762d6889acdb9
Reviewed-on: https://go-review.googlesource.com/17976Reviewed-by: Robert Griesemer <gri@golang.org>

c7b1ef99

cmd/go: for go get -insecure, do not fall back to HTTP for non-200 responses · 2f08bd96

Russ Cox authored Dec 17, 2015

Since we allow non-200 responses from HTTPS in normal operation,
it seems odd to reject them in -insecure operation.

Fixes #13037 (again).

Change-Id: Ie232f7544ab192addfad407525888db6b967befe
Reviewed-on: https://go-review.googlesource.com/17945Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

2f08bd96

cmd/go: fix processing of HTTPS 404 without -insecure · a227351b

Russ Cox authored Dec 17, 2015

The change here is to move the closeBody call into the if block.
The logging adjustments are just arranging to tell the truth:
in particular if we're not in insecure mode and we get a non-200
error then we do not actually ignore the response
(except as caused by closing the body incorrectly).

As the comment below the change indicates, it is intentional that
we process non-200 pages. The code does process them, because
the if err != nil || status != 200 block does not return.
But that block does close the body, which depending on timing
can apparently poison the later read from the body.

See #13037's initial report:

	$ go get -v bosun.org/cmd/bosun/cache
	Fetching https://bosun.org/cmd/bosun/cache?go-get=1
	ignoring https fetch with status code 404
	Parsing meta tags from https://bosun.org/cmd/bosun/cache?go-get=1 (status code 404)
	import "bosun.org/cmd/bosun/cache": parsing bosun.org/cmd/bosun/cache: http: read on closed response body
	package bosun.org/cmd/bosun/cache: unrecognized import path "bosun.org/cmd/bosun/cache"

The log print about ignoring the https fetch is not strictly true,
since the next thing that happened was parsing the body of that fetch.
But the read on the closed response body failed during parsing.

Moving the closeBody to happen only when we're about to discard the
result and start over (that is, only in -insecure mode) fixes the parse.

At least it should fix the parse. I can't seem to break the parse anymore,
because of #13648 (close not barring future reads anymore),
but this way is clearly better than the old way. If nothing else the old code
closed the body twice when err != nil and -insecure was not given.

Fixes #13037.

Change-Id: Idf57eceb6d5518341a2f7f75eb8f8ab27ed4e0b4
Reviewed-on: https://go-review.googlesource.com/17944Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

a227351b

Revert "cmd/go: allow omitted user name in git ssh repo syntax" · 9f0055a2

Russ Cox authored Dec 17, 2015

This caused #13657.
Reverting fixes #13657.

I was trying to be helpful by fixing #12313,
but I don't need the fix myself.
Will leave for someone with more motivation.

This reverts commit 3e9f0636.

Change-Id: Ifc78a6196f23e0f58e3b9ad7340e207a2d5de0a6
Reviewed-on: https://go-review.googlesource.com/17977Reviewed-by: Russ Cox <rsc@golang.org>

9f0055a2

net/http: don't accept invalid bytes in server request headers · c052222b

Brad Fitzpatrick authored Dec 17, 2015

Fixes #11207

Change-Id: I7f00b638e749fbc7907dc1597347ea426367d13e
Reviewed-on: https://go-review.googlesource.com/17980
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

c052222b

net/http: be more consistent about Request.Method "" vs "GET" · 18227bb7

Brad Fitzpatrick authored Dec 17, 2015

Patch from Russ.

No bug identified, but I didn't search exhaustively. The new code is
easier to read.

Fixes #13621

Change-Id: Ifda936e4101116fa254ead950b5fe06adb14e977
Reviewed-on: https://go-review.googlesource.com/17981Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

18227bb7

cmd/go: fix git submodule fetch · 761ac75a

Russ Cox authored Dec 17, 2015

Thanks to @toxeus on GitHub for the test case.

Fixes #12612.

Change-Id: I0c32fbe5044f3552053460a5347c062568093dff
Reviewed-on: https://go-review.googlesource.com/17974Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

761ac75a

net/http: update bundled http2, add tests reading response Body after Close · 66fcf567

Brad Fitzpatrick authored Dec 17, 2015

Updates to golang.org/x/net/http2 git rev 28273ec9 for
https://golang.org/cl/17937

Fixes #13648

Change-Id: I27c77524b2e4a172c5f8be08f6fbb0f2e2e4b200
Reviewed-on: https://go-review.googlesource.com/17938Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>

66fcf567

cmd/go: runtime and runtime/internal packages depend on runtime/internal/sys · 54977cd3

Ian Lance Taylor authored Dec 17, 2015

Fixes #13655.

Change-Id: I764019aecdd59743baa436b7339499e6c2126268
Reviewed-on: https://go-review.googlesource.com/17916
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

54977cd3

cmd/go: respect umask when creating executables · 0cb68ace

Russ Cox authored Dec 17, 2015

Also update many call sites where I forgot that the permission
argument is going to be masked by umask.

Fixes #12692.

Change-Id: I52b315b06236122ca020950447863fa396b68abd
Reviewed-on: https://go-review.googlesource.com/17950Reviewed-by: Ian Lance Taylor <iant@golang.org>

0cb68ace

net: fix the build even harder · 807c6c58

Brad Fitzpatrick authored Dec 17, 2015

Should fix nacl.

Follow-up to
https://golang.org/cl/17936 (fix race) and
https://golang.org/cl/17914 (fix build) for
https://golang.org/cl/16953 (broke the build)

Third time's a charm.

Change-Id: I23930d5cff4235209546952ce2231f165ab5bf8a
Reviewed-on: https://go-review.googlesource.com/17939
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

807c6c58

runtime: disable gdb test when a GOROOT_FINAL move is pending · d270a679

Russ Cox authored Dec 17, 2015

Fixes #13577.

Change-Id: I0bb8157d6210b0c7c09380c2163b7d7349495732
Reviewed-on: https://go-review.googlesource.com/17970Reviewed-by: Ian Lance Taylor <iant@golang.org>

d270a679

net/http: updated bundled http2 to finish trailer support · cfc9fde5

Brad Fitzpatrick authored Dec 17, 2015

This updates the bundled copy of x/net/http2 to git rev d2ecd08
for https://golang.org/cl/17912 (http2: send client trailers)
and enables the final Trailer test for http2.

Fixes #13557

Change-Id: Iaa15552b82bf7a2cb01b7787a2e1ec5ee680a9d3
Reviewed-on: https://go-review.googlesource.com/17935
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

cfc9fde5

net: include both ipv4 and ipv6 netsh output in TestInterfacesWithNetsh · f172a28f

Alex Brainman authored Dec 15, 2015

Also include test for interface state (up or down).

Updates #13606

Change-Id: I03538d65525ddd9c2d0254761861c2df7fc5bd5a
Reviewed-on: https://go-review.googlesource.com/17850Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
Run-TryBot: Russ Cox <rsc@golang.org>

f172a28f

net: fix race in test · 3ad3d593

Brad Fitzpatrick authored Dec 17, 2015

Fixes race builders, broken in https://golang.org/cl/16953

Change-Id: Id61171672b69d0ca412de4b44bf2c598fe557906
Reviewed-on: https://go-review.googlesource.com/17936
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

3ad3d593

cmd/go: allow ~ as first char of path element in general git import paths · 0d641c75

Russ Cox authored Dec 17, 2015

This makes go get gitserver/~user/repo.git/foo work.

Fixes #9193.

Change-Id: I8c9d4096903288f7f0e82d6ed1aa78bf038fb81a
Reviewed-on: https://go-review.googlesource.com/17952Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

0d641c75

cmd/go: don't be clever about mtime precision in test · 06b46c0d

Russ Cox authored Dec 17, 2015

This doesn't happen enough in the tests to be worth debugging.
Empirically, I expect this to add 5 seconds to the overall 'go test -short cmd/go'
on systems with precise file systems, and nothing on systems without them
(like my Mac).

Fixes #12205.

Change-Id: I0a17cb37bdedcfc0f921c5ee658737f1698c153b
Reviewed-on: https://go-review.googlesource.com/17953Reviewed-by: Ian Lance Taylor <iant@golang.org>

06b46c0d

cmd/go: document that package documentation is ignored · e357eb97

Russ Cox authored Dec 17, 2015

Fixes #11801.

Change-Id: I2caeac7fdddc7f29015d6db8d4b3e296c8b9c423
Reviewed-on: https://go-review.googlesource.com/17954Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

e357eb97

net/http: document a few ServeMux behaviors · aaa0bc10

Russ Cox authored Dec 17, 2015

Fixes #13639.
Fixes #11757.

Change-Id: Iecf9ebcd652c23c96477305a41082e5b63b41d83
Reviewed-on: https://go-review.googlesource.com/17955Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

aaa0bc10

cmd/go: allow omitted user name in git ssh repo syntax · 3e9f0636

Russ Cox authored Dec 17, 2015

No test because the code has no test.

Fixes #12313.

Change-Id: I2cfd0a0422c0cd76f0371c2d3bbbdf5bb3b3f1eb
Reviewed-on: https://go-review.googlesource.com/17951Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

3e9f0636

cmd/go: document that tests run in the source directory · f9137c53

Russ Cox authored Dec 17, 2015

Fixes #13538.

Change-Id: I621bbe2befe838d16d3664d7a5e30d5d7cceae33
Reviewed-on: https://go-review.googlesource.com/17949Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

f9137c53

cmd/go: document where get writes, and not vendor directories · f474885f

Russ Cox authored Dec 17, 2015

Fixes #12260.

Change-Id: I95c27aad6de8064b9a205d4ee507bce75926f16d
Reviewed-on: https://go-review.googlesource.com/17948Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

f474885f

cmd/go: document that go generate accepts all build flags · 8fac7e3c

Russ Cox authored Dec 17, 2015

Fixes #12544.

Change-Id: I5e2fd1fbb21816e9f6fb022e2664484a71093b04
Reviewed-on: https://go-review.googlesource.com/17947Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

8fac7e3c

os/signal: document signal handling · ab39b8de

Ian Lance Taylor authored Dec 15, 2015

This is an attempt to document the current state of signal handling.
It's not intended to describe the best way to handle signals.  Future
changes to signal handling should update these docs as appropriate.

update #9896.

Change-Id: I3c50af5cc641357b57dfe90ae1c7883a7e1ec059
Reviewed-on: https://go-review.googlesource.com/17877Reviewed-by: Russ Cox <rsc@golang.org>

ab39b8de

cmd/go: document that -p applies to test binary execution · 0a0f8bae

Russ Cox authored Dec 17, 2015

Fixes #11521.

Change-Id: I73615b881df4a0d5e2f5bc5059359d150ca8c105
Reviewed-on: https://go-review.googlesource.com/17946Reviewed-by: Joe Shaw <joe@joeshaw.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

0a0f8bae

cmd/pprof: fix scaling of "gigabyte" unit · 7688f0d9

Brad Fitzpatrick authored Dec 17, 2015

Fixes #13654

Change-Id: Id2ce32c52efcfdbd66630725d62d2ca6bf0916d5
Reviewed-on: https://go-review.googlesource.com/17934Reviewed-by: Russ Cox <rsc@golang.org>

7688f0d9

os,internal/syscall/windows: use ReadFile/MultiByteToWideChar to read from console · 7a481178

mattn authored Feb 10, 2015

Fixes #6303

Change-Id: Ib2cd15ac6106ef8e6b975943db8efc8d8ab21052
Reviewed-on: https://go-review.googlesource.com/4310Reviewed-by: Russ Cox <rsc@golang.org>

7a481178

net: fix build · 8cdd7d14

Brad Fitzpatrick authored Dec 17, 2015

https://golang.org/cl/16953 broke the world.

Change-Id: I7cbd4105338ff896bd0c8f69a0b126b6272be2e5
Reviewed-on: https://go-review.googlesource.com/17914Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

8cdd7d14

net/http: document that ListenAndServe is a bit more than Listen+Serve · 53a20713

Brad Fitzpatrick authored Dec 09, 2015

Document that ListenAndServe and ListenAndServeTLS also set TCP
keep-alives.

Fixes #12748

Change-Id: Iba2e8a58dd657eba326db49a6c872e2d972883a4
Reviewed-on: https://go-review.googlesource.com/17681Reviewed-by: Russ Cox <rsc@golang.org>

53a20713

archive/tar: document how Reader.Read handles header-only files · 7a2913c9

Joe Tsai authored Dec 16, 2015

Commit dd5e14a7 ensured that no data
could be read for header-only files regardless of what the Header.Size
said. We should document this fact in Reader.Read.

Updates #13647

Change-Id: I4df9a2892bc66b49e0279693d08454bf696cfa31
Reviewed-on: https://go-review.googlesource.com/17913Reviewed-by: Russ Cox <rsc@golang.org>

7a2913c9

net: prefer error for original name on lookups · 5c0629b5

Dan Peterson authored Nov 19, 2015

With certain names and search domain configurations the
returned error would be one encountered while querying a
generated name instead of the original name. This caused
confusion when a manual check of the same name produced
different results.

Now prefer errors encountered for the original name.

Also makes the low-level DNS connection plumbing swappable
in tests enabling tighter control over responses without
relying on the network.

Fixes #12712
Updates #13295

Change-Id: I780d628a762006bb11899caf20b5f97b462a717f
Reviewed-on: https://go-review.googlesource.com/16953Reviewed-by: Russ Cox <rsc@golang.org>

5c0629b5

crypto/x509: handle CRLDistributionPoints without FullNames · be7544be

Russ Cox authored Dec 08, 2015

Fixes #12910.

Change-Id: If446e5dce236483bbb898cc5959baf8371f05142
Reviewed-on: https://go-review.googlesource.com/17550Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>

be7544be

cmd/go: use tags when evaluating file system wildcards like ./... · 70cee781

Russ Cox authored Dec 16, 2015

Thanks to Albert Hafvenström for the diagnosis.

Fixes #11246.

Change-Id: I2b9e670c0ecf6aa01e5bf4d7a402619e93cc4f4a
Reviewed-on: https://go-review.googlesource.com/17942Reviewed-by: Ian Lance Taylor <iant@golang.org>

70cee781