- 13 Feb, 2014 28 commits
-
-
David Symonds authored
4 KB is a bit too small in some situations (e.g. panic during a template execution), and ends up with an unhelpfully-truncated trace. 64 KB should be much more likely to capture the useful information. There's not a garbage generation issue, since this code should only be triggered when there's something seriously wrong with the program. LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/63520043
-
Shenghou Ma authored
Fixes #6850. LGTM=agl R=golang-codereviews, agl CC=golang-codereviews https://golang.org/cl/60500046
-
Shenghou Ma authored
for example, we now rewrite *_Ctype_int to *C.int. Fixes #6781. LGTM=iant R=golang-codereviews, rsc, iant CC=golang-codereviews https://golang.org/cl/36860043
-
Russ Cox authored
Missed this suggestion in CL 57680046. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/63390043
-
David du Colombier authored
In file included from src/lib9/utf/utfecpy.c:17:0: src/lib9/utf/utfdef.h:28:0: error: "nil" redefined [-Werror] In file included from src/lib9/utf/utfrrune.c:17:0: src/lib9/utf/utfdef.h:28:0: error: "nil" redefined [-Werror] LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/63410043
-
David du Colombier authored
This change depends on CL 57170052. LGTM=rsc R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/60840049
-
David du Colombier authored
warning: src/lib9/fmt/dorfmt.c:64 unreachable code RETURN warning: src/lib9/fmt/fltfmt.c:184 set and not used: p warning: src/lib9/utf/utflen.c:35 unreachable code RETURN warning: src/lib9/utf/utfrrune.c:45 unreachable code RETURN warning: src/lib9/utf/utfrune.c:44 unreachable code RETURN LGTM=rsc R=rsc, iant, gobot CC=golang-codereviews https://golang.org/cl/57170052
-
Daniel Morsing authored
Logically, the init statement is in the enclosing scopes loopdepth, not inside the for loop. Fixes #7313. LGTM=rsc R=golang-codereviews, gobot, rsc CC=golang-codereviews https://golang.org/cl/62430043
-
Carlos Castillo authored
go/build is changed to list the .m files in a package, and match them for build constraints, adding them to a new field: Package.MFiles. The go tool is changed to support building .m files and linking in the results during CGO and SWIG builds. This means packages that create a C interface to calls Objective-C code from go are now go-gettable without producing and distributing .syso files. This change is analogous to the one in Go 1.2 made to support C++ built code. This change doesn't support .mm files (Objective C++). Also added support for these MFiles to go list's -json mode. Fixes #6536. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/60590044
-
Kyle Isom authored
This change adds support for parsing and serialisation of PKCS #10, certificate signature requests. LGTM=agl R=golang-codereviews, agl CC=agl, golang-codereviews, nick https://golang.org/cl/49830048
-
Michael T. Jones authored
TextMarshaller and TextUnmarshaller to ease transport of unlimited precision rational numbers. Fixes #7287. Consists of encode and decode functions and two test functions, one using JSON and one using XML. Each verifies round trips for integers (rationals with denominator == 1) and for fractional vaues. LGTM=gri R=gri, cookieo9, bradfitz, mtj CC=golang-codereviews https://golang.org/cl/61180043
-
Dmitriy Vyukov authored
c:\src\go\pkg\obj\windows_amd64\libgc.a(lex.o): In function `catcher': c:/src/go/src/cmd/gc/lex.c:181: undefined reference to `noted' LGTM=0intro R=0intro CC=golang-codereviews https://golang.org/cl/63270043
-
Russ Cox authored
This cleans up the code significantly, and it avoids any possible problems with madvise zeroing out some but not all of the data. Fixes #6400. LGTM=dave R=dvyukov, dave CC=golang-codereviews https://golang.org/cl/57680046
-
Dmitriy Vyukov authored
The issue was that one of the MSpan_Sweep callers was doing sweep with preemption enabled. Additional checks are added. LGTM=rsc R=rsc, dave CC=golang-codereviews https://golang.org/cl/62990043
-
David du Colombier authored
LGTM=rsc R=rsc, jas, gobot CC=ality, golang-codereviews https://golang.org/cl/51650051
-
Nicolas Owens authored
TestLookupHost expects that no duplicate addresses are returned. when cs is consulted for a name, e.g net!localhost!1, it will possibly return multiple available paths, e.g. via il and tcp. this confuses the tests. LGTM=aram R=jas, 0intro, aram CC=golang-codereviews https://golang.org/cl/58120045
-
Alexander Larsson authored
This adds support for archives with the SCHILY.xattr field in the pax header. This is what gnu tar and star generate. Fixes #7154. LGTM=dsymonds R=golang-codereviews, gobot, dsymonds CC=golang-codereviews https://golang.org/cl/54570043
-
Shenghou Ma authored
While we're at it, fix a wrong for statement in cmd/8g. LGTM=rsc R=rsc, golang-codereviews CC=golang-codereviews https://golang.org/cl/62700044
-
David du Colombier authored
warning: src/cmd/gc/popt.c:700 format mismatch d VLONG, arg 4 warning: src/cmd/gc/popt.c:700 format mismatch d VLONG, arg 5 LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/62910043
-
Russ Cox authored
TBR=dvyukov CC=golang-codereviews https://golang.org/cl/62960043
-
Russ Cox authored
This seems to be what causes the 'chunk mismatch' errors. I don't know why the server tells us there's nothing to upload, but at the least we can warn that it did, so that the user will try again. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/62840043
-
Andrew Gerrand authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/62890043
-
Andrew Gerrand authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/62880043
-
Andrew Gerrand authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/62870043
-
Andrew Gerrand authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/62860043
-
Russ Cox authored
copyau1 was assuming that it could deduce the type of the middle register p->reg from the type of the left or right argument: in CMPF F1, F2, the p->reg==2 must be a D_FREG because p->from is F1, and in CMP R1, R2, the p->reg==2 must be a D_REG because p->from is R1. This heuristic fails for CMP $0, R2, which was causing copyau1 not to recognize p->reg==2 as a reference to R2, which was keeping it from properly renaming the register use when substituting registers. cmd/5c has the right approach: look at the opcode p->as to decide the kind of register. It is unclear where 5g's copyau1 came from; perhaps it was an attempt to avoid expanding 5c's a2type to include new instructions used only by 5g. Copy a2type from cmd/5c, expand to include additional instructions, and make it crash the compiler if asked about an instruction it does not understand (avoid silent bugs in the future if new instructions are added). Should fix current arm build breakage. While we're here, fix the print statements dumping the pred and succ info in the asm listing to pass an int arg to %.4ud (Prog.pc is a vlong now, due to the liblink merge). TBR=ken2 CC=golang-codereviews https://golang.org/cl/62730043
-
Anthony Martin authored
Fixes #7294. LGTM=minux.ma, dave, bradfitz R=golang-codereviews, minux.ma, dave, bradfitz CC=golang-codereviews https://golang.org/cl/61370043
-
Robert Sesek authored
New testdata was created from existing using: $ lipo gcc-386-darwin-exec gcc-amd64-darwin-exec -create -output fat-gcc-386-amd64-darwin-exec Fixes #7250. LGTM=dave R=golang-codereviews, dave, josharian, bradfitz CC=golang-codereviews https://golang.org/cl/60190043
-
- 12 Feb, 2014 12 commits
-
-
Dave Cheney authored
From the description of CL 60190043 debug/macho: Add support for opening fat/universal binaries. New testdata was created from existing using: $ lipo gcc-386-darwin-exec gcc-amd64-darwin-exec -create -output fat-gcc-386-amd64-darwin-exec Update #7250 LGTM=iant R=golang-codereviews, gobot, dsymonds, iant CC=golang-codereviews https://golang.org/cl/61720044
-
Brad Fitzpatrick authored
So it doesn't bitrot. Like the sha1 version (https://golang.org/cl/62270043) LGTM=agl R=agl CC=golang-codereviews https://golang.org/cl/62420043
-
Russ Cox authored
State of the world: CL 46430043 introduced a new concurrent sweep but is broken. CL 62360043 made the new sweep non-concurrent to try to fix the world while we understand what's wrong with the concurrent version. This CL fixes the non-concurrent form to run finalizers. This CL is just a band-aid to get the build green again. Dmitriy is working on understanding and then fixing what's wrong with the concurrent sweep. TBR=dvyukov CC=golang-codereviews https://golang.org/cl/62370043
-
Adam Langley authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/57680047
-
Dmitriy Vyukov authored
We see failures on builders, e.g.: http://build.golang.org/log/70bb28cd6bcf8c4f49810a011bb4337a61977bf4 LGTM=rsc, dave R=rsc, dave CC=golang-codereviews https://golang.org/cl/62360043
-
Anthony Martin authored
We now use the %A, %D, %P, and %R routines from liblink across the board. Fixes #7178. Fixes #7055. LGTM=iant R=golang-codereviews, gobot, rsc, dave, iant, remyoudompheng CC=golang-codereviews https://golang.org/cl/49170043
-
Brad Fitzpatrick authored
So it doesn't bitrot. LGTM=agl R=golang-codereviews, agl CC=golang-codereviews https://golang.org/cl/62270043
-
Dmitriy Vyukov authored
Better sampling of objects that are close in size to sampling rate. See the comment for details. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/43830043
-
Dmitriy Vyukov authored
Current "System->etext" is not very informative. Add parent "GC" frame. Replace un-unwindable syscall/cgo frames with Go stack that leads to the call. LGTM=rsc R=rsc, alex.brainman, ality CC=golang-codereviews https://golang.org/cl/61270043
-
Nick Craig-Wood authored
(up to 2.8x). This is a partially unrolled version which performs better for small hashes and only sacrifices a small amount of ultimate speed to a fully unrolled version which uses 5k of code. Code size Before 1636 bytes After 1880 bytes 15% larger Benchmarks on Samsung Exynos 5 ARMv7 Chromebook benchmark old ns/op new ns/op delta BenchmarkHash8Bytes 1907 1136 -40.43% BenchmarkHash1K 20280 7547 -62.79% BenchmarkHash8K 148469 52576 -64.59% benchmark old MB/s new MB/s speedup BenchmarkHash8Bytes 4.19 7.04 1.68x BenchmarkHash1K 50.49 135.68 2.69x BenchmarkHash8K 55.18 155.81 2.82x LGTM=dave, agl R=dave, bradfitz, agl, adg, nick CC=golang-codereviews https://golang.org/cl/56990044
-
Dmitriy Vyukov authored
Remove GOOS_solaris ifdef from netpoll code, instead introduce runtime edge/level triggered IO flag. Replace armread/armwrite with a single arm(mode) function, that's how all other interfaces look like and these functions will need to do roughly the same thing anyway. LGTM=rsc R=golang-codereviews, dave, rsc CC=golang-codereviews https://golang.org/cl/55500044
-
Dmitriy Vyukov authored
1. Make internal chan functions static. 2. Move selgen local variable instead of a member of G struct. 3. Change "bool *pres/selected" parameter of chansend/chanrecv to "bool block", which is simpler, faster and less code. -37 lines total. LGTM=rsc R=golang-codereviews, dave, gobot, rsc CC=bradfitz, golang-codereviews, iant, khr https://golang.org/cl/58610043
-