- 28 Apr, 2014 8 commits
-
-
Shenghou Ma authored
The vi bundled with OS X has a weird bug in that if you turn off filetype in .vimrc when it's not turned on, even a clean exit of vi will return 1 which breaks almost everything. While we're at it, add hint to change $GOROOT to its actual value in .vimrc. Fixes #7865. LGTM=robert.hencke, dsymonds R=golang-codereviews, robert.hencke, gobot, dsymonds CC=golang-codereviews https://golang.org/cl/96800046
-
Keith Randall authored
Use a real type for Gs instead of scanning them conservatively. Zero the schedlink pointer when it is dead. Update #7820 LGTM=rsc R=rsc, dvyukov CC=golang-codereviews https://golang.org/cl/89360043
-
Keith Randall authored
LGTM=rsc R=golang-codereviews, adonovan, rsc CC=golang-codereviews https://golang.org/cl/90440043
-
Robert Hencke authored
Oddly, 404s with the trailing slash. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/90790045
-
Robert Hencke authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/98740046
-
Mikio Hara authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/90810045
-
Mikio Hara authored
Update #7645 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/98790044
-
Robert Hencke authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/98740045
-
- 27 Apr, 2014 8 commits
-
-
Brad Fitzpatrick authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/91770050
-
Mikio Hara authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/91860043
-
Ian Lance Taylor authored
For the gc compiler the Go function Issue7695 is defined in runtime.c, but there is no way to do that for gccgo, because there is no way to get the correct pkgpath. The test is not important for gccgo in any case. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/93870044
-
Peter Collingbourne authored
Previously we used strndup(3) to implement C.CString for gccgo. This is wrong because strndup assumes the string to be null terminated, and stops at the first null terminator. Instead, use malloc and memmove to create a copy of the string, as we do in the gc implementation. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/96790047
-
Brad Fitzpatrick authored
A very smart developer at Gophercon just asked me to help debug a problem and I was horrified to learn that he was using httputil's ClientConn. I forgot ClientConn and ServerConn were even included in Go 1! They should've been deleted. Scare people away from using them. The net/http package does not use them and they're unused, unmaintained and untouched in 4+ years. LGTM=r R=r, adg CC=golang-codereviews https://golang.org/cl/92790043
-
Robert Obryk authored
Remove an RUnlock of syscall.ForkLock with no matching RLock. Holding ForkLock in netFD.dup is unnecessary: dupCloseOnExecOld locks and unlocks the lock on its own and dupCloseOnExec doesn't need the ForkLock to be held. LGTM=iant R=golang-codereviews, bradfitz, iant CC=golang-codereviews https://golang.org/cl/99800044
-
Rui Ueyama authored
Previously Read wouldn't return once its internal input buffer is filled with non-data bytes. Fixes #7875. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/90820043
-
Robert Hencke authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/96850043
-
- 26 Apr, 2014 4 commits
-
-
Brad Fitzpatrick authored
Fixes #7812 LGTM=josharian, iant R=rsc, iant, adg, ruiu, minux.ma, josharian CC=golang-codereviews https://golang.org/cl/89900044
-
Jonathan Allie authored
Fixes #7741. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/96830044
-
Rob Pike authored
The instructions in this document are useful but not reliable. Explain the situation up top. Fixes #7471. LGTM=josharian, iant R=golang-codereviews, josharian, iant CC=golang-codereviews https://golang.org/cl/96830045
-
Robert Hencke authored
(from the discussions on CL 89650044) LGTM=minux.ma, iant R=iant, minux.ma CC=golang-codereviews https://golang.org/cl/97770043
-
- 25 Apr, 2014 4 commits
-
-
Brad Fitzpatrick authored
Fixes #7869 LGTM=dsymonds R=golang-codereviews CC=adg, dsymonds, golang-codereviews, rsc https://golang.org/cl/91770048
-
Mikio Hara authored
Fixes #7645 LGTM=iant, bradfitz R=iant, bradfitz CC=golang-codereviews https://golang.org/cl/90170046
-
Robert Griesemer authored
Fixes #7844. LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://golang.org/cl/90620045
-
Brad Fitzpatrick authored
I fixed this data race regression in two ways: in net/http itself, and also partially reverting the change from https://golang.org/cl/77580046 . Previously a Read from a strings.Reader or bytes.Reader returning 0 bytes would not be a memory write. After 77580046 it was. This reverts that back in case others depended on that. Also adds tests. Fixes #7856 LGTM=ruiu, iant R=iant, ruiu CC=golang-codereviews, gri https://golang.org/cl/94740044
-
- 24 Apr, 2014 1 commit
-
-
Rui Ueyama authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/93750043
-
- 23 Apr, 2014 2 commits
-
-
Rob Pike authored
Godoc makes it look better this way; before, it all ran together into nonsense. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/90400045
-
Brad Fitzpatrick authored
Work around buggy(?) Linux /proc filesystem. Fixes #7808 LGTM=iant R=golang-codereviews, iant CC=adg, golang-codereviews https://golang.org/cl/90400044
-
- 22 Apr, 2014 1 commit
-
-
Rui Ueyama authored
Previously it would panic because of out-of-bound access if s1 is longer than s2. LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/90110043
-
- 21 Apr, 2014 11 commits
-
-
Robert Griesemer authored
Fixes #7814. LGTM=agl, adonovan R=agl, adonovan CC=golang-codereviews https://golang.org/cl/90080043
-
Josh Bleecher Snyder authored
TestVariousDeadlines1Proc was flaky on my system, failing on about 5% of runs. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/89830045
-
Mark Zavislak authored
LGTM=robert.hencke, iant R=golang-codereviews, robert.hencke, iant CC=golang-codereviews https://golang.org/cl/89760043
-
Rémy Oudompheng authored
LGTM=dvyukov R=rsc, iant, khr, dvyukov CC=golang-codereviews https://golang.org/cl/76520045
-
Alex Brainman authored
Fixes #7829 LGTM=dave R=golang-codereviews, aram, dave CC=golang-codereviews https://golang.org/cl/89830043
-
Alex Brainman authored
Update #7829 LGTM=dave R=golang-codereviews, dave CC=golang-codereviews https://golang.org/cl/89810043
-
Alex Brainman authored
This should have been part of 36eb4a62fbb6, but I later discovered that addresses are all wrong. Appropriate test added now. LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/89470043
-
Shenghou Ma authored
Fixes #7331. LGTM=dave, iant R=golang-codereviews, dave, gobot, iant CC=golang-codereviews https://golang.org/cl/89150043
-
Shenghou Ma authored
Update #7331 LGTM=dave, iant R=golang-codereviews, dave, gobot, iant CC=golang-codereviews https://golang.org/cl/89520043
-
Shenghou Ma authored
`GOARCH=arm go tool 6c` used to give "<prog>: cannot use 6c with GOARCH=arm" LGTM=r R=golang-codereviews, r CC=golang-codereviews https://golang.org/cl/89330043
-
Shenghou Ma authored
CL 89050043 only allows -ccflags for 'go test', this CL really handles the flag like the other -??flags. Many thanks to Dobrosław Żybort for pointing this out. Fixes #7810 (again). LGTM=iant, matrixik R=golang-codereviews, iant, matrixik CC=golang-codereviews https://golang.org/cl/89230044
-
- 20 Apr, 2014 1 commit
-
-
David du Colombier authored
LGTM=minux.ma R=r, minux.ma CC=golang-codereviews https://golang.org/cl/89710043
-