Skip to content

G
go
Switch branch/tag
  1. 13 May, 2013 2 commits
  3. 08 May, 2013 7 commits
  5. 07 May, 2013 2 commits
  7. 06 May, 2013 8 commits
    • Dmitriy Vyukov's avatar
      runtime: fix crash in badsignal() · f322c786
      Dmitriy Vyukov authored 
      The linker can generate split stack prolog when a textflag 7 function
makes an indirect function call.  If it happens, badsignal() crashes
trying to dereference g.
Fixes #5337.

R=bradfitz, dave, adg, iant, r, minux.ma
CC=adonovan, golang-dev
https://golang.org/cl/9226043
      f322c786
    • Shenghou Ma's avatar
      runtime: reduce max arena size on windows/amd64 to 32 GiB · b3b1efd8
      Shenghou Ma authored 
      Update #5236
Update #5402
This CL reduces gofmt's committed memory from 545864 KiB to 139568 KiB.
Note: Go 1.0.3 uses about 70MiB.

R=golang-dev, r, iant, nightlyone
CC=golang-dev
https://golang.org/cl/9245043
      b3b1efd8
    • Brad Fitzpatrick's avatar
      database/sql: remove an unused field from Rows · e85016f8
      Brad Fitzpatrick authored 
      Found while debugging memory usage. Nobody accesses this field
anymore.

R=golang-dev, i.caught.air, adg, r
CC=golang-dev
https://golang.org/cl/9108043
      e85016f8
    • Andrew Gerrand's avatar
      doc: add FAQ entry about language changes · 61dbc340
      Andrew Gerrand authored 
      R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/9244043
      61dbc340
    • Shenghou Ma's avatar
      syscall: fix prototype of Fchflags (API change) · 6de184b3
      Shenghou Ma authored 
      API change, but the old API is obviously wrong.

R=golang-dev, iant, r, rsc
CC=golang-dev
https://golang.org/cl/9157044
      6de184b3
    • Jeremiah Harmsen's avatar
      go/doc/example: Fix bug causing false negatives for Example playability. · a228e733
      Jeremiah Harmsen authored 
      Allows Examples with KeyValue expressions to be playable in godoc.

During the traversal of the abstract syntax tree any KeyValueExpr Key.Name was incorrectly being added as an unresolved identifier.
Since this identifier could not be provided the Example was marked as unplayable.
This updates the AST traversal to skip Keys (but continue traversing the Values).

Example of problematic AST now fixed (see L99 where "UpperBound" was being added as a missing identifier):

 81  .  .  .  .  .  .  .  .  .  Values: []ast.Expr (len = 1) {
 82  .  .  .  .  .  .  .  .  .  .  0: *ast.UnaryExpr {
 83  .  .  .  .  .  .  .  .  .  .  .  OpPos: 12:19
 84  .  .  .  .  .  .  .  .  .  .  .  Op: &
 85  .  .  .  .  .  .  .  .  .  .  .  X: *ast.CompositeLit {
 86  .  .  .  .  .  .  .  .  .  .  .  .  Type: *ast.SelectorExpr {
 87  .  .  .  .  .  .  .  .  .  .  .  .  .  X: *ast.Ident {
 88  .  .  .  .  .  .  .  .  .  .  .  .  .  .  NamePos: 12:20
 89  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Name: "t_proto"
 90  .  .  .  .  .  .  .  .  .  .  .  .  .  }
 91  .  .  .  .  .  .  .  .  .  .  .  .  .  Sel: *ast.Ident {
 92  .  .  .  .  .  .  .  .  .  .  .  .  .  .  NamePos: 12:41
 93  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Name: "BConfig"
 94  .  .  .  .  .  .  .  .  .  .  .  .  .  }
 95  .  .  .  .  .  .  .  .  .  .  .  .  }
 96  .  .  .  .  .  .  .  .  .  .  .  .  Lbrace: 12:79
 97  .  .  .  .  .  .  .  .  .  .  .  .  Elts: []ast.Expr (len = 2) {
 98  .  .  .  .  .  .  .  .  .  .  .  .  .  0: *ast.KeyValueExpr {
 99  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Key: *ast.Ident {
100  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  NamePos: 13:3
101  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Name: "UpperBound"
102  .  .  .  .  .  .  .  .  .  .  .  .  .  .  }
103  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Colon: 13:13
104  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Value: *ast.CallExpr {
105  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Fun: *ast.SelectorExpr {
106  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  X: *ast.Ident {
107  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  NamePos: 13:15
108  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Name: "proto"
109  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  }
110  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Sel: *ast.Ident {
111  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  NamePos: 13:21
112  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  Name: "Float32"
113  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  .  }

R=adg
CC=gobot, golang-dev, gri
https://golang.org/cl/8569045
      a228e733
    • Andrew Gerrand's avatar
      C: add Jeremiah Harmsen (Google CLA) · b13eac88
      Andrew Gerrand authored 
      R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/9229043
      b13eac88
    • Brad Fitzpatrick's avatar
      image/png: fix error message to not return width twice · 1294f14f
      Brad Fitzpatrick authored 
      Fixes #5413

R=golang-dev, dave, adg
CC=golang-dev
https://golang.org/cl/9153045
      1294f14f
  9. 04 May, 2013 1 commit
  11. 03 May, 2013 5 commits
  13. 02 May, 2013 3 commits
  15. 01 May, 2013 6 commits
  17. 30 Apr, 2013 6 commits
    • Rob Pike's avatar
      cmd/ld: when linking externally, only generate dwarf info for ELF · 2a1ca145
      Rob Pike authored 
      R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/9025047
      2a1ca145
    • Russ Cox's avatar
      cmd/go: undo CL 8119049 · ed9644fc
      Russ Cox authored 
      Manual undo due to later changes in doc/go1.1.html; cmd/go/test.bash still passes.

Rationale, from CL 8119049 review log:

This makes the 'go run' command different from every other command.
For example, 'go test' does not mean 'go test *.go'.

If we were going to handle the no arguments case in 'go run', I would hope that
it would scan the current directory to find a package just like 'go build' or
'go test' would, and then it would require that package to be 'package main',
and then it would run that package. This would make it match 'go test' and 'go
build' and 'go install' and so on. It would mean that if you are working on a
command in a directory that is 'go install'able, then 'go run' will run the
binary for you. The current CL does not accomplish that when build constraints
or file name constraints are involved.

For example, if I am working on a program like:

$ ls
main.go
main_386.s
main_arm.s
main_amd64.s
$

Then 'go run' will fail here because the .s files are ignored.

If instead I am working on a program like:

$ ls
main.go
main_386.go
main_arm.go
main_amd64.go
$

then 'go run' will fail because too many files are included.

I would like to see this command implemented so that it is compatible with the
other go subcommands. Since it is too late to do that for Go 1.1, I would like
to see this CL reverted, to preserve the option to do it better later.

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/8797049
      ed9644fc
    • Ian Lance Taylor's avatar
      cmd/ld: emit relocs for DWARF info when doing an external link · 825b1e15
      Ian Lance Taylor authored 
      I would like opinions on whether this is a good idea for 1.1.
On the one hand it's a moderately important issue.  On the
other hand this introduces at least the possibility of
external linker errors due to the additional relocations and
it may be better to wait.

I'm fairly confident that the behaviour is unchanged when not
using an external linker.

Update #5221

This CL is tested lightly on 386 and amd64 and fixes the cases
I tested.  I have not tested it on Darwin or Windows.

R=golang-dev, dave, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/8858047
      825b1e15
    • Rob Pike's avatar
      os/exec: disable TestExtraFilesFDShuffle · b461c94c
      Rob Pike authored 
      It's too hard to make portable just now.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/9057043
      b461c94c
    • Cosmos Nicolaou's avatar
      syscall: fix a bug in the shuffling of file descriptors in StartProcess on Linux. · b493f0a8
      Cosmos Nicolaou authored 
      R=iant, iant, r, bradfitz
CC=golang-dev
https://golang.org/cl/8334044
      b493f0a8
    • Rob Pike's avatar
      syscall: fix exec_bsd.go to accompany exec_linux.go changes · 479b1241
      Rob Pike authored 
      exec_plan9.go too.
Those are in CL 8334044

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/9055043
      479b1241
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7