- 18 May, 2016 1 commit
-
-
James Chacon authored
racefini calls __tsan_fini which is C code and at the end of it invoked the standard C library exit(3) call. This has undefined behavior if invoked more than once. Specifically in C++ programs it caused static destructors to run twice. At least on glibc impls it also means the at_exit handlers list (where those are stored) also free's a list entry when it completes these. So invoking twice results in a double free at exit which trips debug memory allocation tracking. Fix all of this by using an atomic as a boolean barrier around calls to racefini being invoked > 1 time. Fixes #15578 Change-Id: I49222aa9b8ded77160931f46434c61a8379570fc Reviewed-on: https://go-review.googlesource.com/22882Reviewed-by:
Dmitry Vyukov <dvyukov@google.com> Run-TryBot: Dmitry Vyukov <dvyukov@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 17 May, 2016 6 commits
-
-
Alessandro Arzilli authored
Fixes #15675 Change-Id: I8bad220988e5d690f20804db970b2db037c81187 Reviewed-on: https://go-review.googlesource.com/23086Reviewed-by:
Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Mikio Hara authored
Fixes #14576. Change-Id: I760907c67c97cb827cf48ba7eb0bb2f4f8d4d790 Reviewed-on: https://go-review.googlesource.com/23111 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Colin Cross authored
The initial implementation of reflect.StructOf in https://golang.org/cl/9251 had a limitation that field names had to be ASCII, which was later lifted by https://golang.org/cl/21777. Remove the out-of-date documentation disallowing UTF-8 field names. Updates: #5748 Updates: #15064 Change-Id: I2c5bfea46bfd682449c6e847fc972a1a131f51b7 Reviewed-on: https://go-review.googlesource.com/23170Reviewed-by:
David Crawshaw <crawshaw@golang.org>
-
Konstantin Shaposhnikov authored
os.SIGINT is not defined, os.Interrupt or syscall.SIGINT should be used. Change-Id: I39867726d28e179d1160a4fd353b7bea676c9dbb Reviewed-on: https://go-review.googlesource.com/23127Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org>
-
Mikio Hara authored
Also replaces google.com with golang.org in package documentation. Updates #15228. Change-Id: I554fa960878fa44557a522635ed412d8d7548d3f Reviewed-on: https://go-review.googlesource.com/23126Reviewed-by:
-
Mikio Hara authored
This change drops parseInterfaceTable which becomes unnecessary by the golang.org/x/net/route plumbing. Change-Id: I05f96e347de950bb1e9292bb3eeff01bb40e292f Reviewed-on: https://go-review.googlesource.com/23125 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
-
- 16 May, 2016 13 commits
-
-
Scott Bell authored
Fixes #15348 Change-Id: I9e0e1e3a26fa4cd697d2c613e6b4952188b7c7e1 Reviewed-on: https://go-review.googlesource.com/23150Reviewed-by:
-
andrew werner authored
before this change, when io.MultiReader was called many times but contain few underlying readers, calls to Read were unnecessarily expensive. Fixes #13558 Change-Id: I3ec4e88c7b50c075b148331fb1b7348a5840adbe Reviewed-on: https://go-review.googlesource.com/17873Reviewed-by:
-
Simon Thulbourn authored
Adds a transparent sort to the mime/multipart package, which is only used in the CreatePart func. This will ensure the ordering of the MIMEHeader. The point of this change was to ensure the output would be consistent and something that could be depended on. Fixes #13522 Change-Id: I9584ef9dbe98ce97d536d897326914653f8d9ddf Reviewed-on: https://go-review.googlesource.com/17497Reviewed-by:
-
Brad Fitzpatrick authored
Change-Id: I7627e480d5d2366cba223fd81635c4115649f752 Reviewed-on: https://go-review.googlesource.com/23154Reviewed-by:
-
Ian Lance Taylor authored
Issue #15613 points out that the darwin builders have been getting regular failures in which a process that should exit with a SIGPIPE signal is instead exiting with exit status 2. The code calls runtime.raise. On most systems runtime.raise is the equivalent of pthread_kill(gettid(), sig); that is, it kills the thread with the signal, which should ensure that the program does not keep going. On darwin, however, runtime.raise is actually kill(getpid(), sig); that is, it sends a signal to the entire process. If the process decides to deliver the signal to a different thread, then it is possible that in some cases the thread that calls raise is able to execute the next system call before the signal is actually delivered. That would cause the observed error. I have not been able to recreate the problem myself, so I don't know whether this actually fixes it. But, optimistically: Fixed #15613. Change-Id: I60c0a9912aae2f46143ca1388fd85e9c3fa9df1f Reviewed-on: https://go-review.googlesource.com/23152 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Scott Bell authored
Fixes #15188 Change-Id: I0ab7791f7db499cef6bc52292d3d93ff4da7caff Reviewed-on: https://go-review.googlesource.com/23151Reviewed-by:
-
David Chase authored
This adds a sparse method for locating nearest ancestors in a dominator tree, and checks blocks with more than one predecessor for differences and inserts phi functions where there are. Uses reversed post order to cut number of passes, running it from first def to last use ("last use" for paramout and mem is end-of-program; last use for a phi input from a backedge is the source of the back edge) Includes a cutover from old algorithm to new to avoid paying large constant factor for small programs. This keeps normal builds running at about the same time, while not running over-long on large machine-generated inputs. Add "phase" flags for ssa/build -- ssa/build/stats prints number of blocks, values (before and after linking references and inserting phis, so expansion can be measured), and their product; the product governs the cutover, where a good value seems to be somewhere between 1 and 5 million. Among the files compiled by make.bash, this is the shape of the tail of the distribution for #blocks, #vars, and their product: #blocks #vars product max 6171 28180 173,898,780 99.9% 1641 6548 10,401,878 99% 463 1909 873,721 95% 152 639 95,235 90% 84 359 30,021 The old algorithm is indeed usually fastest, for 99%ile values of usually. The fix to LookupVarOutgoing ( https://go-review.googlesource.com/#/c/22790/ ) deals with some of the same problems addressed by this CL, but on at least one bug ( #15537 ) this change is still a significant help. With this CL: /tmp/gopath$ rm -rf pkg bin /tmp/gopath$ time go get -v -gcflags -memprofile=y.mprof \ github.com/gogo/protobuf/test/theproto3/combos/... ... real 4m35.200s user 13m16.644s sys 0m36.712s and pprof reports 3.4GB allocated in one of the larger profiles With tip: /tmp/gopath$ rm -rf pkg bin /tmp/gopath$ time go get -v -gcflags -memprofile=y.mprof \ github.com/gogo/protobuf/test/theproto3/combos/... ... real 10m36.569s user 25m52.286s sys 4m3.696s and pprof reports 8.3GB allocated in the same larger profile With this CL, most of the compilation time on the benchmarked input is spent in register/stack allocation (cumulative 53%) and in the sparse lookup algorithm itself (cumulative 20%). Fixes #15537. Change-Id: Ia0299dda6a291534d8b08e5f9883216ded677a00 Reviewed-on: https://go-review.googlesource.com/22342Reviewed-by:Keith Randall <khr@golang.org> Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Austin Clements authored
This should help with debugging failures. For #15138 and #15477. Change-Id: I77db2b6375d8b4403d3edf5527899d076291e02c Reviewed-on: https://go-review.googlesource.com/23134 Run-TryBot: Austin Clements <austin@google.com> Reviewed-by:
Rick Hudson <rlh@golang.org>
-
Scott Bell authored
Fixes #15424 Change-Id: Ib9e97509f5ac239ee54fe6fe37152a7f5fc75087 Reviewed-on: https://go-review.googlesource.com/23109Reviewed-by:
-
Austin Clements authored
The convention for writing something like "64 kB" is 64<<10, since this is easier to read than 1<<16. Update gcBitsChunkBytes to follow this convention. Change-Id: I5b5a3f726dcf482051ba5b1814db247ff3b8bb2f Reviewed-on: https://go-review.googlesource.com/23132Reviewed-by:
-
Austin Clements authored
Change-Id: I5ebf93b60213c0138754fc20888ae5ce60237b8c Reviewed-on: https://go-review.googlesource.com/23131Reviewed-by:
-
Dan Peterson authored
Make clear negotiation can happen via NPN or ALPN, similar to http.Transport.TLSNextProto and x/net/http2.NextProtoTLS. Change-Id: Ied00b842bc04e11159d6d2107beda921cefbc6ca Reviewed-on: https://go-review.googlesource.com/23108Reviewed-by:
-
Artyom Pervukhin authored
If client does not provided User-Agent header, do not set default one used by net/http package when doing request to backend. Fixes #15524 Change-Id: I9a46bb3b7ec106bc7c3071e235b872d279994d67 Reviewed-on: https://go-review.googlesource.com/23089 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 15 May, 2016 6 commits
-
-
Mikio Hara authored
Updates #13372. Change-Id: Id2402a781474e9d0bb0901c5844adbd899f76cbd Reviewed-on: https://go-review.googlesource.com/23123 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Mikio Hara authored
Updates #14982. Change-Id: Id12b1e61456832d2b2ffbdbe8cf0a1db4444b1e4 Reviewed-on: https://go-review.googlesource.com/23122Reviewed-by:
-
Mikio Hara authored
Also removes unnecessary test cases for avoiding unexpected failures on newer operating systems. Updates #14724. Change-Id: I2291585d951fb70383da68293a6ac1ff3524c7f7 Reviewed-on: https://go-review.googlesource.com/22452 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
David du Colombier authored
There was a typo introduced in the initial implementation of the Plan 9 support of the mime package. On Plan 9, the mime type file name should be /sys/lib/mimetype instead of /sys/lib/mimetypes. Change-Id: If0f0a9b6f3fbfa8dde551f790e83bdd05e8f0acb Reviewed-on: https://go-review.googlesource.com/23087 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by:
Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Mikio Hara authored
This change makes use of new routing message APIs for BSD variants to support FreeBSD 11 and newer versions of other BSDs. Fixes #7849. Fixes #14724. Change-Id: I56c7886d6622cdeddd7cc29c8a8062dcc06216d5 Reviewed-on: https://go-review.googlesource.com/22451Reviewed-by:
-
Keith Randall authored
The 17-31 byte code is broken. Disabled it. Added a bunch of tests to at least cover the cases in indexShortStr. I'll channel Brad and wonder why this CL ever got in without any tests. Fixes #15679 Change-Id: I84a7b283a74107db865b9586c955dcf5f2d60161 Reviewed-on: https://go-review.googlesource.com/23106Reviewed-by:
-
- 14 May, 2016 8 commits
-
-
Mikio Hara authored
golang.org/x/net/route becomes vendor/golang.org/x/net/route. At git rev 30be488 (golang.org/cl/22446) Updates #14724. Change-Id: I41cfb5443aeecac4c71e843c09eb8c1d4b7413ea Reviewed-on: https://go-review.googlesource.com/22450Reviewed-by:
-
Alex Brainman authored
Local.String() returns "Local" on every OS, but windows. Change windows code to do like others. Updates #15568 Change-Id: I7a4d2713d940e2a01cff9d7f5cefc89def07546a Reviewed-on: https://go-review.googlesource.com/23078Reviewed-by:
-
Kevin Burke authored
The resource is available over (and redirects to) HTTPS, it seems like a good idea to save a redirect and ensure an encrypted connection. Change-Id: I262c7616ae289cdd756b6f67573ba6bd7e3e0ca6 Reviewed-on: https://go-review.googlesource.com/23104Reviewed-by:
-
Konstantin Shaposhnikov authored
Updates #14047 Change-Id: I4b150533393bfb90e840497095ac32bcca4f04c2 Reviewed-on: https://go-review.googlesource.com/23114 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Austin Clements authored
Currently the heapBitsSetType documentation says that there are no races on the heap bitmap, but that isn't exactly true. There are no *write-write* races, but there are read-write races. Expand the documentation to explain this and why it's okay. Change-Id: Ibd92b69bcd6524a40a9dd4ec82422b50831071ed Reviewed-on: https://go-review.googlesource.com/23092Reviewed-by:
-
Austin Clements authored
Currently we only execute a publication barrier for scan objects (and skip it for noscan objects). This used to be okay because GC would never consult the object itself (so it wouldn't observe uninitialized memory even if it found a pointer to a noscan object), and the heap bitmap was pre-initialized to noscan. However, now we explicitly initialize the heap bitmap for noscan objects when we allocate them. While the GC will still never consult the contents of a noscan object, it does need to see the initialized heap bitmap. Hence, we need to execute a publication barrier to make the bitmap visible before user code can expose a pointer to the newly allocated object even for noscan objects. Change-Id: Ie4133c638db0d9055b4f7a8061a634d970627153 Reviewed-on: https://go-review.googlesource.com/23043 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Mikio Hara authored
Fixes #6879. Change-Id: I9ed2460cf14cb9322d9521e7af910efa48abdaf0 Reviewed-on: https://go-review.googlesource.com/23112 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Tom Bergan authored
This fixes change https://go-review.googlesource.com/#/c/23069/, which assumes all DNS requests are UDP. This is not true -- DNS requests can be TCP in some cases. See: https://tip.golang.org/src/net/dnsclient_unix.go#L154 https://en.wikipedia.org/wiki/Domain_Name_System#Protocol_transport Also, the test code added by the above change doesn't actually test anything because the test uses a faked DNS resolver that doesn't actually make any DNS queries. I fixed that by adding another test that uses the system DNS resolver. Updates #12580 Change-Id: I6c24c03ebab84d437d3ac610fd6eb5353753c490 Reviewed-on: https://go-review.googlesource.com/23101Reviewed-by:
-
- 13 May, 2016 5 commits
-
-
David Crawshaw authored
By picking up a spurious tFlagExtraStar, the method type was printing as unc instead of func. Updates #15673 Change-Id: I0c2c189b99bdd4caeb393693be7520b8e3f342bf Reviewed-on: https://go-review.googlesource.com/23103Reviewed-by:
-
Mikio Hara authored
This reverts commit 7af2ce3f. The commit had a wrong prefix in the description line, probably misreconginized something. As a result it broke golang.org/x/tools/godoc and golang.org/x/tools/cmd/godoc like the following: --- FAIL: TestCLI (10.90s) --- FAIL: TestWeb (13.74s) FAIL FAIL golang.org/x/tools/cmd/godoc 36.428s --- FAIL: TestCommandLine (0.00s) FAIL FAIL golang.org/x/tools/godoc 0.068s Change-Id: I362a862a4ded8592dec7488a28e7a256adee148f Reviewed-on: https://go-review.googlesource.com/23076 Run-TryBot: Mikio Hara <mikioh.mikioh@gmail.com> Reviewed-by:
Andrew Gerrand <adg@golang.org>
-
Dmitry Vyukov authored
Change-Id: Iaf455d1a2863ff752e0c398e1c364373b4d36614 Reviewed-on: https://go-review.googlesource.com/23084Reviewed-by:
-
Brad Fitzpatrick authored
The httptrace.ConnectStart and ConnectDone hooks are just about the post-DNS connection to the host. We were accidentally also firing on the UDP dials to DNS. Exclude those for now. We can add them back later as separate hooks if desired. (but they'd only work for pure Go DNS) This wasn't noticed earlier because I was developing on a Mac at the time, which always uses cgo for DNS. When running other tests on Linux, I started seeing UDP dials. Updates #12580 Change-Id: I2b2403f2483e227308fe008019f1100f6300250b Reviewed-on: https://go-review.googlesource.com/23069Reviewed-by:
-
Alex Brainman authored
Change-Id: I6610b872578d161e535565258039d9f064f01456 Reviewed-on: https://go-review.googlesource.com/23070Reviewed-by:
Nigel Tao <nigeltao@golang.org> Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
- 12 May, 2016 1 commit
-
-
Andrew Gerrand authored
Return an error message instead of eating memory and eventually triggering a stack overflow. Fixes #15618 Change-Id: I3dcf1d669104690a17847a20fbfeb6d7e39e8751 Reviewed-on: https://go-review.googlesource.com/23091Reviewed-by:
Rob Pike <r@golang.org>
-
