Commits · 7377d0c7e972397969382315df915579e32db025 · Kirill Smelkov / go

12 Sep, 2017 3 commits

go/*: use sort.Slice to simplify some code · 7377d0c7

Daniel Martí authored Sep 12, 2017

Skip the ones that have multiple uses for now. Also had to rename the
importComment variable as it shadowed the top-level func by the same
name.

Change-Id: I796285aa7b4fdf2c39e652666390427d37b063ee
Reviewed-on: https://go-review.googlesource.com/63150
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

7377d0c7

all: remove strings.Contains check around Replace · eb2dc3d3

Daniel Martí authored Sep 11, 2017

It doesn't change the outcome. It might have been useful at some point
to avoid Replace from doing work or allocating. However, nowadays the
func returns early without doing any work if Count returns 0.

Change-Id: Id69dc74042a6e39672b405016484db8b50f43d58
Reviewed-on: https://go-review.googlesource.com/62991
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>

eb2dc3d3

cmd/compile: improve single blank variable handling in walkrange · 137e4a6c

Martin Möhrmann authored Sep 03, 2017

Refactor walkrange to treat "for _ = range a" as "for range a".

This avoids generating some later discarded nodes in the compiler.

Passes toolstash -cmp.

Change-Id: Ifb2e1ca3b8519cbb67e8ad5aad514af9d18f1ec4
Reviewed-on: https://go-review.googlesource.com/61017
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>

137e4a6c

11 Sep, 2017 22 commits

net/http: allow reuse of http.Request objects · 78c4dc37

Luan Santos authored Sep 11, 2017

Calling response.Body.Close() early would generarate a race before this.
Since closing would return early before the main code path had a chance
to reset the request canceler. Having a non-nil request canceler at the
start of the next request would cause a "request canceled" error.

Here we simply wait for the eofc channel to be closed before returning
from earlyCloseFn, ensuring that the caller won't be re-using that
Request object before we have a chance to reset the request canceler to
nil.

Fixes #21838

Change-Id: I641815526c6ac63d1816c9b6ad49d73715f7a5cb
Reviewed-on: https://go-review.googlesource.com/62891
Run-TryBot: Tom Bergan <tombergan@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Tom Bergan <tombergan@google.com>

78c4dc37

expvar: make (*Map).Init clear existing keys · cf872fae

Bryan C. Mills authored Sep 08, 2017

fixes #21619

Change-Id: I5bb513dfc8cac875b06a262eec40b5863ae23a4c
Reviewed-on: https://go-review.googlesource.com/62370Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

cf872fae

cmd/link: enable -buildmode=plugin for ppc64le · e9cbabb3

Lynn Boger authored Aug 15, 2017

This enables support for the buildmode plugin on
ppc64le.

Fixes #20756

Change-Id: I83241ff63f9b5c366fe0496cf46a3f67d75d08ac
Reviewed-on: https://go-review.googlesource.com/55850
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>

e9cbabb3

crypto/sha1: speed up sha1 for very small blocks · dc3b8a19

Ilya Tocar authored Aug 09, 2017

For very small blocks significant time is spent in checkSum function,
adding necessary padding. Instead of writing it byte by byte, copy
encoding/binary PutUint functions, which are compiled into single mov.

name old time/op new time/op delta
Hash8Bytes-6 344ns ± 0% 310ns ± 0% -9.78% (p=0.000 n=10+9)
Hash320Bytes-6 1.28µs ± 0% 1.25µs ± 0% -2.58% (p=0.000 n=10+10)
Hash1K-6 2.51µs ± 0% 2.47µs ± 0% -1.67% (p=0.000 n=10+10)
Hash8K-6 15.8µs ± 0% 15.7µs ± 1% -0.21% (p=0.023 n=10+10)

name old speed new speed delta
Hash8Bytes-6 23.2MB/s ± 0% 25.7MB/s ± 0% +10.77% (p=0.000 n=10+9)
Hash320Bytes-6 249MB/s ± 0% 256MB/s ± 0% +2.65% (p=0.000 n=10+10)
Hash1K-6 408MB/s ± 0% 414MB/s ± 0% +1.70% (p=0.000 n=10+10)

Change-Id: I3975ee929465c7dd137d0ca757ad3792a004e1a3
Reviewed-on: https://go-review.googlesource.com/54391
Run-TryBot: Ilya Tocar <ilya.tocar@intel.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Giovanni Bajo <rasky@develer.com>
Reviewed-by: Filippo Valsorda <hi@filippo.io>

dc3b8a19

cmd/compile: simplify a few early var declarations · 27a70ea5

Daniel Martí authored Sep 11, 2017

These were likely written in C or added by an automated tool. Either
way, they're unnecessary now. Clean up the code.

Change-Id: I56de2c7bb60ebab8c500803a8b6586bdf4bf75c7
Reviewed-on: https://go-review.googlesource.com/62951
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Dave Cheney <dave@cheney.net>
TryBot-Result: Gobot Gobot <gobot@golang.org>

27a70ea5

cmd/compile, math/bits: add rotate rules to PPC64.rules · fa3fe2e3

Lynn Boger authored Aug 29, 2017

This adds rules to match the code in math/bits RotateLeft,
RotateLeft32, and RotateLef64 to allow them to be inlined.

The rules are complicated because the code in these function
use different types, and the non-const version of these
shifts generate Mask and Carry instructions that become
subexpressions during the match process.

Also adds a testcase to asm_test.go.

Improvement in math/bits:

BenchmarkRotateLeft-16       1.57     1.32      -15.92%
BenchmarkRotateLeft32-16     1.60     1.37      -14.37%
BenchmarkRotateLeft64-16     1.57     1.32      -15.92%

Updates #21390

Change-Id: Ib6f17669ecc9cab54f18d690be27e2225ca654a4
Reviewed-on: https://go-review.googlesource.com/59932
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>

fa3fe2e3

cmd/go: fix regexp · 4768408e

Joe Tsai authored Sep 11, 2017

The regular expression "A-za-z" is most likely a typo and
the intent seems to be "A-Za-z" instead.

Using "A-z" matches certain characters like: [\]^_`

Updates #10010

Change-Id: If2d064c56ef613f2e46285d8d4e5998e83aed43a
Reviewed-on: https://go-review.googlesource.com/62910Reviewed-by: Matt Layher <mdlayher@gmail.com>
Run-TryBot: Matt Layher <mdlayher@gmail.com>

4768408e

crypto/elliptic: fix incomplete addition used in CombinedMult. · 2d69e9e2

Adam Langley authored May 03, 2017

The optimised P-256 includes a CombinedMult function, which doesn't do
dual-scalar multiplication, but does avoid an affine conversion for
ECDSA verification.

However, it currently uses an assembly point addition function that
doesn't handle exceptional cases.

Fixes #20215.

Change-Id: I4ba2ca1a546d883364a9bb6bf0bdbc7f7b44c94a
Reviewed-on: https://go-review.googlesource.com/42611
Run-TryBot: Adam Langley <agl@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>

2d69e9e2

cmd/vet: print: permit '#' flag in %e, %f, and %g · 7159ab48

Alan Donovan authored Sep 08, 2017

+ Test

Change-Id: I7b42ff70f26a58e1cf58cbbc53d02a65623456ae
Reviewed-on: https://go-review.googlesource.com/62371
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

7159ab48

cmd/compile: request r12 for indirect calls on ppc64le · b74b43de

Lynn Boger authored Sep 11, 2017

On ppc64le, functions compiled with -shared expect r12 to
hold the function's address for indirect calls. Previously
this was enforced by generating a move instruction if the
address wasn't already in r12. This change avoids that extra
move by requesting r12 in the CALL ops that do indirect calls.

As a result of adding support for plugins on ppc64le, it was
discovered that there would be more cases where this extra
move was needed, so this seemed like a better solution.

Updates #20756

Change-Id: I6770885a46990f78c6d2902a715dcdaa822192a1
Reviewed-on: https://go-review.googlesource.com/62890
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>

b74b43de

crypto/elliptic: temporarily disable s390x assembly · 81835302

Michael Munday authored Sep 10, 2017

This disables the s390x assembly. It will be re-enabled when #20215
is resolved on s390x.

Change-Id: I789eca2dd478004956107359fae98ed012f04abb
Reviewed-on: https://go-review.googlesource.com/62292
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

81835302

doc: hide content blocked by GFW when served in CN · 98603e7a

Andrew Bonventre authored Aug 29, 2017

Change-Id: Ia3d0fa0517d96f0672d3c5ce7e7b7bb8bd0ce093
Reviewed-on: https://go-review.googlesource.com/60070Reviewed-by: Chris Broadfoot <cbro@golang.org>

98603e7a

cmd/internal/obj/arm: support more ARM VFP instructions · f727fa79

Ben Shi authored Sep 09, 2017

Add support of more ARM VFP instructions in the assembler.
They were introduced in ARM VFPv4.

"FMULAF/FMULAD   Fm, Fn, Fd": Fd = Fd + Fn*Fm
"FNMULAF/FNMULAD Fm, Fn, Fd": Fd = -(Fd + Fn*Fm)
"FMULSF/FMULSD   Fm, Fn, Fd": Fd = Fd - Fn*Fm
"FNMULSF/FNMULSD Fm, Fn, Fd": Fd = -(Fd - Fn*Fm)

The multiplication results are not rounded.

Change-Id: Id9cc52fd8e1b9a708103cd1e514c85a9e1cb3f47
Reviewed-on: https://go-review.googlesource.com/62550Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

f727fa79

cmd/compile: optimize ARM code with NMULF/NMULD · 2899c3e8

Ben Shi authored Sep 02, 2017

NMULF and NMULD are efficient FP instructions, and the go compiler can
use them to generate better code.

The benchmark tests of my patch did not show general change, but big
improvement in special cases.

1.A special test case improved 12.6%.
https://github.com/benshi001/ugo1/blob/master/fpmul_test.go
name old time/op new time/op delta
FPMul-4 398µs ± 1% 348µs ± 1% -12.64% (p=0.000 n=40+40)

2. the compilecmp test showed little change.
name old time/op new time/op delta
Template 2.30s ± 1% 2.31s ± 1% ~ (p=0.754 n=17+19)
Unicode 1.31s ± 3% 1.32s ± 5% ~ (p=0.265 n=20+20)
GoTypes 7.73s ± 2% 7.73s ± 1% ~ (p=0.925 n=20+20)
Compiler 37.0s ± 1% 37.3s ± 2% +0.79% (p=0.002 n=19+20)
SSA 83.8s ± 4% 83.5s ± 2% ~ (p=0.964 n=20+17)
Flate 1.43s ± 2% 1.44s ± 1% ~ (p=0.602 n=20+20)
GoParser 1.82s ± 2% 1.81s ± 2% ~ (p=0.141 n=19+20)
Reflect 5.08s ± 2% 5.08s ± 3% ~ (p=0.835 n=20+19)
Tar 2.36s ± 1% 2.35s ± 1% ~ (p=0.195 n=18+17)
XML 2.57s ± 2% 2.56s ± 1% ~ (p=0.283 n=20+17)
[Geo mean] 4.74s 4.75s +0.05%

name old user-time/op new user-time/op delta
Template 2.75s ± 2% 2.75s ± 0% ~ (p=0.620 n=20+15)
Unicode 1.59s ± 4% 1.60s ± 4% ~ (p=0.479 n=20+19)
GoTypes 9.48s ± 1% 9.47s ± 1% ~ (p=0.743 n=20+20)
Compiler 45.7s ± 1% 45.7s ± 1% ~ (p=0.482 n=19+20)
SSA 109s ± 1% 109s ± 2% ~ (p=0.800 n=18+20)
Flate 1.67s ± 3% 1.67s ± 3% ~ (p=0.598 n=19+18)
GoParser 2.15s ± 4% 2.13s ± 3% ~ (p=0.153 n=20+20)
Reflect 5.95s ± 2% 5.95s ± 2% ~ (p=0.961 n=19+20)
Tar 2.93s ± 2% 2.92s ± 3% ~ (p=0.242 n=20+19)
XML 3.02s ± 3% 3.04s ± 3% ~ (p=0.233 n=19+18)
[Geo mean] 5.74s 5.74s -0.04%

name old text-bytes new text-bytes delta
HelloSize 588kB ± 0% 588kB ± 0% ~ (all equal)

name old data-bytes new data-bytes delta
HelloSize 5.46kB ± 0% 5.46kB ± 0% ~ (all equal)

name old bss-bytes new bss-bytes delta
HelloSize 72.9kB ± 0% 72.9kB ± 0% ~ (all equal)

name old exe-bytes new exe-bytes delta
HelloSize 1.03MB ± 0% 1.03MB ± 0% ~ (all equal)

3. The go1 benchmark showed little change in total.
name old time/op new time/op delta
BinaryTree17-4 41.8s ± 1% 41.8s ± 1% ~ (p=0.388 n=40+39)
Fannkuch11-4 24.1s ± 1% 24.1s ± 1% ~ (p=0.077 n=40+40)
FmtFprintfEmpty-4 834ns ± 1% 831ns ± 1% -0.31% (p=0.002 n=40+37)
FmtFprintfString-4 1.34µs ± 1% 1.34µs ± 0% ~ (p=0.387 n=40+40)
FmtFprintfInt-4 1.44µs ± 1% 1.44µs ± 1% ~ (p=0.421 n=40+40)
FmtFprintfIntInt-4 2.09µs ± 0% 2.09µs ± 1% ~ (p=0.589 n=40+39)
FmtFprintfPrefixedInt-4 2.32µs ± 1% 2.33µs ± 1% +0.15% (p=0.001 n=40+40)
FmtFprintfFloat-4 4.51µs ± 0% 4.44µs ± 1% -1.50% (p=0.000 n=40+40)
FmtManyArgs-4 7.94µs ± 0% 7.97µs ± 0% +0.36% (p=0.001 n=32+40)
GobDecode-4 104ms ± 1% 102ms ± 2% -1.27% (p=0.000 n=39+37)
GobEncode-4 90.5ms ± 1% 90.9ms ± 2% +0.40% (p=0.006 n=37+40)
Gzip-4 4.10s ± 2% 4.08s ± 1% -0.30% (p=0.004 n=40+40)
Gunzip-4 603ms ± 0% 602ms ± 1% ~ (p=0.303 n=37+40)
HTTPClientServer-4 672µs ± 3% 658µs ± 2% -2.08% (p=0.000 n=39+37)
JSONEncode-4 238ms ± 1% 239ms ± 0% +0.26% (p=0.001 n=40+25)
JSONDecode-4 884ms ± 1% 885ms ± 1% +0.16% (p=0.012 n=40+40)
Mandelbrot200-4 49.3ms ± 0% 49.3ms ± 0% ~ (p=0.588 n=40+38)
GoParse-4 46.3ms ± 1% 46.4ms ± 2% ~ (p=0.487 n=40+40)
RegexpMatchEasy0_32-4 1.28µs ± 1% 1.28µs ± 0% +0.12% (p=0.003 n=40+40)
RegexpMatchEasy0_1K-4 7.78µs ± 5% 7.78µs ± 4% ~ (p=0.825 n=40+40)
RegexpMatchEasy1_32-4 1.29µs ± 1% 1.29µs ± 0% ~ (p=0.659 n=40+40)
RegexpMatchEasy1_1K-4 10.3µs ± 3% 10.4µs ± 2% ~ (p=0.266 n=40+40)
RegexpMatchMedium_32-4 2.05µs ± 1% 2.05µs ± 0% -0.18% (p=0.002 n=40+28)
RegexpMatchMedium_1K-4 533µs ± 1% 534µs ± 1% ~ (p=0.397 n=37+40)
RegexpMatchHard_32-4 28.9µs ± 1% 28.9µs ± 1% -0.22% (p=0.002 n=40+40)
RegexpMatchHard_1K-4 868µs ± 1% 870µs ± 1% +0.21% (p=0.015 n=40+40)
Revcomp-4 67.3ms ± 1% 67.2ms ± 2% ~ (p=0.262 n=38+39)
Template-4 1.07s ± 1% 1.07s ± 1% ~ (p=0.276 n=40+40)
TimeParse-4 7.16µs ± 1% 7.16µs ± 1% ~ (p=0.610 n=39+40)
TimeFormat-4 13.3µs ± 1% 13.3µs ± 1% ~ (p=0.617 n=38+40)
[Geo mean] 720µs 719µs -0.13%

name old speed new speed delta
GobDecode-4 7.39MB/s ± 1% 7.49MB/s ± 2% +1.25% (p=0.000 n=39+38)
GobEncode-4 8.48MB/s ± 1% 8.45MB/s ± 2% -0.40% (p=0.005 n=37+40)
Gzip-4 4.74MB/s ± 2% 4.75MB/s ± 1% +0.30% (p=0.018 n=40+40)
Gunzip-4 32.2MB/s ± 0% 32.2MB/s ± 1% ~ (p=0.272 n=36+40)
JSONEncode-4 8.15MB/s ± 1% 8.13MB/s ± 0% -0.26% (p=0.003 n=40+25)
JSONDecode-4 2.19MB/s ± 1% 2.19MB/s ± 1% ~ (p=0.676 n=40+40)
GoParse-4 1.25MB/s ± 2% 1.25MB/s ± 2% ~ (p=0.823 n=40+40)
RegexpMatchEasy0_32-4 25.1MB/s ± 1% 25.1MB/s ± 0% -0.12% (p=0.006 n=40+40)
RegexpMatchEasy0_1K-4 132MB/s ± 5% 132MB/s ± 5% ~ (p=0.821 n=40+40)
RegexpMatchEasy1_32-4 24.7MB/s ± 1% 24.7MB/s ± 0% ~ (p=0.630 n=40+40)
RegexpMatchEasy1_1K-4 99.1MB/s ± 3% 98.8MB/s ± 2% ~ (p=0.268 n=40+40)
RegexpMatchMedium_32-4 487kB/s ± 2% 490kB/s ± 0% +0.51% (p=0.001 n=40+40)
RegexpMatchMedium_1K-4 1.92MB/s ± 1% 1.92MB/s ± 1% ~ (p=0.208 n=39+40)
RegexpMatchHard_32-4 1.11MB/s ± 1% 1.11MB/s ± 0% +0.36% (p=0.000 n=40+33)
RegexpMatchHard_1K-4 1.18MB/s ± 1% 1.18MB/s ± 1% ~ (p=0.207 n=40+37)
Revcomp-4 37.8MB/s ± 1% 37.8MB/s ± 2% ~ (p=0.276 n=38+39)
Template-4 1.82MB/s ± 1% 1.81MB/s ± 1% ~ (p=0.122 n=38+40)
[Geo mean] 6.81MB/s 6.81MB/s +0.06%

fixes #19843

Change-Id: Ief3a0c2b15f59d40c7b40f2784eeb71196685b59
Reviewed-on: https://go-review.googlesource.com/61150Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

2899c3e8

misc/cgo/testcshared: actually run test executable on android · 538b4bab

Alex Brainman authored Sep 11, 2017

CL 62593 broken TestExportedSymbols and TestUnexportedSymbols
because it started executing android test binary on host.
Make them run on android.

Hopefully fixes android build.

Change-Id: Ic0bb9f0cbbefca23828574282caa33a03ef72431
Reviewed-on: https://go-review.googlesource.com/62830
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Elias Naur <elias.naur@gmail.com>

538b4bab

doc: fix typo in the diagnostics guide · e9163928

Jaana Burcu Dogan authored Sep 09, 2017

Change-Id: Ib1b93e55788168b574badeb84d0e6c4f3795055e
Reviewed-on: https://go-review.googlesource.com/62510Reviewed-by: Ian Lance Taylor <iant@golang.org>

e9163928

misc/cgo/testcshared: simlpify cshared_test.go · 40a7de7b

Alex Brainman authored Sep 11, 2017

Change-Id: Ib35bb7fc9c5b4ccc9b8e1bd16443e0b307be9406
Reviewed-on: https://go-review.googlesource.com/62593Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

40a7de7b

cmd/cgo: treat simple C typedefs as go aliases · 57fa1c7c

Anthony Sottile authored Sep 09, 2017

Fixes #21809

Change-Id: Ic43077c6bea3c7cdc9611e74abf07b6deab70433
Reviewed-on: https://go-review.googlesource.com/62670
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

57fa1c7c

test: add test case that gccgo crashed on · c6d019aa

Ian Lance Taylor authored Sep 10, 2017

Change-Id: I4d5d40e1ed3f58b2cdecd6248cb25c8ae9a1b9a1
Reviewed-on: https://go-review.googlesource.com/62531Reviewed-by: David Crawshaw <crawshaw@golang.org>

c6d019aa

cmd/compile: preserve escape information for map literals · 09812610

Martin Möhrmann authored Sep 10, 2017

While some map literals were marked non-escaping that information
was lost when creating the corresponding OMAKE node which made map
literals always heap allocated.

Copying the escape information to the corresponding OMAKE node allows
stack allocation of hmap and a map bucket for non escaping map literals.

Fixes #21830

Change-Id: Ife0b020fffbc513f1ac009352f2ecb110d6889c9
Reviewed-on: https://go-review.googlesource.com/62790
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

09812610

internal/cpu: add support for x86 FMA cpu feature detection · 1a3230f2

Martin Möhrmann authored Sep 09, 2017

Change-Id: I88ea39de01b07e6afa1c187c0df6a258da4aa8e4
Reviewed-on: https://go-review.googlesource.com/62650
Run-TryBot: Martin Möhrmann <moehrmann@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>

1a3230f2

cmd/link: don't generate runtime.text twice for buildmode=plugin on darwin · f797e485

Hiroshi Ioka authored Sep 11, 2017

https://golang.org/cl/29394 changed to include runtime.text and
runtime.etext in ctxt.Textp as a work around.
But it seems that the CL forgot to change genasmsym.
As a result, we are generating runtime.text and runtime.etext twice.

Change-Id: If7f8faf496c1c489ffa4804da712f91a3d3f4be4
Reviewed-on: https://go-review.googlesource.com/62810Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

f797e485

10 Sep, 2017 10 commits

misc/cgo/testcshared: run tests in parallel · e27a8122

Alex Brainman authored Sep 10, 2017

Change-Id: Id1b5939cfcd210a0cb5f61915ce2d077c7fcec11
Reviewed-on: https://go-review.googlesource.com/62592Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

e27a8122

cmd/link: remove windows-specific kludges from Adddynrel · 410b7372

Hiroshi Ioka authored Sep 10, 2017

Adddynrel does nothing on windows. We can make code don't call Adddynrel
on windows in the first place.

Change-Id: I376cc36d44a5df18bda13be57e3916ca3062f181
Reviewed-on: https://go-review.googlesource.com/62611
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

410b7372

syscall: fix TestCloneNEWUSERAndRemapRootEnableSetgroups on linux · 8435a746

Hiroshi Ioka authored Jan 17, 2017

Despite its name, it did the same thing as
TestCloneNEWUSERAndRemapRootDisableSetgroups in old code. So fix it.

Change-Id: I21265e539179c51980e16f07a553a9bf5bb7903f
Reviewed-on: https://go-review.googlesource.com/35273
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>

8435a746

misc/cgo/testplugin: pass GO_GCFLAGS · 753bac3a

David Crawshaw authored Sep 09, 2017

The noopt builder sets GO_GCFLAGS when building the standard library.
Set it when building plugins to ensure the -shared packages built for it
have the same inlining in the export data (and thus the same package
version).

Tested locally with GO_GCFLAGS="-N -l" ./all.bash

Fixes #17937

Change-Id: Id037cfbf4af744c05c47bdc58eea60a5dba69533
Reviewed-on: https://go-review.googlesource.com/62511
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

753bac3a

cmd/go, cmd/link, cmd/dist: re-enable plugin mode on darwin/amd64 · 1134411a

Hiroshi Ioka authored Sep 04, 2017

1. remove broken verification
   The runtime check assumes that no-pcln symbol entry have zero value,
   but the linker emit no entries if the symbol is no-pcln.
   As a result, if there are no-pcln symbols at the very end of pcln
   table, it will panic.
2. correct condition of export
   Handle special chracters in pluginpath correcty.
   Export "go.itab.*", so different plugins can share the same itab.

Fixes #18190

Change-Id: Ia4f9c51d83ce8488a9470520f1ee9432802cfc1d
Reviewed-on: https://go-review.googlesource.com/61091Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

1134411a

cmd/internal/goobj: parse native objects in the archive · 1053ae5c

Hiroshi Ioka authored Sep 10, 2017

Also add HasCGO() to internal/testenv for tests.

Updates #21706

Change-Id: I938188047024052bdb42b3ac1a77708f3c2a6dbb
Reviewed-on: https://go-review.googlesource.com/62591
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

1053ae5c

cmd/go: check compiler flags per compilers in gccSupportsFlag · d254c613

Hiroshi Ioka authored Sep 03, 2017

Current code always uses a C compilers for checking compiler flags even
for non-C compilers. This CL solves the issue.

Fixes #21736

Change-Id: I5eaddd5fe7d5df699eb2384518b21e6064ca31cf
Reviewed-on: https://go-review.googlesource.com/61270Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

d254c613

cmd/internal/goobj: skip tests on some $GOOS/arm · 43807e0f

Hiroshi Ioka authored Sep 09, 2017

Updates #21817

Change-Id: I77ffaf8a7e54465a5b73691b896edcb20c29440f
Reviewed-on: https://go-review.googlesource.com/62351Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

43807e0f

log: move Ldate doc to general declaration · 04212a16

Will Faught authored Sep 10, 2017

The Ldate doc refers to all the constants.

Note that I changed "Bits or'ed" to "Bits are or'ed".

Fixes #21810

Change-Id: I82a66b589689e29063a39aa6d56000e00a5ed150
Reviewed-on: https://go-review.googlesource.com/62671Reviewed-by: Ian Lance Taylor <iant@golang.org>

04212a16

misc/cgo/testcshared: use TestMain · d0285161

Alex Brainman authored Aug 19, 2017

This CL uses TestMain to create and remove
pkg directory and libgo.so file.

Fixes #21531

Change-Id: I833cfb22b55d8eef98348dad4d56327ac4c07b36
Reviewed-on: https://go-review.googlesource.com/57270Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

d0285161

09 Sep, 2017 5 commits

time: add a number of new examples · 7758abf3

Adrian Hesketh authored Sep 02, 2017

Change-Id: I14d19a3951fcae24e2c2ce2eb76312851e050fdd
Reviewed-on: https://go-review.googlesource.com/61033Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

7758abf3

crypto/x509: store names in signatureAlgorithmDetails. · 4933da68

Adam Langley authored Aug 18, 2017

There is already a table of signature algorithm details so the code
should use it for the name too. This avoids mismatches.

Change-Id: I0d4befbae721ec43db9f87cd93173ec12749e4c8
Reviewed-on: https://go-review.googlesource.com/57210
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

4933da68

crypto/x509: get hash information from signatureAlgorithmDetails and check that it matches · 083ad286

Adam Langley authored Aug 18, 2017

signatureAlgorithmDetails already knows the hash function for each
signature algorithm so there's no point in duplicating that. Also, check
that the public key type of the signature algorithm actually matches the
given public key.

Change-Id: I7aab4ea71691fb815d67ba790b721ce02de11b85
Reviewed-on: https://go-review.googlesource.com/57211Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

083ad286

crypto/tls: fix clientHelloMsg fuzzer not to generate the RI SCSV · 0f9a2cf2

EKR authored Jan 11, 2017

It was causing mysterious fuzzing failure because it affects the
unmarshaling of the secureNegotiationSupported field.

Change-Id: Id396b84eab90a3b22fb6e306b10bdd7e39707012
Reviewed-on: https://go-review.googlesource.com/60912
Run-TryBot: Filippo Valsorda <hi@filippo.io>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>

0f9a2cf2

crypto/tls: fix and expand TestVerifyPeerCertificate and TestGetClientCertificate · e7d46cee

Filippo Valsorda authored Jul 04, 2017

TestGetClientCertificate had disabled verification, and was only passing
because it was mistakenly checking for empty verifiedChains.

Change-Id: Iea0ddbdbbdf8ac34b499569820a2e4ce543a69c7
Reviewed-on: https://go-review.googlesource.com/47430
Run-TryBot: Filippo Valsorda <hi@filippo.io>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>

e7d46cee