Commits · 77d38d9cbe9b4047e7155569e7b9485093807e17 · Kirill Smelkov / go

22 Jul, 2015 23 commits

runtime: handle linux CPU masks up to 64k CPUs · 77d38d9c

Russ Cox authored Jul 22, 2015

Fixes #11823.

Change-Id: Ic949ccb9657478f8ca34fdf1a6fe88f57db69f24
Reviewed-on: https://go-review.googlesource.com/12535Reviewed-by: Austin Clements <austin@google.com>

77d38d9c

net/mail: enhanced Address.String and ParseAddress to match RFC 5322 · daaa4507

MathiasB authored Apr 10, 2015

Updated Address.String so it restores quoted local parts, which wasn't
done before.
When parsing `<" "@example.com>`, the formatted string returned
`< @example>`, which doens't match RFC 5322, since a space is not atext.
Another example is `<"bob@valid"@example.com>` which returned
`<bob@valid@example.com>`, which is completely invalid.
I also added support for quotes and backslashes in a quoted local part.

Besides formatting a parsed Address, the ParseAddress function also
needed more testing and finetuning for special cases.
Things like `<.john.doe@example.com>` and `<john..doe@example.com>`
e.a. were accepted, but are invalid.
I fixed those details and add tests for some other special cases.

Fixes #10768

Change-Id: Ib0caf8ad603eb21e32fcb957a5f1a0fe5d1c6e6e
Reviewed-on: https://go-review.googlesource.com/8724Reviewed-by: Russ Cox <rsc@golang.org>

daaa4507

net: do not look up abc by default · 5201bf7a

Russ Cox authored Jul 20, 2015

Fixes #11665.

Change-Id: I0897e8cf695434e77d14dcb1d96f21747edfe37c
Reviewed-on: https://go-review.googlesource.com/12523Reviewed-by: Ian Lance Taylor <iant@golang.org>

5201bf7a

runtime/cgo: make compatible with race detector · 75d77956

Russ Cox authored Jul 22, 2015

Some routines run without and m or g and cannot invoke the
race detector runtime. They must be opaque to the runtime.
That used to be true because they were written in C.
Now that they are written in Go, disable the race detector
annotations for those functions explicitly.

Add test.

Fixes #10874.

Change-Id: Ia8cc28d51e7051528f9f9594b75634e6bb66a785
Reviewed-on: https://go-review.googlesource.com/12534Reviewed-by: Ian Lance Taylor <iant@golang.org>

75d77956

cmd/link: elide individual gcbits symbols · 0acecb71

Russ Cox authored Jul 22, 2015

Same as we do for string symbols.

Fixes #11583.

Change-Id: Ia9264f6faf486697d987051b7f9851d37d8ad381
Reviewed-on: https://go-review.googlesource.com/12531Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

0acecb71

runtime/pprof: ignore too few samples on Windows test · 3b26e8b2

Russ Cox authored Jul 22, 2015

Fixes #10842.

Change-Id: I7de98f3073a47911863a252b7a74d8fdaa48c86f
Reviewed-on: https://go-review.googlesource.com/12529Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

3b26e8b2

runtime: if we don't handle a signal on a non-Go thread, raise it · 872b168f

Ian Lance Taylor authored Jul 21, 2015

In the past badsignal would crash the program.  In
https://golang.org/cl/10757044 badsignal was changed to call sigsend,
to fix issue #3250.  The effect of this was that when a non-Go thread
received a signal, and os/signal.Notify was not being used to check
for occurrences of the signal, the signal was ignored.

This changes the code so that if os/signal.Notify is not being used,
then the signal handler is reset to what it was, and the signal is
raised again.  This lets non-Go threads handle the signal as they
wish.  In particular, it means that a segmentation violation in a
non-Go thread will ordinarily crash the process, as it should.

Fixes #10139.
Update #11794.

Change-Id: I2109444aaada9d963ad03b1d071ec667760515e5
Reviewed-on: https://go-review.googlesource.com/12503Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>

872b168f

cmd/go: support git.apache.org Git repos · 428ed1e3

Konstantin Shaposhnikov authored May 15, 2015

This change fixes resolution of secure (https) repo URL for
git.apache.org Git repositories.

E.g. the correct repo URL for git.apache.org/thrift.git/lib/go/thrift is
https://git.apache.org/thrift.git, not https://git.apache.org/thrift

Fixes #10797

Change-Id: I67d5312ad8620eb780e42c2e002c8f286f60645a
Reviewed-on: https://go-review.googlesource.com/10092Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

428ed1e3

math/big: document rounding for Rat.FloatToString · f35bc3ee

Robert Griesemer authored Jul 22, 2015

Fixes #11523.

Change-Id: I172f6facd555a1c6db76f25d5097343c20dea59a
Reviewed-on: https://go-review.googlesource.com/12507Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>

f35bc3ee

runtime: disable TestGoroutineParallelism on uniprocessor · 4a4eba9f

Russ Cox authored Jul 20, 2015

It's a bad test and it's worst on uniprocessors.

Fixes #11143.

Change-Id: I0164231ada294788d7eec251a2fc33e02a26c13b
Reviewed-on: https://go-review.googlesource.com/12522Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

4a4eba9f

runtime: fix comments referring to trace functions in runtime/pprof · 58f3a829

Austin Clements authored Jul 22, 2015

ae1ea2aa moved trace-related functions from runtime/pprof to
runtime/trace, but missed a doc comment and a code comment. Update
these to reflect the move.

Change-Id: I6e1e8861e5ede465c08a2e3f80b976145a8b32d8
Reviewed-on: https://go-review.googlesource.com/12525Reviewed-by: Dmitry Vyukov <dvyukov@google.com>

58f3a829

doc: add line break in install-source.html · 4230c73f

Hari haran authored Jul 22, 2015

Change-Id: I8633a005da7d0c34a5f074fbd979c8e0fc1fba37
Reviewed-on: https://go-review.googlesource.com/12505Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

4230c73f

cmd/dist: add command output for dist tests · 1e9f59a7

Ingo Krabbe authored Jul 22, 2015

It is very useful to see which test commands are executed.
This is of global use, but I wrote it for #11654.

Change-Id: I9bfc8e55d5bef21f4c49b917f58bc9a44aefcade
Reviewed-on: https://go-review.googlesource.com/12510Reviewed-by: Russ Cox <rsc@golang.org>

1e9f59a7

crypto/elliptic: call IsOnCurve via the interface. · bad52b35

Adam Langley authored Jul 22, 2015

https://go-review.googlesource.com/#/c/2421/ contains an unfortunate
slip where IsOnCurve is called on the CurveParams rather than the curve.
This doesn't really matter, but it's a pain for people doing tricks with
crypto/elliptic and means that 1.5 would be a regression for them
without this change.

See https://groups.google.com/forum/#!topic/golang-dev/i8OPUTYctOk

Change-Id: Ifa5f25f9a95d7484cb53d4883cfd78dc58a0f9a7
Reviewed-on: https://go-review.googlesource.com/12506Reviewed-by: Russ Cox <rsc@golang.org>

bad52b35

crypto/x509: disable sha2 test with system APIs · a502fb21

Russ Cox authored Jul 22, 2015

Fixes #11730.

Change-Id: I5bc60779a87dc07899dd70659a830996bf7812ca
Reviewed-on: https://go-review.googlesource.com/12527Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

a502fb21

cmd/go: fix missing internal import error · d7094343

Russ Cox authored Jul 20, 2015

Fixes #11331.

Change-Id: I19b8172421044c301bc136fc8f7bfdadbf880e25
Reviewed-on: https://go-review.googlesource.com/12450Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>

d7094343

crypto/tls: check cert chain during VerifyHostname · 3cf15b57

Russ Cox authored Jul 22, 2015

Fixes #9063.

Change-Id: I536ef1f0b30c94c1ebf7922d84cb2f701b7d8a1a
Reviewed-on: https://go-review.googlesource.com/12526Reviewed-by: Adam Langley <agl@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

3cf15b57

strconv: add examples to package · 1c890076

Carlos C authored Jun 23, 2015

Change-Id: I69a2b6a99a53c875162be8a7d86455559cd74504
Reviewed-on: https://go-review.googlesource.com/11371Reviewed-by: Russ Cox <rsc@golang.org>

1c890076

runtime/trace: add new package · ae1ea2aa

Dmitry Vyukov authored Jul 22, 2015

Move tracing functions from runtime/pprof to the new runtime/trace package.

Fixes #9710

Change-Id: I718bcb2ae3e5959d9f72cab5e6708289e5c8ebd5
Reviewed-on: https://go-review.googlesource.com/12511Reviewed-by: Russ Cox <rsc@golang.org>

ae1ea2aa

encoding/json: fix decoding of JSON null values · 1a99ba55

Didier Spezia authored Apr 28, 2015

JSON decoding currently fails for null values bound to any type
which does implement the JSON Unmarshaler interface without checking
for null values (such as time.Time).

It also fails for types implementing the TextUnmarshaler interface.

The expected behavior of the JSON decoding engine in such case is
to process null by keeping the value unchanged without producing
any error.

Make sure null values are handled by the decoding engine itself,
and never passed to the UnmarshalText or UnmarshalJSON methods.

Fixes #9037

Change-Id: I261d85587ba543ef6f1815555b2af9311034d5bb
Reviewed-on: https://go-review.googlesource.com/9376Reviewed-by: Russ Cox <rsc@golang.org>

1a99ba55

misc/makerelease: delete · 1421bc10

Andrew Gerrand authored Jul 22, 2015

This is now superseded by golang.org/x/build/cmd/release.

Fixes #8472

Change-Id: I59664d84996a0fbb5c90582a4702714b3b3cf302
Reviewed-on: https://go-review.googlesource.com/12500Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

1421bc10

lib/time: update to IANA release 2015e. · 23f4e435

David Symonds authored Jul 22, 2015

Fixes #11810.

Change-Id: I8453e53a72e242a69ea34eb393999e7291d4358f
Reviewed-on: https://go-review.googlesource.com/12502
Run-TryBot: David Symonds <dsymonds@golang.org>
Reviewed-by: Rob Pike <r@golang.org>

23f4e435

doc: add a clause about embedded methods to go1compat · 6c7acdfb

Rob Pike authored Jul 21, 2015

This is a corner case but it is suggested we call it out.

Fixes #11798.

Change-Id: I2ddb5b363cd2921666dbf03bbf98107697ca40e5
Reviewed-on: https://go-review.googlesource.com/12460Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

6c7acdfb

21 Jul, 2015 13 commits

cmd/dist: remove prints during test registration · fc7f6d30

Brad Fitzpatrick authored Jul 21, 2015

dist test should not print (especially to stdout) during test
registration.  This confuses other tools interacting with dist using
dist test --list, etc.

Change-Id: Ie4f82c13e49590c23a7a235d90ddbc4f5ed81e0b
Reviewed-on: https://go-review.googlesource.com/12487Reviewed-by: Ian Lance Taylor <iant@golang.org>

fc7f6d30

cmd/go: fix typo in comment · c97b4997

Ian Lance Taylor authored Jul 21, 2015

Change-Id: I3d5e46d376953fbdd21ce8c161214eaed6378d84
Reviewed-on: https://go-review.googlesource.com/12490Reviewed-by: Andrew Gerrand <adg@golang.org>

c97b4997

cmd/go: pass an unmodified environment to a go run program · 419a6c07

Ian Lance Taylor authored Jul 21, 2015

Fixes #11709.
Fixed #11449.

Change-Id: If8fdb27d3dc25fb7017226d143a29cbebc1374c5
Reviewed-on: https://go-review.googlesource.com/12483Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

419a6c07

go/types: make types.Typ a slice, unexport UniverseByte/Rune · 0505dfc6

Robert Griesemer authored Jul 21, 2015

In lieu of the more invasive https://go-review.googlesource.com/#/c/12373/ .

Change-Id: I0221783fcaa8af04520c80cd2993d7d542d2c431
Reviewed-on: https://go-review.googlesource.com/12486Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

0505dfc6

cmd/go: skip TestGoInstallErrorOnCrossCompileToBin in short mode · 72921c66

Ian Lance Taylor authored Jul 21, 2015

That test will install cmd/pack for linux_386; we don't want to change
GOROOT in short mode.

Change-Id: I4b00c578a99779a13c558208bfd4115f8f0513fa
Reviewed-on: https://go-review.googlesource.com/12481
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

72921c66

misc/cgo/testsovar: needs the `extern` keyword to export variables on non-windows platforms · 2e38b351

Ingo Krabbe authored Jul 21, 2015

Change-Id: I87fa25214fbf24469148a63f4e1e61e261105c16
Reviewed-on: https://go-review.googlesource.com/12470
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

2e38b351

cmd/link: if -B option was used, pass it to the external linker · e9fcd6ed

Ian Lance Taylor authored Jul 15, 2015

Fixes #10607.

Change-Id: Ib294cf65b07103b60f62b86b21ff2d07b25136fe
Reviewed-on: https://go-review.googlesource.com/12242Reviewed-by: Russ Cox <rsc@golang.org>

e9fcd6ed

doc: add missing preposition in go1.5.html · aee4f42a

Brad Fitzpatrick authored Jul 20, 2015

Change-Id: I2f855b9ad1676b3c4efedd764ce99e21c104a4ec
Reviewed-on: https://go-review.googlesource.com/12446Reviewed-by: Rob Pike <r@golang.org>

aee4f42a

doc/go1.5.html: update the net.Dial release notes. · abf943aa

Paul Marks authored Jul 17, 2015

Change-Id: Ie02426b2b726170d858de96fdd8c51bfdf20d7dc
Reviewed-on: https://go-review.googlesource.com/12376Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

abf943aa

api: add go1.5.txt API file, reset next.txt · 852f383c

Brad Fitzpatrick authored Jul 17, 2015

Fixes #11752

Change-Id: If4196b4bbba4f1485608bfafa98fa54781177273
Reviewed-on: https://go-review.googlesource.com/12325Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>

852f383c

doc: remove mention of default GOMAXPROCS(1) in Effective Go · aa5118b1

Brad Fitzpatrick authored Jul 18, 2015

Fixes #11781

Change-Id: Idc46a6a4fb5bf1c4d394eadf2d860d7ef75c8ccf
Reviewed-on: https://go-review.googlesource.com/12390Reviewed-by: Rob Pike <r@golang.org>

aa5118b1

syscall: warn not to use FormatMessage · 7ebcf5ea

Alex Brainman authored Jul 13, 2015

Fixes #11147

Change-Id: Ib31160946a53f6f9b11daea211ff04d186b51b3f
Reviewed-on: https://go-review.googlesource.com/12067Reviewed-by: Ian Lance Taylor <iant@golang.org>

7ebcf5ea

go/internal/gccgoimporter: fix handling of "byte" and "rune" alias types · af8297da

Matthew Dempsky authored Jul 20, 2015

Fixes #11762.

Change-Id: I0c7797a2dfdbbcf137bb287f854037a4a697c6e4
Reviewed-on: https://go-review.googlesource.com/12443Reviewed-by: Robert Griesemer <gri@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>

af8297da

20 Jul, 2015 4 commits

doc: document net/http.Request.Cancel in go1.5.html · e28ff1f3

Brad Fitzpatrick authored Jul 20, 2015

Change-Id: If1c12b43ef467c3ef2cbbaaba1bda4ea98032c7e
Reviewed-on: https://go-review.googlesource.com/12430Reviewed-by: Rob Pike <r@golang.org>

e28ff1f3

doc: add crypto/sha512 additions to go1.5.html · 1b5eaa43

Brad Fitzpatrick authored Jul 20, 2015

Change-Id: I805bb7ba40c8ed579c4ca796e408995586d219b3
Reviewed-on: https://go-review.googlesource.com/12434Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Rob Pike <r@golang.org>

1b5eaa43

go/types: remove non-existing mention of MethodSetCache from comment · 3051ab2c

Robert Griesemer authored Jul 20, 2015

Fixes #11800.

Change-Id: I5eb178331f4ae80821f188e19c0c6fadeb330278
Reviewed-on: https://go-review.googlesource.com/12433Reviewed-by: Alan Donovan <adonovan@google.com>

3051ab2c

cmd/dist: increase timeout for standard tests · 1a0818a4

Ian Lance Taylor authored Jul 20, 2015

The cmd/go tests run too long on a Raspberry Pi.  I've cut times as
much as I can see without more serious steps like not running tests.

Fixes #11779.

Change-Id: Ice5da052902decea2e6ac32d0f2ce084c39ea1ab
Reviewed-on: https://go-review.googlesource.com/12368
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

1a0818a4