- 14 Feb, 2013 6 commits
-
-
David Symonds authored
This is based on rsc's code posted to issue 2585. Benchmark results are greatly improved: benchmark old ns/op new ns/op delta BenchmarkSortString1K 564397 445897 -21.00% BenchmarkSortInt1K 270889 221249 -18.32% BenchmarkSortInt64K 26850765 21351967 -20.48% Eyeballing a sampling of the raw number of comparisons shows a drop on the order of 20-30% almost everywhere. The test input data that doesn't match that are some of sawtooth/rand/plateau distributions, where there is no change in the number of comparisons; that is, there are no situations where this makes *more* comparisons. Fixes #2585. R=iant, rsc CC=golang-dev https://golang.org/cl/7306098
-
Russ Cox authored
The column information can be misleading. R=golang-dev, dsymonds, r CC=golang-dev https://golang.org/cl/7300100
-
Russ Cox authored
Use local variable so that stack trace will show value of v. Fixes #4790. R=golang-dev, iant CC=golang-dev https://golang.org/cl/7300106
-
Brad Fitzpatrick authored
It used to be package "db" but was long ago renamed to be "sql". R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7322075
-
Brad Fitzpatrick authored
Fixes #4792 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7314093
-
Russ Cox authored
Fixes #4798. R=ken2 CC=golang-dev https://golang.org/cl/7323061
-
- 13 Feb, 2013 14 commits
-
-
Julien Schmidt authored
Completly the same like the Execer-Interface, just for Queries. This allows Drivers to execute Queries without preparing them first R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7085056
-
Dave Cheney authored
The test for issue 3590 causes an error to be printed to stderr when run (although the error is obscured during go test std). This is confusing for people who get breakage in the net package as the error is harmless and most likely unrelated to their build breakage. Given the way the test works, by reaching into the guts of the netFD, I can't see a way to silence the error without adding a bunch of code to support the test, therefore I am suggesting the test be removed before Go 1.1 ships. R=alex.brainman, mikioh.mikioh, rsc CC=golang-dev https://golang.org/cl/7307110
-
Mikio Hara authored
R=dave, bradfitz CC=golang-dev https://golang.org/cl/7305081
-
Brad Fitzpatrick authored
Changed accidentally in 28966b7b2f0c (CopyN using Copy). Updating docs to be consistent with 29bf5ff5064e (ReadFull & ReadAtLeast) R=rsc CC=golang-dev https://golang.org/cl/7314069
-
Lucio De Re authored
R=golang-dev, dave CC=golang-dev https://golang.org/cl/7304065
-
Brad Fitzpatrick authored
Update #3865 R=golang-dev, alex.brainman, nightlyone CC=golang-dev https://golang.org/cl/7324051
-
Robert Griesemer authored
Unexported field and method names that appear in the export data (as part of some exported type) are fully qualified with a package id (path). In some cases, a package with that id was never exported for any other use (i.e. only the path is of interest). We must not create a "real" package in those cases because we don't have a package name. Entering an unnamed package into the map of imported packages makes that package accessible for other imports. Such a subsequent import may find the unnamed package in the map, and reuse it. That reused and imported package is then entered into the importing file scope, still w/o a name. References to that package cannot resolved after that. Was bug. R=adonovan CC=golang-dev https://golang.org/cl/7307112
-
Dmitriy Vyukov authored
R=golang-dev, iant CC=golang-dev https://golang.org/cl/7322068
-
Christian Himpel authored
This behavior is identical to GNU tar 1.26. R=dsymonds, dave CC=golang-dev https://golang.org/cl/7307101
-
David Symonds authored
R=golang-dev, adg CC=golang-dev https://golang.org/cl/7225080
-
Alex Brainman authored
R=golang-dev, dave CC=golang-dev https://golang.org/cl/7323051
-
Alan Donovan authored
Operands returns the SSA values used by an instruction. Referrers returns the SSA instructions that use a value, for some values. These will be used for SSA renaming, to follow. R=iant, gri CC=golang-dev https://golang.org/cl/7312090
-
Robert Griesemer authored
R=adonovan CC=golang-dev https://golang.org/cl/7304089
-
Alex Brainman authored
Not everyone has the file (http://golang.org/issue/4723#c4). Update #4723. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7311091
-
- 12 Feb, 2013 10 commits
-
-
Alan Donovan authored
R=iant CC=golang-dev https://golang.org/cl/7307105
-
Shenghou Ma authored
Thanks Mitică for reporting this. R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7308081
-
Alan Donovan authored
Previously merely printing an error would cause the golden file comparison (in 'bash run') to fail, but that is no longer the case with the new run.go driver. R=iant CC=golang-dev https://golang.org/cl/7310087
-
Shenghou Ma authored
R=golang-dev, rsc, dave CC=golang-dev https://golang.org/cl/7229082
-
Shenghou Ma authored
R=golang-dev, rsc, dave CC=golang-dev https://golang.org/cl/7287044
-
Shenghou Ma authored
R=golang-dev, rsc, dave CC=golang-dev https://golang.org/cl/7288050
-
Shenghou Ma authored
R=rsc, dave CC=golang-dev https://golang.org/cl/7289044
-
Marcel van Lohuizen authored
into separate package. This allows this code to be shared with the search package without the need for these two to use the same tables. Adjusted various files accordingly. R=rsc CC=golang-dev https://golang.org/cl/7213044
-
Robert Griesemer authored
Fixes #4744. R=adonovan CC=golang-dev https://golang.org/cl/7305080
-
Alan Donovan authored
The lowering of ast.RangeStmt now has three distinct cases: 1) rangeIter for maps and strings; approximately: it = range x for { k, v, ok = next it if !ok { break } ... } The Range instruction and the interpreter's "iter" datatype are now restricted to these types. 2) rangeChan for channels; approximately: for { k, ok = <-x if !ok { break } ... } 3) rangeIndexed for slices, arrays, and *array; approximately: for k, l = 0, len(x); k < l; k++ { v = x[k] ... } In all cases we now evaluate the side effects of the range expression exactly once, per comments on http://code.google.com/p/go/issues/detail?id=4644. However the exact spec wording is still being discussed in https://golang.org/cl/7307083/. Further (small) changes may be required once the dust settles. R=iant CC=golang-dev https://golang.org/cl/7303074
-
- 11 Feb, 2013 10 commits
-
-
Alan Donovan authored
Details: - reorder.go: delete p8. (Once expectation is changed per b/4627 it is identical to p1.) - switch.go: added some more (degenerate) switches. - range.go: improved error messages in a few cases. - method.go: added tests of calls to promoted methods. R=iant CC=golang-dev https://golang.org/cl/7306087
-
Rob Pike authored
Simplify the internal logic for flags controlling what to vet, by introducing a map of flags that gathers them all together. This change should simplify the process of adding further flags. Add a test for untagged struct literals. Delete a redundant test that was also in the wrong file. Clean up some ERROR patterns that weren't working. "make test" passes again. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7305075
-
Robin Eklind authored
R=golang-dev, bradfitz, dave CC=golang-dev https://golang.org/cl/7303065
-
Russ Cox authored
Fixes #4762. R=daniel.morsing, adg CC=golang-dev https://golang.org/cl/7308045
-
Russ Cox authored
This is documenting the status quo. The previous cleanup added this language as an implementation restriction, but at least for now it is really part of the language proper. Fixes #4605. R=golang-dev, r CC=golang-dev https://golang.org/cl/7305071
-
Russ Cox authored
The gc compilers already behave this way. It was an explicit decision during the very long constant design discussions, but it appears not to have made it into the spec. Fixes #4398. R=golang-dev, r CC=golang-dev https://golang.org/cl/7313069
-
Russ Cox authored
Fixes #4586. R=golang-dev, remyoudompheng, r CC=golang-dev https://golang.org/cl/7307082
-
Andrew Gerrand authored
R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/7300084
-
Andrew Gerrand authored
R=golang-dev, minux.ma CC=golang-dev https://golang.org/cl/7306078
-
Nigel Tao authored
sub-repo. The matching change is at https://golang.org/cl/7310063 The rationale was discussed at https://groups.google.com/d/topic/golang-nuts/Qq5hTQyPuLg/discussion R=adg, dave CC=golang-dev https://golang.org/cl/7317043
-