1. 01 Nov, 2011 3 commits
    • Russ Cox's avatar
      gopack: change archive file name length back to 16 · 7b04471d
      Russ Cox authored
      This CL grew the archive file name length from 16 to 64:
      
              changeset:   909:58574851d792
              user:        Russ Cox <rsc@golang.org>
              date:        Mon Oct 20 13:53:56 2008 -0700
      
      Back then, every x.go file in a package became an x.6 file
      in the archive.  It was important to be able to allow the
      use of long Go source file names, hence the increase in size.
      
      Today, all Go source files compile into a single _go_.6 file
      regardless of their names, so the archive file name length
      no longer needs to be long.  The longer name causes some
      problems on Plan 9, where the native archive format is the
      same but with 16-byte names, so revert back to 16.
      
      R=golang-dev, r
      CC=golang-dev
      https://golang.org/cl/5333050
      7b04471d
    • Russ Cox's avatar
      os: do not interpret 0-length read as EOF · 4853c517
      Russ Cox authored
      Fixes #2402.
      
      R=golang-dev, bradfitz, r
      CC=golang-dev
      https://golang.org/cl/5298081
      4853c517
    • Andrew Balholm's avatar
      html: process </td> tags; foster parent at most one node per token · 9db3f78c
      Andrew Balholm authored
      Correctly close table cell when </td> is read.
      
      Because of reconstructing the active formatting elements, more than one
      node may be created when reading a single token.
      If both nodes are foster parented, they will be siblings, but the first
      node should be the parent of the second.
      
      Pass tests1.dat, test 77:
      <a href="blah">aba<table><a href="foo">br<tr><td></td></tr>x</table>aoe
      
      | <html>
      |   <head>
      |   <body>
      |     <a>
      |       href="blah"
      |       "aba"
      |       <a>
      |         href="foo"
      |         "br"
      |       <a>
      |         href="foo"
      |         "x"
      |       <table>
      |         <tbody>
      |           <tr>
      |             <td>
      |     <a>
      |       href="foo"
      |       "aoe"
      
      R=nigeltao
      CC=golang-dev
      https://golang.org/cl/5305074
      9db3f78c
  2. 31 Oct, 2011 13 commits
  3. 29 Oct, 2011 1 commit
    • Dave Cheney's avatar
      exp/ssh: fix length header leaking into channel data streams. · 0f6b80c6
      Dave Cheney authored
      The payload of a data message is defined as an SSH string type,
      which uses the first four bytes to encode its length. When channelData
      and channelExtendedData were added I defined Payload as []byte to
      be able to use it directly without a string to []byte conversion. This
      resulted in the length data leaking into the payload data.
      
      This CL fixes the bug, and restores agl's original fast path code.
      
      Additionally, a bug whereby s.lock was not released if a packet arrived
      for an invalid channel has been fixed.
      
      Finally, as they were no longer used, I have removed
      the channelData and channelExtedendData structs.
      
      R=agl, rsc
      CC=golang-dev
      https://golang.org/cl/5330053
      0f6b80c6
  4. 28 Oct, 2011 17 commits
  5. 27 Oct, 2011 6 commits
    • Andrew Balholm's avatar
      html: allow whitespace text nodes in <head> · 053549ca
      Andrew Balholm authored
      Pass tests1.dat, test 50:
      <!DOCTYPE html><script> <!-- </script> --> </script> EOF
      
      | <!DOCTYPE html>
      | <html>
      |   <head>
      |     <script>
      |       " <!-- "
      |     " "
      |   <body>
      |     "-->  EOF"
      
      Also pass tests through test 54:
      <!DOCTYPE html><title>U-test</title><body><div><p>Test<u></p></div></body>
      
      R=nigeltao
      CC=golang-dev
      https://golang.org/cl/5311066
      053549ca
    • Alex Brainman's avatar
      misc/windows: allow to be used for amd64 · c92a499b
      Alex Brainman authored
      R=jdpoirier
      CC=golang-dev
      https://golang.org/cl/5305048
      c92a499b
    • Russ Cox's avatar
      spec: define that initialization is sequential · b7ef3c9a
      Russ Cox authored
      This is true of the existing implementations, and I think
      it is an important property to guarantee.
      
      R=golang-dev, r, borman, r
      CC=golang-dev
      https://golang.org/cl/5321058
      b7ef3c9a
    • Russ Cox's avatar
      go/parser: test and fix := scoping bug · fd31d9fd
      Russ Cox authored
      R=iant
      CC=golang-dev, gri
      https://golang.org/cl/5327048
      fd31d9fd
    • Julian Phillips's avatar
      goinstall: More intelligent vcs selection for common sites · d066e02a
      Julian Phillips authored
      goinstall has built in support for a few common code hosting sites.  The
      identification of which vcs tool should be used was based purely on a
      regex match against the provided import path.  The problem with this
      approach is that it requires distinct import paths for different vcs
      tools on the same site.
      
      Since bitbucket has recently starting hosting Git repositories under the
      same bitbucket.org/user/project scheme as it already hosts Mercurial
      repositories, now would seem a good time to take a more flexible
      approach.
      
      We still match the import path against a list of regexes, but now the
      match is purely to distinguish the different hosting sites.  Once the
      site is identified, the specified function is called with the repo and
      path matched out of the import string.  This function is responsible for
      creating the vcsMatch structure that tells us what we need to download
      the code.
      
      For github and launchpad, only one vcs tool is currently supported, so
      these functions can simply return a vcsMatch structure.  For googlecode,
      we retain the behaviour of determing the vcs from the import path - but
      now it is done by the function instead of the regex.  For bitbucket, we
      use api.bitbucket.org to find out what sort of repository the specified
      import path corresponds to - and then construct the appropriate vcsMatch
      structure.
      
      R=golang-dev, adg
      CC=golang-dev, rsc
      https://golang.org/cl/5306069
      d066e02a
    • Andrew Gerrand's avatar
      doc: fix escaping in weekly.html · 1e900b0d
      Andrew Gerrand authored
      R=golang-dev, dsymonds
      CC=golang-dev
      https://golang.org/cl/5306070
      1e900b0d