Skip to content

GitLab

Switch branch/tag
  1. 29 Jul, 2019 2 commits
  3. 28 Jul, 2019 1 commit
  5. 27 Jul, 2019 2 commits
  7. 23 Jul, 2019 4 commits
  9. 22 Jul, 2019 2 commits
  11. 19 Jul, 2019 2 commits
    • Jay Conrod's avatar
      cmd/go: document go get @upgrade behavior in release notes · f518a96e
      Jay Conrod authored 
      Fixes #33149

Change-Id: If9ff24fea6d087b4047a9f6e50f99f449f9b1c52
Reviewed-on: https://go-review.googlesource.com/c/go/+/186618


Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarBryan C. Mills <bcmills@google.com>
      f518a96e
    • Austin Clements's avatar
      runtime: align allocations harder in GODEBUG=sbrk=1 mode · 5b15510d
      Austin Clements authored 
      Currently, GODEBUG=sbrk=1 mode aligns allocations by their type's
alignment. You would think this would be the right thing to do, but
because 64-bit fields are only 4-byte aligned right now (see #599),
this can cause a 64-bit field of an allocated object to be 4-byte
aligned, but not 8-byte aligned. If there is an atomic access to that
unaligned 64-bit field, it will crash.

This doesn't happen in normal allocation mode because the
size-segregated allocation and the current size classes will cause any
types larger than 8 bytes to be 8 byte aligned.

We fix this by making sbrk=1 mode use alignment based on the type's
size rather than its declared alignment. This matches how the tiny
allocator aligns allocations.

This was tested with

  GOARCH=386 GODEBUG=sbrk=1 go test sync/atomic

This crashes with an unaligned access before this change, and passes
with this change.

This should be reverted when/if we fix #599.

Fixes #33159.

Change-Id: Ifc52c72c6b99c5d370476685271baa43ad907565
Reviewed-on: https://go-review.googlesource.com/c/go/+/186919


Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: default avatarKeith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
      5b15510d
  13. 18 Jul, 2019 7 commits
  15. 17 Jul, 2019 4 commits
    • Jay Conrod's avatar
      cmd/go: include GOEXPERIMENT flags in tool id for cache key · 4814e7d5
      Jay Conrod authored 
      The go command invokes each tool with -V=full to discover its version
to compute a tool id. For release versions (that don't include the
word "devel"), the go command only used the third word in
the output (e.g., "go1.13"), ignoring any toolchain experiments that
followed. With this change, the go command will use whole version line
in the tool id for release versions.

Also, when -V=full is set and there are non-default experiments,
experiments are no longer printed twice.

Fixes #33091

Change-Id: I19b96f939c7e2fbc5d8befe3659156ee4b58daef
Reviewed-on: https://go-review.googlesource.com/c/go/+/186200


Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarBryan C. Mills <bcmills@google.com>
      4814e7d5
    • Joe Tsai's avatar
      net/http/httputil: fix regression in ReverseProxy.ServeHTTP · f93234ad
      Joe Tsai authored 
      In Go1.12 and below, the logic in ReverseProxy.ServeHTTP would always
allocate request.Header even if it were not present in the incoming request.
CL 174324 added http.Request.Clone and re-factors ReverseProxy.ServeHTTP
to use the new Clone method. However, the new Clone logic is not equivalent
to the former logic. We preserve former semantics by explicitly allocating
the Header map if nil.

Fixes #33142

Change-Id: I356f94a915dd9779584ce3fe31e56e5474b9ad37
Reviewed-on: https://go-review.googlesource.com/c/go/+/186437


Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: default avatarAndrew Bonventre <andybons@golang.org>
      f93234ad
    • Alberto Donizetti's avatar
      doc/go1.13: remove 1.12 reference from 1.13 release notes · 5bc46cb7
      Alberto Donizetti authored 
      While it's true that CL 168479 was also backported to 1.12, this is
irrelevant for the Go1.13 release notes.

Change-Id: I044be69f8f2bc005f58a0d63db05129add15f674
Reviewed-on: https://go-review.googlesource.com/c/go/+/186138

Reviewed-by: default avatarIan Lance Taylor <iant@golang.org>
      5bc46cb7
    • Dmitri Shuralyov's avatar
      CONTRIBUTORS: first round of updates for Go 1.13 · b5df14c3
      Dmitri Shuralyov authored 
      This update has been automatically generated using the updatecontrib
command:

	cd gotip
	go run golang.org/x/build/cmd/updatecontrib

With minor manual changes to canonicalize letter case for a few names.

Actions taken (relative to CONTRIBUTORS at origin/master):

	Added Ahsun Ahmed <ahmed.ahsun@gmail.com>
	Added Al Cutter <al@google.com>
	Added Alex Tokarev <aleksator@gmail.com>
	Added Alexander Lourier <aml@rulezz.ru>
	Added Alexander Rakoczy <alex@golang.org>
	Added Andrei Matei <andrei@cockroachlabs.com>
	Added Andrei Vagin <avagin@google.com>
	Added Andrew Z Allen <me@andrewzallen.com>
	Added Aofei Sheng <aofei@aofeisheng.com>
	Added Arash Bina <arash@arash.io>
	Added Benjamin Peterson <benjamin@python.org>
	Added Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
	Added Brandon Ryan <bjryan19@gmail.com>
	Added Bryan Heden <b.heden@gmail.com>
	Added Carlos Eduardo <me@carlosedp.com>
	Added Carrie Bynon <cbynon@gmail.com>
	Added Chris Marchesi <chri...
      b5df14c3
  17. 16 Jul, 2019 4 commits
  19. 15 Jul, 2019 6 commits
  21. 14 Jul, 2019 1 commit
  23. 12 Jul, 2019 3 commits
  25. 11 Jul, 2019 2 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7