- 19 Nov, 2019 14 commits
-
-
Bryan C. Mills authored
At one point (before GOCACHE), the '-i' flag meant, effectively, “save the intermediate results of this command to make future commands faster”. However, now that we require GOCACHE to be enabled everywhere, '-i' no longer has that meaning: the intermediate results are already saved in GOCACHE, so the -i flag merely adds extra work (copying or linking things from GOCACHE into pkg), and also adds additional failure modes resulting from that extra work (particularly when 'pkg' is read-only). Since the flag now causes more harm than good, omit it. Updates #30316 Change-Id: I295b6c0fc460dfc11ffa2a964cbb2a40f2935edc Reviewed-on: https://go-review.googlesource.com/c/go/+/207962 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Ian Lance Taylor authored
Change-Id: I71fc3016106db733b888f3daccc00b493abe39b2 Reviewed-on: https://go-review.googlesource.com/c/go/+/207840Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: I31e04c89f2cc226f9b5110f14c8b80a18e937efb Reviewed-on: https://go-review.googlesource.com/c/go/+/207960 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Jay Conrod <jayconrod@google.com>
-
Bryan C. Mills authored
This test runs 'go test -race -i runtime/race' and checks that it did not overwrite cmd/cgo. If GOROOT/pkg is read-only and GOROOT/pkg/$GOOS_$GOARCH_race is not already populated, as are the conditions if the Go toolchain was installed from source as root using 'make.bash', then 'go test -race -i' itself will fail because it cannot install packages to GOROOT/pkg. However, such a failure is not relevant to the test: even if 'go test -race -i' fails, we can still verify that it did not incidentally overwrite cmd/cgo. Updates #28387 Updates #30316 Change-Id: Iff2f75a0aeb4c926290ac3062c83695604522078 Reviewed-on: https://go-review.googlesource.com/c/go/+/207959 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: I48c6dd8619ea9602e9617ce11dfa05f1c70a485d Reviewed-on: https://go-review.googlesource.com/c/go/+/207958Reviewed-by:
-
Ian Lance Taylor authored
The darwin-arm64-correlium builder was failing the test consistently at the old values. Give the ticks more time to let the test pass. Updates #35692 Change-Id: Ibc636cd4db2595c82f4e8c6c822c3df4c2b7e0a1 Reviewed-on: https://go-review.googlesource.com/c/go/+/207839 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
Updates #6239 Updates #27707 Change-Id: I65e6471829c9de4677d3ac78ef6cd7aa0a1fc4cb Reviewed-on: https://go-review.googlesource.com/c/go/+/171884Reviewed-by:
Michael Knyszek <mknyszek@google.com> Reviewed-by:
Emmanuel Odeke <emm.odeke@gmail.com>
-
Joel Sing authored
Handle immediates larger than 12-bits by rewriting as an LUI instruction with the high bits, followed by the original instruction with the low bits. Based on the riscv-go port. Updates #27532 Change-Id: I8ed6d6e6db06fb8a27f3ab75f467ec2b7ff1f075 Reviewed-on: https://go-review.googlesource.com/c/go/+/204626Reviewed-by:
Cherry Zhang <cherryyz@google.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
Joel Sing authored
Based on the riscv-go port. Updates #27532 Change-Id: I478254306441c253d3a2c09c10932ad1ac0be3c6 Reviewed-on: https://go-review.googlesource.com/c/go/+/204625Reviewed-by:
-
Ian Lance Taylor authored
Dan Scales pointed out a theoretical deadlock in the runtime. The timer code runs timer functions while holding the timers lock for a P. The scavenger queues up a timer function that calls wakeScavenger, which acquires the scavenger lock. The scavengeSleep function acquires the scavenger lock, then calls resetTimer which can call addInitializedTimer which acquires the timers lock for the current P. So there is a potential deadlock, in that the scavenger lock and the timers lock for some P may both be acquired in different order. It's not clear to me whether this deadlock can ever actually occur. Issue 35532 describes another possible deadlock. The pollSetDeadline function acquires pd.lock for some poll descriptor, and in some cases calls resettimer which can in some cases acquire the timers lock for the current P. The timer code runs timer functions while holding the timers lock for a P. The timer function for poll descriptors winds up in netpolldeadlineimpl which acquires pd.lock. So again there is a potential deadlock, in that the pd lock for some poll descriptor and the timers lock for some P may both be acquired in different order. I think this can happen if we change the deadline for a network connection exactly as the former deadline expires. Looking at the code, I don't see any reason why we have to hold the timers lock while running a timer function. This CL implements that change. Updates #6239 Updates #27707 Fixes #35532 Change-Id: I17792f5a0120e01ea07cf1b2de8434d5c10704dd Reviewed-on: https://go-review.googlesource.com/c/go/+/207348 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
Take the opportunity of deflaking to make it take less time to run. Updates #35537 Change-Id: I91ca8094fbe18fbfcd34dfda98da1592c9c82943 Reviewed-on: https://go-review.googlesource.com/c/go/+/207403 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
This will help to detect regressions of #28387 when running 'go test cmd/go' in a writable GOROOT. Updates #28387 Updates #30316 Change-Id: I551e044111535404688b1a76e63163dfcb41bb5c Reviewed-on: https://go-review.googlesource.com/c/go/+/207701 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
-
David Chase authored
The old recipe for making an infinite loop not be infinite in the debugger could create an instruction (Prog) with a line number not tied to any file (index == 0). This caused downstream failures in DWARF processing. So don't do that. Also adds a test, also adds a check+panic to ensure that the next time this happens the error is less mystifying. Fixes #35652 Change-Id: I04f30bc94fdc4aef20dd9130561303ff84fd945e Reviewed-on: https://go-review.googlesource.com/c/go/+/207613 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
It was attempting to write a test binary to the working directory. Updates #28387 Updates #30316 Change-Id: I82eca3a8a3e019dc6dacbe1f02a0583577694b93 Reviewed-on: https://go-review.googlesource.com/c/go/+/207614 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
- 18 Nov, 2019 14 commits
-
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: I06e50c8d148cb4d7e08cdc2ba90de5e91d35781d Reviewed-on: https://go-review.googlesource.com/c/go/+/207699 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: If2e66176e2c92a469cbab20e60f4439b0d8668bb Reviewed-on: https://go-review.googlesource.com/c/go/+/207700 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: I08eb0e144387735f7a7811a82e547a581991b335 Reviewed-on: https://go-review.googlesource.com/c/go/+/207697 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
Also convert associated tests of GOPATH and 'go install' so that we can remove the corresponding source file from testdata/src. Updates #28387 Updates #30316 Change-Id: Id8c2fde4dc88954b29aefe71c9fa7e974a2ca932 Reviewed-on: https://go-review.googlesource.com/c/go/+/207605 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: I6192cc02b9e4fce3015cc47da9ec63fbea79a935 Reviewed-on: https://go-review.googlesource.com/c/go/+/207698 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Than McIntosh authored
Reduced test case for gollvm compiler crash building docker-ce. Updates #35586. Change-Id: Ib805dc9ab7b63cc61f207f1f000bef9809cfd428 Reviewed-on: https://go-review.googlesource.com/c/go/+/207258 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Updates #30316 Change-Id: I5a1a7870928083a98a76225c428ad4d7263fd832 Reviewed-on: https://go-review.googlesource.com/c/go/+/207610 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
I'm hoping to eliminate testdata/src/go-cmd-test, so porting over tests that assume its existence. Updates #28387 Updates #30316 Change-Id: I20bae780a4eb87cc19cc1e8531b84ab4a8a3c255 Reviewed-on: https://go-review.googlesource.com/c/go/+/207608 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
These tests were all attempting to write to their working directory, which may fail if GOROOT is read-only. Updates #28387 Updates #30316 Change-Id: Ib85234cdcf5ef4d554d8c99cf0942981bbd394ee Reviewed-on: https://go-review.googlesource.com/c/go/+/207604 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Cherry Zhang authored
When initializing an M, we set up its signal stack to the gsignal stack if an alternate signal stack is not already set. On Android, an alternate signal stack is always set, even cgo is not used. This breaks the logic of saving/fetching G on the signal stack during VDSO, which assumes the signal stack is allocated by Go if cgo is not used (if cgo is used, we use TLS for saving G). When cgo is not used, we can always use the Go signal stack, even if an alternate signal stack is already set. Since cgo is not used, no one other than the Go runtime will care. Fixes #35554. Change-Id: Ia9d84cd55cb35097f3df46f37996589c86f10e0f Reviewed-on: https://go-review.googlesource.com/c/go/+/207445 Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
ramenjuniti authored
tabs.getSelected has been deprecated since Chrome 33. Instead, use tabs.query. Fixes #35663 Change-Id: I4f7f17f948987aff8409ac8210f04eb1f7ebf908 Reviewed-on: https://go-review.googlesource.com/c/go/+/207402Reviewed-by:
Andrew Bonventre <andybons@golang.org>
-
Bryan C. Mills authored
Fixes #35632 Change-Id: I55c3d53c2a6240868ec001866047a15ec8f91809 Reviewed-on: https://go-review.googlesource.com/c/go/+/207603 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Bryan C. Mills authored
This reverts CL 207477, restoring CL 207352 with a fix for the regression observed in the Windows builders. cmd/compile evidently does not fully support NUL as an output on Windows, so this time we write ignored 'compile' outputs to temporary files (instead of os.DevNull as in CL 207352). Updates #28387 Fixes #35619 Change-Id: I2edc5727c3738fa1bccb4b74e50d114cf2a7fcff Reviewed-on: https://go-review.googlesource.com/c/go/+/207602 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Tom Thorogood authored
CL 206078 introduced a stray errno check that was always false. This CL removes it. Updates #35276 Change-Id: I6996bb595d347fe81752786a3d83d3432735c9cb GitHub-Last-Rev: e026e71b16c8532ad707a0b43b4f02c7a366257e GitHub-Pull-Request: golang/go#35650 Reviewed-on: https://go-review.googlesource.com/c/go/+/207577 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
- 16 Nov, 2019 3 commits
-
-
Keith Randall authored
This allows maphash.Hash to be allocated on the stack for typical uses. Fixes #35636 Change-Id: I8366507d26ea717f47a9fb46d3bd69ba799845ac Reviewed-on: https://go-review.googlesource.com/c/go/+/207444 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Ian Lance Taylor authored
Fixes #35616 Change-Id: I51b2490100cfe0e902da09eee8d027e0ec86ed53 Reviewed-on: https://go-review.googlesource.com/c/go/+/207466 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Clément Chigot authored
On AIX, addresses returned by mmap are between 0x0a00000000000000 and 0x0afffffffffffff. The previous solution to handle these large addresses was to increase the arena size up to 60 bits addresses, cf CL 138736. However, with the new page allocator, the 60bit heap addresses are causing huge memory allocations, especially by (s *pageAlloc).init. mmap and munmap syscalls dealing with these allocations are reducing performances of every Go programs. In order to avoid these allocations, arenaBaseOffset is set to 0x0a00000000000000 and heap addresses are on 48bit, as others operating systems. Updates: #35451 Change-Id: Ice916b8578f76703428ec12a82024147a7592bc0 Reviewed-on: https://go-review.googlesource.com/c/go/+/206841 Run-TryBot: Michael Knyszek <mknyszek@google.com> Reviewed-by:
-
- 15 Nov, 2019 9 commits
-
-
Bryan C. Mills authored
This reverts CL 207352 Reason for revert: broke more builders than it fixed.
😞 Change-Id: Ic5adefe92edfa2230b9c7d750c922473a6a5ded4 Reviewed-on: https://go-review.googlesource.com/c/go/+/207477Reviewed-by: -
Ian Lance Taylor authored
The test is inherently slightly flaky, so repeat to reduce flakiness. Fixes #35537 Change-Id: Id918d48d33c7d5e19c4f24df104adc7fbf3720f2 Reviewed-on: https://go-review.googlesource.com/c/go/+/207457 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by:
-
Bryan C. Mills authored
When we run tests, we may need to write the test binary (and/or test variants of its dependencies) to GOCACHE. (This also fixes several test cases in cmd/go, which preserves the GOCACHE variable for efficiency.) It is highly unlikely that tests will try to modify .git, and that directory contains many files, so don't bother with it. Updates #30316 Change-Id: Id11136c6c64d8f0afc6c6ba5d94c9269df231052 Reviewed-on: https://go-review.googlesource.com/c/go/+/207441 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Ville Skyttä authored
Change-Id: I5b909df0fd048cd66c5a27fca1b06466d3bcaac7 GitHub-Last-Rev: 778c5d21311abee09a5fbda2e4005a5fd4cc3f9f GitHub-Pull-Request: golang/go#35624 Reviewed-on: https://go-review.googlesource.com/c/go/+/207421 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Elias Naur authored
CL 205340 changed the linker to skip certain flags when linking for iOS. However, for host linking on iOS (such as on the Corellium darwin/arm64 builders) the MachO platform defaults to PLATFORM_MACOS, and the flags are not skipped. Avoids warnings such as ld: warning: -no_pie ignored for arm64 Updates #32963 Change-Id: Ib6b4c2375fd14cf89410bf5ff1537b692b7a1c15 Reviewed-on: https://go-review.googlesource.com/c/go/+/206337 Run-TryBot: Elias Naur <mail@eliasnaur.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: -
Bryan C. Mills authored
While running various tests for #28387, I keep ending up with an unwritable GOROOT after a failure. While the unwritable GOROOT is a fairly exotic condition (normally only happens on builders), it's somewhat annoying when debugging, so I'm switching all of the log.Fatal* call sites to use the existing fatalf function, which supports general atexit-like cleanup. Updates #28387 Change-Id: I473cda7eacd9ad82bdeab647766373126dc7390e Reviewed-on: https://go-review.googlesource.com/c/go/+/207341 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Updates #28387 Fixes #35619 Change-Id: I162f3427b7901c117e3f3e403df7edec7c529bd1 Reviewed-on: https://go-review.googlesource.com/c/go/+/207352 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
Bryan C. Mills authored
Previously, we were writing binaries to GOROOT without ever reading them. Updates #28387 Change-Id: Ic84999f46a367fcbf2ae1eac8bfdcbceb24dc748 Reviewed-on: https://go-review.googlesource.com/c/go/+/207342 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by:
-
Agniva De Sarker authored
Updates #33848 Change-Id: I505490906be7cd6fbcdc6a05c1017c779dbf7bba Reviewed-on: https://go-review.googlesource.com/c/go/+/207397 Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by:
-
